Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 175819 New Sign in : Signing in to sync as a different user is redirecting to sync settings even though "Take me to my sync settings after signing in" option is unchecked.
Starred by 5 users Project Member Reported by jnaveen@chromium.org, Feb 12 2013 Back to list
Status: Verified
Owner: rogerta@chromium.org
Closed: Feb 2013
Cc: rponnada@chromium.org
Components:
OS: ----
Pri: 2
Type: Bug


Sign in to add a comment
ENVIRONMENT
OS : Win7/ Mac OSX
Chrome : 26.0.1410.3

REPRO STEPS
1. On a clean client, Sign into sync.
2. Go to settings page and disconnect the account from sync.
3. Again "Sign in to Chrome" 
4. Click "Sign out and sign in as a different user" link.
5. Uncheck the "Take me to my sync settings after signing in" option
6. Sign-in with a different account and click "Sign in anyway" in the modal dialog.


ACTUAL RESULTS
redirecting to sync settings.

EXPECTED RESULTS
Signed in to sync and is redirected to settings page.


 
Owner: rogerta@chromium.org
Status: Started
The original code only handled the case where the user checked the option, not unchecked the option.
Comment 2 by tmc...@chromium.org, Feb 13 2013
Labels: ReleaseBlock-Stable
Project Member Comment 3 by bugdroid1@chromium.org, Feb 15 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182750

------------------------------------------------------------------------
r182750 | rogerta@chromium.org | 2013-02-15T17:47:17.560803Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/sync_setup_handler.cc?r1=182750&r2=182749&pathrev=182750
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/sync/one_click_signin_helper.cc?r1=182750&r2=182749&pathrev=182750

Initially the gaia sign in page did not allow the user to turn off the "let me choose want to sync" option when signing in from the settings page.  To fix a bug in the page, this is now allowed.  The chrome code must now deal with this situation correctly.

BUG= 175819 


Review URL: https://chromiumcodereview.appspot.com/12256015
------------------------------------------------------------------------
Labels: Merge-Requested
Status: Fixed
Labels: -Merge-Requested Merge-Approved
Project Member Comment 6 by bugdroid1@chromium.org, Feb 20 2013
Labels: -Merge-Approved merge-merged-1410
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=183388

------------------------------------------------------------------------
r183388 | rogerta@google.com | 2013-02-20T02:58:40.425055Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/webui/sync_setup_handler.cc?r1=183388&r2=183387&pathrev=183388
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/sync/one_click_signin_helper.cc?r1=183388&r2=183387&pathrev=183388

Merge 182750
> Initially the gaia sign in page did not allow the user to turn off the "let me choose want to sync" option when signing in from the settings page.  To fix a bug in the page, this is now allowed.  The chrome code must now deal with this situation correctly.
> 
> BUG= 175819 
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/12256015

TBR=rogerta@chromium.org
Review URL: https://codereview.chromium.org/12321002
------------------------------------------------------------------------
Labels: Action-FeedbackNeeded
Tested this issue on win7 7 Mac on 26.0.1410.29 (Official Build 186597)  with below steps.

1. On a clean client, Sign into sync.
2. Go to settings page and disconnect the account from sync.
3. Again "Sign in to Chrome" from settings page
4. Click "Sign out and sign in as a different user" link.
5. There is no check box to check or uncheck 
6. Sign-in with a different account and click "Sign in anyway" in the modal dialog.

Results: Navigated to Chrome://settings/syncSetup Page and Confirm Sync Settings pop up window is displayed. 

Please confirm the behavior as it is not redirected to Settings page. 
You mention in Results that the Confirm Sync Settings pop up is displayed, but say "it is not redirected to the Settings page" -- do you mean that we don't navigate to the page with all the options check boxes, and instead land on the page that asks you to confirm the default settings?
Project Member Comment 9 by bugdroid1@chromium.org, Mar 9 2013
Labels: -Action-FeedbackNeeded Needs-Feedback
Project Member Comment 10 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Feature-Sync -Feature-SignIn -Mstone-26 Cr-Services-Sync M-26 Cr-Services-SignIn
Cc: rponnada@chromium.org
As per the steps mentioned in comment7# since there is no checkbox (mentioned in Step5), page redirected to Chrome://settings/syncSetup Page with confirm Sync Settings pop up window  as shown in the attached screenshot. 

Please confirm on this behavior as it is deviating from the Expected results mentioned in original bug .
Screen Shot 2013-03-13 at 11.31.49 AM.png
112 KB View Download
Status: Verified
The Sign in flow has changed quite a bit in the last 1 year. Closing this now.
Sign in to add a comment