Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 175672 Unable to Sign into Chrome from chrome://Settings page.
Starred by 8 users Project Member Reported by srsridhar@chromium.org, Feb 12, 2013 Back to list
Status: Fixed
Owner: rogerta@chromium.org
Closed: Feb 2013
Cc: srsridhar@chromium.org, ligim...@chromium.org
Components:
OS: All
Pri: 1
Type: Bug-Regression


Sign in to add a comment
Version: <26.0.1409.0>
OS: <MAC>

What steps will reproduce the problem?
1. Open chrome/canary.
2. Navigate to chrome://settings page. Click on 'Sign into Chrome' button. This redirects to Sign in to Chrome page in a new tab.
3.  Enter valid credentials and click on Sign in button. Make sure that 'Take me to my sync settings after signing in" checkbox is checked.

What is the expected output?
Clicking on sign in button should navigate to 'chrome://settings/syncSetup' page with Confirm Sync settings dialog displayed.

What do you see instead?
Page is not being redirected and displays a blank page "https://www.google.com/intl/en-US/chrome/blank.html?source=3".

 
Labels: -OS-Mac OS-All
Bisect Info:
Good Build: 26.0.1407.0 (Official Build 181436) dev
Bad build: 26.0.1408.0 (Official Build 181571) dev

You are probably looking for a change made after 181549 (known good), but no later than 181565 (first known bad).
WEBKIT CHANGELOG URL:
  http://trac.webkit.org/log/trunk/?rev=142323&stop_rev=142224&verbose=on&limit=10000
CHANGELOG URL:
  http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&range=181549%3A181565
Comment 2 by geki...@gmail.com, Feb 12, 2013
same problem; see also Issue 173282 (is fixed but for me it's not fixed)
Comment 3 by atwilson@chromium.org, Feb 12, 2013
Owner: rogerta@chromium.org
Roger, when I added code to download policy as part of signin, I found that we sit looking at that blank page for a while - I guess we just display that blank page the entire time that SigninManager is off doing its thing.

I wonder if maybe we ought to display some kind of "Signing in..." message on that page at least? Because in the worst case, we are making a *ton* of network requests in the middle of signin:

* SigninManager issues request to turn cookies into OAuth tokens
* SM issues request to turn OAuth tokens into SID/LSID
* SM issues a GetUserInfo request
* Policy code does another OAuth GetUserInfo request
* Policy code fetches DMToken from DMServer
* Policy code fetches policy blob
* Token service starts loading tokens
* Sync service accesses the sync server and downloads the nigori node.

...and only then does SigninTracker report a successful signin. Seems like a user on a slow/flaky connection could be left looking at a blank page for a long time?
Comment 4 by tanyarad@google.com, Feb 12, 2013
Status: Assigned
Comment 5 by rogerta@chromium.org, Feb 12, 2013
Status: Started
This is a regression caused by crrev.com/181782. The expected continue URL has
changed and sync setup handler needs to handle the new one.
Project Member Comment 6 by bugdroid1@chromium.org, Feb 14, 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182342

------------------------------------------------------------------------
r182342 | rogerta@chromium.org | 2013-02-13T23:57:24.431227Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/sync_setup_handler.cc?r1=182342&r2=182341&pathrev=182342

Fix regression caused by crrev.com/181782.  The expected continue URL has
changed and sync setup handler needs to handle the new one.

BUG= 175672 


Review URL: https://chromiumcodereview.appspot.com/12221153
------------------------------------------------------------------------
Comment 7 by dharani@chromium.org, Feb 15, 2013
Labels: Merge-Requested
Please verify if this is fixed in 267.0.1413.0 build.
Tested the issue on Mac 10.8.2, Windows 7 and Ubuntu 12.04 OS - chrome version 27.0.1413.0 (Official Build 182629). It is working as intended.

Able to successfully sing in and sync from chrome://settings page.

Please let me know if further info required on the same.
Labels: TE-Verified-27.0.1413.0
Comment 10 by dharani@chromium.org, Feb 18, 2013
Labels: -Merge-Requested Merge-Approved
Comment 11 by rogerta@chromium.org, Feb 19, 2013
Status: Fixed
Project Member Comment 12 by bugdroid1@chromium.org, Feb 20, 2013
Labels: -Merge-Approved merge-merged-1410
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=183346

------------------------------------------------------------------------
r183346 | rogerta@chromium.org | 2013-02-20T00:57:16.667666Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/webui/sync_setup_handler.cc?r1=183346&r2=183345&pathrev=183346

Merge 182342
> Fix regression caused by crrev.com/181782.  The expected continue URL has
> changed and sync setup handler needs to handle the new one.
> 
> BUG= 175672 
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/12221153

TBR=rogerta@chromium.org
Review URL: https://codereview.chromium.org/12304039
------------------------------------------------------------------------
Labels: TE-Verified-26.0.1410.29
Tested this issue on Win, MAC, Linux & 26.0.1410.29 (Official Build 186597) . Able to navigate chrome://settings/syncSetup page and Confirm Sync Settings pop up window is displayed. 
Project Member Comment 14 by bugdroid1@chromium.org, Mar 9, 2013
Labels: -Type-Regression -Area-UI -Mstone-26 -Feature-SignIn Type-Bug-Regression Cr-UI M-26 Cr-Services-SignIn
Sign in to add a comment