Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 175335 Scroollbar & ComboBox (in classic Windows theme). Visual defects.
Starred by 20 users Reported by skytel...@gmail.com, Feb 10 2013 Back to list
Status: Verified
Owner:
User never visited
Closed: Feb 2013
Cc:
Components:
NextAction: ----
OS: Windows
Pri: 1
Type: Bug


Sign in to add a comment
Chrome Version       : 26.0.1409.0
Other browsers tested:
     Safari 5: OK
  Firefox 4.x: OK
     IE 7/8/9: OK

What steps will reproduce the problem?
1. Use Windows classic theme.
2. Launch Chromium.
3. Load any web page, where can be used any ScrollBar and ComboBox.

What is the expected result?
Scrollbar - is visible.
ComboBox - is visible.

What happens instead?
Scrollbar - not visible.
ComboBox - not visible.

 
scrollbar_combobox.png
425 KB View Download
Labels: -Area-Undefined Area-UI Action-BisectNeeded
Labels: -Action-BisectNeeded Mstone-26
Status: Untriaged
This was working fine on current dev build 26.0.1403.0
Please find the bisect info below:

You are probably looking for a change made after 26.0.1403.1 (known good), but n
o later than 26.0.1404.0 (first known bad).
CHANGELOG URL:
http://omahaproxy.appspot.com/changelog?old_version=26.0.1403.1&new_version=26.0
.1404.0
Owner: kevers@chromium.org
Status: Assigned
Most likely suspect looks like http://src.chromium.org/viewvc/chrome?view=rev&revision=180431.

kevers: Can you take a look?
Same here. After 26.0.1410.3 dev-m all scrollbars disappeared!

also i was opened Issue 174645
Comment 5 by kevers@chromium.org, Feb 13 2013
Status: Started
Investigating.
Comment 6 by maxar...@gmail.com, Feb 14 2013
There's no scrollbar on select elements with size attribute, and there's no resize handle in textarea elements anymore.

Opened issue #176175.
Issue 176175 has been merged into this issue.
Issue 175311 has been merged into this issue.
Issue 174645 has been merged into this issue.
Cc: telukuntak@chromium.org jayakrishnat@chromium.org ranavdk@chromium.org joycel@chromium.org mangalampalli@chromium.org
Issue 176009 has been merged into this issue.
Labels: -Pri-2 Pri-1 OS-All ReleaseBlock-Stable
Labels: -OS-All OS-Windows
It's Windows only.
Comment 14 by ric.p...@gmail.com, Feb 14 2013
Version 26.0.1410.3, 26.0.1410.5 dev-m

win 7 with classic interface: no scroll bar, arrow comboBox, and related;
win 7 with aero interface: ok;
Comment 15 Deleted
So when do we see a fix or go back a rev?
As mentioned in issue 175311, it looks like it started with build 180358. 
Fix will be committed shortly.

Project Member Comment 19 by bugdroid1@chromium.org, Feb 15 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182726

------------------------------------------------------------------------
r182726 | kevers@chromium.org | 2013-02-15T16:16:39.974853Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/native_theme/native_theme_win.cc?r1=182726&r2=182725&pathrev=182726

Fix retrieval of unthemed scrollbar size.

BUG= 175335 

Review URL: https://codereview.chromium.org/12256011
------------------------------------------------------------------------
Labels: Merge-Requested
Fixed in 27.0.1414.  Very safe fix to backport.

Labels: -Merge-Requested Merge-Approved
When should we see this update??


Comment 23 by kevers@google.com, Feb 15 2013
The fix should be in the next Canary build.
Project Member Comment 24 by bugdroid1@chromium.org, Feb 15 2013
Labels: -Merge-Approved merge-merged-1410
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182793

------------------------------------------------------------------------
r182793 | kevers@chromium.org | 2013-02-15T19:46:37.103735Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/ui/native_theme/native_theme_win.cc?r1=182793&r2=182792&pathrev=182793

Merge 182726
> Fix retrieval of unthemed scrollbar size.
> 
> BUG= 175335 
> 
> Review URL: https://codereview.chromium.org/12256011

TBR=kevers@chromium.org
Review URL: https://codereview.chromium.org/12290004
------------------------------------------------------------------------
Status: Fixed
Comment 26 Deleted
Comment 27 Deleted
Comment 28 Deleted
Comment 29 by gval...@gmail.com, Feb 17 2013
I just tried 183010, scrollbars seem fine. :-)

@joe
Just search for Chrome Canary:
https://www.google.com/intl/en/chrome/browser/canary.html

Or you can try the latest builds (but they don't support MP4 and proprietary codecs):
http://commondatastorage.googleapis.com/chromium-browser-continuous/index.html?path=Win/

@legend
A note about Chrome stable: I once happened to report a bug in the nightly builds that eventually got fixed. Surprisingly, the same bug appeared a month later in the so called Chrome stable. So I had to stay away from it. Once the auto-updater installs a bad version, going back is not as easy as with the nightly builds.

Comment 30 Deleted
Comment 31 by make...@gmail.com, Feb 18 2013
I know it's a dev build, but how can this happen? Even if it's dev build, how can this become a published build? Canary is even worse, it gets broken like every two days. I switched to dev build from Canary some time ago, because Canary is just not usable, because every third or fifth auto update breakes the complete browser, I had everything from not starting anymore, to stupid bugs making it impossible to use anymore. The dev build is similiar though it works for a few wekks before something like this happenes. Too bad the stable release is months ahead of the dev or even Canary, here it is like half a year.
Comment 32 by maxar...@gmail.com, Feb 18 2013
I have to admit that the dev channel - which I use to get all the new tech goodies early - was more stable in the past. I'm starting to consider to switch to the beta channel to get a little more stability.

Anyway, for me this bug is just an annoyance - the workaround was to put up an Aero theme. But XP users can't do the same.
Please don't spam people with irrelevant comments about what version of a browser you're going to use. If you aren't willing to accept the occasional breaks, crashes, and loss of time, stick with the stable release and don't test the most recent builds. 

This issue has already been fixed. 
Can someone in Chromium team remove the name calling/personal attack made by #30 joeventura@gmail.com before closing this issue? Thanks. 
Yeah legend, I see message #28 where you said:
Stupid people like you need to stay off Google code.... You don't need to post more than once to annoy many people... If you don't know what canary is, just use chrome stable...

is now missing so let's discuss who is doing the name calling?

Labels: TE-Verified-26.0.1410.10
Status: Verified
Tested this issue with 26.0.1410.10 on Win7 - Working as intended.

Thank you!
Project Member Comment 37 by bugdroid1@chromium.org, Feb 20 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=183496

------------------------------------------------------------------------
r183496 | simonjam@chromium.org | 2013-02-20T12:08:41.214973Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/native_theme/native_theme_win.cc?r1=183496&r2=183495&pathrev=183496

Revert 182726 - Speculative. Will reland if no perf change.
> Fix retrieval of unthemed scrollbar size.
> 
> BUG= 175335 
> 
> Review URL: https://codereview.chromium.org/12256011

TBR=kevers@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12302043
------------------------------------------------------------------------
Comment 38 by make...@gmail.com, Feb 20 2013
I dont want to break the illusion, but this bug still persist for my pc, it wasn't fixed. Tested newest Canary and dev, both still have this behavior for my setup. I tried to reset profiles too.
Comment 39 by maxar...@gmail.com, Feb 20 2013
Tested with Windows 7 and Classic Theme.
Chrome 26.0.1410.10 dev works just fine.

@makedir Can you report the versions you're using?
Comment 40 by make...@gmail.com, Feb 20 2013
26.0.1410.10 dev-m and 27.0.1417.2 canary. maybe this is another related issue. though it started happen to me at the same time. the scroll bars arent totally gone, they are just unusable small (see screenshot).
scrollbars.gif
8.7 KB View Download
Blockedon: chromium:176612
Status: Assigned
Reverted due to performance regression.
Comment 42 by gval...@gmail.com, Feb 21 2013
I just tested: 27.0.1415.0 canary, 27.0.1416.0 (183038) dev, 27.0.1418.2 canary. The scrollbars work fine on all. Windows 2003 x64, i7 930, GTX 570, no themes.

I prefer using the SVN. Once a month I check if the waterfall is green, choose the right moment and sync to that. Then recompile and see if GPU acceleration and everything else seem fine. This appears to be a good strategy.
You couldnot fix it correctly. Yes scrollbar and combobox came back but you broke another thing. Please look at attachment. As you can see something is wrong on Chrome.
youtube.PNG
94.2 KB View Download
Comment 44 by maxar...@gmail.com, Feb 21 2013
I can see the Related Channels list on Youtube just fine with Chrome 26.0.1410.10 dev.
Anyway the scrollbars look fine and this is what this issue was about.

Don't spam on this issue for something unrelated: open another one.
This should hold for everyone.
Comment 45 Deleted
Comment 46 by maxar...@gmail.com, Feb 21 2013
@45 This issue is about scrollbars *now showing*.
In your screenshot, scrollbars are showing *perfectly*. End of story.

I guess what's wrong there is some style-related and sub-pixel precision issue.
With every release, *many* fixes and implementations are added. Version 26.0.1410.10 wasn't out just for this issue.
Please stop spamming and *open another issue* if you think there's a problem.

Man, I shouldn't really explain these things...
I'm de-starring this.
@44

My comment is about scrollbars. I put screenshot, as you can see it's not fine for me. There's only one person here spamming with unnecessary comments and it's you not someone else.

My comment is about this bug. Even developers reverted this bug from "fixed" status and it's still active now. So who do you think you are and you can say "this issue is fixed. no one will comment on this issue anymore. It's fine for me so it should be fine for everyone on the universe" ?

Btw, I use Windows 7 32bit with no theme.
@46 This issue is about "Visual defects of scrollbars and combobox"
In my screenshot, scrollbars SHOULD NOT APPEAR AT ALL. And it started after THIS FIX. So it's about THIS BUG. BECAUSE it seems they couldnot FIX IT PROPERLY!

END OF STORY
@Maxar

Oh no not the De-star PLEASE!!!

Comment 50 by make...@gmail.com, Feb 21 2013
@dogantun...

What about my problem though, which seems to be related to this problem. It's the same on my laptop and desktop. All scrollbars are just 1-2px in width.
Project Member Comment 51 by bugdroid1@chromium.org, Feb 21 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=183838

------------------------------------------------------------------------
r183838 | dharani@google.com | 2013-02-21T18:39:02.297185Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/ui/native_theme/native_theme_win.cc?r1=183838&r2=183837&pathrev=183838

Revert 182793
> Merge 182726
> > Fix retrieval of unthemed scrollbar size.
> > 
> > BUG= 175335 
> > 
> > Review URL: https://codereview.chromium.org/12256011
> 
> TBR=kevers@chromium.org
> Review URL: https://codereview.chromium.org/12290004

TBR=kevers@chromium.org
Review URL: https://codereview.chromium.org/12334015
------------------------------------------------------------------------
Cc: jeffreyc@chromium.org
Comment 53 by gval...@gmail.com, Feb 21 2013
@dharani
Historicaly, first the scrollbars bacame thin, then disapeared, then that code which you just removed was added and everything went to normal. So I kind of have a bad feeling about removing that code from 183837 to 183838. Well, the truth will reveal itself in a few hours, when 183838 gets compiled by the buildbot. ;-)

I'm currently using 27.0.1416.0 (183038) (I compiled it from SVN on Feb 17) the scrollbars are fine, the issue in #43 is not present.
Project Member Comment 54 by bugdroid1@chromium.org, Feb 22 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=183990

------------------------------------------------------------------------
r183990 | kevers@chromium.org | 2013-02-22T02:37:22.617167Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webthemeengine_impl_win.cc?r1=183990&r2=183989&pathrev=183990

Fix the size of scrollbars when using the Windows Classic theme.

BUG= 175335 

Review URL: https://chromiumcodereview.appspot.com/12330018
------------------------------------------------------------------------
Comment 55 by gval...@gmail.com, Feb 23 2013
27.0.1422.0 (184321) Scrollbars appear properly on XP and Windows 8 x64. :-) Cheers!
Labels: Merge-Requested
Comment 57 by dharani@google.com, Feb 25 2013
Labels: -Merge-Requested Merge-Approved
Project Member Comment 58 by bugdroid1@chromium.org, Feb 26 2013
Labels: -Merge-Approved
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=184405

------------------------------------------------------------------------
r184405 | kevers@chromium.org | 2013-02-25T14:34:21.189521Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/webkit/glue/webthemeengine_impl_win.cc?r1=184405&r2=184404&pathrev=184405

Merge 183990
> Fix the size of scrollbars when using the Windows Classic theme.
> 
> BUG= 175335 
> 
> Review URL: https://chromiumcodereview.appspot.com/12330018

TBR=kevers@chromium.org
Review URL: https://codereview.chromium.org/12320091
------------------------------------------------------------------------
Is there anymore work need to be done? If not, please close this bug.
Status: Fixed
Blockedon: -chromium:176612
Comment 62 by make...@gmail.com, Feb 27 2013
It's still not fixed dammit, why was this changed to fixed...
Cc: agautam@chromium.org
Status: Verified
This issue is fixed and verified on:- 

Google Chrome   26.0.1410.18 (Official Build 184847)
Platform        Win 7
Issue 176142 has been merged into this issue.
This is not fixed! Still there's no scrollbar on some windows of chrome. Look my screenshot.

ps: Don't say me "open another issue". I already opened another issue and you merged that issue 174645 to this one. So this is about this issue.
chrome bookmark edit.png
8.5 KB View Download
Also this issue still exists.
youtube.PNG
54.5 KB View Download
Check scrollbars for task manager, please.
Безымянный.png
14.1 KB View Download
Project Member Comment 68 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Area-UI -Mstone-26 M-26 Cr-UI
Tested this issue, Still able to reproduce, Verified on 26.0.1410.30 beta.

Thanks.
Cc: tfarina@chromium.org jchaffraix@chromium.org estade@chromium.org lafo...@chromium.org ramankk@chromium.org nyerramilli@chromium.org msw@chromium.org
Issue 176074 has been merged into this issue.
Comment 71 by mattj...@gmail.com, Mar 14 2013
I'm having the same problem. I'm using Windows 8... there is no "classic theme" though. 
Comment 72 by mattj...@gmail.com, Mar 14 2013
This bug is still in the latest version of chromium... it looks like it will be a while before it's fixed. 
Tracked the background color for scrollbars as issue 195603.  The disappearance of scrollbars and combobox buttons in Windows Classic mode has been dealt with.  As the background color issue does not appear limited to Windows Classic mode, we are clearly dealing with a different issue.
Comment 74 by mattj...@gmail.com, Mar 14 2013
I actually do have a scroll bar, but it's 2 pixels wide and it's hardly visible at the edge of the window.
This bug is closed, if you're still seeing issues, please file a new bug. (You can post a link to the bug here, when you do.)
Comment 76 Deleted
Comment 78 by laforge@google.com, Jul 24 2013
Cc: -jeffreyc@chromium.org
Sign in to add a comment