Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 175071 Chrome hangs in Mac when clicking on Permission link on Extensions.
Starred by 6 users Project Member Reported by agautam@chromium.org, Feb 8, 2013 Back to list
Status: Fixed
Owner: mpcomplete@chromium.org
Closed: Feb 2013
Cc: pludwig@chromium.org, jyasskin@chromium.org, kalman@chromium.org, finnur@chromium.org, ligim...@chromium.org, yoz@chromium.org
Components:
OS: Mac
Pri: 1
Type: Bug-Regression


Sign in to add a comment
Chrome Version: <26.0.1406.0 (Official Build 181233) Dev>
OS: <Macairbook OS X 10.8.2 >

What steps will reproduce the problem?
1. Open chrome://extensions
2. Install few extensions if not there.
3. Now in any extension click on "permissions: link.
4. A pop window will open observe it is without any text and one blank button.

What is the expected output? 
Pop up window should open with text current permission and "cancel" button option. like in other OS {WIN7 , Ubuntu}

What do you see instead?
1. There is no text in popup window and no text in button.
2. Chrome hangs and user cant click on any link in opened page in that chrome session.
3. Quit Chrome option (Commant+Q) doesn't work.
4. Only new tab opens and if type any URL and enter nothing happen.
5. Chrome is unusable after that, And user has to forcefully kill the process from OS Activity manager.

Please use labels and text to provide additional information.
 
Screen Shot 2013-02-08 at 1.13.39 PM.png
157 KB View Download
Labels: Action-BisectNeeded ReleaseBlock-Stable
Aditya .. Can u find the regression window?
Comment 3 by agautam@chromium.org, Feb 11, 2013
Labels: -Action-BisectNeeded
Bisected this on MAC. Issue is existing in Current Dev 26.0.1403.0

Manual Bisect:
Good Build:
26.0.1399.0 (Official Build 179793
Bad Build:
26.0.1400.0 (Official Build  180085)
Comment 4 by agautam@google.com, Feb 11, 2013
You are probably looking for a change made after 179909 (known good), but no later than 179945 (first known bad).
CHANGELOG URL:
  http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&range=179909%3A179945

Comment 5 by agautam@chromium.org, Feb 11, 2013
Labels: -Type-Bug -Pri-2 Type-Regression Pri-1 Mstone-26
Comment 6 by ligim...@chromium.org, Feb 11, 2013
Labels: -Area-UI -ReleaseBlock-Stable Area-Internals ReleaseBlock-Beta Stability-Hang
Comment 7 by tanyarad@google.com, Feb 12, 2013
Owner: finnur@chromium.org
Status: Assigned
Looks like http://src.chromium.org/viewvc/chrome?view=rev&revision=179916

Finnur - can you please take a look or redirect?

Thanks!
Comment 8 by finnur@chromium.org, Feb 13, 2013
Cc: finnur@chromium.org
Owner: pludwig@chromium.org
Sigh. Super bad timing as I just started my paternity leave. 

Peter, can you see if someone with a Mac can take a quick look to check if this is easy to fix?
Comment 9 by pludwig@chromium.org, Feb 13, 2013
Cc: kalman@chromium.org yoz@chromium.org pludwig@chromium.org jyasskin@chromium.org
Owner: mpcomplete@chromium.org
Comment 10 by pludwig@chromium.org, Feb 13, 2013
The feature bug for this is: https://code.google.com/p/chromium/issues/detail?id=170742
Comment 11 by mhx...@motorola.com, Feb 13, 2013
http://crrev.com/12220142/ might resolve this. I can wire it up for Mac and check it. 

Btw, I just tested it on Mac 10.6 with a debug Chrome build and I am getting the same DCHECK failure mentioned in http://crrev.com/12220142/. But the same root cause could result in a hang somewhere else on a Release build.

Comment 12 by laforge@google.com, Feb 13, 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182274

------------------------------------------------------------------------
r182274 | mpcomplete@chromium.org | 2013-02-13T18:59:28.710180Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_install_prompt.h?r1=182274&r2=182273&pathrev=182274
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc?r1=182274&r2=182273&pathrev=182274
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/extensions/extension_list.js?r1=182274&r2=182273&pathrev=182274
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/extensions/extensions.html?r1=182274&r2=182273&pathrev=182274
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=182274&r2=182273&pathrev=182274
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/extensions/extension_settings_handler.cc?r1=182274&r2=182273&pathrev=182274
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_install_prompt.cc?r1=182274&r2=182273&pathrev=182274
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/extensions/extension_settings_handler.h?r1=182274&r2=182273&pathrev=182274

Revert 179916. It breaks on Mac.
> Add a link (to view Permissions) to the Extension details on chrome://extensions.
> 
> BUG= 170742 
> TEST=None
> 
> Review URL: https://chromiumcodereview.appspot.com/12094034

BUG= 170742 , 175071 
TBR=finnur@chromium.org
Review URL: https://codereview.chromium.org/12263014
------------------------------------------------------------------------
Labels: Merge-Requested
Will need to merge r182274 to M26 once we're sure it's finalized.
Comment 14 by mhx...@motorola.com, Feb 13, 2013
FYI, CL to fix Chrome Hanging http://crrev.com/12258023
Comment 15 by mhx...@motorola.com, Feb 14, 2013
Attached the screenshot with the fix mentioned in http://crrev.com/12258023
Screen Shot 2013-02-13 at 6.38.16 PM.png
178 KB View Download
Comment 16 by tanyarad@google.com, Feb 14, 2013
I will approve once the QA is OK with the fix.
Project Member Comment 17 by bugdroid1@chromium.org, Feb 14, 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182576

------------------------------------------------------------------------
r182576 | MHX348@motorola.com | 2013-02-14T23:43:32.077062Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.mm?r1=182576&r2=182575&pathrev=182576
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/extensions/extension_list.js?r1=182576&r2=182575&pathrev=182576
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/extensions/extensions.html?r1=182576&r2=182575&pathrev=182576
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm?r1=182576&r2=182575&pathrev=182576
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=182576&r2=182575&pathrev=182576
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/extensions/extension_settings_handler.cc?r1=182576&r2=182575&pathrev=182576
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_install_prompt.cc?r1=182576&r2=182575&pathrev=182576
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm?r1=182576&r2=182575&pathrev=182576
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/extensions/extension_settings_handler.h?r1=182576&r2=182575&pathrev=182576
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm?r1=182576&r2=182575&pathrev=182576
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_install_prompt.h?r1=182576&r2=182575&pathrev=182576
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.h?r1=182576&r2=182575&pathrev=182576
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc?r1=182576&r2=182575&pathrev=182576

Re-land "view permission" feature (r179916) with Mac Fix.

The feature review URL: http://crrev.com/12094034
Mac fix review URL: http://crrev.com/12258023
This CL also combines the extension_install_prompt changes reviewed at http://crrev.com/12220142

RootCause for Mac failure: Permission Prompt does not have a OK button. 
And Chrome hangs while trying to create a OK button with empty string. 
Solution: Remove |okButton_| when its title is empty and adjust 
|cancelButton_|'s position. 
The screenshot with the fix is uploaded at http://crbug.com/175071#c15 

BUG= 170742 , 175071 
TBR=finnur@chromium.org
TBR=sky@chromium.org for http://crrev.com/12094034
TBR=sail@chromium.org for http://crrev.com/12258023


Review URL: https://chromiumcodereview.appspot.com/12212195
------------------------------------------------------------------------
Comment 18 Deleted
Comment 19 Deleted
Verified to be fixed on Canary.
Labels: TE-Verified-Build27.0.1413.0
Comment 22 by dharani@chromium.org, Feb 15, 2013
Labels: -Merge-Requested Merge-Approved
Project Member Comment 23 by bugdroid1@chromium.org, Feb 15, 2013
Labels: -Merge-Approved merge-merged-1410
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182838

------------------------------------------------------------------------
r182838 | mpcomplete@chromium.org | 2013-02-15T21:52:22.591133Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/app/generated_resources.grd?r1=182838&r2=182837&pathrev=182838
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/webui/extensions/extension_settings_handler.cc?r1=182838&r2=182837&pathrev=182838
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/extensions/extension_install_prompt.cc?r1=182838&r2=182837&pathrev=182838
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/webui/extensions/extension_settings_handler.h?r1=182838&r2=182837&pathrev=182838
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/extensions/extension_install_prompt.h?r1=182838&r2=182837&pathrev=182838
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc?r1=182838&r2=182837&pathrev=182838
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/resources/extensions/extension_list.js?r1=182838&r2=182837&pathrev=182838
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/resources/extensions/extensions.html?r1=182838&r2=182837&pathrev=182838

Merge 182274
> Revert 179916. It breaks on Mac.
> > Add a link (to view Permissions) to the Extension details on chrome://extensions.
> > 
> > BUG= 170742 
> > TEST=None
> > 
> > Review URL: https://chromiumcodereview.appspot.com/12094034
> 
> BUG= 170742 , 175071 
> TBR=finnur@chromium.org
> Review URL: https://codereview.chromium.org/12263014

TBR=mpcomplete@chromium.org
Review URL: https://codereview.chromium.org/12289013
------------------------------------------------------------------------
Comment 24 by dharani@chromium.org, Feb 16, 2013
Status: Fixed
Comment 25 by agautam@chromium.org, Feb 19, 2013
Labels: Action-FeedbackNeeded
Tested this issue on 26.0.1410.10 Dev on Mac 10.8.2 and observing that permission link is now disabled. please let us know testing scenario for this issue.
Comment 26 by mhx...@motorola.com, Feb 19, 2013
This is reverted from M26 in r182838. To enable it back, we need to merge r182576 & r182837
Project Member Comment 27 by bugdroid1@chromium.org, Feb 19, 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=183258

------------------------------------------------------------------------
r183258 | mpcomplete@chromium.org | 2013-02-19T18:54:43.908950Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/webui/extensions/extension_settings_handler.cc?r1=183258&r2=183257&pathrev=183258
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/extensions/extension_install_prompt.cc?r1=183258&r2=183257&pathrev=183258
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm?r1=183258&r2=183257&pathrev=183258
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/webui/extensions/extension_settings_handler.h?r1=183258&r2=183257&pathrev=183258
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm?r1=183258&r2=183257&pathrev=183258
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/extensions/extension_install_prompt.h?r1=183258&r2=183257&pathrev=183258
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.h?r1=183258&r2=183257&pathrev=183258
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc?r1=183258&r2=183257&pathrev=183258
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.mm?r1=183258&r2=183257&pathrev=183258
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/resources/extensions/extension_list.js?r1=183258&r2=183257&pathrev=183258
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/resources/extensions/extensions.html?r1=183258&r2=183257&pathrev=183258
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm?r1=183258&r2=183257&pathrev=183258
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/app/generated_resources.grd?r1=183258&r2=183257&pathrev=183258

Merge 182576 to M26 beta branch.
> Re-land "view permission" feature (r179916) with Mac Fix.
> 
> The feature review URL: http://crrev.com/12094034
> Mac fix review URL: http://crrev.com/12258023
> This CL also combines the extension_install_prompt changes reviewed at http://crrev.com/12220142
> 
> RootCause for Mac failure: Permission Prompt does not have a OK button. 
> And Chrome hangs while trying to create a OK button with empty string. 
> Solution: Remove |okButton_| when its title is empty and adjust 
> |cancelButton_|'s position. 
> The screenshot with the fix is uploaded at http://crbug.com/175071#c15 
> 
> BUG= 170742 , 175071 
> TBR=finnur@chromium.org
> TBR=sky@chromium.org for http://crrev.com/12094034
> TBR=sail@chromium.org for http://crrev.com/12258023
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/12212195

TBR=MHX348@motorola.com
Review URL: https://codereview.chromium.org/12303030
------------------------------------------------------------------------
Project Member Comment 28 by bugdroid1@chromium.org, Mar 9, 2013
Labels: -Action-FeedbackNeeded Needs-Feedback
Project Member Comment 29 by bugdroid1@chromium.org, Mar 9, 2013
Labels: -Type-Regression -Area-Internals -Feature-Extensions -Mstone-26 Type-Bug-Regression Cr-Platform-Extensions Cr-Internals M-26
Sign in to add a comment