New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 14 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Whole folder is getting Cut/Removed when a part of 'Text' is cut using (Ctrl+X) in Bookmark Manager.

Project Member Reported by ashej...@chromium.org, Feb 6 2013

Issue description

Chrome Version       : <'26.0.1404.0'>
URLs (if applicable) :chrome://bookmarks/#1


What steps will reproduce the problem?
1.Install and launch above chrome version.
2.Open bookmark manager using "Ctrl+Shift+O".
3.<Right click> "Bookmark bar" & Create a "New folder" with Name "Google Chrome".
4.Click on Bookmark bar again, "Google chrome" folder will be displayed on the right hand side.
5.Click on "Google chrome" folder on right hand side and hit F2, now Select text "Google" and hit "Ctrl+X".
6.Observe.

What is the expected result?
It should allow user to cut part of text while renaming the folder using "Ctrl+X".


What happens instead?
Whole folder is getting Cut/Removed.

Note:- Regression issue as functionality is working correctly in latest stable version "24.0.1312.57".

Will provide the bisect info shortly.
Attached is the Print-Screen below.

 
Ctrl+X_bookmarks.jpg
88.3 KB View Download
Summary: Whole folder is getting Cut/Removed when a part of 'Text' is cut using (Ctrl+X) in Bookmark Manager. (was: Regression:- Cutting (Ctrl+X) part of text is not working as intended in Bookmarks Manager.)
Labels: Mstone-25 ReleaseBlock-Stable
Below is the bisect info:-
Good build:-25.0.1356.0
Bad Build:-25.0.1358.0

Narrow bisect from bisect tool:-

You are probably looking for a change made after 172222 (known good), but no lat
er than 172253 (first known bad).
WEBKIT CHANGELOG URL:
  http://trac.webkit.org/log/trunk/?rev=137213&stop_rev=137194&verbose=on&limit=
10000
CHANGELOG URL:
  http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/tru
nk/src&range=172222%3A172253

Comment 3 by k...@google.com, Feb 6 2013

Labels: -Mstone-25 -ReleaseBlock-Stable Mstone-26
Won't hold for this.
Cc: thakis@chromium.org
Owner: a...@chromium.org
Status: Assigned
Avi, this one might be related to the other one "bookmark" bug assigned to you. Please excuse if I am wrong and assign back to me if that's the case.

Thank you!
Cc: ashej...@chromium.org
 Issue 177929  has been merged into this issue.

Comment 6 by a...@chromium.org, Feb 28 2013

Cc: a...@chromium.org
Owner: tanyarad@google.com
What other bookmark bug? I don't know anything about the bookmark manager.
Cc: yosin@chromium.org
**Suspecting 172230 revisions might have cause the above issue**
Looping the developer of the above revision.
Thanks

Comment 8 by yosin@chromium.org, Mar 1 2013

Owner: yosin@chromium.org
Status: Started
I found a root cause in r172230, and submit patch for review:
https://codereview.chromium.org/12387036/

Comment 9 by yosin@chromium.org, Mar 1 2013

Cc: mbollu@chromium.org
 Issue 178414  has been merged into this issue.
Cc: nyerramilli@chromium.org
 Issue 179039  has been merged into this issue.
Labels: OS-Chrome
This issue is also reproducible on "ChromeOS-Daisy" below are the details.

Google chrome:-25.0.1364.152(185281).
Platform:-3428.196.0 (Stable-channel daisy).
Webkit:-537.22 (@144108)
Javascript: V8 3.15.11.16. 
Hence adding OS-Chrome label.
Thanks 

Comment 12 Deleted

Labels: -OS-Chrome
 Issue 180177  has been merged into this issue.
Status: Fixed
Sorry for late response. I forgot to put review link.
https://codereview.chromium.org/12387036/

I got LGTM. Once, I verify the fix on Canary, I'll request merge to M25 and M26.
Thanks!
Project Member

Comment 16 by bugdroid1@chromium.org, Mar 6 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=186312

------------------------------------------------------------------------
r186312 | yosin@chromium.org | 2013-03-06T01:08:51.706030Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/bookmark_manager/js/main.js?r1=186312&r2=186311&pathrev=186312

Bookmark manager: Handle "copy", "cut"and "paste" events only when list or tree pane active.

This caused by a change of getSelectedBookmarkNodes() in r172230. Before r177230, getSelectedBookmarkNodes() threw error unless list or tree is active. From r177230, getSelectedBookmarkNodes() returns selected items of list when list nor tree is active.

Note: For a11y, when context menu or organize menu is open, menu takes focus. So, list/tree is no more active element when menu is opened.

This causes "cut" event handler of document object does "cut" operation on an active item of list. In bug case, an active item is editing bookmark.

This patch changes to check active element in "copy", "cut", and "paste" event handler.

BUG= 174613 
TEST=On bookmark manager, edit/rename bookmark/folder and hit Ctrl+X in edit field.

Review URL: https://codereview.chromium.org/12387036
------------------------------------------------------------------------
Labels: -Mstone-26 Mstone-25 Merge-Requested
Verified on canary
  27.0.1431.2 (Official Build 186408) canary

Please approve to merge M25 branch and M26 branch.
Thanks in advance.

Note: Changes are adding two liens of JavaScript code into chrome/browser/resources/bookmark_manager/main.js. So, this change won't cause crash.

On Chromium  27.0.1432.0 (186556)
This bug is fixed well,
But I can't use Ctrl+X,Ctrl+C,Ctrl+V to cut copy paste bookmark itself in Bookmark manager anymore!

It works ok in the current chrome stable branch!
Status: Started
MeiJialun@ Thanks for finding this. I'm so stupid.

I submit the patch:
https://codereview.chromium.org/12583002/

Project Member

Comment 20 by bugdroid1@chromium.org, Mar 8 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=186843

------------------------------------------------------------------------
r186843 | yosin@chromium.org | 2013-03-08T01:36:52.416240Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/bookmark_manager/js/main.js?r1=186843&r2=186842&pathrev=186843

REGRESSION(r174613) Bookmark manager: Ctrl+C, Ctrl+X, and Ctrl+V doesn't work

This patch fixes regerssion of r174613. Conditional expression for checking active element was wrong, it uses "||" rather than "&&"

Bad patch:
https://codereview.chromium.org/12387036/

BUG= 174613 

Review URL: https://codereview.chromium.org/12583002
------------------------------------------------------------------------
Project Member

Comment 21 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Type-Regression -Area-UI -Feature-Bookmarks -Mstone-25 Type-Bug-Regression Cr-UI-Browser-Bookmarks Cr-UI M-25

Comment 22 by yosin@chromium.org, Mar 11 2013

Status: Fixed
Verified on "27.0.1435.0 (Official Build 187188) canary"
- Ctrl+X and Ctrl+C can cut/copy bookmark
- Ctrl+V works
- Ctrl+X and Ctrl+C can cut/copy contents of label/URI fields

Please approve merge to M25 and M26 branches.
Thanks in advance!
Labels: -M-25 M-26
Merge approved for M26
Labels: -Merge-Requested Merge-Approved
Project Member

Comment 25 by bugdroid1@chromium.org, Mar 12 2013

Labels: -Merge-Approved merge-merged-1364
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=187445

------------------------------------------------------------------------
r187445 | yosin@chromium.org | 2013-03-12T01:39:11.283022Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1364/src/chrome/browser/resources/bookmark_manager/js/main.js?r1=187445&r2=187444&pathrev=187445

Merge 186312
> Bookmark manager: Handle "copy", "cut"and "paste" events only when list or tree pane active.
> 
> This caused by a change of getSelectedBookmarkNodes() in r172230. Before r177230, getSelectedBookmarkNodes() threw error unless list or tree is active. From r177230, getSelectedBookmarkNodes() returns selected items of list when list nor tree is active.
> 
> Note: For a11y, when context menu or organize menu is open, menu takes focus. So, list/tree is no more active element when menu is opened.
> 
> This causes "cut" event handler of document object does "cut" operation on an active item of list. In bug case, an active item is editing bookmark.
> 
> This patch changes to check active element in "copy", "cut", and "paste" event handler.
> 
> BUG= 174613 
> TEST=On bookmark manager, edit/rename bookmark/folder and hit Ctrl+X in edit field.
> 
> Review URL: https://codereview.chromium.org/12387036

TBR=yosin@chromium.org
------------------------------------------------------------------------

Comment 26 by yosin@chromium.org, Mar 12 2013

Cc: yoichio@chromium.org
 Issue 181670  has been merged into this issue.

Comment 27 by yosin@chromium.org, Mar 12 2013

M25 merge r187455 is reverted.

Comment 28 by yosin@chromium.org, Mar 12 2013

Labels: -merge-merged-1364
For M26, please merge it in 1410 branch.
Project Member

Comment 30 by bugdroid1@chromium.org, Mar 12 2013

Labels: merge-merged-1410
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=187479

------------------------------------------------------------------------
r187479 | chrome-bot@google.com | 2013-03-12T03:50:03.619206Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/resources/bookmark_manager/js/main.js?r1=187479&r2=187478&pathrev=187479

Merge 186312
> Bookmark manager: Handle "copy", "cut"and "paste" events only when list or tree pane active.
> 
> This caused by a change of getSelectedBookmarkNodes() in r172230. Before r177230, getSelectedBookmarkNodes() threw error unless list or tree is active. From r177230, getSelectedBookmarkNodes() returns selected items of list when list nor tree is active.
> 
> Note: For a11y, when context menu or organize menu is open, menu takes focus. So, list/tree is no more active element when menu is opened.
> 
> This causes "cut" event handler of document object does "cut" operation on an active item of list. In bug case, an active item is editing bookmark.
> 
> This patch changes to check active element in "copy", "cut", and "paste" event handler.
> 
> BUG= 174613 
> TEST=On bookmark manager, edit/rename bookmark/folder and hit Ctrl+X in edit field.
> 
> Review URL: https://codereview.chromium.org/12387036

TBR=yosin@chromium.org
Review URL: https://codereview.chromium.org/12566031
------------------------------------------------------------------------
Labels: TE-Verified-26.0.1410.33
Tested the issue and it is working fine on chrome version 26.0.1410.33 (Official Build 187744) beta - MAC 0.8.2, Windows 7 OS.

Cut, copy and paste options are working fine with Bookmark pages and folders.
Labels: -M-26 M-25 Merge-Requested
M25 merge requested.
Issue reproducible on below version chromeOS & Still whole folder is getting "Cut/Removed" while renaming in bookmark manager.

Version 26.0.1410.30 beta
Platform 3701.46.0 (Official Build) beta-channel daisy
Firmware Google_Snow.2695.117.0.


26.0.1410.30 doesn't have the fix. That's why its not fixed for Chrome OS.
Labels: Needs-Feedback
kenjibaheux@, I am wondering is M25 merge still required here? Since M25 is out of production builds (i.e Not a Dev / Beta / Stable) currently.

Thank you.
Labels: -M-25 -Merge-Requested
Nope. Thanks for following up!
Labels: -Needs-Feedback

Sign in to add a comment