New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 174035 link

Starred by 21 users

Issue metadata

Status: Verified
Owner:
Email to this user bounced
Closed: Mar 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Switch window key (F5) stopped working with new launcher

Reported by tturchetto@chromium.org, Feb 1 2013

Issue description

Google Chrome	26.0.1400.0 (Official Build 180085) dev
Platform	3644.0.0 (Official Build) dev-channel 

Please specify Area-* of the system to which this bug/feature applies (add
the label below).

Switch window key (F5) stopped working on R26 TOT
 
Cc: osh...@chromium.org skuhne@chromium.org
Labels: -Type-Bug -Pri-2 -Feature-Ash Type-Regression Pri-1 Feature-Ash-WM ReleaseBlock-Stable
Status: Available
Yes, this seems to have regressed.
Cc: krisr@chromium.org tturchetto@chromium.org patricia@chromium.org
 Issue 174040  has been merged into this issue.
Cc: sontis@chromium.org chiraggupta@chromium.org
Owner: osh...@chromium.org
Status: Assigned
Status: Started
Cc: kuscher@chromium.org
Labels: -Mstone-26 Mstone-27
Owner: skuhne@chromium.org
Status: Assigned
This is due because the new launcher changed the way it creates launcher items.
F5 is designed to wall though the launcher items, so we need to redesign F5 functionality
for new launcher (+kuscher). Moving to 27 as new launcher is disabled for 26.
 We need to fix the test (launcher_navigator_unittest) though.
It's using fake environment and the test didn't fail when this feature is enabled.
It should use the AshTestBase instead.

 Assigning to stefan as it owns this feature.
Cc: pkotw...@chromium.org

Comment 8 Deleted

Platform 26.0.1405.0   (Official Build 180921) dev
ChromeOS 3666.0.0      (Official Build) dev-channel
 
F5 works on R26 TOT
Status: Started
Will look into this.
Status: Assigned
I was too fast - (didn't read the entire thread before marking it as started).

Since this is a new launcher item I look at it later.

Comment 12 by kareng@google.com, Feb 11 2013

just heads up m27 starts this week so please don't put off too long :)
Labels: iteration-76
I know. Was

Comment 14 by kareng@google.com, Feb 13 2013

thanks :) since we're far away from stable date, i am going to assume it will get done before branch point and won't block anyway. do we need the blocker label on it?
Labels: -ReleaseBlock-Stable
Summary: Switch window key (F5) stopped working with new launcher (was: Switch window key (F5) stopped working)
Just to be clear. This is for 27, but not 26. Updated the summary and removed
blocker label to avoid confusion.
Yepp indeed. No blocker (yet).
After discussing with Alex we should possibly use F5 to cycle through our workspaces.
Labels: -iteration-76
Owner: harrym@chromium.org
Bug swap!  Per-app launcher is targeted for M27, so still P1.

Labels: iteration-76
Platform 27.0.1430.0   dev
ChromeOS 3797.0.0      dev-channel

not work on tot R27
Labels: ReleaseBlock-Beta OS-Chrome
Tagging as blocker to track it before getting to beta
Project Member

Comment 22 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Type-Regression -Area-UI -Feature-Ash-WM -Mstone-27 Cr-UI-Shell-WindowManager Type-Bug-Regression Cr-UI M-27
Be sure to check with pkotwicz about this, as he was looking at that key for some workspace switching stuff.

harrym@, I was going to hook up the workspace switching button to do the same thing as Alt-Tab.
I am working on doing some super fancy animations for workspace switching. (Similar to how the tab switcher looks on Chrome for Android). However it is super experimental and may not be good enough to turn on by default for a couple milestones.
In the mean time we could either stick with making it do Alt-Tab or something better. I am not sure if you had something better in mind.

Comment 25 by zonte...@gmail.com, Mar 14 2013

Hi guys,
after reading all the issue... i'm not sure... is the switch window key not working yet? Or is the problem already fixed? I have a Chromebook - Samsung - and my switch window key is not working. Is there any alternative?
thanks in advance.
Screenshot 2013-03-14 at 17.00.38.png
22.7 KB View Download
[Triage] Harry, can you just wire this up to Alt-Tab?
Status: Started
Project Member

Comment 28 by bugdroid1@chromium.org, Mar 26 2013

------------------------------------------------------------------------
r190579 | harrym@chromium.org | 2013-03-26T07:43:18.126552Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ash/shelf/shelf_layout_manager.cc?r1=190579&r2=190578&pathrev=190579
   M http://src.chromium.org/viewvc/chrome/trunk/src/ash/wm/window_cycle_controller.cc?r1=190579&r2=190578&pathrev=190579
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/extensions/wallpaper_private_api.cc?r1=190579&r2=190578&pathrev=190579
   M http://src.chromium.org/viewvc/chrome/trunk/src/ash/accelerators/accelerator_controller.cc?r1=190579&r2=190578&pathrev=190579
   M http://src.chromium.org/viewvc/chrome/trunk/src/ash/wm/window_cycle_controller.h?r1=190579&r2=190578&pathrev=190579
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/ash/window_positioner.cc?r1=190579&r2=190578&pathrev=190579
   M http://src.chromium.org/viewvc/chrome/trunk/src/ash/focus_cycler.cc?r1=190579&r2=190578&pathrev=190579
   M http://src.chromium.org/viewvc/chrome/trunk/src/ash/wm/gestures/bezel_gesture_handler.cc?r1=190579&r2=190578&pathrev=190579
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/window_sizer/window_sizer_ash.cc?r1=190579&r2=190578&pathrev=190579

Switch Next Window Key functionality

Switches the next window button on chromeos (f5) to act the same as alt-tab/shift-alt-tab


BUG= 174035 
TBR=sky@chromium.org


Review URL: https://chromiumcodereview.appspot.com/12618014
------------------------------------------------------------------------
Any additional CL needed here? can you merge request to M-27 branch if ready?
Labels: -iteration-76 Merge-Requested

Comment 31 by kareng@google.com, Mar 29 2013

Labels: -Merge-Requested Merge-Approved
can someone confirm this is indeed working ?
Project Member

Comment 32 by bugdroid1@chromium.org, Mar 29 2013

Labels: -Merge-Approved merge-merged-1453
------------------------------------------------------------------------
r191466 | harrym@chromium.org | 2013-03-29T23:29:37.638526Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1453/src/chrome/browser/ui/ash/window_positioner.cc?r1=191466&r2=191465&pathrev=191466
   M http://src.chromium.org/viewvc/chrome/branches/1453/src/ash/focus_cycler.cc?r1=191466&r2=191465&pathrev=191466
   M http://src.chromium.org/viewvc/chrome/branches/1453/src/ash/wm/gestures/bezel_gesture_handler.cc?r1=191466&r2=191465&pathrev=191466
   M http://src.chromium.org/viewvc/chrome/branches/1453/src/chrome/browser/ui/window_sizer/window_sizer_ash.cc?r1=191466&r2=191465&pathrev=191466
   M http://src.chromium.org/viewvc/chrome/branches/1453/src/ash/shelf/shelf_layout_manager.cc?r1=191466&r2=191465&pathrev=191466
   M http://src.chromium.org/viewvc/chrome/branches/1453/src/ash/wm/window_cycle_controller.cc?r1=191466&r2=191465&pathrev=191466
   M http://src.chromium.org/viewvc/chrome/branches/1453/src/chrome/browser/chromeos/extensions/wallpaper_private_api.cc?r1=191466&r2=191465&pathrev=191466
   M http://src.chromium.org/viewvc/chrome/branches/1453/src/ash/accelerators/accelerator_controller.cc?r1=191466&r2=191465&pathrev=191466
   M http://src.chromium.org/viewvc/chrome/branches/1453/src/ash/wm/window_cycle_controller.h?r1=191466&r2=191465&pathrev=191466

Merge 190579 "Switch Next Window Key functionality"

> Switch Next Window Key functionality
> 
> Switches the next window button on chromeos (f5) to act the same as alt-tab/shift-alt-tab
> 
> 
> BUG= 174035 
> TBR=sky@chromium.org
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/12618014

TBR=harrym@chromium.org
Review URL: https://codereview.chromium.org/13224006
------------------------------------------------------------------------
Status: Fixed
 Issue 225308  has been merged into this issue.
Status: Verified
Google Chrome	27.0.1453.15 (Official Build 191758) dev
Platform	3912.9.0 (Official Build) dev-channel link
WebKit	537.36 (@147366)
JavaScript	V8 3.17.6.1

Sign in to add a comment