New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: ----

Blocked on:
issue 236272



Sign in to add a comment

Disallow from scoped_ptr<T> construction from NULL

Project Member Reported by dcheng@chromium.org, Jan 31 2013

Issue description

This matches the behavior of unique_ptr<T>:

$ cat test.cc
#include <memory>

int main() {
  std::unique_ptr<int> y(0);
}
$ clang++ -std=c++11 -stdlib=libc++ -c test.cc -Wall
test.cc:4:24: error: call to constructor of 'std::unique_ptr<int>' is ambiguous
  std::unique_ptr<int> y(0);
                       ^ ~
/usr/include/c++/4.6/bits/unique_ptr.h:120:7: note: candidate constructor
      unique_ptr(pointer __p)
      ^
/usr/include/c++/4.6/bits/unique_ptr.h:136:17: note: candidate constructor
      constexpr unique_ptr(nullptr_t)
                ^
/usr/include/c++/4.6/bits/unique_ptr.h:142:7: note: candidate constructor
      unique_ptr(unique_ptr&& __u)
      ^
/usr/include/c++/4.6/bits/unique_ptr.h:256:7: note: candidate constructor has
been explicitly
      deleted
      unique_ptr(const unique_ptr&) = delete;
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Type-Cleanup -Pri-2 -Area-Internals Cr-Internals Pri-3
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 12 2013

------------------------------------------------------------------------
r205700 | dcheng@chromium.org | 2013-06-12T03:02:45.979668Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/tools/clang/rewrite_scoped_ptr_ctor_null/tests/test-original.cc?r1=205700&r2=205699&pathrev=205700
   M http://src.chromium.org/viewvc/chrome/trunk/src/tools/clang/rewrite_scoped_ptr_ctor_null/RewriteScopedPtrCtorNull.cpp?r1=205700&r2=205699&pathrev=205700
   M http://src.chromium.org/viewvc/chrome/trunk/src/tools/clang/rewrite_scoped_ptr_ctor_null/tests/test-expected.cc?r1=205700&r2=205699&pathrev=205700

Teach rewrite_scoped_ptr_ctor_null about scoped_ptr_malloc's default arg

Without filtering out default args, the tool matches the implicit
initializers generated for scoped_ptr_malloc<T> members... and then
deletes random tokens. Needless to say, the result doesn't compile.

BUG= 173286 
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/16658016
------------------------------------------------------------------------
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 12 2013

------------------------------------------------------------------------
r205741 | dcheng@chromium.org | 2013-06-12T13:10:15.933990Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/plugins/ppapi/ppapi_plugin_instance.cc?r1=205741&r2=205740&pathrev=205741
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/browser/database/database_tracker.cc?r1=205741&r2=205740&pathrev=205741

Rewrite scoped_ptr<T>(NULL) to use the default ctor in webkit/.

This is the result of running the rewrite_scoped_ptr_ctor_null tool
across all files built on Linux in the webkit/ directory.

BUG= 173286 

Review URL: https://chromiumcodereview.appspot.com/15662016
------------------------------------------------------------------------
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 12 2013

------------------------------------------------------------------------
r205779 | dcheng@chromium.org | 2013-06-12T14:48:11.209790Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/resource/resource_bundle_unittest.cc?r1=205779&r2=205778&pathrev=205779

Rewrite scoped_ptr<T>(NULL) to use the default ctor in ui/.

This is the result of running the rewrite_scoped_ptr_ctor_null tool
across all files built on Linux in the ui/ directory.

BUG= 173286 

Review URL: https://chromiumcodereview.appspot.com/15967013
------------------------------------------------------------------------
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 12 2013

------------------------------------------------------------------------
r205810 | dcheng@chromium.org | 2013-06-12T16:23:58.739113Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/resources/resource_update_controller_unittest.cc?r1=205810&r2=205809&pathrev=205810
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/test/layer_tree_test.cc?r1=205810&r2=205809&pathrev=205810
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/layers/layer_unittest.cc?r1=205810&r2=205809&pathrev=205810
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/layers/texture_layer_unittest.cc?r1=205810&r2=205809&pathrev=205810
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/trees/layer_tree_host_impl_unittest.cc?r1=205810&r2=205809&pathrev=205810
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/layers/tiled_layer_unittest.cc?r1=205810&r2=205809&pathrev=205810
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/trees/single_thread_proxy.cc?r1=205810&r2=205809&pathrev=205810
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/layers/scrollbar_layer_unittest.cc?r1=205810&r2=205809&pathrev=205810
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/trees/layer_tree_host_unittest_context.cc?r1=205810&r2=205809&pathrev=205810
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/trees/tree_synchronizer_unittest.cc?r1=205810&r2=205809&pathrev=205810
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/base/scoped_ptr_hash_map.h?r1=205810&r2=205809&pathrev=205810
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/layers/delegated_renderer_layer_impl_unittest.cc?r1=205810&r2=205809&pathrev=205810
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/base/scoped_ptr_vector.h?r1=205810&r2=205809&pathrev=205810
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/layers/nine_patch_layer_unittest.cc?r1=205810&r2=205809&pathrev=205810
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/resources/prioritized_resource_unittest.cc?r1=205810&r2=205809&pathrev=205810

Rewrite scoped_ptr<T>(NULL) to use the default ctor in cc/.

This is the result of running the rewrite_scoped_ptr_ctor_null tool
across all files built on Linux in the cc/ directory.

BUG= 173286 

Review URL: https://chromiumcodereview.appspot.com/16355009
------------------------------------------------------------------------
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 12 2013

------------------------------------------------------------------------
r205836 | dcheng@chromium.org | 2013-06-12T17:10:10.411131Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/gpu/command_buffer/service/gpu_scheduler.cc?r1=205836&r2=205835&pathrev=205836

Rewrite scoped_ptr<T>(NULL) to use the default ctor in gpu/.

This is the result of running the rewrite_scoped_ptr_ctor_null tool
across all files built on Linux in the gpu/ directory.

BUG= 173286 

Review URL: https://chromiumcodereview.appspot.com/16443007
------------------------------------------------------------------------
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 12 2013

------------------------------------------------------------------------
r205866 | dcheng@chromium.org | 2013-06-12T17:58:55.270427Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/website_settings/website_settings_unittest.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/dns_probe_service.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/predictor.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/api/socket/socket_api.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/profile_impl_io_data.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/sqlite_server_bound_cert_store.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/menu_manager.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_history.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_sync_bundle.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/permissions/api_permission.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/startup_pages_handler.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/character_encoding.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/google_apis/gdata_wapi_parser.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/app_sync_bundle.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/api/web_request/form_data_parser_unittest.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_database.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_event_queue.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/api/declarative_content/content_condition.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/search/instant_controller.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/google_apis/drive_api_parser.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/custom_button.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/google_apis/gdata_wapi_service.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/google_apis/drive_api_service.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/component_updater/test/component_updater_service_unittest.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/external_provider_impl.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/user_script_slave.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_function.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/performance_monitor/performance_monitor.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/dns_probe_service_unittest.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/shared_change_processor_unittest.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/database_manager.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/search/instant_loader.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/off_the_record_profile_io_data.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/notifications/balloon_notification_ui_manager.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/background/background_application_list_model.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_history_unittest.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync_file_system/drive_file_sync_service_sync_unittest.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/performance_monitor/performance_monitor_ui_util_unittest.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/translate/translate_helper_metrics_unittest.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/chromedriver/chrome/performance_logger_unittest.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync_file_system/drive_file_sync_service_unittest.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/performance_monitor/performance_monitor_ui_util.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/search/instant_controller_unittest.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/api/declarative/declarative_rule.h?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/malware_details_cache.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/test_extension_prefs.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager_metrics_unittest.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_unittest.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/profile_manager.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/value_store/value_store_frontend_unittest.cc?r1=205866&r2=205865&pathrev=205866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/icon_loader.cc?r1=205866&r2=205865&pathrev=205866

Rewrite scoped_ptr<T>(NULL) to use the default ctor in chrome/.

This is the result of running the rewrite_scoped_ptr_ctor_null tool
across all files built on Linux in the chrome/ directory.

BUG= 173286 

Review URL: https://chromiumcodereview.appspot.com/16703018
------------------------------------------------------------------------
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 12 2013

------------------------------------------------------------------------
r205884 | dcheng@chromium.org | 2013-06-12T18:42:16.273526Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/webm/webm_crypto_helpers.cc?r1=205884&r2=205883&pathrev=205884
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/ffmpeg/ffmpeg_unittest.cc?r1=205884&r2=205883&pathrev=205884

Rewrite scoped_ptr<T>(NULL) to use the default ctor in media/.

This is the result of running the rewrite_scoped_ptr_ctor_null tool
across all files built on Linux in the media/ directory.

BUG= 173286 

Review URL: https://chromiumcodereview.appspot.com/16705009
------------------------------------------------------------------------
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 12 2013

------------------------------------------------------------------------
r205919 | dcheng@chromium.org | 2013-06-12T20:34:11.219055Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/sync/engine/sync_scheduler_unittest.cc?r1=205919&r2=205918&pathrev=205919
   M http://src.chromium.org/viewvc/chrome/trunk/src/sync/syncable/directory_backing_store.cc?r1=205919&r2=205918&pathrev=205919
   M http://src.chromium.org/viewvc/chrome/trunk/src/sync/test/engine/mock_connection_manager.cc?r1=205919&r2=205918&pathrev=205919

Rewrite scoped_ptr<T>(NULL) to use the default ctor in sync/.

This is the result of running the rewrite_scoped_ptr_ctor_null tool
across all files built on Linux in the sync/ directory.

BUG= 173286 

Review URL: https://chromiumcodereview.appspot.com/16654009
------------------------------------------------------------------------
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 12 2013

------------------------------------------------------------------------
r205961 | dcheng@chromium.org | 2013-06-12T22:53:01.456903Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/tcp_listen_socket_unittest.cc?r1=205961&r2=205960&pathrev=205961
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/quic/quic_stream_factory.cc?r1=205961&r2=205960&pathrev=205961
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_proxy_client_socket_unittest.cc?r1=205961&r2=205960&pathrev=205961
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_script_fetcher_impl.cc?r1=205961&r2=205960&pathrev=205961
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/dns/dns_socket_pool.cc?r1=205961&r2=205960&pathrev=205961
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/test/embedded_test_server/embedded_test_server.cc?r1=205961&r2=205960&pathrev=205961
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/dns/dns_session.cc?r1=205961&r2=205960&pathrev=205961
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_auth_handler_negotiate.cc?r1=205961&r2=205960&pathrev=205961
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/dns/dns_transaction_unittest.cc?r1=205961&r2=205960&pathrev=205961
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/url_request/url_request_http_job.cc?r1=205961&r2=205960&pathrev=205961
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_proxy_client_socket_pool_spdy2_unittest.cc?r1=205961&r2=205960&pathrev=205961
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_proxy_client_socket_pool_spdy3_unittest.cc?r1=205961&r2=205960&pathrev=205961
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/url_request/url_fetcher_core.cc?r1=205961&r2=205960&pathrev=205961
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_stream_parser.cc?r1=205961&r2=205960&pathrev=205961
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/disk_cache/simple/simple_index_file.cc?r1=205961&r2=205960&pathrev=205961
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_cache_transaction.cc?r1=205961&r2=205960&pathrev=205961
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/deterministic_socket_data_unittest.cc?r1=205961&r2=205960&pathrev=205961
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/url_request/url_fetcher_impl_unittest.cc?r1=205961&r2=205960&pathrev=205961
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/base/filter.cc?r1=205961&r2=205960&pathrev=205961
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/base/sdch_filter.cc?r1=205961&r2=205960&pathrev=205961
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/ftp/ftp_network_transaction.cc?r1=205961&r2=205960&pathrev=205961
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_transaction_unittest.cc?r1=205961&r2=205960&pathrev=205961

Rewrite scoped_ptr<T>(NULL) to use the default ctor in net/.

This is the result of running the rewrite_scoped_ptr_ctor_null tool
across all files built on Linux in the net/ directory.

BUG= 173286 

Review URL: https://chromiumcodereview.appspot.com/16434016
------------------------------------------------------------------------
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 13 2013

------------------------------------------------------------------------
r206062 | dcheng@chromium.org | 2013-06-13T13:42:30.276395Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_host_browsertest.cc?r1=206062&r2=206061&pathrev=206062
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/touchscreen_tap_suppression_controller_stub.cc?r1=206062&r2=206061&pathrev=206062
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/loader/resource_dispatcher_host_browsertest.cc?r1=206062&r2=206061&pathrev=206062
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/device_orientation_dispatcher.cc?r1=206062&r2=206061&pathrev=206062
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/media/gpu_video_decode_accelerator.cc?r1=206062&r2=206061&pathrev=206062
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/session_history_browsertest.cc?r1=206062&r2=206061&pathrev=206062
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_data_remover_impl.cc?r1=206062&r2=206061&pathrev=206062
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_browser_main_parts.cc?r1=206062&r2=206061&pathrev=206062
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/test/test_renderer_host.cc?r1=206062&r2=206061&pathrev=206062
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_file_unittest.cc?r1=206062&r2=206061&pathrev=206062
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/gpu_memory_manager_unittest.cc?r1=206062&r2=206061&pathrev=206062
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/net/sqlite_persistent_cookie_store.cc?r1=206062&r2=206061&pathrev=206062
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/gpu_channel_manager.cc?r1=206062&r2=206061&pathrev=206062
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/drag_download_file_browsertest.cc?r1=206062&r2=206061&pathrev=206062
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/devtools/devtools_protocol.cc?r1=206062&r2=206061&pathrev=206062
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/websharedworker_stub.cc?r1=206062&r2=206061&pathrev=206062
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/cc_messages.cc?r1=206062&r2=206061&pathrev=206062
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/v8_value_converter_impl_unittest.cc?r1=206062&r2=206061&pathrev=206062
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_impl.cc?r1=206062&r2=206061&pathrev=206062
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/touchpad_tap_suppression_controller.cc?r1=206062&r2=206061&pathrev=206062
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/google_streaming_remote_engine.cc?r1=206062&r2=206061&pathrev=206062

Rewrite scoped_ptr<T>(NULL) to use the default ctor in content/.

This is the result of running the rewrite_scoped_ptr_ctor_null tool
across all files built on Linux in the content/ directory.

BUG= 173286 

Review URL: https://chromiumcodereview.appspot.com/16703020
------------------------------------------------------------------------
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 13 2013

------------------------------------------------------------------------
r206104 | dcheng@chromium.org | 2013-06-13T17:32:14.036746Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/extensions/common/matcher/url_matcher_unittest.cc?r1=206104&r2=206103&pathrev=206104
   M http://src.chromium.org/viewvc/chrome/trunk/src/extensions/common/matcher/url_matcher_factory.cc?r1=206104&r2=206103&pathrev=206104

Rewrite scoped_ptr<T>(NULL) to use the default ctor in extensions/.

This is the result of running the rewrite_scoped_ptr_ctor_null tool
across all files built on Linux in the extensions/ directory.

BUG= 173286 

Review URL: https://chromiumcodereview.appspot.com/16866009
------------------------------------------------------------------------
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 13 2013

------------------------------------------------------------------------
r206116 | dcheng@chromium.org | 2013-06-13T18:01:07.558528Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/prefs/json_pref_store.cc?r1=206116&r2=206115&pathrev=206116
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/debug/trace_event_impl.cc?r1=206116&r2=206115&pathrev=206116
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/memory/scoped_vector_unittest.cc?r1=206116&r2=206115&pathrev=206116
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/threading/worker_pool_posix.cc?r1=206116&r2=206115&pathrev=206116

Rewrite scoped_ptr<T>(NULL) to use the default ctor in base/.

This is the result of running the rewrite_scoped_ptr_ctor_null tool
across all files built on Linux in the base/ directory.

BUG= 173286 

Review URL: https://chromiumcodereview.appspot.com/16950008
------------------------------------------------------------------------
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 13 2013

------------------------------------------------------------------------
r206118 | dcheng@chromium.org | 2013-06-13T18:06:25.793608Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc?r1=206118&r2=206117&pathrev=206118

Rewrite scoped_ptr<T>(NULL) to use the default ctor in ppapi/.

This is the result of running the rewrite_scoped_ptr_ctor_null tool
across all files built on Linux in the ppapi/ directory.

BUG= 173286 

Review URL: https://chromiumcodereview.appspot.com/16965002
------------------------------------------------------------------------
Project Member

Comment 17 by bugdroid1@chromium.org, Jun 13 2013

------------------------------------------------------------------------
r206125 | dcheng@chromium.org | 2013-06-13T18:19:42.549356Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ash/root_window_controller.cc?r1=206125&r2=206124&pathrev=206125
   M http://src.chromium.org/viewvc/chrome/trunk/src/ash/wm/frame_painter.cc?r1=206125&r2=206124&pathrev=206125
   M http://src.chromium.org/viewvc/chrome/trunk/src/ash/wm/workspace/workspace_cycler.cc?r1=206125&r2=206124&pathrev=206125
   M http://src.chromium.org/viewvc/chrome/trunk/src/ash/wm/gestures/long_press_affordance_handler.cc?r1=206125&r2=206124&pathrev=206125
   M http://src.chromium.org/viewvc/chrome/trunk/src/ash/drag_drop/drag_drop_controller.cc?r1=206125&r2=206124&pathrev=206125
   M http://src.chromium.org/viewvc/chrome/trunk/src/ash/shelf/shelf_widget.cc?r1=206125&r2=206124&pathrev=206125
   M http://src.chromium.org/viewvc/chrome/trunk/src/ash/wm/workspace/workspace_window_resizer_unittest.cc?r1=206125&r2=206124&pathrev=206125
   M http://src.chromium.org/viewvc/chrome/trunk/src/ash/wm/drag_window_resizer_unittest.cc?r1=206125&r2=206124&pathrev=206125
   M http://src.chromium.org/viewvc/chrome/trunk/src/ash/wm/workspace/workspace_manager.cc?r1=206125&r2=206124&pathrev=206125
   M http://src.chromium.org/viewvc/chrome/trunk/src/ash/display/screen_position_controller_unittest.cc?r1=206125&r2=206124&pathrev=206125
   M http://src.chromium.org/viewvc/chrome/trunk/src/ash/wm/workspace/workspace_cycler_animator.cc?r1=206125&r2=206124&pathrev=206125

Rewrite scoped_ptr<T>(NULL) to use the default ctor in ash/.

This is the result of running the rewrite_scoped_ptr_ctor_null tool
across all files built on CrOS in the ash/ directory.

BUG= 173286 

Review URL: https://chromiumcodereview.appspot.com/16968003
------------------------------------------------------------------------
Project Member

Comment 18 by bugdroid1@chromium.org, Jun 13 2013

------------------------------------------------------------------------
r206127 | dcheng@chromium.org | 2013-06-13T18:26:31.631962Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/sql/connection.cc?r1=206127&r2=206126&pathrev=206127

Rewrite scoped_ptr<T>(NULL) to use the default ctor in sql/.

This is the result of running the rewrite_scoped_ptr_ctor_null tool
across all files built on Linux in the sql/ directory.

BUG= 173286 

Review URL: https://chromiumcodereview.appspot.com/16866008
------------------------------------------------------------------------
Project Member

Comment 19 by bugdroid1@chromium.org, Jun 14 2013

------------------------------------------------------------------------
r206234 | dcheng@chromium.org | 2013-06-14T00:03:39.753574Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/net_internals/net_internals_ui.cc?r1=206234&r2=206233&pathrev=206234
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/login_browsertest.cc?r1=206234&r2=206233&pathrev=206234
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chromeos/system_info_ui.cc?r1=206234&r2=206233&pathrev=206234
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc?r1=206234&r2=206233&pathrev=206234
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/net/network_portal_detector_stub.cc?r1=206234&r2=206233&pathrev=206234
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc?r1=206234&r2=206233&pathrev=206234
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc?r1=206234&r2=206233&pathrev=206234
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc?r1=206234&r2=206233&pathrev=206234
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/drive/resource_metadata_unittest.cc?r1=206234&r2=206233&pathrev=206234
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_view_layout.cc?r1=206234&r2=206233&pathrev=206234
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/cros/cros_library.cc?r1=206234&r2=206233&pathrev=206234
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/notifications/balloon_view_views.cc?r1=206234&r2=206233&pathrev=206234
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/login_utils_browsertest.cc?r1=206234&r2=206233&pathrev=206234
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/ash/launcher/launcher_context_menu.cc?r1=206234&r2=206233&pathrev=206234
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/drive/drive_integration_service_unittest.cc?r1=206234&r2=206233&pathrev=206234
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc?r1=206234&r2=206233&pathrev=206234
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc?r1=206234&r2=206233&pathrev=206234
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/status_bubble_views.cc?r1=206234&r2=206233&pathrev=206234

Rewrite scoped_ptr<T>(NULL) to use the default ctor in chrome/.

This is the result of running the rewrite_scoped_ptr_ctor_null tool
across all files built on CrOS in the chrome/ directory.

BUG= 173286 

Review URL: https://chromiumcodereview.appspot.com/16871010
------------------------------------------------------------------------
Project Member

Comment 20 by bugdroid1@chromium.org, Jun 14 2013

------------------------------------------------------------------------
r206241 | dcheng@chromium.org | 2013-06-14T00:22:59.467462Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chromeos/dbus/debug_daemon_client.cc?r1=206241&r2=206240&pathrev=206241
   M http://src.chromium.org/viewvc/chrome/trunk/src/chromeos/dbus/ibus/ibus_object.cc?r1=206241&r2=206240&pathrev=206241

Rewrite scoped_ptr<T>(NULL) to use the default ctor in chromeos/.

This is the result of running the rewrite_scoped_ptr_ctor_null tool
across all files built on CrOS in the chromeos/ directory.

BUG= 173286 

Review URL: https://chromiumcodereview.appspot.com/16966003
------------------------------------------------------------------------
Project Member

Comment 21 by bugdroid1@chromium.org, Jun 14 2013

------------------------------------------------------------------------
r206243 | dcheng@chromium.org | 2013-06-14T00:23:58.297097Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/controls/combobox/native_combobox_views_unittest.cc?r1=206243&r2=206242&pathrev=206243
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/controls/textfield/native_textfield_views.cc?r1=206243&r2=206242&pathrev=206243
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/controls/scrollbar/scrollbar_unittest.cc?r1=206243&r2=206242&pathrev=206243
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/oak/oak_window.cc?r1=206243&r2=206242&pathrev=206243

Rewrite scoped_ptr<T>(NULL) to use the default ctor in ui/.

This is the result of running the rewrite_scoped_ptr_ctor_null tool
across all files built on CrOS in the ui/ directory.

BUG= 173286 

Review URL: https://chromiumcodereview.appspot.com/16922010
------------------------------------------------------------------------
Project Member

Comment 22 by bugdroid1@chromium.org, Jun 14 2013

------------------------------------------------------------------------
r206247 | dcheng@chromium.org | 2013-06-14T00:35:13.159713Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/codec/audio_decoder_speex.cc?r1=206247&r2=206246&pathrev=206247
   M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/input_injector_linux.cc?r1=206247&r2=206246&pathrev=206247
   M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/protocol/video_reader.cc?r1=206247&r2=206246&pathrev=206247
   M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/protocol/ssl_hmac_channel_authenticator.cc?r1=206247&r2=206246&pathrev=206247
   M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/jingle_glue/iq_sender.cc?r1=206247&r2=206246&pathrev=206247
   M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/client_session.cc?r1=206247&r2=206246&pathrev=206247
   M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/protocol/audio_writer.cc?r1=206247&r2=206246&pathrev=206247
   M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/codec/video_encoder_vp8.cc?r1=206247&r2=206246&pathrev=206247
   M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/codec/audio_decoder.cc?r1=206247&r2=206246&pathrev=206247
   M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/protocol/libjingle_transport_factory.cc?r1=206247&r2=206246&pathrev=206247
   M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/protocol/video_writer.cc?r1=206247&r2=206246&pathrev=206247
   M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/protocol/audio_reader.cc?r1=206247&r2=206246&pathrev=206247
   M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/protocol/me2me_host_authenticator_factory.cc?r1=206247&r2=206246&pathrev=206247

Rewrite scoped_ptr<T>(NULL) to use the default ctor in remoting/.

This is the result of running the rewrite_scoped_ptr_ctor_null tool
across all files built on Linux in the remoting/ directory.

BUG= 173286 

Review URL: https://chromiumcodereview.appspot.com/16964002
------------------------------------------------------------------------
Project Member

Comment 23 by bugdroid1@chromium.org, Jun 14 2013

------------------------------------------------------------------------
r206406 | dcheng@chromium.org | 2013-06-14T13:02:30.231153Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/audio_capturer_mac.cc?r1=206406&r2=206405&pathrev=206406
   M http://src.chromium.org/viewvc/chrome/trunk/src/apps/app_shim/app_shim_host_mac.cc?r1=206406&r2=206405&pathrev=206406

Rewrite scoped_ptr<T>(NULL) to use the default ctor.

This is the result of running the rewrite_scoped_ptr_ctor_null tool
across all files built on Mac.

BUG= 173286 
R=tapted@chromium.org, wez@chromium.org

Review URL: https://codereview.chromium.org/16844021
------------------------------------------------------------------------
Blockedon: chromium:236272
Project Member

Comment 25 by bugdroid1@chromium.org, Jun 17 2013

------------------------------------------------------------------------
r206763 | dcheng@chromium.org | 2013-06-17T18:46:29.094659Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_drag_win.cc?r1=206763&r2=206762&pathrev=206763
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/audio/win/audio_unified_win.cc?r1=206763&r2=206762&pathrev=206763
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/urlmon_bind_status_callback.h?r1=206763&r2=206762&pathrev=206763
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc?r1=206763&r2=206762&pathrev=206763
   M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/setup/daemon_controller_win.cc?r1=206763&r2=206762&pathrev=206763
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_auth_handler_ntlm_win.cc?r1=206763&r2=206762&pathrev=206763

Rewrite scoped_ptr<T>(NULL) to use the default ctor.

This is a manual cleanup of call sites that invoke scoped_ptr<T>'s
constructor with an explicit NULL argument, since the clang tooling
infrastructure does not work on Windows. Also fixes a misuse of
scoped_ptr<T> in chrome_frame to hold memory allocated by operator
new[].

BUG= 173286 
R=alexeypa@chromium.org, erg@chromium.org, jochen@chromium.org, mmenke@chromium.org, tommi@chromium.org

Review URL: https://codereview.chromium.org/16943003
------------------------------------------------------------------------
Project Member

Comment 27 by bugdroid1@chromium.org, Jun 26 2013

------------------------------------------------------------------------
r208730 | dcheng@chromium.org | 2013-06-26T18:01:22.772754Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/android/activity_status_unittest.cc?r1=208730&r2=208729&pathrev=208730
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service_android.cc?r1=208730&r2=208729&pathrev=208730
   M http://src.chromium.org/viewvc/chrome/trunk/src/tools/android/forwarder2/daemon.cc?r1=208730&r2=208729&pathrev=208730

Rewrite scoped_ptr<T>(NULL) to use the default ctor.

This is a manual cleanup of call sites that invoke scoped_ptr<T>'s
constructor with an explicit NULL argument that are only built on
Android.

BUG= 173286 
R=rlarocque@chromium.org, yfriedman@chromium.org

Review URL: https://codereview.chromium.org/17780002
------------------------------------------------------------------------
Project Member

Comment 28 by bugdroid1@chromium.org, Jun 26 2013

------------------------------------------------------------------------
r208732 | dcheng@chromium.org | 2013-06-26T18:07:03.288136Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/automation_client_mock.h?r1=208732&r2=208731&pathrev=208732

Fix one more instance of scoped_ptr<T>(NULL) on Windows.

Not sure why I missed this the first time.

BUG= 173286 
R=robertshield@chromium.org

Review URL: https://codereview.chromium.org/17911004
------------------------------------------------------------------------
Project Member

Comment 29 by bugdroid1@chromium.org, Jun 26 2013

------------------------------------------------------------------------
r208752 | dcheng@chromium.org | 2013-06-26T19:05:11.031505Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/policy/device_local_account_browsertest.cc?r1=208752&r2=208751&pathrev=208752

Fix one more instance of scoped_ptr<T>(NULL) on ChromeOS.

BUG= 173286 
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/17846006
------------------------------------------------------------------------
Project Member

Comment 30 by bugdroid1@chromium.org, Jun 26 2013

------------------------------------------------------------------------
r208773 | dcheng@chromium.org | 2013-06-26T20:29:00.555482Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/memory/scoped_ptr.h?r1=208773&r2=208772&pathrev=208773

Disallow explicit scoped_ptr<T> construction from NULL.

This matches the behavior of std::unique_ptr<T>, which is the
long-term replacement for scoped_ptr<T>.

BUG= 173286 
R=jyasskin@chromium.org, mark@chromium.org

Review URL: https://codereview.chromium.org/17028014
------------------------------------------------------------------------
Project Member

Comment 31 by bugdroid1@chromium.org, Jun 26 2013

------------------------------------------------------------------------
r208803 | dcheng@chromium.org | 2013-06-26T22:18:50.403913Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/audio/cras/cras_unified.cc?r1=208803&r2=208802&pathrev=208803

Fix yet another instance of scoped_ptr<T>(NULL) on ChromeOS.

BUG= 173286 
TBR=henrika@chromium.org

Review URL: https://codereview.chromium.org/17950002
------------------------------------------------------------------------
Project Member

Comment 32 by bugdroid1@chromium.org, Jun 26 2013

------------------------------------------------------------------------
r208818 | dcheng@chromium.org | 2013-06-26T23:24:34.906309Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/media/exynos_video_decode_accelerator.cc?r1=208818&r2=208817&pathrev=208818

Fix yet another instance of scoped_ptr<T>(NULL) on ChromeOS.

BUG= 173286 
TBR=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/17846008
------------------------------------------------------------------------
Status: Fixed

Sign in to add a comment