Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 173205 Mac: DevTools overlaps bookmark bar and tabs
Starred by 14 users Reported by robert.c...@gmail.com, Jan 30, 2013 Back to list
Status: Verified
Owner: sail@chromium.org
Closed: Feb 2013
Cc: srihariraju@chromium.org, mangalampalli@chromium.org, jryans@chromium.org, jayakrishnat@chromium.org, vclarke@chromium.org, dpete@chromium.org, ranavdk@chromium.org, sail@chromium.org, mbollu@chromium.org, ashej...@chromium.org, athigle@chromium.org
Components:
OS: Mac
Pri: 2
Type: Bug


Sign in to add a comment
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_2) AppleWebKit/537.28 (KHTML, like Gecko) Chrome/26.0.1398.0 Safari/537.28

Steps to reproduce the problem:
1. Open Chrome Canary in Full Screen Presentation Mode
2. Open Dev Tools
3. Hover the top part of the screen to reveal tabs/menus

What is the expected behavior?
Dev Tools stays locked in Tab Area

What went wrong?
Dev Tools overlap browser Chrome.  Blocks access to Settings menu, unless you first close Dev Tools)

Did this work before? Yes Chrome Stable

Chrome version: 26.0.1398.0  Channel: canary
OS Version: OS X 10.8.2
 
stable.png
144 KB View Download
canary.png
158 KB View Download
Comment 1 by sail@chromium.org, Jan 31, 2013
Owner: sail@chromium.org
Status: Assigned
This is due to r178392. Will fix.
Comment 2 by sail@chromium.org, Feb 1, 2013
Issue 173715 has been merged into this issue.
Comment 3 by sail@chromium.org, Feb 6, 2013
Summary: Mac: DevTools overlaps bookmark bar and tabs (was: In Presentation Mode: DevTools overlaps tab chrome)
Comment 4 by sail@chromium.org, Feb 6, 2013
Issue 174653 has been merged into this issue.
Comment 5 by sail@chromium.org, Feb 7, 2013
Status: Started
https://codereview.chromium.org/12208060/
Comment 6 by sail@chromium.org, Feb 7, 2013
Cc: vclarke@chromium.org sail@chromium.org athigle@chromium.org
Issue 174022 has been merged into this issue.
Project Member Comment 7 by bugdroid1@chromium.org, Feb 7, 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=181301

------------------------------------------------------------------------
r181301 | sail@chromium.org | 2013-02-07T14:09:55.470505Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_controller.h?r1=181301&r2=181300&pathrev=181301
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_controller.mm?r1=181301&r2=181300&pathrev=181301
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/dev_tools_controller.mm?r1=181301&r2=181300&pathrev=181301
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/devtools/devtools_window.h?r1=181301&r2=181300&pathrev=181301
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm?r1=181301&r2=181300&pathrev=181301
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=181301&r2=181300&pathrev=181301

Alternate NTP: Don't overlap dev tools with bookmark bar

When docked vertically the dev tools view overlaps the bookmark bar.

This was a bug I introduced in r178367 when I changed the bookmark bar to overlap web contents.

To fix this I've made the following changes:
  - implement constrainSplitPosition: to prevent the splitter from being dragged past the bookmark bar
  - move the dev tools view into a container view. The container view resizes the dev tools view to be below the bookmark bar

BUG= 173205 
TEST=Open dev tools and verified that it never went under the bookmark bar.


Review URL: https://chromiumcodereview.appspot.com/12208060
------------------------------------------------------------------------
Comment 8 by sail@chromium.org, Feb 7, 2013
Status: Fixed
Thanks!

On Thursday, February 7, 2013, wrote:
Issue 175117 has been merged into this issue.
Hey Sail,

here is still something going wrong in 26.0.1407.0 (Official Build 181436) canary.

Now, the DevTools' Toolbar is under the bookmarksbar in a special case.

Here are the steps to reproduce (tested on 10.6.8.):

1.) go to google.com
2.) open DevTools (it is attached at th bottom)
3.) drag it to the right side
4.) close the DevTools
5.) open DevTools again

--> Result: please see the screenshot



devtools.png
102 KB View Download
Comment 12 by sail@chromium.org, Feb 8, 2013
Status: Assigned
Will fix. Thanks.
Comment 13 by sail@chromium.org, Feb 9, 2013
Issue 175213 has been merged into this issue.
Issue 175290 has been merged into this issue.
Comment 15 by sail@chromium.org, Feb 11, 2013
Status: Started
https://codereview.chromium.org/12226086/
Comment 16 by sail@chromium.org, Feb 12, 2013
Status: Fixed
Comment 17 by meh...@chromium.org, Feb 12, 2013
Issue 175700 has been merged into this issue.
Comment 18 by sail@chromium.org, Feb 12, 2013
Status: Assigned
Re-opening. My fix didn't make the M26 branch cut.
Once I verify on Canary I'll ask for merge approval.
Project Member Comment 19 by bugdroid1@chromium.org, Feb 12, 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=181867

------------------------------------------------------------------------
r181867 | sail@chromium.org | 2013-02-12T05:15:40.058227Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/dev_tools_controller.mm?r1=181867&r2=181866&pathrev=181867
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm?r1=181867&r2=181866&pathrev=181867

Alternate NTP: Fix dev tools layout

When docked to the right the dev tool's web view would be cropped.

This bug was due to the way I implemented view layout in r181301.

The dev tool view was being correctly layed out but the subview was not.

To fix this I've removed the container view (DevToolsContainerView). The new code just use the view's auto layout instead.

BUG= 173205 
TEST=Docked the devtools to the right and opened a new browser window. Verified that the devtools view was correctly layed out.

Review URL: https://codereview.chromium.org/12226086
------------------------------------------------------------------------
Comment 20 by sail@chromium.org, Feb 13, 2013
Labels: Merge-Requested Mstone-26
Verified that the fix works in 26.0.1411.0 canary. Merged requested.
Comment 21 by meh...@chromium.org, Feb 13, 2013
Hi Sail. Before merging, I noticed there is still an issue, when unhiding the bookmarks bar (Version 26.0.1411.0 canary / OSX 10.8.2). Please see the screenshot.

Steps to reproduce:

1.) Visit a page with visible Bookmarksbar
2.) Open DevTools
3.) drag to the right side
4.) Unhide the Bookmarksbar

-> Result: Please see the screenshot.


Thanks
Mehmet
Bildschirmfoto 2013-02-13 um 19.25.26.png
38.6 KB View Download
Yes, issue is still there. Can't see tabs in DevTools when docked to right with bookmark bar.
Comment 23 by sail@chromium.org, Feb 13, 2013
Labels: -Merge-Requested
mehmet: good catch, will fix.

akshayaurora2008: The issue in comment 21 only happens when you hide/show the bookmark bar while dev tools is open. Make sure you're using today's Canary (26.0.1411.0)
Comment 24 by meh...@chromium.org, Feb 13, 2013
sail: One more thing :-)

When you do the following steps, then the overlap is also still there...

1.) Drag Devtools to the right.
2.) Close DevTools
3.) hide Bookmarksbar
4.) open DevTools (it is attached to the right)
5.) unhide Bookmarksbar


Bildschirmfoto 2013-02-13 um 19.41.28.png
31.6 KB View Download
Comment 25 by meh...@chromium.org, Feb 13, 2013
Issue 176073 has been merged into this issue.
Cc: ranavdk@chromium.org mangalampalli@chromium.org dpete@chromium.org srihariraju@chromium.org jayakrishnat@chromium.org
Issue 176245 has been merged into this issue.
@sail: The issue is still nowhere fixed, are you working on it?
Project Member Comment 28 by bugdroid1@chromium.org, Feb 14, 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182499

------------------------------------------------------------------------
r182499 | sail@chromium.org | 2013-02-14T18:26:33.465144Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/dev_tools_controller.mm?r1=182499&r2=182498&pathrev=182499
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm?r1=182499&r2=182498&pathrev=182499

Alternate NTP: Resize devtools when hiding bookmark bar

Hiding the bookmark bar didn't update the devtools height. Fix was to update the frame when setTopContentOffset: was called.

BUG= 173205 

Review URL: https://codereview.chromium.org/12254021
------------------------------------------------------------------------
Comment 29 by jryans@chromium.org, Feb 15, 2013
Cc: jryans@chromium.org
Comment 30 by meh...@chromium.org, Feb 15, 2013
This looks good now in Version 27.0.1413.0 canary (OSX 10.8.2). Can't reproduce it with the steps from comment 21 & 24.
Comment 31 by sail@chromium.org, Feb 15, 2013
Labels: Merge-Requested
Comment 32 by dharani@chromium.org, Feb 15, 2013
Labels: -Merge-Requested Merge-Approved
Comment 33 by sail@chromium.org, Feb 15, 2013
Labels: -Merge-Approved Merge-Merged
Comment 34 by sail@chromium.org, Feb 15, 2013
Status: Fixed
Project Member Comment 35 by bugdroid1@chromium.org, Feb 15, 2013
Labels: merge-merged-1410
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182776

------------------------------------------------------------------------
r182776 | sail@chromium.org | 2013-02-15T19:12:12.966066Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/cocoa/dev_tools_controller.mm?r1=182776&r2=182775&pathrev=182776
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm?r1=182776&r2=182775&pathrev=182776

Merge 181867
> Alternate NTP: Fix dev tools layout
> 
> When docked to the right the dev tool's web view would be cropped.
> 
> This bug was due to the way I implemented view layout in r181301.
> 
> The dev tool view was being correctly layed out but the subview was not.
> 
> To fix this I've removed the container view (DevToolsContainerView). The new code just use the view's auto layout instead.
> 
> BUG= 173205 
> TEST=Docked the devtools to the right and opened a new browser window. Verified that the devtools view was correctly layed out.
> 
> Review URL: https://codereview.chromium.org/12226086

TBR=sail@chromium.org
Review URL: https://codereview.chromium.org/12288006
------------------------------------------------------------------------
Project Member Comment 36 by bugdroid1@chromium.org, Feb 15, 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182777

------------------------------------------------------------------------
r182777 | sail@chromium.org | 2013-02-15T19:13:07.398861Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/cocoa/dev_tools_controller.mm?r1=182777&r2=182776&pathrev=182777
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm?r1=182777&r2=182776&pathrev=182777

Merge 182499
> Alternate NTP: Resize devtools when hiding bookmark bar
> 
> Hiding the bookmark bar didn't update the devtools height. Fix was to update the frame when setTopContentOffset: was called.
> 
> BUG= 173205 
> 
> Review URL: https://codereview.chromium.org/12254021

TBR=sail@chromium.org
Review URL: https://codereview.chromium.org/12285005
------------------------------------------------------------------------
Comment 37 by mbollu@chromium.org, Feb 15, 2013
OS: Mac 10.8.2
Chrome:  27.0.1413.0 (Official Build 182629) canary

Able to reproduce DevTools overlaps bookmark bar and tabs when following Steps to Reproduce. See attachement 1. 

Unable to reproduce the issues mentioned in Comment 21 & 24.
Screen Shot 2013-02-15 at 11.39.55 AM.png
199 KB View Download
Screen Shot 2013-02-15 at 11.24.23 AM.png
214 KB View Download
Comment 38 by mbollu@chromium.org, Feb 15, 2013
Cc: mbollu@chromium.org
Comment 39 by meh...@chromium.org, Feb 15, 2013
Hi mbollu@.

What are the steps to reproduce the issue from screenshot 1 ?

Thanks in advance.
Comment 40 by meh...@chromium.org, Feb 15, 2013
Ah, I see. This happen in Presentation Mode SHIFT-CMD-F.

Sail, should I file a seperate report for this ?
Comment 41 by sail@chromium.org, Feb 15, 2013
Hi mehmet, yea could you file a new bug? Thanks!
Comment 42 by meh...@chromium.org, Feb 15, 2013
sail: I filed issue 176585.
Cc: ashej...@chromium.org
Labels: TE-Verified-27.0.1416.0
Status: Verified
Retested the above issue as per comment 21 & 24 with Canary version "27.0.1416.0" on MAC 10.8.2 and Bookmark bar is not getting overlapped for "Normal mode".
As per comment #42 separate issue has been filed for "Presentation Mode" . Hence marking this issue as "Verified".
Project Member Comment 44 by bugdroid1@chromium.org, Mar 10, 2013
Labels: -Area-UI -Mstone-26 M-26 Cr-UI
Sign in to add a comment