Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 171236 Prompt enterprise users to create a new profile at signin time
Starred by 3 users Project Member Reported by atwilson@chromium.org, Jan 21 2013 Back to list
Status: Verified
Owner: vivianz@chromium.org
Closed: Feb 2013
Cc: atwilson@chromium.org, vivianz@chromium.org, tkonch...@chromium.org, nepper@chromium.org, dconnelly@chromium.org, kaichou@chromium.org
Components:
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 141123


Sign in to add a comment
As a privacy enhancement, enterprise users will be prompted to create a new profile at signin time, to give them the option to keep their existing private data from being synced to their enterprise acct.

This also allows enterprise admins to prohibit signout (only allow deleting enterprise profiles) to help avoid accidental leakage of enterprise data through syncing with different accounts.

Shooting for M26, if time allows.
 
Blocking: chromium:141123
Blocking: chromium:165057
Project Member Comment 3 by bugdroid1@chromium.org, Feb 6 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=181018

------------------------------------------------------------------------
r181018 | dconnelly@chromium.org | 2013-02-06T19:12:43.423479Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/google_chrome_strings.grd?r1=181018&r2=181017&pathrev=181018
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=181018&r2=181017&pathrev=181018
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chromium_strings.grd?r1=181018&r2=181017&pathrev=181018

Define strings for enterprise account sign-in profile link confirmation.

BUG= 171236 

Review URL: https://chromiumcodereview.appspot.com/12184012
------------------------------------------------------------------------
Project Member Comment 4 by bugdroid1@chromium.org, Feb 8 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=181567

------------------------------------------------------------------------
r181567 | atwilson@chromium.org | 2013-02-08T22:55:16.704192Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/profile_manager.h?r1=181567&r2=181566&pathrev=181567
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/signin/signin_manager.cc?r1=181567&r2=181566&pathrev=181567
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/signin/signin_manager.h?r1=181567&r2=181566&pathrev=181567

Add SigninManager::TransferCredentialsToNewProfile() API.

This API is not yet called pending the addition of associated UI.

TBR=erg

BUG= 171236 


Review URL: https://chromiumcodereview.appspot.com/12210089
------------------------------------------------------------------------
Comment 5 by mkwst@chromium.org, Feb 11 2013
Cc: nepper@chromium.org kaichou@chromium.org
Labels: Feature-Privacy
Labels: ReleaseBlock-Beta
Status: Assigned
Project Member Comment 8 by bugdroid1@chromium.org, Feb 15 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182702

------------------------------------------------------------------------
r182702 | atwilson@chromium.org | 2013-02-15T14:02:50.613572Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/url_constants.cc?r1=182702&r2=182701&pathrev=182702
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_resources.grd?r1=182702&r2=182701&pathrev=182702
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/url_constants.h?r1=182702&r2=182701&pathrev=182702
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/profile_signin_confirmation.html?r1=182702&r2=182701&pathrev=182702
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/signin/signin_manager.cc?r1=182702&r2=182701&pathrev=182702
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc?r1=182702&r2=182701&pathrev=182702
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/signin/signin_manager.h?r1=182702&r2=182701&pathrev=182702
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/signin/profile_signin_confirmation_ui.cc?r1=182702&r2=182701&pathrev=182702
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/signin/profile_signin_confirmation_dialog.cc?r1=182702&r2=182701&pathrev=182702
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/signin/profile_signin_confirmation_ui.h?r1=182702&r2=182701&pathrev=182702
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser_ui.gypi?r1=182702&r2=182701&pathrev=182702
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/signin/profile_signin_confirmation_dialog.h?r1=182702&r2=182701&pathrev=182702
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/profile_signin_confirmation.js?r1=182702&r2=182701&pathrev=182702

Add a modal confirmation dialog to the enterprise profile sign-in flow.

When signing in with an enterprise user account, the user is prompted to
create a new Chrome profile, continue signing in with the current
profile, or cancel the signin process.

BUG= 171236 
TBR=jhawkins

Review URL: https://codereview.chromium.org/12221111
------------------------------------------------------------------------
Cc: dconnelly@chromium.org
Labels: Merge-Requested
I'd like to merge this to M26 - this code change only impacts enterprise users that are signed up for the Chrome for Business dasher feature so it will have no impact on overall stability for the general user population, but it addresses a significant privacy issue for those users.
Once this lands in canary and verified that it didn't cause any side-effects, we can take the merge.
Cc: vivianz@chromium.org
I verified this on 27.0.1415.0 (183021) mac canary. Does that suffice? If not, I can ask vivianz to also verify before I merge? I'm just concerned about waiting too long on the merge since the beta deadline is looming.
Labels: -Merge-Requested Merge-Approved
Project Member Comment 14 by bugdroid1@chromium.org, Feb 19 2013
Labels: -Merge-Approved merge-merged-1410
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=183184

------------------------------------------------------------------------
r183184 | atwilson@chromium.org | 2013-02-19T08:38:12.050286Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/common/url_constants.cc?r1=183184&r2=183183&pathrev=183184
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/browser_resources.grd?r1=183184&r2=183183&pathrev=183184
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/common/url_constants.h?r1=183184&r2=183183&pathrev=183184
   A http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/resources/profile_signin_confirmation.html?r1=183184&r2=183183&pathrev=183184
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/signin/signin_manager.cc?r1=183184&r2=183183&pathrev=183184
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc?r1=183184&r2=183183&pathrev=183184
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/signin/signin_manager.h?r1=183184&r2=183183&pathrev=183184
   A http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/webui/signin/profile_signin_confirmation_ui.cc?r1=183184&r2=183183&pathrev=183184
   A http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/webui/signin/profile_signin_confirmation_dialog.cc?r1=183184&r2=183183&pathrev=183184
   A http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/webui/signin/profile_signin_confirmation_ui.h?r1=183184&r2=183183&pathrev=183184
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/chrome_browser_ui.gypi?r1=183184&r2=183183&pathrev=183184
   A http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/webui/signin/profile_signin_confirmation_dialog.h?r1=183184&r2=183183&pathrev=183184
   A http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/resources/profile_signin_confirmation.js?r1=183184&r2=183183&pathrev=183184

Merge 182702
> Add a modal confirmation dialog to the enterprise profile sign-in flow.
> 
> When signing in with an enterprise user account, the user is prompted to
> create a new Chrome profile, continue signing in with the current
> profile, or cancel the signin process.
> 
> BUG= 171236 
> TBR=jhawkins
> 
> Review URL: https://codereview.chromium.org/12221111

TBR=atwilson@chromium.org
Review URL: https://codereview.chromium.org/12302015
------------------------------------------------------------------------
Cc: atwilson@chromium.org
Owner: vivianz@chromium.org
Status: Fixed
This has been merged to M26 - reassigning to Vivian to verify.
Cc: tkonch...@chromium.org
Labels: TE-Verified-26.0.1410.12
Tested the same on mac 10.8.2 chrome latest dev 26.0.1410.12 (Official Build 183726) - Working as intended.
Project Member Comment 17 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Area-UI -Feature-Enterprise -Feature-SignIn -Feature-Profiles -Mstone-26 -Feature-Privacy Cr-Privacy Cr-UI Cr-UI-Browser-Profiles M-26 Cr-Services-SignIn Cr-Enterprise
Status: Verified
Sign in to add a comment