Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 170742 Allow extension permissions to be viewed from extension settings page
Starred by 9 users Project Member Reported by pludwig@chromium.org, Jan 17, 2013 Back to list
Status: Fixed
Owner: finnur@chromium.org
Closed: Feb 2013
Cc: pludwig@chromium.org, mpcomplete@chromium.org, alcor@google.com, mihaip@chromium.org, asargent@chromium.org
Components:
OS: ----
Pri: ----
Type: Feature


Sign in to add a comment
Today, there is not an easy way to see the permissions that an extension has after it is installed.  It should be easy to see extension permissions from the extension settings page.

See screenshots.

Finnur, it would be great if this could make it into M26, but this isn't urgent.  I marked M27 to be conservative.

M26 features need to be default enabled in Trunk by January 24th.
 
permissions dialog 1.fw.png
373 KB View Download
permissions 1.png
326 KB View Download
Comment 1 by finnur@chromium.org, Jan 25, 2013
The Permissions link appears in the bottom line for the extension. The one that disappears when the extension is disabled. The line above (where View Website appears), is not hidden when the extension is disabled. Shouldn't it appear there?
Comment 2 Deleted
Comment 3 by pludwig@chromium.org, Jan 25, 2013
You're completely right.  Thanks for pointing that out.  New mock attached.
permissions 2.fw.png
245 KB View Download
Project Member Comment 4 by bugdroid1@chromium.org, Jan 31, 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=179916

------------------------------------------------------------------------
r179916 | finnur@chromium.org | 2013-01-31T19:05:08.684894Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/extensions/extension_list.js?r1=179916&r2=179915&pathrev=179916
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/extensions/extensions.html?r1=179916&r2=179915&pathrev=179916
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=179916&r2=179915&pathrev=179916
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/extensions/extension_settings_handler.cc?r1=179916&r2=179915&pathrev=179916
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_install_prompt.cc?r1=179916&r2=179915&pathrev=179916
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/extensions/extension_settings_handler.h?r1=179916&r2=179915&pathrev=179916
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_install_prompt.h?r1=179916&r2=179915&pathrev=179916
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc?r1=179916&r2=179915&pathrev=179916

Add a link (to view Permissions) to the Extension details on chrome://extensions.

BUG= 170742 
TEST=None

Review URL: https://chromiumcodereview.appspot.com/12094034
------------------------------------------------------------------------
Comment 5 by finnur@chromium.org, Feb 7, 2013
Cc: mwichary@google.com alcor@google.com mihaip@chromium.org asargent@chromium.org
Issue 89907 has been merged into this issue.
Comment 6 by finnur@chromium.org, Feb 7, 2013
Status: Fixed
Comment 7 by finnur@chromium.org, Feb 7, 2013
Cc: -mwichary@google.com
Removing mwichary due to message delivery failures.
Comment 8 by laforge@google.com, Feb 13, 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182274

------------------------------------------------------------------------
r182274 | mpcomplete@chromium.org | 2013-02-13T18:59:28.710180Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_install_prompt.h?r1=182274&r2=182273&pathrev=182274
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc?r1=182274&r2=182273&pathrev=182274
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/extensions/extension_list.js?r1=182274&r2=182273&pathrev=182274
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/extensions/extensions.html?r1=182274&r2=182273&pathrev=182274
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=182274&r2=182273&pathrev=182274
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/extensions/extension_settings_handler.cc?r1=182274&r2=182273&pathrev=182274
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_install_prompt.cc?r1=182274&r2=182273&pathrev=182274
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/extensions/extension_settings_handler.h?r1=182274&r2=182273&pathrev=182274

Revert 179916. It breaks on Mac.
> Add a link (to view Permissions) to the Extension details on chrome://extensions.
> 
> BUG= 170742 
> TEST=None
> 
> Review URL: https://chromiumcodereview.appspot.com/12094034

BUG= 170742 , 175071 
TBR=finnur@chromium.org
Review URL: https://codereview.chromium.org/12263014
------------------------------------------------------------------------
Project Member Comment 9 by bugdroid1@chromium.org, Feb 14, 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182576

------------------------------------------------------------------------
r182576 | MHX348@motorola.com | 2013-02-14T23:43:32.077062Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.mm?r1=182576&r2=182575&pathrev=182576
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/extensions/extension_list.js?r1=182576&r2=182575&pathrev=182576
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/extensions/extensions.html?r1=182576&r2=182575&pathrev=182576
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm?r1=182576&r2=182575&pathrev=182576
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=182576&r2=182575&pathrev=182576
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/extensions/extension_settings_handler.cc?r1=182576&r2=182575&pathrev=182576
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_install_prompt.cc?r1=182576&r2=182575&pathrev=182576
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm?r1=182576&r2=182575&pathrev=182576
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/extensions/extension_settings_handler.h?r1=182576&r2=182575&pathrev=182576
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm?r1=182576&r2=182575&pathrev=182576
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_install_prompt.h?r1=182576&r2=182575&pathrev=182576
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.h?r1=182576&r2=182575&pathrev=182576
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc?r1=182576&r2=182575&pathrev=182576

Re-land "view permission" feature (r179916) with Mac Fix.

The feature review URL: http://crrev.com/12094034
Mac fix review URL: http://crrev.com/12258023
This CL also combines the extension_install_prompt changes reviewed at http://crrev.com/12220142

RootCause for Mac failure: Permission Prompt does not have a OK button. 
And Chrome hangs while trying to create a OK button with empty string. 
Solution: Remove |okButton_| when its title is empty and adjust 
|cancelButton_|'s position. 
The screenshot with the fix is uploaded at http://crbug.com/175071#c15 

BUG= 170742 , 175071 
TBR=finnur@chromium.org
TBR=sky@chromium.org for http://crrev.com/12094034
TBR=sail@chromium.org for http://crrev.com/12258023


Review URL: https://chromiumcodereview.appspot.com/12212195
------------------------------------------------------------------------
Project Member Comment 10 by bugdroid1@chromium.org, Feb 15, 2013
Labels: merge-merged-1410
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182838

------------------------------------------------------------------------
r182838 | mpcomplete@chromium.org | 2013-02-15T21:52:22.591133Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/app/generated_resources.grd?r1=182838&r2=182837&pathrev=182838
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/webui/extensions/extension_settings_handler.cc?r1=182838&r2=182837&pathrev=182838
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/extensions/extension_install_prompt.cc?r1=182838&r2=182837&pathrev=182838
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/webui/extensions/extension_settings_handler.h?r1=182838&r2=182837&pathrev=182838
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/extensions/extension_install_prompt.h?r1=182838&r2=182837&pathrev=182838
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc?r1=182838&r2=182837&pathrev=182838
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/resources/extensions/extension_list.js?r1=182838&r2=182837&pathrev=182838
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/resources/extensions/extensions.html?r1=182838&r2=182837&pathrev=182838

Merge 182274
> Revert 179916. It breaks on Mac.
> > Add a link (to view Permissions) to the Extension details on chrome://extensions.
> > 
> > BUG= 170742 
> > TEST=None
> > 
> > Review URL: https://chromiumcodereview.appspot.com/12094034
> 
> BUG= 170742 , 175071 
> TBR=finnur@chromium.org
> Review URL: https://codereview.chromium.org/12263014

TBR=mpcomplete@chromium.org
Review URL: https://codereview.chromium.org/12289013
------------------------------------------------------------------------
Labels: Action-FeedbackNeeded
finnur@, I am NOT able to see "View Permissions" link in chrome://extensions page with chrome#26.0.1410.10. am i missing any of the repro steps apart from adding an extension from webstore? Please confirm.

NOTE: Please find the attached screenshot for your reference.

Thank you!
Extensions_Issue.JPG
66.1 KB View Download
Tested this scenario on Win7.
Project Member Comment 13 by bugdroid1@chromium.org, Feb 19, 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=183258

------------------------------------------------------------------------
r183258 | mpcomplete@chromium.org | 2013-02-19T18:54:43.908950Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/webui/extensions/extension_settings_handler.cc?r1=183258&r2=183257&pathrev=183258
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/extensions/extension_install_prompt.cc?r1=183258&r2=183257&pathrev=183258
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm?r1=183258&r2=183257&pathrev=183258
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/webui/extensions/extension_settings_handler.h?r1=183258&r2=183257&pathrev=183258
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm?r1=183258&r2=183257&pathrev=183258
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/extensions/extension_install_prompt.h?r1=183258&r2=183257&pathrev=183258
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.h?r1=183258&r2=183257&pathrev=183258
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc?r1=183258&r2=183257&pathrev=183258
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.mm?r1=183258&r2=183257&pathrev=183258
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/resources/extensions/extension_list.js?r1=183258&r2=183257&pathrev=183258
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/resources/extensions/extensions.html?r1=183258&r2=183257&pathrev=183258
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm?r1=183258&r2=183257&pathrev=183258
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/app/generated_resources.grd?r1=183258&r2=183257&pathrev=183258

Merge 182576 to M26 beta branch.
> Re-land "view permission" feature (r179916) with Mac Fix.
> 
> The feature review URL: http://crrev.com/12094034
> Mac fix review URL: http://crrev.com/12258023
> This CL also combines the extension_install_prompt changes reviewed at http://crrev.com/12220142
> 
> RootCause for Mac failure: Permission Prompt does not have a OK button. 
> And Chrome hangs while trying to create a OK button with empty string. 
> Solution: Remove |okButton_| when its title is empty and adjust 
> |cancelButton_|'s position. 
> The screenshot with the fix is uploaded at http://crbug.com/175071#c15 
> 
> BUG= 170742 , 175071 
> TBR=finnur@chromium.org
> TBR=sky@chromium.org for http://crrev.com/12094034
> TBR=sail@chromium.org for http://crrev.com/12258023
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/12212195

TBR=MHX348@motorola.com
Review URL: https://codereview.chromium.org/12303030
------------------------------------------------------------------------
Tested this issue on 27.0.1417.2 (Official Build 183216) canary & MAC. By clicking on Permissions link able to see permissions pop up with close button. By clicking on close button, able to close pop up successfully. Attached the screenshot

As per comment1# & 3#, disable the extension. Still able to see Visit Web site as well permission links. Please confirm is this expected behavior? 

Permissions pop up.png
51.0 KB View Download
Disable extensions.png
31.5 KB View Download
Comment 15 by pludwig@chromium.org, Feb 20, 2013
Yes, this is expected behavior.  This is now working correctly on Mac.
Currently the Permissions link shows even those permissions that the user has not granted. This case happens when an extension gets disabled after update due to permission increase.  In my opinion, it should show only the permissions approved by the user.

What should be the behavior in this scenario? I can create a CL if needed. 

The current implementation is good as-is.

When an extension is disabled after a permissions increase, the permissions link shows what permissions the extension will be granted if it is enabled.  Since the old version of the extension (with fewer permissions) isn't on the system anymore, it wouldn't make sense to show the old set of permissions.
OK. Thanks for the clarification.
Labels: TE-Verified-27.0.1426.1
Tested issue on Win 8 Chrome 27.0.1426.1, I am able to see permissions next to extensions (as per the mock)
Project Member Comment 20 by bugdroid1@chromium.org, Mar 9, 2013
Labels: -Action-FeedbackNeeded Needs-Feedback
Project Member Comment 21 by bugdroid1@chromium.org, Mar 10, 2013
Labels: -Area-UI -Mstone-27 -Feature-Extensions Cr-Platform-Extensions Cr-UI M-27
Sign in to add a comment