New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 168776 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Jun 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: missing console command lines from firebug

Reported by wilkerlu...@gmail.com, Jan 8 2013

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_2) AppleWebKit/537.11 (KHTML, like Gecko) Chrome/23.0.1271.101 Safari/537.11

Steps to reproduce the problem:
the google developer docs says that console supports firebug's Command Line API according to this page: https://developers.google.com/chrome-developer-tools/docs/console

according to the docs it should support all commands described here: http://getfirebug.com/wiki/index.php/Command_Line_API

but there are some commands there that still not available on Chrome console, here is a list of those missing commands, just try to call any of those and you will get an "ReferenceError: XXX is not defined"

$n(index)
cd(window)
include(url[, alias]) / include(alias) # this one would be specially useful
debug(fn)
undebug(fn)
monitor(fn)
unmonitor(fn)
table(data[, columns])
traceCalls(fn)
untraceCalls(fn)
traceAll()
untraceAll()

What is the expected behavior?
Those methods should work, since the docs doesn't says any restrictions about firebug console compatibility

What went wrong?
The methods are not defined.

Did this work before? No 

Chrome version: 23.0.1271.101  Channel: stable
OS Version: OS X 10.8.2

The best think would be have those implemented on Chrome console, but until them will be nice to tell the users that only some of the Firebug console commands are implemented, current docs suggest they are all full implemented.
 
Labels: -OS-Mac OS-All
Cc: kaznacheev@chromium.org
Status: Available
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Feature-DevTools Cr-Platform-DevTools
Status: WontFix
We now list supported command at https://developers.google.com/chrome-developer-tools/docs/commandline-api. Please file bugs per missing command if you feel it is necessary.
Status: Available
Summary: DevTools: missing console command lines from firebug (was: missing console command lines from firebug)
Revisiting it...

cd -> fixed via combo box

table -> can be easily built on top of console.table that has been recently introduced

include -> worth fixing

debug, undebug, monitor, unmonitor, traceCalls / untraceCalls -> all look interesting

Comment 6 by serya@chromium.org, Apr 18 2013

Owner: serya@chromium.org
Status: Started
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 5 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=151844

------------------------------------------------------------------------
r151844 | serya@chromium.org | 2013-06-05T15:58:05.501547Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/ScriptDebugServer.cpp?r1=151844&r2=151843&pathrev=151844
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/DebuggerModel.js?r1=151844&r2=151843&pathrev=151844
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/DebuggerScript.js?r1=151844&r2=151843&pathrev=151844
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorDebuggerAgent.h?r1=151844&r2=151843&pathrev=151844
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/BreakpointManager.js?r1=151844&r2=151843&pathrev=151844
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/ScriptDebugServer.h?r1=151844&r2=151843&pathrev=151844
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/inspector/debugger-test.js?r1=151844&r2=151843&pathrev=151844
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/debugger/set-breakpoint.html?r1=151844&r2=151843&pathrev=151844
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/ScriptDebugListener.h?r1=151844&r2=151843&pathrev=151844
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/protocol.json?r1=151844&r2=151843&pathrev=151844
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorDebuggerAgent.cpp?r1=151844&r2=151843&pathrev=151844

Passing hit breakpoint IDs to ScriptDebugServer.

BUG= 168776 

Review URL: https://chromiumcodereview.appspot.com/15096004
------------------------------------------------------------------------
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 7 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=152034

------------------------------------------------------------------------
r152034 | serya@chromium.org | 2013-06-07T17:20:17.771128Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/debugger/debug-console-command.html?r1=152034&r2=152033&pathrev=152034
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/ScriptsPanel.js?r1=152034&r2=152033&pathrev=152034
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InjectedScriptSource.js?r1=152034&r2=152033&pathrev=152034
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp?r1=152034&r2=152033&pathrev=152034
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InjectedScriptHost.cpp?r1=152034&r2=152033&pathrev=152034
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/protocol.json?r1=152034&r2=152033&pathrev=152034
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/debugger/debug-console-command-expected.txt?r1=152034&r2=152033&pathrev=152034
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorDebuggerAgent.cpp?r1=152034&r2=152033&pathrev=152034
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InjectedScriptExterns.js?r1=152034&r2=152033&pathrev=152034
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InjectedScriptHost.h?r1=152034&r2=152033&pathrev=152034
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InjectedScriptHost.idl?r1=152034&r2=152033&pathrev=152034
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/DebuggerModel.js?r1=152034&r2=152033&pathrev=152034
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorDebuggerAgent.h?r1=152034&r2=152033&pathrev=152034

Implementing console command 'debug'.

BUG= 168776 

Review URL: https://chromiumcodereview.appspot.com/14294004
------------------------------------------------------------------------
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 17 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=152561

------------------------------------------------------------------------
r152561 | serya@chromium.org | 2013-06-17T16:48:01.229953Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InjectedScriptHost.h?r1=152561&r2=152560&pathrev=152561
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/RuntimeModel.js?r1=152561&r2=152560&pathrev=152561
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InjectedScriptHost.idl?r1=152561&r2=152560&pathrev=152561
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorDebuggerAgent.h?r1=152561&r2=152560&pathrev=152561
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/debugger/monitor-console-command.html?r1=152561&r2=152560&pathrev=152561
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/inspector/console-test.js?r1=152561&r2=152560&pathrev=152561
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InjectedScriptSource.js?r1=152561&r2=152560&pathrev=152561
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp?r1=152561&r2=152560&pathrev=152561
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InjectedScriptHost.cpp?r1=152561&r2=152560&pathrev=152561
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorDebuggerAgent.cpp?r1=152561&r2=152560&pathrev=152561
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/debugger/monitor-console-command-expected.txt?r1=152561&r2=152560&pathrev=152561

monitor console command implemented.

monitor logs each function call in console. For instance:

function f() {}
monitor(f);
f();
unmonitor(f);

Logs:
function f called

BUG= 168776 

Review URL: https://chromiumcodereview.appspot.com/16143005
------------------------------------------------------------------------
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 18 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=152624

------------------------------------------------------------------------
r152624 | serya@chromium.org | 2013-06-18T09:07:07.683195Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InjectedScriptExterns.js?r1=152624&r2=152623&pathrev=152624

Make compile_frontend.py happy about monitorFunction/unmonitorFunction.

Left from https://codereview.chromium.org/16143005/

BUG= 168776 
R=vsevik@chromium.org

Review URL: https://codereview.chromium.org/17378004
------------------------------------------------------------------------

Comment 13 by serya@chromium.org, Jun 24 2013

Status: Fixed
include, traceCalls / untraceCalls we decided not to implement.

Sign in to add a comment