New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 9 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Feature



Sign in to add a comment

Feature request - source panel: keyboard shortcut for comment toggle

Reported by remysh...@gmail.com, Dec 21 2012

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_4) AppleWebKit/537.11 (KHTML, like Gecko) Chrome/23.0.1271.101 Safari/537.11

Steps to reproduce the problem:
When testing live code in devtools, I find myself hitting a shortcut to comment out blocks of code to test inside of devtools. Normally I use cmd+/ - so instead is just pauses execution (I'm not suggestion to change that shortcut - just it would be a useful addition).

What is the expected behavior?

What went wrong?
No comment toggle

Did this work before? N/A 

Chrome version: 23.0.1271.101  Channel: stable
OS Version: OS X 10.7.4
 

Comment 1 by meh...@chromium.org, Dec 21 2012

Labels: -Type-Bug Type-Feature
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Feature-DevTools Cr-Platform-DevTools
Cc: vsevik@chromium.org
cmd+/ should indeed comment out the line, IMO.   We could do it for JS, HTML, CSS

I think it's worth considering changing the pause execution shortcut to make this happen.

Comment 4 by vsevik@chromium.org, May 13 2013

Owner: lushnikov@chromium.org
Status: Assigned
Project Member

Comment 5 by bugdroid1@chromium.org, May 20 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=150672

------------------------------------------------------------------------
r150672 | lushnikov@chromium.org | 2013-05-20T15:14:01.797020Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/cm/javascript.js?r1=150672&r2=150671&pathrev=150672
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/cm/css.js?r1=150672&r2=150671&pathrev=150672
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/cm/htmlmixed.js?r1=150672&r2=150671&pathrev=150672
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/CodeMirrorTextEditor.js?r1=150672&r2=150671&pathrev=150672

DevTools: [CodeMirror] update js/css/html modes

Pull codemirror modes from the upstream. The intent for
this change is the codemirror's comment.js plugin which
requires modes to have "lineComment" property.

BUG= 167284 

Review URL: https://chromiumcodereview.appspot.com/15469002
------------------------------------------------------------------------
Status: Fixed
Landed in CodeMirror.

Sign in to add a comment