New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 16657 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2009
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

Ensure FFmpeg binaries end up in snapshots on all platforms

Project Member Reported by ajwong@chromium.org, Jul 13 2009

Issue description

Currently, the daily snapshots are not always including the ffmpeg binaries 
required to enable the audio/video tags.

This needs to be fixed.

This is a continuous of bug:
  http://code.google.com/p/chromium/issues/detail?id=15906
 
Status: Started
CL out for review

http://codereview.chromium.org/149571

Comment 2 by bugdro...@gmail.com, Jul 13 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=20548 

------------------------------------------------------------------------
r20548 | mmoss@chromium.org | 2009-07-13 14:47:29 -0700 (Mon, 13 Jul 2009) | 6 lines
Changed paths:
   D /trunk/src/third_party/ffmpeg/copy_binaries.sh
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/ffmpeg/ffmpeg.gyp?r1=20548&r2=20547

Rewrite ffmpeg_binaries target to use GYP built-ins and branding conditions.

BUG= 16657 

Review URL: http://codereview.chromium.org/149554

------------------------------------------------------------------------

Comment 3 by bugdro...@gmail.com, Jul 14 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=20583 

------------------------------------------------------------------------
r20583 | scherkus@chromium.org | 2009-07-13 17:02:36 -0700 (Mon, 13 Jul 2009) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/build/linux/FILES?r1=20583&r2=20582
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/build/linux/FILES.official?r1=20583&r2=20582
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/build/win/FILES?r1=20583&r2=20582

Adding Ogg/Theora/Vorbis-only FFmpeg binaries to Chromium nightly builds.

BUG= 16657 
TEST=nightly builds of Chromium should include avutil-50.dll, avformat-52.dll, avcodec-52.dll and pthreadGC2.dll

Review URL: http://codereview.chromium.org/149571
------------------------------------------------------------------------

I was told there was little way of testing this change, so let's see if snapshots of 
r20583 or greater contain the DLLs!
http://build.chromium.org/buildbot/snapshots/chromium-rel-linux/20583/

contains the linux chromium libraries, will test shortly

still waiting on the windows build
Confirmed working on Linux using the following command:
cd /path/to/chrome-linux
LD_LIBRARY_PATH=. ./chrome
Confirmed working on Windows latest snapshots.
Status: Fixed
The binaries are packaged with Mac snapshots, however <video> is still disabled.

Closing this bug and will open a separate one for enabling the Mac snapshots.
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.

Sign in to add a comment