New issue
Advanced search Search tips
Starred by 33 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2013
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 8606



Sign in to add a comment
link

Issue 166496: Fix simple 64-bit Windows compilation failures

Reported by jsc...@chromium.org, Dec 17 2012 Project Member

Issue description

Just a bug to collect all the various compilation issues that need fixing for Windows 64-bit.
 
Showing comments 18 - 117 of 117 Older

Comment 18 by bugdroid1@chromium.org, Jan 10 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=175954

------------------------------------------------------------------------
r175954 | jschuh@chromium.org | 2013-01-10T00:55:22.657582Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/crypto/crypto.gyp?r1=175954&r2=175953&pathrev=175954

Make crypto build on Win64

BUG= 166496 
BUG=167187
TBR=rsleevi

Review URL: https://chromiumcodereview.appspot.com/11833014
------------------------------------------------------------------------

Comment 19 by bugdroid1@chromium.org, Jan 10 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=175994

------------------------------------------------------------------------
r175994 | jschuh@chromium.org | 2013-01-10T02:31:01.144781Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/temp_gyp/googleurl.gyp?r1=175994&r2=175993&pathrev=175994

Make GURL build on Win64

BUG= 166496 
BUG=167187
TBR=scottmg

Review URL: https://chromiumcodereview.appspot.com/11833015
------------------------------------------------------------------------

Comment 20 by bugdroid1@chromium.org, Jan 10 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=176003

------------------------------------------------------------------------
r176003 | jschuh@chromium.org | 2013-01-10T02:58:24.921921Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/sqlite.gyp?r1=176003&r2=176002&pathrev=176003

Make sqlite targets build on Win64

BUG= 166496 
BUG=167187
TBR=shess

Review URL: https://chromiumcodereview.appspot.com/11819042
------------------------------------------------------------------------

Comment 21 by bugdroid1@chromium.org, Jan 10 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=176020

------------------------------------------------------------------------
r176020 | scottmg@chromium.org | 2013-01-10T04:38:12.567446Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=176020&r2=176019&pathrev=176020

Roll icu -> 175290

r175290: Make icu compile for Win64 (disables C4267)

TBR=jschuh@chromium.org
BUG= 166496 


Review URL: https://chromiumcodereview.appspot.com/11830034
------------------------------------------------------------------------

Comment 22 by bugdroid1@chromium.org, Jan 10 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=176025

------------------------------------------------------------------------
r176025 | jschuh@chromium.org | 2013-01-10T04:52:48.423488Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/google_apis/google_apis.gyp?r1=176025&r2=176024&pathrev=176025

Make all google_apis build on Win64

BUG= 166496 
BUG=167187
TBR=joi

Review URL: https://chromiumcodereview.appspot.com/11818045
------------------------------------------------------------------------

Comment 23 by bugdroid1@chromium.org, Jan 10 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=176055

------------------------------------------------------------------------
r176055 | jschuh@chromium.org | 2013-01-10T12:52:53.220345Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/cacheinvalidation/cacheinvalidation.gyp?r1=176055&r2=176054&pathrev=176055

Make cacheinvalidation build on Win64

BUG= 166496 
BUG=167187
TBR=scottmg

Review URL: https://chromiumcodereview.appspot.com/11819049
------------------------------------------------------------------------

Comment 24 by bugdroid1@chromium.org, Jan 10 2013

Project Member

Comment 25 by bugdroid1@chromium.org, Jan 11 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=176355

------------------------------------------------------------------------
r176355 | jschuh@chromium.org | 2013-01-11T15:59:43.223105Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/libjingle/libjingle.gyp?r1=176355&r2=176354&pathrev=176355
   M http://src.chromium.org/viewvc/chrome/trunk/src/jingle/jingle.gyp?r1=176355&r2=176354&pathrev=176355

Make all jingle targets build on Win64

BUG= 166496 
BUG=167187

Review URL: https://chromiumcodereview.appspot.com/11818046
------------------------------------------------------------------------

Comment 26 by bugdroid1@chromium.org, Jan 11 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=176397

------------------------------------------------------------------------
r176397 | jschuh@chromium.org | 2013-01-11T18:47:53.710551Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/sql/sql.gyp?r1=176397&r2=176396&pathrev=176397

Make sql build on Win64

BUG= 166496 
BUG=167187
TBR=shess

Review URL: https://chromiumcodereview.appspot.com/11860013
------------------------------------------------------------------------

Comment 27 by bugdroid1@chromium.org, Jan 14 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=176594

------------------------------------------------------------------------
r176594 | jschuh@chromium.org | 2013-01-12T20:16:55.395109Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/codesighs/codesighs.gyp?r1=176594&r2=176593&pathrev=176594

Make codesighs build on Win64

BUG= 166496 
BUG=167187
TBR=scottmg


Review URL: https://chromiumcodereview.appspot.com/11887007
------------------------------------------------------------------------

Comment 28 by bugdroid1@chromium.org, Jan 15 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=176847

------------------------------------------------------------------------
r176847 | scottmg@chromium.org | 2013-01-15T08:20:51.386191Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/win8/metro_driver/chrome_app_view.cc?r1=176847&r2=176846&pathrev=176847

fix SetWindowLong->SetWindowLongPtr for win x64

ref: http://msdn.microsoft.com/en-us/library/windows/desktop/ms644898(v=vs.85).aspx

R=cpu@chromium.org
BUG= 166496 


Review URL: https://chromiumcodereview.appspot.com/11882029
------------------------------------------------------------------------

Comment 29 by bugdroid1@chromium.org, Jan 15 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=176854

------------------------------------------------------------------------
r176854 | scottmg@chromium.org | 2013-01-15T08:40:57.255106Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/win8/metro_driver/file_picker.cc?r1=176854&r2=176853&pathrev=176854
   M http://src.chromium.org/viewvc/chrome/trunk/src/win8/metro_driver/winrt_utils.cc?r1=176854&r2=176853&pathrev=176854

size_t fixes for building on win x64

Fixes C4267 warnings, and errors regarding passing size_t* when they chould be unsigned int *.

winrt_utils:
WindowsCreateString takes a UINT32 as size. Truncation would mean
shorter than expected string, but presumably not a severe problem
in this case.

file_picker:
The interface uses unsigned int, not size_t, so change implementation and callers to unsigned int.


R=cpu@chromium.org
BUG= 166496 


Review URL: https://chromiumcodereview.appspot.com/11884021
------------------------------------------------------------------------

Comment 30 by bugdroid1@chromium.org, Jan 15 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=176859

------------------------------------------------------------------------
r176859 | scottmg@chromium.org | 2013-01-15T08:51:28.518259Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/atomicops_internals_x86_msvc.h?r1=176859&r2=176858&pathrev=176859
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/atomicops.h?r1=176859&r2=176858&pathrev=176859

Workaround to make MemoryBarrier compile on Win x64

windows.h #defines "MemoryBarrier" on x64 (on x86 it's an forceinline function). Because atomicops.h uses MemoryBarrier as the public api name, workaround by #undefing and then calling the implementation directly.

ref: http://msdn.microsoft.com/en-us/library/windows/desktop/ms684208.aspx


R=brettw@chromium.org
BUG= 166496 

Review URL: https://chromiumcodereview.appspot.com/11888016
------------------------------------------------------------------------

Comment 31 by bugdroid1@chromium.org, Jan 15 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=176860

------------------------------------------------------------------------
r176860 | scottmg@chromium.org | 2013-01-15T08:52:31.591751Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/range/range.h?r1=176860&r2=176859&pathrev=176860
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/win/hwnd_subclass.cc?r1=176860&r2=176859&pathrev=176860
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/ui.gyp?r1=176860&r2=176859&pathrev=176860
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/text_utils.cc?r1=176860&r2=176859&pathrev=176860
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/icon_util.cc?r1=176860&r2=176859&pathrev=176860
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/dragdrop/os_exchange_data_provider_win.cc?r1=176860&r2=176859&pathrev=176860
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/range/range_win.cc?r1=176860&r2=176859&pathrev=176860
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/win/dpi.cc?r1=176860&r2=176859&pathrev=176860

some fixes and warning disables in ui/ for building on win x64

- Some |int|s that should be |ptrdiff_t|s.
- Icon structures are packing to known size (same signs).
- GetWindowLong needs to be GetWindowLongPtr to work on 32 & 64.

R=ben@chromium.org, jschuh@chromium.org
BUG=167187,  166496 

Review URL: https://chromiumcodereview.appspot.com/11889017
------------------------------------------------------------------------

Comment 32 by bugdroid1@chromium.org, Jan 16 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=177075

------------------------------------------------------------------------
r177075 | jshin@chromium.org | 2013-01-16T03:47:38.251292Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=177075&r2=177074&pathrev=177075

Roll OTS to r96

This is to make OTS compile on Win64

See http://code.google.com/p/ots/source/detail?r=96 for the actual change.

BUG= chromium:166496 ,chromium:167187
TEST=Chrome can be compile on Windows 64
TBR=jschuh

Review URL: https://chromiumcodereview.appspot.com/11968002
------------------------------------------------------------------------

Comment 33 by bugdroid1@chromium.org, Jan 16 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=177264

------------------------------------------------------------------------
r177264 | scottmg@chromium.org | 2013-01-16T23:34:04.434059Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/base/safe_numerics_unittest.cc?r1=177264&r2=177263&pathrev=177264
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/base.gyp?r1=177264&r2=177263&pathrev=177264
   A http://src.chromium.org/viewvc/chrome/trunk/src/base/safe_numerics.h?r1=177264&r2=177263&pathrev=177264
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/base.gypi?r1=177264&r2=177263&pathrev=177264
   A http://src.chromium.org/viewvc/chrome/trunk/src/base/safe_numerics_unittest.nc?r1=177264&r2=177263&pathrev=177264

Add numeric_cast for checked integral narrowing casts

In work on bringing up Windows x64, there are many places that need
to be safely narrowed to the types used for interacting with other
APIs (particularly when using containers). Rather than scatter these
CHECKs all over, numeric_cast<> CHECKs that the runtime value can be
safely converted to the target type.

BUG= 8606 , 167187,  166496 

Review URL: https://codereview.chromium.org/11886037
------------------------------------------------------------------------

Comment 34 by bugdroid1@chromium.org, Jan 17 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=177437

------------------------------------------------------------------------
r177437 | wtc@chromium.org | 2013-01-17T18:24:28.184007Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/nss/nss.gyp?r1=177437&r2=177436&pathrev=177437

It is not necessary to disable Visual C++ warning C4334 when
compiling NSPR.

R=jschuh@chromium.org
BUG= 166496 
TEST=no compilation errors
Review URL: https://codereview.chromium.org/11886033
------------------------------------------------------------------------

Comment 35 by bugdroid1@chromium.org, Jan 18 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=177653

------------------------------------------------------------------------
r177653 | fgalligan@chromium.org | 2013-01-18T12:35:13.064862Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/yasm/yasm_compile.gypi?r1=177653&r2=177652&pathrev=177653

Add support for win64 flags to yasm.

This change is needed to add win64 support to libvpx.

BUG= 166496 ,  170672 


Review URL: https://chromiumcodereview.appspot.com/11971037
------------------------------------------------------------------------

Comment 36 by bugdroid1@chromium.org, Jan 18 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=177756

------------------------------------------------------------------------
r177756 | wtc@chromium.org | 2013-01-18T21:20:37.711760Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=177756&r2=177755&pathrev=177756

Update nss_revision to r177437.

The underlying CL is https://codereview.chromium.org/11886033/.

R=jschuh@chromium.org
BUG= 166496 
TEST=no compilation errors
Review URL: https://codereview.chromium.org/11867017
------------------------------------------------------------------------

Comment 37 by bugdroid1@chromium.org, Jan 18 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=177790

------------------------------------------------------------------------
r177790 | scottmg@chromium.org | 2013-01-18T23:14:34.708820Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/win8/metro_driver/print_handler.cc?r1=177790&r2=177789&pathrev=177790
   M http://src.chromium.org/viewvc/chrome/trunk/src/win8/metro_driver/print_document_source.cc?r1=177790&r2=177789&pathrev=177790

some size_t -> uint32/ulong to match windows api for x64

(I looked at changing size_t to unsigned int elsewhere, but then the interactions with std::vector get messier then).

R=cpu@chromium.org
BUG= 166496 

Review URL: https://chromiumcodereview.appspot.com/11876033
------------------------------------------------------------------------

Comment 38 by bugdroid1@chromium.org, Jan 22 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=177925

------------------------------------------------------------------------
r177925 | jschuh@chromium.org | 2013-01-21T15:38:28.506767Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/gpu/gpu.gyp?r1=177925&r2=177924&pathrev=177925

Make gpu build on Win64

This just suppresses warnings for chrome.exe.
More suppressions are needed for the tests.

BUG= 166496 
BUG=167187
TBR=apatrick@chromium.org
Review URL: https://codereview.chromium.org/12039008
------------------------------------------------------------------------

Comment 39 by bugdroid1@chromium.org, Jan 22 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=177924

------------------------------------------------------------------------
r177924 | jschuh@chromium.org | 2013-01-21T15:36:36.159668Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/base/audio_bus.h?r1=177924&r2=177923&pathrev=177924
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/base/audio_bus.cc?r1=177924&r2=177923&pathrev=177924

Fix media/base 64-bit compilation issues

BUG= 166496 
TBR=scherkus@chromium.org
Review URL: https://codereview.chromium.org/12043004
------------------------------------------------------------------------

Comment 40 by bugdroid1@chromium.org, Jan 22 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=177940

------------------------------------------------------------------------
r177940 | jschuh@chromium.org | 2013-01-21T17:58:28.710322Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/printing/image.cc?r1=177940&r2=177939&pathrev=177940
   M http://src.chromium.org/viewvc/chrome/trunk/src/printing/pdf_metafile_skia.cc?r1=177940&r2=177939&pathrev=177940
   M http://src.chromium.org/viewvc/chrome/trunk/src/printing/print_destination_win.cc?r1=177940&r2=177939&pathrev=177940

Make printing build on Win64

Just adds some safe casts for the integer conversions.

BUG= 166496 
TBR=thestig@chromium.org

Review URL: https://chromiumcodereview.appspot.com/11953003
------------------------------------------------------------------------

Comment 41 by bugdroid1@chromium.org, Jan 22 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=177941

------------------------------------------------------------------------
r177941 | jschuh@chromium.org | 2013-01-21T18:04:52.044698Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_common.gypi?r1=177941&r2=177940&pathrev=177941

Make common_net build on Win64

BUG= 166496 
BUG=167187
TBR=brettw@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12034004
------------------------------------------------------------------------

Comment 42 by wolenetz@chromium.org, Jan 23 2013

See https://gerrit.chromium.org/gerrit/41868 "Ignore size_t conversion data loss compiler warnings for win64 ffmpeg"

Comment 43 by bugdroid1@chromium.org, Jan 23 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=178429

------------------------------------------------------------------------
r178429 | wolenetz@chromium.org | 2013-01-23T23:44:28.499232Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/yasm/yasm_compile.gypi?r1=178429&r2=178428&pathrev=178429

Remove -DPREFIX from win64 yasm_compile.gypi to fix ffmpeg linking

BUG= 171542 , 171721 , 166496 
TEST=ffmpegsumo target builds on win64 with private fix to disable ffmpeg compiler warning 4267 on win64


Review URL: https://chromiumcodereview.appspot.com/12059002
------------------------------------------------------------------------

Comment 44 by bugdroid1@chromium.org, Jan 26 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=178991

------------------------------------------------------------------------
r178991 | jschuh@chromium.org | 2013-01-26T02:08:41.649287Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/storage/webkit_storage.gypi?r1=178991&r2=178990&pathrev=178991

Make webkit_storage build on Win64

BUG= 166496 
BUG=167187
TBR=brettw@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12036107
------------------------------------------------------------------------

Comment 45 by bugdroid1@chromium.org, Jan 26 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=178999

------------------------------------------------------------------------
r178999 | jschuh@chromium.org | 2013-01-26T02:20:39.191819Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/ppapi_internal.gyp?r1=178999&r2=178998&pathrev=178999

Make ppapi build on Win64

BUG= 166496 
BUG=167187
TBR=viettrungluu@chromium.org


Review URL: https://chromiumcodereview.appspot.com/12086006
------------------------------------------------------------------------

Comment 46 by bugdroid1@chromium.org, Jan 26 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=179018

------------------------------------------------------------------------
r179018 | jschuh@chromium.org | 2013-01-26T03:58:50.745411Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/media/webkit_media.gypi?r1=179018&r2=179017&pathrev=179018

Make webkit_media build on Win64

BUG= 166496 
BUG=167187
TBR=scherkus@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12082008
------------------------------------------------------------------------

Comment 47 by bugdroid1@chromium.org, Jan 26 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=179030

------------------------------------------------------------------------
r179030 | jschuh@chromium.org | 2013-01-26T04:27:45.949427Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/gpu/webkit_gpu.gypi?r1=179030&r2=179029&pathrev=179030

Make webkit_gpu build on Win64

BUG= 166496 
BUG=167187
TBR=gman@chromium.org
Review URL: https://codereview.chromium.org/12090005
------------------------------------------------------------------------

Comment 48 by bugdroid1@chromium.org, Jan 29 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=179279

------------------------------------------------------------------------
r179279 | jschuh@chromium.org | 2013-01-29T02:53:54.262828Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/apps/apps.gypi?r1=179279&r2=179278&pathrev=179279

Make apps build on Win64

Just a warning suppression.

BUG= 166496 
BUG=167187
TBR=asargent@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12089028
------------------------------------------------------------------------

Comment 49 by bugdroid1@chromium.org, Jan 29 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=179327

------------------------------------------------------------------------
r179327 | jschuh@chromium.org | 2013-01-29T13:26:45.756449Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/win8/metro_driver/metro_driver.cc?r1=179327&r2=179326&pathrev=179327

Make metro build on Win64

Remove a dependency that was eliminated when
 crbug.com/140545  was fixed.

BUG= 166496 
BUG= 140545 

Review URL: https://chromiumcodereview.appspot.com/11929041
------------------------------------------------------------------------

Comment 50 by bugdroid1@chromium.org, Jan 29 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=179379

------------------------------------------------------------------------
r179379 | dalecurtis@google.com | 2013-01-29T19:15:03.395047Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/base/simd/x86inc.asm?r1=179379&r2=179378&pathrev=179379
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/yasm/yasm_compile.gypi?r1=179379&r2=179378&pathrev=179379
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/media.gyp?r1=179379&r2=179378&pathrev=179379

Enables win64 build of yuv_convert_simd_x86 without rolling x86inc.asm forward.

BUG= 172129 ,  166496 

Review URL: https://codereview.chromium.org/12036108
------------------------------------------------------------------------

Comment 51 by bugdroid1@chromium.org, Jan 30 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=179483

------------------------------------------------------------------------
r179483 | jschuh@chromium.org | 2013-01-30T00:30:19.103352Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/message_center/message_center.gyp?r1=179483&r2=179482&pathrev=179483
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/views.gyp?r1=179483&r2=179482&pathrev=179483
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/app_list/app_list.gyp?r1=179483&r2=179482&pathrev=179483

Make ui build on Win64

Just c4267 build suppressions.

BUG= 166496 
BUG=167187
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12096043
------------------------------------------------------------------------

Comment 52 by bugdroid1@chromium.org, Jan 30 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=179486

------------------------------------------------------------------------
r179486 | jschuh@chromium.org | 2013-01-30T00:47:21.150453Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/cc.gyp?r1=179486&r2=179485&pathrev=179486

Make cc build on Win64 

Just c4267 build suppressions. 

BUG= 166496 
BUG=167187
TBR=jamesr@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12096044
------------------------------------------------------------------------

Comment 53 by bugdroid1@chromium.org, Jan 30 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=179612

------------------------------------------------------------------------
r179612 | wolenetz@chromium.org | 2013-01-30T12:24:10.733454Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/media.gyp?r1=179612&r2=179611&pathrev=179612

Disable size_t to int conversion data loss warnings in media win64 builds

BUG= 172415 , 166496 
TEST=local build of media target on win64 doesn't emit compiler warning 4267, with libvpx DEPS rolled privately per https://codereview.chromium.org/12087013/
R=scherkus@chromium.org


Review URL: https://chromiumcodereview.appspot.com/12094047
------------------------------------------------------------------------

Comment 54 by bugdroid1@chromium.org, Jan 31 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=179730

------------------------------------------------------------------------
r179730 | jschuh@chromium.org | 2013-01-30T23:18:32.461186Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/base/io_buffer.cc?r1=179730&r2=179729&pathrev=179730
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/base/io_buffer.h?r1=179730&r2=179729&pathrev=179730

Make net::IOBuffer 64-bit safe

BUG= 166496 

Review URL: https://chromiumcodereview.appspot.com/12091071
------------------------------------------------------------------------

Comment 55 by bugdroid1@chromium.org, Jan 31 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=179791

------------------------------------------------------------------------
r179791 | jschuh@chromium.org | 2013-01-31T04:26:30.792486Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/plugins/npapi/webplugin_delegate_impl_win.cc?r1=179791&r2=179790&pathrev=179791

SetWindowLongPtrA takes a GWLP_WNDPROC

Right now it's a GWL_WNDPROC, which is the same value but technically incorrect and invalid on Win64.

BUG= 166496 
Review URL: https://codereview.chromium.org/12090079
------------------------------------------------------------------------

Comment 56 by bugdroid1@chromium.org, Feb 1 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=180078

------------------------------------------------------------------------
r180078 | jschuh@chromium.org | 2013-02-01T05:09:27.598654Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/qcms/qcms.gyp?r1=180078&r2=180077&pathrev=180078

Disable MMX intrinsics in qcms for x64 earlier than MSVC 2012

MMX intrinsics aren't supported on x64 until MSVC 2012.

BUG= 166496 
TBR=scottmg

Review URL: https://chromiumcodereview.appspot.com/12088098
------------------------------------------------------------------------

Comment 57 by bugdroid1@chromium.org, Feb 1 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=180141

------------------------------------------------------------------------
r180141 | jschuh@chromium.org | 2013-02-01T14:34:59.421092Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/media.gyp?r1=180141&r2=180140&pathrev=180141
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/base/simd/convert_yuv_to_rgb_x86.cc?r1=180141&r2=180140&pathrev=180141
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/base/yuv_convert.cc?r1=180141&r2=180140&pathrev=180141
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/base/yuv_convert.h?r1=180141&r2=180140&pathrev=180141
   A http://src.chromium.org/viewvc/chrome/trunk/src/media/base/simd/empty_register_state_mmx.asm?r1=180141&r2=180140&pathrev=180141

Replace or exclude MMX intrinsics in yuv_convert_simd_x86 due to lack of VS2010 support for them in Win64 

On Win64, exclude MMX version in ChooseFilterYUVRowsProc; still use faster 
SSE2 version. 
Replace _mm_empty() with new yasm that implements EmptyRegisterState_MMX() 
with emms in EmptyRegisterState(), ConvertYUVToRGB32_MMX(...), and 
ConvertYUVToRGB32_SSE(...). 

This patch does not fix other win64 media link errors; more work remains for 
 bug 172938 . 

Committing for wolenetz from : https://codereview.chromium.org/12082087/#msg15

BUG= 172938 ,  166496 
R=wolenetz@chromium.org
TBR=wolenetz@chromium.org
Review URL: https://codereview.chromium.org/12090114
------------------------------------------------------------------------

Comment 58 by bugdroid1@chromium.org, Feb 1 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=180142

------------------------------------------------------------------------
r180142 | jschuh@chromium.org | 2013-02-01T14:39:10.832889Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webkit_glue.gypi?r1=180142&r2=180141&pathrev=180142

Make webkit_glue build on Win64 

Just c4267 build suppressions. 

BUG= 166496 
BUG=167187
R=brettw@chromium.org
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/12084104
------------------------------------------------------------------------

Comment 59 by bugdroid1@chromium.org, Feb 1 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=180184

------------------------------------------------------------------------
r180184 | wolenetz@chromium.org | 2013-02-01T20:55:21.241973Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/tools/generate_stubs/generate_stubs.py?r1=180184&r2=180183&pathrev=180184

Enable win64 stub library generation.
Previously, /machine:X86 was the hardcoded lib option.
This patch enables /machine:X64, if the file type parameter is 'windows_lib_x64'. To unblock media <-> ffmpeg win64 linking, this patch along with a separate patch to ffmpeg.gyp will be necessary.

BUG= 172938 ,  166496 
TEST=win_rel try bot (win32). Private with additional fix to use 'windows_lib_x64' for win64 in ffmpeg.gyp eliminates media<->ffmpeg link errors in win64. Unittests.

Review URL: https://chromiumcodereview.appspot.com/12087128
------------------------------------------------------------------------

Comment 60 by bugdroid1@chromium.org, Feb 2 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=180216

------------------------------------------------------------------------
r180216 | jschuh@chromium.org | 2013-02-02T00:39:10.874718Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=180216&r2=180215&pathrev=180216

Make debugger and utility build on Win64 

Just c4267 build suppressions. 

BUG= 166496 
BUG=167187
TBR=thakis@chromium.org
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/12095107
------------------------------------------------------------------------

Comment 61 by bugdroid1@chromium.org, Feb 2 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=180259

------------------------------------------------------------------------
r180259 | jschuh@chromium.org | 2013-02-02T13:11:36.463680Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_installer_util.gypi?r1=180259&r2=180258&pathrev=180259

Make installer_util build on Win64 

Just c4267 build suppressions. 

BUG= 166496 
BUG=167187
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/12181002
------------------------------------------------------------------------

Comment 62 by bugdroid1@chromium.org, Feb 2 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=180260

------------------------------------------------------------------------
r180260 | jschuh@chromium.org | 2013-02-02T13:15:05.101133Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/panels/panel_view.cc?r1=180260&r2=180259&pathrev=180260
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/panels/panel_stack_view.cc?r1=180260&r2=180259&pathrev=180260

Convert to *WindowLongPtr functions for Win64 compatability 

BUG= 166496 
TBR=jianli@chromium.org 
Review URL: https://codereview.chromium.org/12094107
------------------------------------------------------------------------

Comment 63 by bugdroid1@chromium.org, Feb 2 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=180261

------------------------------------------------------------------------
r180261 | jschuh@chromium.org | 2013-02-02T13:28:41.693541Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=180261&r2=180260&pathrev=180261

Roll ffmpeg DEPS to 180199 

Manually landing: https://chromiumcodereview.appspot.com/12096120/ 

TBR=wolenetz, dalecurtis 
BUG= 172938 ,  166496 
Review URL: https://codereview.chromium.org/12185005
------------------------------------------------------------------------

Comment 64 by bugdroid1@chromium.org, Feb 3 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=180318

------------------------------------------------------------------------
r180318 | jschuh@chromium.org | 2013-02-03T19:30:26.307803Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content.gyp?r1=180318&r2=180317&pathrev=180318

Enable BIGOBJ in MSVC for content target

Under Win64 builds content exceeds the obj section limit. 
Eventually we need to enable this in common.gypi, but we 
need to fix some targets to make them compatible first. 

BUG= 166496 ,  173851 
TBR=jam

Review URL: https://chromiumcodereview.appspot.com/12191002
------------------------------------------------------------------------

Comment 65 by bugdroid1@chromium.org, Feb 3 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=180323

------------------------------------------------------------------------
r180323 | jschuh@chromium.org | 2013-02-03T21:16:00.276181Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/hang_monitor/hung_window_detector.cc?r1=180323&r2=180322&pathrev=180323

Pass a DWORD_PTR to SendMessageTimeout in HungWindowDetector::CheckChildWindow

Trivial x64 Windows compile fix.

BUG= 166496 
TBR=brettw@chromium.org
R=brettw@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12193006
------------------------------------------------------------------------

Comment 66 by bugdroid1@chromium.org, Feb 4 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=180331

------------------------------------------------------------------------
r180331 | jschuh@chromium.org | 2013-02-04T00:58:26.154478Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/media.gyp?r1=180331&r2=180330&pathrev=180331

Exclude filter_yuv_mmx.cc from x64 on MSVC prior to 2012

Minor follow-up fix to r179379. Linking content fails otherwise, because MMX intrinsics aren't supported.

TBR=scherkus
BUG= 172129 ,  166496 

Review URL: https://chromiumcodereview.appspot.com/12183011
------------------------------------------------------------------------

Comment 67 by bugdroid1@chromium.org, Feb 5 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=180801

------------------------------------------------------------------------
r180801 | jschuh@chromium.org | 2013-02-05T22:32:18.340277Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome.dll.manifest?r1=180801&r2=180800&pathrev=180801
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome.exe.manifest?r1=180801&r2=180800&pathrev=180801
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/build/win/create_installer_archive.py?r1=180801&r2=180800&pathrev=180801

MSVC manifests should use processorArchitecture="*"

This is inferred from the binary itself, and specifying it here breaks the Win64 build.

BUG= 166496 
Review URL: https://codereview.chromium.org/12222002
------------------------------------------------------------------------

Comment 68 by bugdroid1@chromium.org, Feb 6 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=180874

------------------------------------------------------------------------
r180874 | wolenetz@chromium.org | 2013-02-06T02:46:08.180576Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/media.gyp?r1=180874&r2=180873&pathrev=180874

Ignore C4267 size_t to int truncations in win64 media_unittests


BUG= 173697 ,  166496 
TEST=media_unittests target builds without C4267 errors. With other build errors fixed in privates (fix win64 gmock_mutant template functor redefinitions & lift MEDIA...INTRINSICS... definition into yuv_convert.h and use it to not link in methods that use MMX intrinsics), media_unittests executes


Review URL: https://chromiumcodereview.appspot.com/12213027
------------------------------------------------------------------------

Comment 69 by bugdroid1@chromium.org, Feb 7 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=181344

------------------------------------------------------------------------
r181344 | wolenetz@chromium.org | 2013-02-07T19:09:39.356255Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/base/yuv_convert_unittest.cc?r1=181344&r2=181343&pathrev=181344
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/base/yuv_convert.cc?r1=181344&r2=181343&pathrev=181344
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/base/yuv_convert.h?r1=181344&r2=181343&pathrev=181344

Lift MEDIA_MMX_INTRINSICS_AVAILABLE definition to header and use it to condition media_unittests


BUG= 173697 ,  166496 
TEST=With other build errors fixed in privates (fix win64 gmock_mutant template functor redefinitions & ignore C4267 size_t to int truncations), win64 media_unittests builds without link error to (shared library) media::FilterYUVRows_MMX
R=scherkus@chromium.org


Review URL: https://chromiumcodereview.appspot.com/12213029
------------------------------------------------------------------------

Comment 70 by bugdroid1@chromium.org, Feb 7 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=181348

------------------------------------------------------------------------
r181348 | wolenetz@chromium.org | 2013-02-07T19:20:21.073280Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/testing/generate_gmock_mutant.py?r1=181348&r2=181347&pathrev=181348
   M http://src.chromium.org/viewvc/chrome/trunk/src/testing/gmock_mutant.h?r1=181348&r2=181347&pathrev=181348

Exclude duplicate gmock_mutant functor templates in WIN64

On WIN64, there is only one calling convention.  Therefore,
implicit calling conventions and __stdcall are the same, hence
template redefinition errors occur in the previous gmock_mutant.h
on WIN64.

BUG= 173697 ,  166496 
TEST=media_unittests target builds without template redefinition errors.  With other build errors fixed in privates (ignore C4267 & lift MEDIA...INTRINSICS... definition into yuv_convert.h and use it to not link in methods that use MMX intrinsics), media_unittests executes


Review URL: https://chromiumcodereview.appspot.com/12208028
------------------------------------------------------------------------

Comment 71 by bugdroid1@chromium.org, Feb 8 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=181403

------------------------------------------------------------------------
r181403 | jschuh@chromium.org | 2013-02-08T02:01:32.325758Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/ppapi_tests.gypi?r1=181403&r2=181402&pathrev=181403

Make ppapi_unittests build on Win64

Just c4267 build suppressions. 

BUG= 166496 
BUG=167187
TBR=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/12208076
------------------------------------------------------------------------

Comment 72 by bugdroid1@chromium.org, Feb 8 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=181419

------------------------------------------------------------------------
r181419 | jschuh@chromium.org | 2013-02-08T03:28:17.416288Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/printing/printing.gyp?r1=181419&r2=181418&pathrev=181419

Make printing_unittests build on Win64 

Just c4267 build suppressions. 

BUG= 166496 
BUG=167187
TBR=abodenha@chromium.org
Review URL: https://codereview.chromium.org/12218066
------------------------------------------------------------------------

Comment 73 by bugdroid1@chromium.org, Feb 8 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=181422

------------------------------------------------------------------------
r181422 | jschuh@chromium.org | 2013-02-08T03:46:32.747824Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/ui_unittests.gypi?r1=181422&r2=181421&pathrev=181422

Make ui_unittests build on Win64 

Just c4267 build suppressions. 

BUG= 166496 
BUG=167187
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/12208077
------------------------------------------------------------------------

Comment 74 by bugdroid1@chromium.org, Feb 8 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=181433

------------------------------------------------------------------------
r181433 | jschuh@chromium.org | 2013-02-08T05:22:00.632422Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_installer.gypi?r1=181433&r2=181432&pathrev=181433
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/upgrade_test.gyp?r1=181433&r2=181432&pathrev=181433

Make installer_util_unittests build on Win64 

Just c4267 build suppressions. 

BUG= 166496 
BUG=167187
TBR=robertshield@chromium.org, brettw@chromium.org
R=robertshield@chromium.org, brettw@chromium.org
Review URL: https://codereview.chromium.org/12207072
------------------------------------------------------------------------

Comment 75 by bugdroid1@chromium.org, Feb 8 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=181451

------------------------------------------------------------------------
r181451 | jschuh@chromium.org | 2013-02-08T07:39:41.163809Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/support/webkit_support.gypi?r1=181451&r2=181450&pathrev=181451

Make views_unittests build on Win64 

Just c4267 build suppressions. 

BUG= 166496 
BUG=167187
TBR=tkent@chromium.org
R=tkent@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12218070
------------------------------------------------------------------------

Comment 76 by bugdroid1@chromium.org, Feb 8 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=181453

------------------------------------------------------------------------
r181453 | jschuh@chromium.org | 2013-02-08T07:48:38.001453Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/gpu/gpu.gyp?r1=181453&r2=181452&pathrev=181453

Make gpu_unittests build on Win64 

Just c4267 build suppressions. 

BUG= 166496 
BUG=167187
TBR=piman@chromium.org
R=piman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12210078
------------------------------------------------------------------------

Comment 77 by bugdroid1@chromium.org, Feb 9 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=181631

------------------------------------------------------------------------
r181631 | jschuh@chromium.org | 2013-02-09T21:18:42.371918Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/components_tests.gypi?r1=181631&r2=181630&pathrev=181631

Make component_unittests build on Win64 

Just c4267 build suppressions. 

BUG= 166496 
BUG=167187

TBR=joi@chromium.org
R=joi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12221107
------------------------------------------------------------------------

Comment 78 by bugdroid1@chromium.org, Feb 9 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=181635

------------------------------------------------------------------------
r181635 | jschuh@chromium.org | 2013-02-09T22:31:00.834856Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/tools/json_schema_compiler/test/json_schema_compiler_tests.gyp?r1=181635&r2=181634&pathrev=181635
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/plugin.gyp?r1=181635&r2=181634&pathrev=181635

Make content_unittests build on Win64 

Just c4267 build suppressions. 

BUG= 166496 
BUG=167187

TBR=bbudge@chromium.org
R=bbudge@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12207094
------------------------------------------------------------------------

Comment 79 by bugdroid1@chromium.org, Feb 10 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=181636

------------------------------------------------------------------------
r181636 | jschuh@chromium.org | 2013-02-10T00:12:55.845257Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/courgette/courgette.gyp?r1=181636&r2=181635&pathrev=181636

Make courgette_unittests build on Win64 

Just c4267 build suppressions. 

BUG= 166496 
BUG=167187

TBR=sra@chromium.org
R=sra@chromium.org
Review URL: https://codereview.chromium.org/12207096
------------------------------------------------------------------------

Comment 80 by bugdroid1@chromium.org, Feb 10 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=181650

------------------------------------------------------------------------
r181650 | jschuh@chromium.org | 2013-02-10T16:11:57.644510Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/disconnect_window_win.cc?r1=181650&r2=181649&pathrev=181650
   M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/remoting.gyp?r1=181650&r2=181649&pathrev=181650

Make remoting_unittests build on Win64 

Two simple compilation fixes and some c4267 build suppressions. 

BUG= 166496 
BUG=167187
R=wez@chromium.org
Review URL: https://codereview.chromium.org/12225111
------------------------------------------------------------------------

Comment 81 by bugdroid1@chromium.org, Feb 12 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=181687

------------------------------------------------------------------------
r181687 | jschuh@chromium.org | 2013-02-11T14:05:49.281018Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/upgrade_test.gyp?r1=181687&r2=181686&pathrev=181687

Make installer_util_unittests build on Win64 

Just c4267 build suppressions. 

BUG= 166496 
BUG=167187
TBR=robertshield@chromium.org
R=robertshield@chromium.org
Review URL: https://codereview.chromium.org/12213107
------------------------------------------------------------------------

Comment 82 by bugdroid1@chromium.org, Feb 13 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182223

------------------------------------------------------------------------
r182223 | jschuh@chromium.org | 2013-02-13T15:28:12.139597Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/ppapi_internal.gyp?r1=182223&r2=182222&pathrev=182223

Make ppapi static and release builds work on Win64 

Just c4267 build suppressions. 

BUG= 166496 
BUG=167187
TBR=yzshen@chromium.org
R=yzshen@chromium.org
Review URL: https://codereview.chromium.org/12258010
------------------------------------------------------------------------

Comment 83 by bugdroid1@chromium.org, Feb 13 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182224

------------------------------------------------------------------------
r182224 | jschuh@chromium.org | 2013-02-13T15:29:02.296955Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content.gyp?r1=182224&r2=182223&pathrev=182224

Make content static and release builds work on Win64 

Just c4267 build suppressions. 

BUG= 166496 
BUG=167187
TBR=jam@chromium.org
R=jam@chromium.org
Review URL: https://codereview.chromium.org/12254004
------------------------------------------------------------------------

Comment 84 by bugdroid1@chromium.org, Feb 13 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182225

------------------------------------------------------------------------
r182225 | jschuh@chromium.org | 2013-02-13T15:29:53.878950Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/gpu/gpu.gyp?r1=182225&r2=182224&pathrev=182225

Make gpu static and release builds work on Win64 

Just c4267 build suppressions. 

BUG= 166496 
BUG=167187
TBR=gman@chromium.org
R=gman@chromium.org
Review URL: https://codereview.chromium.org/12261007
------------------------------------------------------------------------

Comment 85 by bugdroid1@chromium.org, Feb 14 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182353

------------------------------------------------------------------------
r182353 | jschuh@chromium.org | 2013-02-14T00:37:15.282596Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/jemalloc/chromium/jemalloc.c?r1=182353&r2=182352&pathrev=182353

Fix jemalloc c4334 warnings when compiling win64 

BUG= 166496 
TBR=cpu
Review URL: https://codereview.chromium.org/12230011
------------------------------------------------------------------------

Comment 86 by bugdroid1@chromium.org, Feb 14 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182457

------------------------------------------------------------------------
r182457 | wfh@chromium.org | 2013-02-14T14:19:49.024597Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/allocator/prep_libc.py?r1=182457&r2=182456&pathrev=182457

Fixes to prep_libc.py to support correct stripping of x64 libcmt on x64 target

BUG= 166496 

Review URL: https://chromiumcodereview.appspot.com/12258025
------------------------------------------------------------------------

Comment 87 by bugdroid1@chromium.org, Feb 15 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182653

------------------------------------------------------------------------
r182653 | jschuh@chromium.org | 2013-02-15T09:22:13.081436Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/all.gyp?r1=182653&r2=182652&pathrev=182653

Exclude win64 cross-compile dependencies from normal win64 build

BUG= 166496 
R=scottmg@chromium.org
TBR=scottmg@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12252059
------------------------------------------------------------------------

Comment 88 by bugdroid1@chromium.org, Feb 15 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182740

------------------------------------------------------------------------
r182740 | gab@chromium.org | 2013-02-15T17:24:58.348331Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/build/win/create_installer_archive.py?r1=182740&r2=182739&pathrev=182740

Remove processArchitecture value from manifests.


BUG= 166496 
TEST=Install component build of Chrome via "setup.exe --chrome --multi-install" and make sure you can launch chrome.exe.

Review URL: https://chromiumcodereview.appspot.com/12252043
------------------------------------------------------------------------

Comment 90 by bugdroid1@chromium.org, Feb 15 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182785

------------------------------------------------------------------------
r182785 | jschuh@chromium.org | 2013-02-15T19:31:41.665020Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_javascript_dialog_win.cc?r1=182785&r2=182784&pathrev=182785
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_shell.gypi?r1=182785&r2=182784&pathrev=182785

Make content_shell build on Win64 

A c4267 build suppression and some simple compile fixes
for the wrong argument types.

BUG= 166496 
BUG=167187
TBR=jam@chromium.org
R=jam@chromium.org
Review URL: https://codereview.chromium.org/12254051
------------------------------------------------------------------------

Comment 91 by bugdroid1@chromium.org, Feb 15 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182788

------------------------------------------------------------------------
r182788 | wfh@chromium.org | 2013-02-15T19:37:13.250991Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/allocator/allocator_shim.cc?r1=182788&r2=182787&pathrev=182788

Change call_new_handler to be non extern C; not called outside this code and it's causing issues with the linker on Win-64

BUG= 166496 


Review URL: https://chromiumcodereview.appspot.com/12256047
------------------------------------------------------------------------

Comment 92 by bugdroid1@chromium.org, Feb 16 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182979

------------------------------------------------------------------------
r182979 | jschuh@chromium.org | 2013-02-16T18:04:24.102305Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/gpu/gles2_conform_support/gles2_conform_support.gyp?r1=182979&r2=182978&pathrev=182979
   M http://src.chromium.org/viewvc/chrome/trunk/src/gpu/gpu.gyp?r1=182979&r2=182978&pathrev=182979

Make all gpu tests build on Win64 

Just a bunch of c4267 build suppressions. 

BUG= 166496 
BUG=167187
TBR=piman@chromium.org
R=piman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12282017
------------------------------------------------------------------------

Comment 93 by bugdroid1@chromium.org, Feb 16 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182994

------------------------------------------------------------------------
r182994 | jschuh@chromium.org | 2013-02-16T18:36:31.593793Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=182994&r2=182993&pathrev=182994

Make all content tests build on Win64 

Just a c4267 build suppression. 

BUG= 166496 
BUG=167187
TBR=creis@chromium.org
R=creis@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12281018
------------------------------------------------------------------------

Comment 94 by bugdroid1@chromium.org, Feb 16 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182998

------------------------------------------------------------------------
r182998 | jschuh@chromium.org | 2013-02-16T19:15:56.711900Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/importer/ie_importer_unittest_win.cc?r1=182998&r2=182997&pathrev=182998

Use qualified ITEMIDLISTs in CreateOrderBlob

Win64 builds fail on alignment error if you use the wrong struct type.

BUG= 166496 
R=isherman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12287025
------------------------------------------------------------------------

Comment 95 by bugdroid1@chromium.org, Feb 16 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182999

------------------------------------------------------------------------
r182999 | jschuh@chromium.org | 2013-02-16T19:16:12.714236Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/ppapi_tests.gypi?r1=182999&r2=182998&pathrev=182999

Make ppapi tests build on Win64 

Just a bunch of c4267 build suppressions. 

BUG= 166496 
BUG=167187
TBR=yzshen@chromium.org
R=yzshen@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12287026
------------------------------------------------------------------------

Comment 96 by bugdroid1@chromium.org, Feb 16 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=183007

------------------------------------------------------------------------
r183007 | jschuh@chromium.org | 2013-02-16T22:20:16.175122Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/cc_tests.gyp?r1=183007&r2=183006&pathrev=183007

Make compositor tests build on Win64

Just some warning suppressions.

BUG= 166496 
BUG=167187
R=jamesr@chromium.org
TBR=jamser@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12284018
------------------------------------------------------------------------

Comment 97 by bugdroid1@chromium.org, Feb 16 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=183008

------------------------------------------------------------------------
r183008 | jschuh@chromium.org | 2013-02-16T22:20:29.574141Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=183008&r2=183007&pathrev=183008

Make chromedriver build on Win64

Just disable some warnings in mongoose.

BUG= 166496 
BUG=167187
R=brettw@chromium.org
TBR=brettw@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12285020
------------------------------------------------------------------------

Comment 99 by bugdroid1@chromium.org, Feb 17 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=183041

------------------------------------------------------------------------
r183041 | jschuh@chromium.org | 2013-02-17T18:57:41.296228Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=183041&r2=183040&pathrev=183041

Make content_tests build on Win64

Just some c4267 warning suppressions.

BUG= 166496 
BUG=167187
TBR=jam@chromium.org
R=jam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12301003
------------------------------------------------------------------------

Comment 100 by bugdroid1@chromium.org, Feb 17 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=183042

------------------------------------------------------------------------
r183042 | jschuh@chromium.org | 2013-02-17T19:35:55.841054Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/nacl_host/test/mock_nacl_gdb.gyp?r1=183042&r2=183041&pathrev=183042

Make mock_nacl_gdb build on Win64

Just a c4267 suppression.

BUG= 166496 
BUG=167187
R=bradnelson@chromium.org
TBR=bradnelson@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12302003
------------------------------------------------------------------------

Comment 101 by bugdroid1@chromium.org, Feb 18 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=183062

------------------------------------------------------------------------
r183062 | jschuh@chromium.org | 2013-02-18T04:48:14.014435Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=183062&r2=183061&pathrev=183062

Make chrome_tests build on Win64 

Just c4267 build suppressions. 

BUG= 166496 
BUG=167187
TBR=brettw@chromium.org
R=brettw@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12295005
------------------------------------------------------------------------

Comment 102 by bugdroid1@chromium.org, Feb 18 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=183108

------------------------------------------------------------------------
r183108 | jschuh@chromium.org | 2013-02-18T13:11:30.657759Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/rlz/rlz.gyp?r1=183108&r2=183107&pathrev=183108

Make rlz build on Win64 

Just c4267 build suppressions. 

BUG= 166496 
BUG=167187
TBR=rogerta@chromium.org
R=rogerta@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12299010
------------------------------------------------------------------------

Comment 103 by bugdroid1@chromium.org, Feb 18 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=183133

------------------------------------------------------------------------
r183133 | jschuh@chromium.org | 2013-02-18T18:34:40.361139Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=183133&r2=183132&pathrev=183133

Make chromedriver build on Win64 

Just c4267 build suppressions. 

BUG= 166496 
BUG=167187
TBR=brettw@chromium.org
R=brettw@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12296012
------------------------------------------------------------------------

Comment 104 by bugdroid1@chromium.org, Feb 18 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=183136

------------------------------------------------------------------------
r183136 | jschuh@chromium.org | 2013-02-18T18:56:08.664049Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/media/webkit_media.gypi?r1=183136&r2=183135&pathrev=183136

Make clearkey build on Win64 

Just c4267 build suppressions. 

BUG= 166496 
BUG=167187
TBR=ddorwin@chromium.org
R=ddorwin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12299015
------------------------------------------------------------------------

Comment 105 by bugdroid1@chromium.org, Feb 19 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=183161

------------------------------------------------------------------------
r183161 | jschuh@chromium.org | 2013-02-19T05:22:57.127374Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/cloud_print/service/service.gyp?r1=183161&r2=183160&pathrev=183161

Make cloud_print service build on Win64 

Just c4267 build suppressions. 

BUG= 166496 
BUG=167187
TBR=abodenha@chromium.org
R=abodenha@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12282034
------------------------------------------------------------------------

Comment 106 by bugdroid1@chromium.org, Feb 19 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=183164

------------------------------------------------------------------------
r183164 | jschuh@chromium.org | 2013-02-19T05:24:13.621841Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/tools/imagediff/image_diff.cc?r1=183164&r2=183163&pathrev=183164

Make imagediff build on Win64 

Just fix an implicit conversion.

BUG= 166496 

Review URL: https://chromiumcodereview.appspot.com/12296017
------------------------------------------------------------------------

Comment 107 by bugdroid1@chromium.org, Feb 19 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=183224

------------------------------------------------------------------------
r183224 | jschuh@chromium.org | 2013-02-19T16:02:05.877173Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/app_list/app_list.gyp?r1=183224&r2=183223&pathrev=183224

Make app_list tests build on Win64 

Just c4267 build suppressions. 

BUG= 166496 
BUG=167187
TBR=benwells@chromium.org
R=benwells@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12303024
------------------------------------------------------------------------

Comment 108 by bugdroid1@chromium.org, Feb 20 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=183413

------------------------------------------------------------------------
r183413 | jschuh@chromium.org | 2013-02-20T05:01:52.106077Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/media.gyp?r1=183413&r2=183412&pathrev=183413
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/tools/shader_bench/window_win.cc?r1=183413&r2=183412&pathrev=183413

Make all media tests build on Win64 

Trivial compile fixes and c4267 warning suppressions. 

BUG= 166496 
BUG=167187
BUG= 176178 
R=scherkus@chromium.org
Review URL: https://codereview.chromium.org/12300013
------------------------------------------------------------------------

Comment 109 by bugdroid1@chromium.org, Feb 20 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=183414

------------------------------------------------------------------------
r183414 | jschuh@chromium.org | 2013-02-20T05:03:54.122538Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_shell.gypi?r1=183414&r2=183413&pathrev=183414
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/webwidget_host_win.cc?r1=183414&r2=183413&pathrev=183414

Make test_shell build on Win64

Disable c4267 warning and fix a broken call site due to a deprecated function.

BUG= 166496 
BUG=167187
Review URL: https://codereview.chromium.org/12296004
------------------------------------------------------------------------

Comment 110 by bugdroid1@chromium.org, Feb 20 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=183415

------------------------------------------------------------------------
r183415 | jschuh@chromium.org | 2013-02-20T05:05:11.454101Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/ui_controls_internal_win.cc?r1=183415&r2=183414&pathrev=183415

Fix mismatched prototype in InputDispatcher constructor

Minor bug, but it breaks the Win64 compile because a
WPARAM is not a UINT in 64-bit.

BUG= 166496 
R=jcivelli@chromium.org
Review URL: https://codereview.chromium.org/12294029
------------------------------------------------------------------------

Comment 111 by bugdroid1@chromium.org, Feb 20 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=183470

------------------------------------------------------------------------
r183470 | jschuh@chromium.org | 2013-02-20T11:16:22.936086Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/all.gyp?r1=183470&r2=183469&pathrev=183470

Disable memory_watcher on Win64 build

This uses inline assembler, which isn't suppported on 64-bit msvc.
So, disabling it for now.

BUG= 176877 , 166496 
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/12317006
------------------------------------------------------------------------

Comment 112 by bugdroid1@chromium.org, Feb 20 2013

Project Member
Labels: merge-merged-1418
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=183519

------------------------------------------------------------------------
r183519 | karen@chromium.org | 2013-02-20T14:03:48.587801Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1418/src/webkit/tools/test_shell/test_shell.gypi?r1=183519&r2=183518&pathrev=183519
   M http://src.chromium.org/viewvc/chrome/branches/1418/src/webkit/tools/test_shell/webwidget_host_win.cc?r1=183519&r2=183518&pathrev=183519

Revert 183414
> Make test_shell build on Win64
> 
> Disable c4267 warning and fix a broken call site due to a deprecated function.
> 
> BUG= 166496 
> BUG=167187
> Review URL: https://codereview.chromium.org/12296004

TBR=jschuh@chromium.org
Review URL: https://codereview.chromium.org/12328007
------------------------------------------------------------------------

Comment 113 by bugdroid1@chromium.org, Feb 21 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=183908

------------------------------------------------------------------------
r183908 | wfh@chromium.org | 2013-02-21T23:54:50.791523Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/allocator/allocator.gyp?r1=183908&r2=183907&pathrev=183908
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/allocator/prep_libc.py?r1=183908&r2=183907&pathrev=183908

fixes to pre_libc.py script to correctly strip x64
object files from libcmt during 64bit build


BUG= 166496 


Review URL: https://chromiumcodereview.appspot.com/12303010
------------------------------------------------------------------------

Comment 114 by bugdroid1@chromium.org, Feb 26 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=184500

------------------------------------------------------------------------
r184500 | jschuh@chromium.org | 2013-02-25T22:28:18.229157Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/mini_installer.gyp?r1=184500&r2=184499&pathrev=184500

Fix Win64 build breakage in installer

Just c4267 build suppression for a warning that just popped up.

BUG= 166496 
BUG=167187

TBR=grt@chroium.org
R=grt@chroium.org
Review URL: https://codereview.chromium.org/12321120
------------------------------------------------------------------------

Comment 115 by bugdroid1@chromium.org, Feb 27 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=184872

------------------------------------------------------------------------
r184872 | wfh@chromium.org | 2013-02-27T04:27:21.298947Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/mini_installer.gypi?r1=184872&r2=184871&pathrev=184872
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/mini_installer.gyp?r1=184872&r2=184871&pathrev=184872
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/build/win/create_installer_archive.py?r1=184872&r2=184871&pathrev=184872

Fix create_installer_archive.py to correctly determine
the debug/release mode regardless of x86/x64 platform
and also pick up the right CRT DLLs

BUG= 166496 


Review URL: https://chromiumcodereview.appspot.com/12326117
------------------------------------------------------------------------

Comment 116 by jsc...@chromium.org, Mar 3 2013

Status: Fixed
Fixed for all supported build types. Anything from here on is a regression fix.

Comment 117 by bugdroid1@chromium.org, Mar 10 2013

Project Member
Labels: -Area-Internals Cr-Internals
Showing comments 18 - 117 of 117 Older

Sign in to add a comment