New issue
Advanced search Search tips
Starred by 7 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

Cannot submit comments on facebook posts or pictures

Project Member Reported by aska...@chromium.org, Dec 14 2012 Back to list

Issue description

Application Version (from "Chrome Settings > About Chrome"): 25.0.1359.1 
Android Build Number (from "Android Settings > About Phone/Tablet"): JDP73/ JOP40C
Device: Nexus 10/ Nexus7

Steps to reproduce: 
1. Launch chrome
2. Navigate to facebook.com and sign in
3. Go to any post or picture -> tab on comment
4. Enter text in the text box and press 'Return' key on keypad to submit the comment

Observed behavior: 
Comment cannot be submitted. User is instead retured to a new line.

Expected behavior: 
Comment should be submitted on tapping the 'Return' key

Frequency: 
100% 


 
m.facebook.com - has 'Comment' button so no issues on mobile site

www.facebook.com - doesn't have 'Comment' button. It affects Nexus 10 and Nexus 7 whenever the desktop site is served. And there is no workaround.
Labels: -Pri-3 Pri-2 Type-Bug Feature-TextInput Mstone-25
Owner: aurimas@chromium.org
Status: Assigned
Labels: ReleaseBlock-Stable
Labels: Area-WebKit
Cc: aurimas@chromium.org
Owner: yus...@chromium.org
Status: Started
I will take a look at this one

Comment 7 by k...@google.com, Jan 10 2013

Labels: -Restrict-View-Google Restrict-AddIssueComment-Commit

Comment 8 by k...@google.com, Jan 14 2013

Labels: -Restrict-AddIssueComment-Commit
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 18 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=177774

------------------------------------------------------------------------
r177774 | yusufo@chromium.org | 2013-01-18T22:22:31.659927Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java?r1=177774&r2=177773&pathrev=177774
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java?r1=177774&r2=177773&pathrev=177774

Start sending synthetic keyevents for enter and tab in Android IME

After sdk 15 Android framework no longer sends keyevents for enter and tab
and the current spec says the dispatchKeyEvent call should only be used for
hardware keyboard. So we stop calling ImeAdapter with dispathKeyEvent if the
keyboard is not connected and also start sending these keyevents when a
they are committed as a single character

BUG= 166233 


Review URL: https://chromiumcodereview.appspot.com/11914003
------------------------------------------------------------------------
Labels: Merge-Requested

Comment 12 by k...@google.com, Jan 22 2013

Labels: -Merge-Requested Merge-Approved
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 22 2013

Labels: -Merge-Approved merge-merged-1364
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=178090

------------------------------------------------------------------------
r178090 | yusufo@google.com | 2013-01-22T21:04:29.777879Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1364/src/content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java?r1=178090&r2=178089&pathrev=178090
   M http://src.chromium.org/viewvc/chrome/branches/1364/src/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java?r1=178090&r2=178089&pathrev=178090

Merge 177774
> Start sending synthetic keyevents for enter and tab in Android IME
> 
> After sdk 15 Android framework no longer sends keyevents for enter and tab
> and the current spec says the dispatchKeyEvent call should only be used for
> hardware keyboard. So we stop calling ImeAdapter with dispathKeyEvent if the
> keyboard is not connected and also start sending these keyevents when a
> they are committed as a single character
> 
> BUG= 166233 
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/11914003

TBR=yusufo@chromium.org
Review URL: https://codereview.chromium.org/12045030
------------------------------------------------------------------------
Status: Fixed
Labels: Merge-Merged
Status: Verified
----Verification Attempt--
App Version(Help->About): 25.0.1364.45 
Phone Make/Model/Revision: Nexus 7
Skylab ID: SKYUKPSO0895
Network: WiFi 
OS version: JDQ18
Related test case: 19570236 Facebook Comments 

Steps Performed To Verify Fix: 
1. Launch chrome
2. Navigate to facebook.com and sign in
3. Go to any post or picture -> tab on comment
4. Enter text in the text box and press 'Return' key on keypad to submit the comment

Verification Succeeded (yes/no): Yes. Comment entered. 
Project Member

Comment 17 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Feature-TextInput -Mstone-25 -Area-WebKit Cr-Content M-25 Cr-UI-Input-Text-IME
Project Member

Comment 18 by bugdroid1@chromium.org, Apr 5 2013

Labels: -Cr-Content Cr-Blink
http://www.lindajerseys.com is an professional cheap china jerseys online website,wholesale all kinds soccer jerseys china cheap,NFL jerseys wholesale online,cheap ncaa jerseys on sale,Nike NFL jerseys,All our jerseys are embroidered and high quality ones,overnight deliver,Accept paypal. Welcome to choose.
http://www.lindajerseys.com/NBA-Jerseys-c77/ cheap NBA Jerseys
http://www.lindajerseys.com/MLB-Jerseys-c94/ MLB Jerseys china
http://www.lindajerseys.com/NCAA-Jerseys-c118/ Wholesale NCAA Jerseys cheap

Comment 20 by Deleted ...@, Jul 5 2013

<a href=" http://www.cheapjerseyfactory.com/"> 2012 Super Bowl XLVI Jersey
</a> 
<a href=" http://www.cheapjerseyfactory.com/">Women jerseys </a> 
<a href=" http://www.cheapjerseyfactory.com/"> 2013 Nike Pro Bowl Jerseys </a> wholesale nba jerseys, nba jersey cheap

Labels: Restrict-AddIssueComment-Commit

Sign in to add a comment