New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 165873 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

"first" double click doesn't work correct with "Enable Views Textfield" flag

Reported by geki...@gmail.com, Dec 13 2012

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.21 (KHTML, like Gecko) Chrome/25.0.1359.0 Safari/537.21

Steps to reproduce the problem:
1. go to about:flags and enable "Enable Views Textfield"
2. restart chrome
3. go to some page (eg: https://chromiumcodereview.appspot.com/11549004)
4. double click on the number in the url

What is the expected behavior?
should mark the number

What went wrong?
marks https

Did this work before? N/A 

Chrome version: 25.0.1359.0  Channel: n/a
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)

tested with r172826

i works correct without the flag
i works correct if i make a "normal" left click in the omnibox and than the double click
 

Comment 1 by msw@chromium.org, Mar 6 2013

Labels: Feature-TextInput Feature-Omnibox
Owner: msw@chromium.org
Status: Assigned
Thanks for the report, I'll take a look soon.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Feature-TextInput -Feature-Omnibox Cr-UI Cr-UI-Browser-Omnibox Cr-UI-Input-Text-IME
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 12 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=187643

------------------------------------------------------------------------
r187643 | msw@chromium.org | 2013-03-12T20:53:19.091904Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/controls/textfield/native_textfield_views.cc?r1=187643&r2=187642&pathrev=187643

Fix views omnibox unfocused double-click behavior.

Move the cursor to the double-click event location before selecting the surrounding word.
This fixes double-click behavior when the views omnibox is unfocused.
( unfocused mouse-up on the first click selects all, changing the cursor position )

BUG= 131660 , 165873 
TEST=double-clicking the unfocused omnibox selects the expected word.
R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12408023
------------------------------------------------------------------------

Comment 4 by msw@chromium.org, Mar 12 2013

Labels: M-26
Status: Started
This should be fixed in the next Canary.
Please help verify for merging to M26!
Cc: ligim...@chromium.org
Labels: Merge-Requested
Ligi, could you please assign someone to verify this bug in tomorrow's canary? thank you!
Cc: manoranj...@chromium.org nyerramilli@chromium.org
Please verify this issue.
Able to repro the issue on Latest 27.0.1438.4 canary on Win 7.

Followed the below steps to repro the issue -

1. go to about:flags and enable "Enable Views Textfield"
2. restart chrome
3. go to some page (eg: https://chromiumcodereview.appspot.com/11549004)
4. double click on the number in the url - Marking 'https'

Comment 8 by msw@chromium.org, Mar 13 2013

Indeed, the latest canary, 27.0.1438.7, was cut at r187506, before my fix: http://crrev.com/187643
We'll have to wait for the next Canary to verify the fix. 
Able to repro the issue on Latest Chrome canary 27.0.1438.7 on Win 7

Followed the below steps to repro the issue -

1. go to about:flags and enable "Enable Views Textfield"
2. restart chrome
3. go to some page (eg: https://chromiumcodereview.appspot.com/11549004)
4. double click on the number in the url - Marking 'https'

Please find the about:version details below ---

Google Chrome	27.0.1438.7 (Official Build 187670) canary
OS	Windows 
WebKit	537.33 (@145573)

Comment 10 by msw@chromium.org, Mar 13 2013

Correct, it still repros on canary, we'll have to wait for the next release to verify my fix: http://crrev.com/187643
Current canary 27.0.1438.7 was cut at r187506. See this branch file log, which shows that canary does not yet include my fix:
http://src.chromium.org/viewvc/chrome/branches/1438/src/ui/views/controls/textfield/native_textfield_views.cc?view=log

Comment 11 by geki...@gmail.com, Mar 13 2013

it works better, BUT not perfect

http://www.heise.de/newsticker/ double click on newsticker

without flag it marks "newsticker/"
with flag it marks "newsticker"

Comment 12 by msw@chromium.org, Mar 13 2013

Please file a separate issue if word breaking behavior is incorrect.
Please validate the fix with the next canary build and let us know.
Status: Verified

Comment 15 by geki...@gmail.com, Mar 13 2013

@comment #12: filled new issue 190160

Comment 16 by geki...@gmail.com, Mar 13 2013

don't know why it now says the new issue is deleted

Comment 17 by geki...@gmail.com, Mar 13 2013

@msw please tell me if i should again fill a new one

Comment 18 by msw@chromium.org, Mar 13 2013

rsaluja, how did you verify this issue? My fix still hasn't landed on Canary...
geki007, indeed, the issue appears to have been deleted, please file another.

Comment 19 by geki...@gmail.com, Mar 14 2013

@msw can you help me or fill the bug for me

with http://crbug.com/new the new bug is always be deleted ... the 2. new was Issue 193609
with the new bug wizard i always get an Error 400 page ... see  Issue 180287  ... but nobody works on the issue
Works fine on the latest Canary.

Verified on version 27.0.1440.0 (official Build # 187987) Canary
OS - Windows 7
Labels: -Merge-Requested Merge-Approved
Project Member

Comment 22 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Merge-Approved merge-merged-1410
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=188155

------------------------------------------------------------------------
r188155 | msw@chromium.org | 2013-03-14T19:21:51.461101Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/ui/views/controls/textfield/native_textfield_views.cc?r1=188155&r2=188154&pathrev=188155

Fix CrOS Beta (branch 1410) Omnibox select-all on click-to-focus.

The CrOS Beta (branch 1410) omnibox doesn't select-all on click-to-focus. 
This is the minimal fix from http://crrev.com/183239, which doesn't apply.
( unrelated parts depend on http://crrev.com/183146 and http://crrev.com/183198 )

Run applicable handlers in NativeTextfieldViews::OnMousePressed.
(textfield_->OnMousePressed wasn't being run properly due to logic error)

NOTE: Landing this CL will expose another issue on branch 1410:
 http://crbug.com/165873  - "first" double click doesn't work correct...
That will be fixed by merging http://crrev.com/187643 to branch 1410.

BUG= 181406 , 165873 , 176708 
TEST=CrOS Beta Omnibox selects-all on click-to-focus.
R=pkasting@chromium.org,sky@chromium.org
Review URL: https://codereview.chromium.org/12436011
------------------------------------------------------------------------
Project Member

Comment 23 by bugdroid1@chromium.org, Mar 14 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=188158

------------------------------------------------------------------------
r188158 | msw@chromium.org | 2013-03-14T19:26:16.856219Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/ui/views/controls/textfield/native_textfield_views.cc?r1=188158&r2=188157&pathrev=188158

Merge 187643 "Fix views omnibox unfocused double-click behavior."

> Fix views omnibox unfocused double-click behavior.
> 
> Move the cursor to the double-click event location before selecting the surrounding word.
> This fixes double-click behavior when the views omnibox is unfocused.
> ( unfocused mouse-up on the first click selects all, changing the cursor position )
> 
> BUG= 131660 , 165873 
> TEST=double-clicking the unfocused omnibox selects the expected word.
> R=sky@chromium.org
> 
> Review URL: https://chromiumcodereview.appspot.com/12408023

TBR=msw@chromium.org
Review URL: https://codereview.chromium.org/12432019
------------------------------------------------------------------------

Comment 24 by msw@chromium.org, Mar 14 2013

Status: Fixed
Please help verify that this issue and  http://crbug.com/176708  are both fixed on the next beta channel update; thanks!
Status: Verified
Tested this issue with Latest Beta#26.0.1410.40 on Win7 - Working as intended.

Thank you!

Sign in to add a comment