Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Issue 165783 Enable compositing scrollable frames on Android
Starred by 2 users Project Member Reported by wangxianzhu@chromium.org, Dec 12 2012 Back to list
Status: Verified
Owner:
Vacation until 8/16
Closed: Jan 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment
1. Add --enable-accelerated-scrollable-frames flag when starting renderer
2. Examine if frame scrolling behaves correctly.
 
Comment 1 by klo...@chromium.org, Dec 13 2012
Labels: Mstone-25 ReleaseBlock-Beta
With the switch, though iframes is composited, the scroll layer of the iframe is not set scrollable in WebKit's ScrollingCoordinator, so the compositor still uses the scroll layer of the main page and falls back to use slow scrolling according to the nonFastScrollableRegion of the main scroll layer.
Labels: WebKit-ID-104950
Project Member Comment 4 by bugdroid1@chromium.org, Dec 14 2012
Labels: -WebKit-ID-104950 WebKit-ID-104950-NEW
https://bugs.webkit.org/show_bug.cgi?id=104950
Project Member Comment 5 by bugdroid1@chromium.org, Jan 8 2013
Labels: WebKit-Rev-138991
http://trac.webkit.org/changeset/138991
Labels: WebKit-ID-106262
Project Member Comment 7 by bugdroid1@chromium.org, Jan 8 2013
Labels: -WebKit-ID-104950-NEW -WebKit-ID-106262 WebKit-ID-104950-RESOLVED WebKit-Rev-139024 WebKit-ID-106262-NEW
https://bugs.webkit.org/show_bug.cgi?id=104950
http://trac.webkit.org/changeset/139024
https://bugs.webkit.org/show_bug.cgi?id=106262
Project Member Comment 8 by bugdroid1@chromium.org, Jan 8 2013
Labels: -WebKit-ID-106262-NEW WebKit-ID-106262-RESOLVED WebKit-Rev-139028
https://bugs.webkit.org/show_bug.cgi?id=106262
http://trac.webkit.org/changeset/139028
Labels: Area-WebKit
Comment 10 by k...@google.com, Jan 8 2013
Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
Blockedon: chromium:169028
Temporarily roll out to see if it caused performance regression.
Blockedon: -chromium:169028
Project Member Comment 14 by bugdroid1@chromium.org, Jan 9 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=175917

------------------------------------------------------------------------
r175917 | wangxianzhu@chromium.org | 2013-01-09T23:19:08.619672Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webpreferences.cc?r1=175917&r2=175916&pathrev=175917
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_impl.cc?r1=175917&r2=175916&pathrev=175917
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webpreferences.h?r1=175917&r2=175916&pathrev=175917
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/content_switches.cc?r1=175917&r2=175916&pathrev=175917
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/common_param_traits_macros.h?r1=175917&r2=175916&pathrev=175917
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/android/content_startup_flags.cc?r1=175917&r2=175916&pathrev=175917
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/content_switches.h?r1=175917&r2=175916&pathrev=175917

Reapply "Add a switch to enable composited scrolling for frames and enable it on Android"

Verified that  crbug.com/169028  is not caused by this change. Reapply it.

This reverts commit 9acaad1441f150c9ef8206c28a3c2bfda13634f5 which reverted 4c3f35e33ee2656ae567b9aef3df03a653f57d35.

TBR=darin
BUG= 165783 , 169028 

Review URL: https://codereview.chromium.org/11818039
------------------------------------------------------------------------
Labels: Merge-Requested
Status: Fixed
Will do the merge together with  bug 146075 .
Labels: -Merge-Requested Merge-Approved
 bug 146075  is approved so is this :) 
Comment 17 by k...@google.com, Jan 11 2013
Status: Started
Comment 18 by k...@google.com, Jan 14 2013
How long until this is ready to merge?
 Bug 167201  which is blocking  bug 146075  seems not affecting this bug. So this bug is ready to merge. Will merge on Monday.
Labels: WebKit-ID-104272
Add other prerequisites of the bug. 
Also need this:

Add accelerated_compositing_for_scrollable_frames_enabled field in WebPreferences IPC

The field was added in WebPreferences in https://codereview.chromium.org/11543002/.
Now declare it for IPC.

BUG=none


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173819

Project Member Comment 22 by bugdroid1@chromium.org, Jan 14 2013
Labels: -WebKit-ID-104272 WebKit-ID-104272-RESOLVED WebKit-Rev-136861
https://bugs.webkit.org/show_bug.cgi?id=104272
http://trac.webkit.org/changeset/136861
Project Member Comment 23 by bugdroid1@chromium.org, Jan 14 2013
Labels: -Merge-Approved merge-merged-1364
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=176706

------------------------------------------------------------------------
r176706 | wangxianzhu@chromium.org | 2013-01-14T20:25:52.921828Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1364/src/webkit/glue/webpreferences.cc?r1=176706&r2=176705&pathrev=176706
   M http://src.chromium.org/viewvc/chrome/branches/1364/src/content/browser/web_contents/web_contents_impl.cc?r1=176706&r2=176705&pathrev=176706
   M http://src.chromium.org/viewvc/chrome/branches/1364/src/webkit/glue/webpreferences.h?r1=176706&r2=176705&pathrev=176706
   M http://src.chromium.org/viewvc/chrome/branches/1364/src/content/public/common/content_switches.cc?r1=176706&r2=176705&pathrev=176706
   M http://src.chromium.org/viewvc/chrome/branches/1364/src/content/browser/android/content_startup_flags.cc?r1=176706&r2=176705&pathrev=176706
   M http://src.chromium.org/viewvc/chrome/branches/1364/src/content/common/view_messages.h?r1=176706&r2=176705&pathrev=176706
   M http://src.chromium.org/viewvc/chrome/branches/1364/src/content/public/common/content_switches.h?r1=176706&r2=176705&pathrev=176706

Merge 175917
> Reapply "Add a switch to enable composited scrolling for frames and enable it on Android"
> 
> Verified that  crbug.com/169028  is not caused by this change. Reapply it.
> 
> This reverts commit 9acaad1441f150c9ef8206c28a3c2bfda13634f5 which reverted 4c3f35e33ee2656ae567b9aef3df03a653f57d35.
> 
> TBR=darin
> BUG= 165783 , 169028 
> 
> Review URL: https://codereview.chromium.org/11818039

TBR=wangxianzhu@chromium.org
Review URL: https://codereview.chromium.org/11878026
------------------------------------------------------------------------
Status: Fixed
Labels: Merge-Merged
Labels: -Restrict-View-Google
Status: Verified
Verified with 25.0.1364.36 on Galaxy Nexus and Nexus 10.

iframe scrolling working fine.
Thanks!
Project Member Comment 28 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Mstone-25 -Area-WebKit Cr-Content M-25
Project Member Comment 29 by bugdroid1@chromium.org, Apr 5 2013
Labels: -Cr-Content Cr-Blink
Sign in to add a comment