New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 161246 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Email to this user bounced
Closed: Nov 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Fullscreen disabled when launched with --app arg

Reported by toxmeis...@gmail.com, Nov 15 2012

Issue description

Chrome Version       : 24.0.1312.14
OS Version: OS X 10.7.5
URLs (if applicable) :

What steps will reproduce the problem?
1. launch chrome from terminal:

exec /Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome --app="http://google.com"

2. Press Cmd+Shift+F

What is the expected result?

The browser should go into fullscreen mode

What happens instead of that?

The keyboard shortcut is ignored and fullscreen menu items are disabled. This means that an SSB built using Chrome cannot be run as fullscreen app anymore, something which worked until this beta has been pushed out...

I believe the culprit has to do w/ r167006 -> http://is.gd/wjmmgm

Please provide any additional information below. Attach a screenshot if
possible.

FWIW The entire Google Chrome Web Lab exhibition is making use of such SSBs and the only current workaround seems to be to stick with v23 and disable auto-updates...

 

Comment 1 by meh...@chromium.org, Nov 15 2012

Cc: rsesek@chromium.org
Labels: -Area-Undefined Area-Internals Feature-FullScreen
Can't confirm on SnowLeopard. Maybe a 10.7+ issue ?

Comment 2 by rsesek@chromium.org, Nov 15 2012

Cc: jeremya@chromium.org
Labels: Feature-Apps-OSIntegration

Comment 3 by yoz@chromium.org, Nov 15 2012

Cc: sail@chromium.org
Labels: -Area-Internals Area-UI
c#1: this seems related to 10.7's fullscreen mode, yes.

Comment 4 by mbollu@chromium.org, Nov 16 2012

Labels: -Type-Bug Type-Regression Mstone-24 ReleaseBlock-Stable
Status: Untriaged
Reproducible on 24.0.1312.14. Unable to reproduce it on 23.0.1271.64 stable. for Mac 10.8.2. I will update bisect info.

Comment 5 by yoz@chromium.org, Nov 16 2012

Status: Available
mbollu: did you see the comment that it's likely related to r167006?

Comment 6 by dharani@google.com, Nov 16 2012

Labels: -Pri-2 Pri-1
Owner: sail@chromium.org
Status: Assigned

Comment 7 by sail@chromium.org, Nov 16 2012

Hi  dharani and mbollu. Did you see lforge's email about Release Blockers? Is this bug consistent with that?

Comment 8 by dharani@google.com, Nov 17 2012

Since this regression happened due to the recent merge, we don't want it to get it through stable. Also this is a new feature that getting promoted to M24 and it makes sense to keep this blocker label.

Comment 9 by sail@chromium.org, Nov 17 2012

I don't think I understand.

If a user can't fullscreen a window they opened by using a command line switch, you would block the release?

Comment 10 by dharani@google.com, Nov 17 2012

Labels: -ReleaseBlock-Stable
Removed the release blocker label. Since it regressed in 1312.14, it should either be reverted or fixed by next beta build.
Cc: mbollu@chromium.org

Comment 12 by sail@chromium.org, Nov 17 2012

Status: Started
https://codereview.chromium.org/11308085/
Labels: Action-BisectNeeded
Cc: msrchandra@chromium.org nyerramilli@chromium.org
Labels: -Action-BisectNeeded
Hello,
This is a Regression in M24.
Please find the Bisect Info below:
Chrome Builds:
Last Good Build: 24.0.1312.8 (Official Build 166843) beta.
First Bad Build : 24.0.1312.9 (Official Build 167035) beta.
Bisect Info is not possible between the above two mentioned Versions using Bisect Tool as Chromium has to be launched using Terminal.

Bisect Information has been provided by installing the Chromium builds manually and launching them through Terminal.
Change Log URL: http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/branches/1312/src&range=166843:167035&mode=html (Provided Manually).

I am suspecting the version "167006" is the culprit as I am seeing the issue in above change log URL.

Please let me know if any more information is required.


Thanks,
Ravi.

Comment 15 by yoz@chromium.org, Nov 19 2012

 Issue 161750  has been merged into this issue.
Project Member

Comment 16 by bugdroid1@chromium.org, Nov 20 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=168694

------------------------------------------------------------------------
r168694 | sail@chromium.org | 2012-11-20T01:56:53.745530Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.h?r1=168694&r2=168693&pathrev=168694
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_command_controller_unittest.cc?r1=168694&r2=168693&pathrev=168694
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_command_controller.cc?r1=168694&r2=168693&pathrev=168694

Enable fullscreen for apps windows

This CL allows apps windows to enter fullscreen on all platforms.

This fixes a regression introduced by r167006.

BUG= 161246 


Review URL: https://chromiumcodereview.appspot.com/11308085
------------------------------------------------------------------------

Comment 17 by sail@chromium.org, Nov 20 2012

Labels: Merge-Requested
Verified that this is fixed in Canary (25.0.1330.0). Merge requested.
Tested on 25.0.1331.0 (Official Build 168995) canary. Cmd+Shift+F makes browser Fullscreen. Fix works as expected. QA is signing off this fix to be merged to M24.

Comment 19 by dharani@google.com, Nov 21 2012

Labels: -Merge-Requested Merge-Approved
Project Member

Comment 20 by bugdroid1@chromium.org, Nov 21 2012

Labels: -Merge-Approved merge-merged-1312
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=169107

------------------------------------------------------------------------
r169107 | sail@chromium.org | 2012-11-21T20:00:12.632671Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/ui/browser_command_controller_unittest.cc?r1=169107&r2=169106&pathrev=169107
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/ui/browser_command_controller.cc?r1=169107&r2=169106&pathrev=169107
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/ui/browser.h?r1=169107&r2=169106&pathrev=169107

Merge 168694 - Enable fullscreen for apps windows

This CL allows apps windows to enter fullscreen on all platforms.

This fixes a regression introduced by r167006.

BUG= 161246 


Review URL: https://chromiumcodereview.appspot.com/11308085

TBR=sail@chromium.org
Review URL: https://codereview.chromium.org/11411132
------------------------------------------------------------------------

Comment 21 by sail@chromium.org, Nov 21 2012

Status: Fixed
Status: Verified
Confirmed that the fix works in 24.0.1312.25 (Official Build 169562)
Project Member

Comment 24 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Area-UI -Type-Regression -Feature-FullScreen -Feature-Apps-OSIntegration -Mstone-24 Type-Bug-Regression Cr-Platform-Apps-OSIntegration M-24 Cr-UI Cr-UI-Browser-FullScreen

Sign in to add a comment