New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 16 days ago
Closed: Nov 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment
link

Issue 160830: Print preview page hardcodes a font-family to use

Reported by js...@chromium.org, Nov 13 2012 Project Member

Issue description

In https://chromiumcodereview.appspot.com/11359020,   the print preview was turned to use a webkit and the html file for that uses a hardcode font-family, "sans". 

At minimum, it has to be 'sans-serif' (a CSS generic font family we use for the UI). 

Better would be to use IDS_WEB_FONT_FAMILY instead of hard-coding the family.
 

Comment 1 by vitalyb...@chromium.org, Nov 13 2012

Status: Started
I can change to sans-serif, 11359020 just copied that was before there.
Still not sure about IDS_WEB_FONT_FAMILY, it may break layout if font is different.

Comment 2 by bugdroid1@chromium.org, Nov 14 2012

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=167608

------------------------------------------------------------------------
r167608 | vitalybuka@chromium.org | 2012-11-14T05:32:01.221628Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/print_preview/print_preview_page.html?r1=167608&r2=167607&pathrev=167608

Use 'sans-serif' instead of 'sans' to print headers and footers.

BUG= 160830 ,  152893 


Review URL: https://chromiumcodereview.appspot.com/11275302
------------------------------------------------------------------------

Comment 3 by vitalyb...@chromium.org, Nov 14 2012

Status: Fixed

Comment 4 by bugdroid1@chromium.org, Nov 17 2012

Project Member
Labels: merge-merged-1312
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=168380

------------------------------------------------------------------------
r168380 | vitalybuka@chromium.org | 2012-11-17T04:45:12.689359Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/resources/print_preview/print_preview_page.html?r1=168380&r2=168379&pathrev=168380

Merge 167608 - Use 'sans-serif' instead of 'sans' to print headers and footers.

BUG= 160830 ,  152893 


Review URL: https://chromiumcodereview.appspot.com/11275302

TBR=vitalybuka@chromium.org
Review URL: https://codereview.chromium.org/11348114
------------------------------------------------------------------------

Comment 5 by bugdroid1@chromium.org, Mar 10 2013

Project Member
Labels: -Area-UI -Feature-I18N Cr-UI-I18N Cr-UI

Comment 6 by bugdroid1@chromium.org, Mar 20 2013

Project Member
Labels: -Cr-UI-I18N Cr-UI-Internationalization

Sign in to add a comment