New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 160069 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Extension icons don't show numbers

Reported by wize...@wizy.org, Nov 8 2012

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.11 (KHTML, like Gecko) Chrome/23.0.1271.64 Safari/537.11

Steps to reproduce the problem:
1. Install an extension such as "Mt. Gox Peek" or "Gold & Silver price"

What is the expected behavior?
Extension should show number / price on its icon.

What went wrong?
It does not show any number / price.

Did this work before? Yes Google Chrome 22

Chrome version: 23.0.1271.64  Channel: stable
OS Version: Ubuntu 12.04

The extensions / icons work fine on Windows.
 
Cc: rponnada@chromium.org
Status: Untriaged
Issue is existing only in Linux.

I am able to repro this issue on Linux Ubuntu 10.4 & Chrome 23.0.1271.64 (Official Build 165188) & Current Dev 24.0.1312.5

It is working fine in Prev Stable build 22.0.1229.94 (Official Build 161065)



Screenshot-- M23--Google Chrome.png
183 KB View Download
Labels: -Type-Bug Type-Regression
Bisect Info::

Good Build:
23.0.1234.1 (Official Build 151277)
Bad Build:
23.0.1235.0 (Official Build 151635)

You are probably looking for a change made after 151398 (known good), but no later than 151399 (first known bad).
CHANGELOG URL:
  http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&range=151398%3A151399

Thanks!!
Labels: Mstone-23 Feature-Extensions
Cc: tbarzic@chromium.org
Labels: -Pri-2 Pri-1 ReleaseBlock-Stable
Suspecting :151399
Cc: -tbarzic@chromium.org
Owner: tbarzic@chromium.org
Status: Started

Comment 6 by kareng@google.com, Nov 9 2012

can we revert that CL if needed?
not really, but fix is really small: https://codereview.chromium.org/11364185/
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 10 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=167018

------------------------------------------------------------------------
r167018 | tbarzic@chromium.org | 2012-11-10T00:23:07.614189Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_action.cc?r1=167018&r2=167017&pathrev=167018

Fix extension action badges with long text.

BUG= 160069 
TEST=manual

Review URL: https://codereview.chromium.org/11364185
------------------------------------------------------------------------

Comment 9 by kareng@google.com, Nov 12 2012

can u confirm this works in canary and has no crashes?

Comment 10 by kareng@google.com, Nov 12 2012

that's assuming it's not linux only.
It is linux only. I suppose M23 ship has sailed for this one?

Comment 12 by kareng@google.com, Nov 12 2012

Labels: Merge-Requested
Works fine : 25.0.1323.1 (Official Build 167142) 
couldn't find anything suspicious on crash server.. 

Comment 15 by kareng@google.com, Nov 13 2012

Labels: -Merge-Requested Merge-Approved
Project Member

Comment 16 by bugdroid1@chromium.org, Nov 13 2012

Labels: -Merge-Approved merge-merged-1271
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=167480

------------------------------------------------------------------------
r167480 | tbarzic@chromium.org | 2012-11-13T21:49:30.356846Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1271/src/chrome/common/extensions/extension_action.cc?r1=167480&r2=167479&pathrev=167480

Merge 167018 - Fix extension action badges with long text.

BUG= 160069 
TEST=manual

Review URL: https://codereview.chromium.org/11364185

TBR=tbarzic@chromium.org
Review URL: https://codereview.chromium.org/11275294
------------------------------------------------------------------------

Comment 17 by kareng@google.com, Nov 13 2012

Status: Fixed
Cc: manoranj...@chromium.org
Status: Verified
Verified this issue on Latest Stable#23.0.1271.91 and Latest Dev#25.0.1323.1 - Working as intended ("Gold & Silver price" Extension is showing the numbers).

Thanks,
Mano
Labels: -Mstone-23 Mstone-24 Merge-Requested
Status: Started
we probably want to merge to M24 too :)

Comment 20 by dharani@google.com, Nov 16 2012

Labels: -Merge-Requested Merge-Approved
Project Member

Comment 21 by bugdroid1@chromium.org, Nov 19 2012

Labels: -Merge-Approved merge-merged-1312
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=168587

------------------------------------------------------------------------
r168587 | tbarzic@chromium.org | 2012-11-19T20:22:17.768867Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/extensions/extension_action.cc?r1=168587&r2=168586&pathrev=168587

Merge 167018 - Fix extension action badges with long text.

BUG= 160069 
TEST=manual

Review URL: https://codereview.chromium.org/11364185

TBR=tbarzic@chromium.org
Review URL: https://codereview.chromium.org/11417068
------------------------------------------------------------------------
Status: Fixed
Verified the issue on 24.0.1312.23 (Official Build 168956) beta & 25.0.1330.0 (Official Build 168752) dev. Extensions are showing the numbers properly. 

Please find the attached screen shot

Need to verify on Stable channel, once the revision meets the criteria. 

Thanks!!
Screenshot-Chrome Web Store - Mt. Gox Peek - Google Chrome Dev.png
75.5 KB View Download

Comment 24 Deleted

Comment 25 by wize...@wizy.org, Nov 22 2012

makella: which OS are you using? The issue is only reproducible on Linux.

Stable channel build 23.0.1271.64 is not working for me.
Verified on Latest Dev Build # 25.0.1323.1 working as intended.
For Latest Beta # 24.0.1312.14 and Stable # 23.0.1271.64 builds the issue still exists using Linux LTS 10.04 OS

Comment 27 by wize...@wizy.org, Nov 27 2012

The fix seems to have worked for me on stable channel build 23.0.1271.91.
The numbers show up properly now.

Thanks!
Confirmed that it works fine in Beta - 24.0.1312.25
Project Member

Comment 29 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Area-UI -Type-Regression -Mstone-24 -Feature-Extensions Type-Bug-Regression Cr-Platform-Extensions Cr-UI M-24
Labels: hasTestcase

Sign in to add a comment