Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 159902 Print preview is not working in Windows 8 mode of chrome
Starred by 11 users Project Member Reported by pbomm...@chromium.org, Nov 7 2012 Back to list
Status: Verified
Owner: bauerb@chromium.org
Closed: Dec 2012
Cc: ibra...@gmail.com, cpu@chromium.org, jam@chromium.org, fsam...@chromium.org, gideonwald@chromium.org, mad@chromium.org, pbomm...@chromium.org, bauerb@chromium.org, mbollu@chromium.org
Components:
OS: Windows
Pri: 2
Type: Bug-Regression


Sign in to add a comment
Version: 24.0.1312.5
OS: Win8

What steps will reproduce the problem?
1. Install Chrome and launch in windows 8 mode 
2. Open any webpage and try to do an print preview


What is the expected output?
Print preview of the page should be shown

What do you see instead?
Unable to see the print preview and saw the message "Google Chrome Cannot show the print preview when the built-in PDF viewer is missing". 
Is this the expected behavior are we suppose to show the Infobar to relaunch for print preview.





 
Cc: mad@chromium.org
Hummm. MAD, what's up with this one, since you worked on printing in Metro?
Comment 2 by mad@chromium.org, Nov 8 2012
Yeah, I didn't think about that... We would need to redirect the user to OS print dialog which opens the charm and show the (ugly) preview there...
Ah, I see. How bad is this bug? How can a user trigger a print preview?

Aren't we supposed to have Pepper PDF viewer bundled with Metro Chrome?
Owner: vitalyb...@chromium.org
Status: Unconfirmed
Vitaly, could you repro?
Labels: ReleaseBlock-Stable
pbommana@ Can you clarify what is "Install Chrome and launch in windows 8 mode"?
Cc: pbomm...@chromium.org
Comment 8 by mad@chromium.org, Nov 9 2012
I thought he meant running Chrome in Metro mode, but I couldn't reproduce it there, I thought I blocked all the access to print preview from metro... Maybe I missed an entry point?
Windows 8 mode aka Metro mode of chrome.
Prudhvi, how did you invoke print preview in Metro mode?
Through keyboard shortcut "Ctrl+P"
pbommana@ How to run Chrome in metro mode? I see only desktop Chrome if I use normal installer.
vit, make Chrome your default browser on Windows 8 and then choose Relaunch Chrome in Windows 8 mode from the Chrome menu.
Navigate to Wrench--> Relaunch Chrome in Windows 8 mode(If chrome is Default browser it would be launched straight away, If not system dialog will be seen to make chrome as default)
This can be reproduced with short cut key(CTRL+P) and wrench --> Print.
Status: Assigned
Thanks. Reproduced. It's not clear yet why it does not work. PDF plugin seems working in metro mode. 

As quick fix we can disable preview and use system dialog (Ctrl+Shit+P).

Comment 16 by mad@chromium.org, Nov 9 2012
It's working for Stable/Beta? Why did it stop working in M24?

And sorry about my comment for the entry point, I remember now that this is when PDF is not installed, we go straight to OS printing which brings up the charm... And I was testing with Tip of tree without PDF...

Labels: -Type-Bug Type-Regression
Here is the Bisect:

Good build : 24.0.1308.0
Broken Build : 24.0.1309.0

Change log : http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&range=164268:164521&mode=html
Labels: Feature-Plugins Feature-Plugins-Pepper
Interestingly enough, the plug-in *is* available in working for regular PDFs in Metro mode, but when we try to load it in print preview, some of the custom methods on the plug-in object seem to be missing (see http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/browser/resources/print_preview/previewarea/preview_area.js&exact_package=chromium&type=cs&l=325)
If we have no ideas, I'll try bisect to particular CL next week.

BTW. I have installed canary and see "Run in Windows8 Mode in menu", but it does nothing. Is this expected?
Unfortunately yes :/. Canary can't be set as your default browser, and browsers have to be default to run in Metro. We could remove the option just for Canary, but haven't gotten around to it yet.
Cc: vitalyb...@chromium.org jam@chromium.org
Owner: bauerb@chromium.org
Argh, I think I know what's happening here. We override the plug-in for print preview so that it's always enabled (http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/browser/printing/print_preview_tab_controller.cc&exact_package=chromium&l=62), but we override it with a WebPluginInfo that claims to be NPAPI, and NPAPI is not supported in Metro mode.
That's part of it, but the most recent change that triggered this was https://chromiumcodereview.appspot.com/11066043.
Project Member Comment 25 by bugdroid1@chromium.org, Nov 14 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=167524

------------------------------------------------------------------------
r167524 | wez@chromium.org | 2012-11-14T00:29:11.455779Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/browser_with_test_window_test.h?r1=167524&r2=167523&pathrev=167524
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc?r1=167524&r2=167523&pathrev=167524
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller_unittest.cc?r1=167524&r2=167523&pathrev=167524
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller.cc?r1=167524&r2=167523&pathrev=167524

Revert 167487 - Get full WebPluginInfo for the PDF plug-in before enabling it for print preview.

This CL coincided with the DuplicateTab test starting to fail due to a prior
test failing to unregister a window class; the addition of the AtExitManager
could potentially be the cause.  See crbug.com/160862.

BUG= 159902 

Review URL: https://chromiumcodereview.appspot.com/11364202

TBR=bauerb@chromium.org
Review URL: https://codereview.chromium.org/11312223
------------------------------------------------------------------------
Issue 160042 has been merged into this issue.
Cc: ibra...@gmail.com fsam...@chromium.org
Issue 160128 has been merged into this issue.
Cc: mbollu@chromium.org
Issue 158192 has been merged into this issue.
Issue 160923 has been merged into this issue.
Comment 30 by dharani@google.com, Nov 20 2012
bauerb: will the change be landing again soon?
Comment 31 by dharani@google.com, Nov 27 2012
The change is still under review - https://codereview.chromium.org/11417003/
Project Member Comment 32 by bugdroid1@chromium.org, Nov 28 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=169938

------------------------------------------------------------------------
r169938 | bauerb@chromium.org | 2012-11-28T14:45:46.440931Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_test.cc?r1=169938&r2=169937&pathrev=169938
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_test.h?r1=169938&r2=169937&pathrev=169938
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/browser_with_test_window_test.h?r1=169938&r2=169937&pathrev=169938
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/win/window_impl.cc?r1=169938&r2=169937&pathrev=169938
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc?r1=169938&r2=169937&pathrev=169938
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests_unit.gypi?r1=169938&r2=169937&pathrev=169938
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/win/window_impl.h?r1=169938&r2=169937&pathrev=169938
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller_unittest.cc?r1=169938&r2=169937&pathrev=169938
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller.cc?r1=169938&r2=169937&pathrev=169938

Reland r167487: Get full WebPluginInfo for the PDF plug-in before enabling it for print preview.

Previous review: http://codereview.chromium.org/11364202/

TBR=thestig@chromium.org
BUG= 159902 ,113008

Review URL: https://chromiumcodereview.appspot.com/11417003
------------------------------------------------------------------------
Comment 33 by dharani@google.com, Nov 29 2012
Labels: Merge-Requested
This is part of 25.0.1338.0. Please verify the fix.
Labels: QA-Verified
Print Preview works fine in current canary - 25.0.1342.0 ( Official Build 170408)
Comment 35 by dharani@google.com, Nov 30 2012
Labels: -Merge-Requested Merge-Approved
Project Member Comment 36 by bugdroid1@chromium.org, Dec 2 2012
Labels: -Merge-Approved merge-merged-1312
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=170690

------------------------------------------------------------------------
r170690 | bauerb@chromium.org | 2012-12-02T18:20:15.900582Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/test/base/browser_with_test_window_test.h?r1=170690&r2=170689&pathrev=170690
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/ui/base/win/window_impl.cc?r1=170690&r2=170689&pathrev=170690
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc?r1=170690&r2=170689&pathrev=170690
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/ui/base/win/window_impl.h?r1=170690&r2=170689&pathrev=170690
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/printing/print_preview_tab_controller_unittest.cc?r1=170690&r2=170689&pathrev=170690
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/chrome_tests.gypi?r1=170690&r2=170689&pathrev=170690
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/printing/print_preview_tab_controller.cc?r1=170690&r2=170689&pathrev=170690
   A http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/printing/print_preview_test.cc?r1=170690&r2=170689&pathrev=170690
   A http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/printing/print_preview_test.h?r1=170690&r2=170689&pathrev=170690

Merge r169938: Reland r167487: Get full WebPluginInfo for the PDF plug-in before enabling it for print preview.

Previous review: http://codereview.chromium.org/11364202/

TBR=thestig@chromium.org
BUG= 159902 ,113008

Review URL: https://chromiumcodereview.appspot.com/11417003


Conflicts:

	chrome/chrome_tests_unit.gypi

Review URL: https://codereview.chromium.org/11316300
------------------------------------------------------------------------
Status: Fixed
Status: Verified
verified that print preview is available in windows 8 mode.
Project Member Comment 39 by bugdroid1@chromium.org, Mar 9 2013
Labels: -Type-Regression -Area-UI -Mstone-24 -Feature-PrintPreview -Feature-Plugins -Feature-Plugins-Pepper Type-Bug-Regression Cr-Content-Plugins Cr-UI M-24 Cr-Content-Plugins-Pepper Cr-UI-Browser-PrintPreview
Project Member Comment 40 by bugdroid1@chromium.org, Apr 5 2013
Labels: Cr-Blink
Project Member Comment 41 by bugdroid1@chromium.org, Apr 6 2013
Labels: -Cr-Content-Plugins Cr-Internals-Plugins
Project Member Comment 42 by bugdroid1@chromium.org, Apr 6 2013
Labels: -Cr-Content-Plugins-Pepper Cr-Internals-Plugins-Pepper
Comment 43 by Deleted ...@, Aug 30 2013
Forgive me if this is the wrong place to ask, but how are you managing to bypass the system charm print dialog from withing the metro application?  I thought that was a hard WinRT restriction.
Comment 44 by cpu@chromium.org, Sep 3 2013
@43, default metro browsers are a special category of application. When in metro API restrictions are not enforced, by the same token they can't be distributed in the store. Sort of a hybrid between a regular metro app and a regular desktop app.


Cc: -vitalyb...@chromium.org
Sign in to add a comment