New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 158912 link

Starred by 6 users

Issue metadata

Status: Verified
Owner:
Working on ARC now
Closed: Nov 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Sidebar links (History, Extensions & Help) are not accessible after dismissing a confirmation dialog

Project Member Reported by msrchandra@chromium.org, Nov 1 2012

Issue description

Chrome Version       : <'24.0.1312.2'>
URLs (if applicable) :
Other browsers tested: Chrome Related
Add OK or FAIL after other browsers where you have tested this issue:
Safari 5:
Firefox 4.x:
IE 7/8/9:

What steps will reproduce the problem?
1. Open Chrome Browser.
2. Go to chrome://settings.
3. Check(Select) the options "Continue where I Left", "Show Home Button", "Always show the bookmarks bar" and "Enable instant for faster searching(omnibox input may be logged).
4. Now move the cursor on to the options "History", "Extensions" & "Help" and notice that none of these links are not accessible.
5. Page has to be refreshed to access these links.

What is the expected result?
All the links should be accessible after checking the above options in chrome://settings

What happens instead?
All the links are not accessible after checking the above options in chrome://settings

Please find the bisected Info,
Good Build: 24.0.1306.1.
Bad Build : 24.0.1307.0.

You are probably looking for a change made after 163853 (known good), but no lat
er than 163876 (first known bad).
CHANGELOG URL:
  http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/tru
nk/src&range=163853%3A163876


Please provide any additional information below. Attach a screenshot if
possible.
 
They are only accessible again if the page is refreshed.
Status: Available
This has something to do with the confirmation dialog that's shown.

There's no need to click on any of the other options. It suffices to just click on the "Enable Instant for faster searching" option alone. Note however that the initial confirmation dialog must show (doesn't matter if you click OK or Cancel on the dialog). After the dialog is dismissed, you can't click on History, Extensions or Help. You can see the same issue with other options that also popup confirmation dialogs, such as "Use a web service to help resolve spelling errors".
Cc: est...@chromium.org
Summary: Sidebar links (History, Extensions & Help) are not accessible after dismissing a confirmation dialog

Comment 4 by dharani@google.com, Nov 1 2012

Labels: -Type-Bug -Pri-2 Type-Regression Pri-1 ReleaseBlock-Beta
Owner: bartfab@chromium.org
Status: Assigned
This could be due to http://src.chromium.org/viewvc/chrome?view=rev&revision=163874

Comment 5 by dbeam@chromium.org, Nov 1 2012

Labels: Action-BisectNeeded
dharani@: did you bisect to that rev?
Labels: -Action-BisectNeeded
I got the same bisect result as in original bug. 

Revision 163876 is [(g)ood/(b)ad/(u)nknown/(q)uit]: b
You are probably looking for a change made after 163853 (known good), but no lat
er than 163876 (first known bad).
CHANGELOG URL:
  http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/tru
nk/src&range=163853%3A163876

Comment 8 by dbeam@chromium.org, Nov 1 2012

Thanks for checking, pavanv@ and cem.kocagil@!
Status: Started
Thanks for the analysis and bisect. This regression was caused by my refactor indeed.

Here is a CL that fixes the issue:
https://codereview.chromium.org/11366083

I also created an alternative CL that makes the same code change but leaves the indentation unchanged:
https://codereview.chromium.org/11293090

I would like to land and merge the first CL. The second just serves to illustrate how little the code changes.

Comment 10 Deleted

Comment 11 Deleted

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 5 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=166023

------------------------------------------------------------------------
r166023 | bartfab@chromium.org | 2012-11-05T20:37:22.328852Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/options/options.js?r1=166023&r2=166022&pathrev=166023

Ensure sidebar links are re-enabled when a confirmation dialog is closed

Confirmation dialogs should have the BrowserOptions  page as their parent.
If they do not, closing a confirmation dialog will not re-enable the
sidebar links (History/Extensions/Settings/Help).

The parent used to be set correctly but got lost accidentally in the
refactor of crrev.com/163874.

BUG= 158912 

Review URL: https://codereview.chromium.org/11366083
------------------------------------------------------------------------
Fix landed as http://crrev.com/166023
Requesting merge to 1312.
Labels: -Merge-Requested Merge-Approved
Please merge it in 1312 branch.
Labels: -Merge-Approved Merge-Merged
Merged as http://crrev.com/166026
Project Member

Comment 16 by bugdroid1@chromium.org, Nov 5 2012

Labels: merge-merged-1312
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=166026

------------------------------------------------------------------------
r166026 | bartfab@chromium.org | 2012-11-05T20:44:50.812790Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/resources/options/options.js?r1=166026&r2=166025&pathrev=166026

Merge 166023 - Ensure sidebar links are re-enabled when a confirmation dialog is closed

Confirmation dialogs should have the BrowserOptions  page as their parent.
If they do not, closing a confirmation dialog will not re-enable the
sidebar links (History/Extensions/Settings/Help).

The parent used to be set correctly but got lost accidentally in the
refactor of crrev.com/163874.

BUG= 158912 

Review URL: https://codereview.chromium.org/11366083

TBR=bartfab@chromium.org
Review URL: https://codereview.chromium.org/11367099
------------------------------------------------------------------------
Status: Fixed
Status: Verified
As the issue has been merged into 1312, the issue has been verified on latest Beta Chrome Version, 24.0.1312.52 and found Fixed.

Hence closing the issue.

Thanks.
Project Member

Comment 19 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Type-Regression -Area-UI -Mstone-24 -Feature-Settings Type-Bug-Regression Cr-UI-Settings Cr-UI M-24

Sign in to add a comment