Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 15882 bookmark bar padding cleanups
Starred by 1 user Project Member Reported by estade@chromium.org, Jul 2 2009 Back to list
Status: Fixed
Owner:
Closed: Jul 2009
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment
- bookmark bar too tall
- button item padding wrong

source: Ben/Glen UI review
 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=19871 

------------------------------------------------------------------------
r19871 | estade@chromium.org | 2009-07-02 17:43:13 -0700 (Thu, 02 Jul 2009) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc?r1=19871&r2=19870
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc?r1=19871&r2=19870

Change some numbers on the gtk bookmark bar.

height = 29 matches windows constant
padding between bookmark name and favico: I couldn't find a relevant constant in the windows code, so I experimentally matched the spacing between the two, for the same bookmark on linux and windows.

BUG= http://crbug.com/15882 
TEST=look at bookmark bar

Review URL: http://codereview.chromium.org/155019
------------------------------------------------------------------------

Status: Fixed
Project Member Comment 3 by bugdroid1@chromium.org, Oct 12 2012
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Sign in to add a comment