Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Issue 158744 Support for the "resolution" media query
Starred by 7 users Project Member Reported by peter@chromium.org, Oct 31 2012 Back to list
Status: Fixed
Owner:
Closed: Jul 2013
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: ----
Launch-Privacy: ----
Launch-Security: ----
Launch-Status: ----
Launch-Test: ----
Launch-UI: ----



Sign in to add a comment
*High-level description of the change (1-2 sentences):*
Enabling support for the "resolution" query in media queries.

*Listing of additions/modifications/changes to API surface (bullet
points):*
Support for the "resolution" query to be used in CSS media queries, and the MediaQuery listeners in the DOM.

This feature was implemented by Intel.

*Link to relevant webkit or crbug:*
https://bugs.webkit.org/show_bug.cgi?id=99077 "Add support for resolution media query"

*Link to relevant public standards discussion:*
http://dev.w3.org/csswg/css3-mediaqueries/#resolution

*Support in other browsers (current and expected):*
Internet Explorer: Yes.
Firefox: Yes.
Safari: No.
Opera: Yes.
 
Comment 1 by peter@chromium.org, Oct 31 2012
Cc: kenneth....@gmail.com
Comment 2 by peter@chromium.org, Oct 31 2012
Cc: rbyers@chromium.org
Comment 3 by meh@chromium.org, Nov 8 2012
Labels: -Mstone-X Mstone-25
Status: Fixed
Landed in this changeset: http://trac.webkit.org/changeset/132227
Comment 4 by peter@chromium.org, Nov 8 2012
Status: Available
My bad -- I should have clarified. This isn't enabled for Chrome yet.
Cc: felipeg@chromium.org
Comment 6 by meh@chromium.org, Nov 21 2012
Labels: -Mstone-25 Mstone-X
Moving to Mstone-X because it's unclear when this will be enabled for Chrome.
Comment 7 by vli@chromium.org, Nov 26 2012
Labels: ImportantForMobile
Comment 8 by vli@chromium.org, Jan 31 2013
would be great to have this in chrome soon!
Project Member Comment 9 by bugdroid1@chromium.org, Mar 9 2013
Labels: -OWP-DesignReview-No OWP-Design-No
Project Member Comment 10 by bugdroid1@chromium.org, May 10 2013
------------------------------------------------------------------------
r150142 | chrome-bot@google.com | 2013-05-10T22:10:04.793183Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/media/w3c/test_media_queries-expected.txt?r1=150142&r2=150141&pathrev=150142
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSStyleSheet.cpp?r1=150142&r2=150141&pathrev=150142
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/Screen.cpp?r1=150142&r2=150141&pathrev=150142
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSParser.cpp?r1=150142&r2=150141&pathrev=150142
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/media/mq-resolution-expected.txt?r1=150142&r2=150141&pathrev=150142
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/StyleSheetContents.cpp?r1=150142&r2=150141&pathrev=150142
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/testing/InternalSettings.idl?r1=150142&r2=150141&pathrev=150142
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/Screen.h?r1=150142&r2=150141&pathrev=150142
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaQueryMatcher.cpp?r1=150142&r2=150141&pathrev=150142
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/testing/Internals.idl?r1=150142&r2=150141&pathrev=150142
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSParser.h?r1=150142&r2=150141&pathrev=150142
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaList.cpp?r1=150142&r2=150141&pathrev=150142
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/features.gypi?r1=150142&r2=150141&pathrev=150142
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSPrimitiveValue.cpp?r1=150142&r2=150141&pathrev=150142
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaList.h?r1=150142&r2=150141&pathrev=150142
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/testing/InternalSettings.cpp?r1=150142&r2=150141&pathrev=150142
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaQueryExp.cpp?r1=150142&r2=150141&pathrev=150142
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSPrimitiveValue.h?r1=150142&r2=150141&pathrev=150142
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaFeatureNames.h?r1=150142&r2=150141&pathrev=150142
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/Settings.cpp?r1=150142&r2=150141&pathrev=150142
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/testing/Internals.cpp?r1=150142&r2=150141&pathrev=150142
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/testing/InternalSettings.h?r1=150142&r2=150141&pathrev=150142
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaQueryEvaluator.cpp?r1=150142&r2=150141&pathrev=150142
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/testing/Internals.h?r1=150142&r2=150141&pathrev=150142
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/Settings.h?r1=150142&r2=150141&pathrev=150142
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/media/mq-resolution.html?r1=150142&r2=150141&pathrev=150142

Enable resolution media queries with fixed implementation
    
The fixes to the original implementation are partly based on a
patch by Rune Lillesveen <rune@opera.com>

The implementation used the physical resolution to evaluate the
resolution media features. Changed to use the actual CSS resolution,
also known as the device-pixel-ratio, instead. Unified the code for
evaluating the resolution and device-pixel-ratio media features.

Intent to ship thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/odQrXmT5vHk

BUG= 158744 , 230393 
WKBUG=114029

Review URL: https://chromiumcodereview.appspot.com/14408004
------------------------------------------------------------------------
Cc: -felipeg@chromium.org
Comment 12 by meh@chromium.org, May 13 2013
Labels: -Mstone-X M-29
Comment 13 by meh@chromium.org, Jun 21 2013
Labels: -OWP-Format-Unprefixed -OWP-LaunchBug-Needed -OWP-Documentation-Needed -OWP-TargetChannel-Stable
Will this feature ship in M-29?  Here's the Intent to Ship, for reference: https://groups.google.com/a/chromium.org/d/msg/blink-dev/odQrXmT5vHk/N7T0rhgtJDsJ
Comment 14 by meh@chromium.org, Jul 3 2013
Status: Fixed
I believe this is shipping in M-29.
Sign in to add a comment