New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 158562 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Nov 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Focus does not change from Omnibox to Find in Page on mouseclick

Project Member Reported by mmenke@chromium.org, Oct 30 2012

Issue description

Version: 24.0.1312.0 (Official Build 164863) canary
OS: Windows 7

What steps will reproduce the problem?
1.  Hit Ctrl-F, opening the find-in-files doalog.
2.  Focus some other control (omnibox, something in the page, reload the page, etc)
3.  Select the find-in-files text control again.
4.  Type.  All text entered goes to the last focused object, rather than the find-in-files dialog.
 

Comment 1 by meh@chromium.org, Oct 30 2012

Labels: Action-BisectNeeded

Comment 2 by mmenke@chromium.org, Oct 30 2012

Labels: -Action-BisectNeeded
164656 is good, 164681 is bad

Comment 3 by finnur@chromium.org, Oct 31 2012

Labels: -Pri-2 -Area-Internals Pri-1 Area-UI Regression ReleaseBlock-Beta
Owner: nona@chromium.org
Status: Assigned
Summary: Focus does not change from Omnibox to Find in Page on mouseclick
Looking at that regression range, I would say this is the most likely candidate:
https://chromiumcodereview.appspot.com/11305002/

nona: Can you see if this is related to your change? Thanks!

Comment 4 by nona@chromium.org, Nov 1 2012

Status: Started
I confirmed the problem.
Sorry for my mistake.

Comment 5 by nona@chromium.org, Nov 1 2012

Cc: yukawa@chromium.org
No problem. These things happen. :)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 2 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=165629

------------------------------------------------------------------------
r165629 | nona@chromium.org | 2012-11-02T05:50:39.591668Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/controls/textfield/native_textfield_win.cc?r1=165629&r2=165628&pathrev=165629

Calls default window procedure for WM_KILLFOCUS.

Without default window procedure, the actual focus does not change correctly.

BUG= 158562 
TEST=Manually done

Review URL: https://chromiumcodereview.appspot.com/11365028
------------------------------------------------------------------------

Comment 8 by nona@chromium.org, Nov 2 2012

Status: Fixed

Comment 9 by nona@chromium.org, Nov 2 2012

Labels: Merge-Requested

Comment 10 by nona@chromium.org, Nov 5 2012

Status: Started
Reopen for M24, canary works fine.
I think this is safe to merge.

Please let me merge to M24.

Thanks.
Labels: -Merge-Requested Merge-Approved Mstone-24
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 5 2012

Labels: -Merge-Approved merge-merged-1312
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=165898

------------------------------------------------------------------------
r165898 | nona@chromium.org | 2012-11-05T04:43:24.374462Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/ui/views/controls/textfield/native_textfield_win.cc?r1=165898&r2=165897&pathrev=165898

Merge 165629 - Calls default window procedure for WM_KILLFOCUS.

Without default window procedure, the actual focus does not change correctly.

BUG= 158562 
TEST=Manually done

Review URL: https://chromiumcodereview.appspot.com/11365028

TBR=nona@chromium.org
Review URL: https://codereview.chromium.org/11361088
------------------------------------------------------------------------
Status: Fixed
Marking it as fixed.

Comment 14 by nona@chromium.org, Nov 5 2012

Thank you.
Status: Verified
Not able to repro this issue on Latest Canary 25.0.1324.0,Beta 24.0.1312.5 and Dev  24.0.1312.14,marking this issue as 'Verified'


Project Member

Comment 16 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Type-Bug -Regression Type-Bug-Regression
Project Member

Comment 17 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Area-UI -Feature-FindInPage -Mstone-24 Cr-UI-Browser-FindInPage Cr-UI M-24

Sign in to add a comment