Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 15845 need bookmark bar overflow chevron
Starred by 6 users Project Member Reported by aocampo@chromium.org, Jul 2, 2009 Back to list
Status: Fixed
Owner: estade@chromium.org
Closed: Sep 2009
Cc: e...@chromium.org, estade@chromium.org
OS: Linux
Pri: 2
Type: Bug
M-4

Restricted
  • Only users with EditIssue permission may comment.


Sign in to add a comment
Chrome Version       :3.0.191.0 (Official Build 19705)
OS + version : Ubuntu 8.04 
CPU architecture (32-bit / 64-bit): 64-bit
window manager : Gnome 2.22.3
URLs (if applicable) :
Behavior in Firefox 3.x (if applicable):
Behavior in Chrome for Windows (optional):

What steps will reproduce the problem?
1. Create a few bookmarks in the bookmarks folder so that some will not fit
in the bar view 


What is the expected result?
There should be a >> in the bookmarks bar to expand the list of bookmarks

What happens instead?
Nothing. No way to get to the bookmarks that do not fit in the bookmarks
bar view.

Please provide any additional information below. Attach a screenshot
and backtrace if possible.

 
Comment 1 by estade@chromium.org, Jul 2, 2009
Labels: -Size-Medium Pri-2 Size-Small Mstone-LinuxBeta
Status: Available
Summary: need bookmark bar overflow chevron (was: NULL)
well, it's not exactly true there's *no way*, as the bookmark manager will let you 
access them
I meant no way to get to the other bookmarks from the bookmarks menu.
Comment 3 by evan@chromium.org, Jul 18, 2009
Labels: -Size-Small Size-Medium
Comment 4 by jh0763...@gmail.com, Jul 31, 2009
Status: Assigned
Comment 5 by evan@chromium.org, Sep 1, 2009
If we used a GtkToolbar we could _set_show_arrow() to get this, but I guess that might 
not work right with our theme.
http://library.gnome.org/devel/gtk/unstable/GtkToolbar.html
Comment 6 by e...@chromium.org, Sep 1, 2009
IIRC, we do use a GtkToolbar, and only for the content that could overflow...
Comment 7 by estade@chromium.org, Sep 1, 2009
yep. I'm looking at it right now, for some reason that call isn't working. In the 
process of investigating...
Comment 8 by estade@chromium.org, Sep 1, 2009
ok, wth, this doesn't work as a standalone program (see attachment)
gtk_test.cc
664 bytes View Download
Comment 9 by estade@chromium.org, Sep 1, 2009
d'oh, apparently we need to make "proxy menu items" for the tool items. Dang it!
Status: Started
Comment 11 by evan@chromium.org, Sep 2, 2009
Labels: -Mstone-LinuxBeta ReleaseBlock-Beta Mstone-4
Rearranging bugs to eliminate LinuxBeta label.
Status: Fixed
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=25200 

------------------------------------------------------------------------
r25200 | estade@chromium.org | 2009-09-02 11:10:09 -0700 (Wed, 02 Sep 2009) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc?r1=25200&r2=25199
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h?r1=25200&r2=25199

GTK: Implement the bookmark bar chevron.

I didn't use the native GtkToolbar version of this because, as usual, GTK doesn't give us enough flexibility to do what we want. But it wasn't too hard or super hacky to re-implement it.

The chromium version (and hence the Windows version) looks bad. This is not my fault. I don't know why it points right rather than down, when the menu pops down, not to the right. This is why I used a down arrow for the GTK version rather than matching with a right arrow.

BUG= 15845 

Review URL: http://codereview.chromium.org/187001
------------------------------------------------------------------------

Project Member Comment 14 by bugdroid1@chromium.org, Jun 3, 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=87732

------------------------------------------------------------------------
r87732 | rginda@chromium.org | Thu Jun 02 17:08:02 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/file_manager/js/file_manager.js?r1=87732&r2=87731&pathrev=87732

file manager: Fix okButton updating.

update the okButton whenever the directory changes.
This fixes bug 15845, which was caused by trying to update the button before we had set the current directory, and bug 15464, which was due to the fact that we relied on "Selection changed" events to trigger button updates.

BUG=chromium-os:15845,chromium-os:15464
TEST=manual testing on chromeos-chrome on linux

Review URL: http://codereview.chromium.org/7109033
------------------------------------------------------------------------
Project Member Comment 15 by bugdroid1@chromium.org, Jun 3, 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=87798

------------------------------------------------------------------------
r87798 | rginda@chromium.org | Fri Jun 03 10:01:33 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/742/src/chrome/browser/resources/file_manager/js/file_manager.js?r1=87798&r2=87797&pathrev=87798

Merge 87732 - file manager: Fix okButton updating.

update the okButton whenever the directory changes.
This fixes bug 15845, which was caused by trying to update the button before we had set the current directory, and bug 15464, which was due to the fact that we relied on "Selection changed" events to trigger button updates.

BUG=chromium-os:15845,chromium-os:15464
TEST=manual testing on chromeos-chrome on linux

Review URL: http://codereview.chromium.org/7109033

TBR=rginda@chromium.org
Review URL: http://codereview.chromium.org/7054047
------------------------------------------------------------------------
Project Member Comment 16 by bugdroid1@chromium.org, Jun 3, 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=87805

------------------------------------------------------------------------
r87805 | rginda@chromium.org | Fri Jun 03 10:57:57 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/782/src/chrome/browser/resources/file_manager/js/file_manager.js?r1=87805&r2=87804&pathrev=87805

Merge 87732 - file manager: Fix okButton updating.

update the okButton whenever the directory changes.
This fixes bug 15845, which was caused by trying to update the button before we had set the current directory, and bug 15464, which was due to the fact that we relied on "Selection changed" events to trigger button updates.

BUG=chromium-os:15845,chromium-os:15464
TEST=manual testing on chromeos-chrome on linux

Review URL: http://codereview.chromium.org/7109033

TBR=rginda@chromium.org
Review URL: http://codereview.chromium.org/7065061
------------------------------------------------------------------------
Project Member Comment 17 by bugdroid1@chromium.org, Oct 12, 2012
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member Comment 18 by bugdroid1@chromium.org, Mar 10, 2013
Labels: -Mstone-4 M-4
Project Member Comment 19 by bugdroid1@chromium.org, Mar 13, 2013
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Sign in to add a comment