New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 158422 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

{gtk} <input> selection renders white text on white bg in apps

Project Member Reported by lazyboy@chromium.org, Oct 29 2012

Issue description

Version: @tott
OS: linux/gtk

What steps will reproduce the problem?
1. Create a packaged app that has <input> element.
2. Select some text in the input element.
(I think all types of selection color are broken, not just <input>)


What is the expected output? What do you see instead?
White on white, so the selected text is not visible anymore.

Avi, it seems related to your change: crrev.com/163322.
Can you take a look?
 

Comment 1 by a...@chromium.org, Oct 29 2012

Cc: benwells@chromium.org
Can you do a bisection and be sure?

In any case, I can't look at it for a few days as I'm WFHurricane/Home. Where does Gtk get its selection color from? Why would the loss of tab helpers have anything to do with it?
If I haven't messed up something, crrev.com/163322 seems to be the one.
[
This is what I did to be sure:
$ gclient sync --revision  src@`git svn find-rev r163321`
Then checked selection colors work.
$ git cl patch 11222003
Selection color is broken.
]

Gtk gets its selection color from: RendererPreferences, WebContents()->GetMutableRendererPreferences() afaik. But I don't know any further.

"Why would the loss of tab helpers have anything to do with it?" -> I actually have no idea.

Comment 3 by a...@chromium.org, Oct 29 2012

Huh. OK.

I'll put together a Gtk build when I get in and take a look at it.
Cc: fsam...@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 6 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=166146

------------------------------------------------------------------------
r166146 | avi@chromium.org | 2012-11-06T04:39:59.820233Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/renderer_preferences.cc?r1=166146&r2=166145&pathrev=166146
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/renderer_preferences.h?r1=166146&r2=166145&pathrev=166146
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_gtk.cc?r1=166146&r2=166145&pathrev=166146

Initialize renderer color preferences to reasonable defaults.

BUG= 158422 
TEST=as in bug


Review URL: https://chromiumcodereview.appspot.com/11365096
------------------------------------------------------------------------

Comment 6 by a...@chromium.org, Nov 6 2012

Labels: Mstone-24 Merge-Requested
This needs a merge.

Comment 7 by dharani@google.com, Nov 6 2012

lazyboy@: could you please verify the fix in 1318.0 build? I would take the merge if its fixed in today's canary.
Status: Verified
Checked at 25.0.1318.0 (Developer Build 166146), input selection color is happy now!
Labels: -Merge-Requested Merge-Approved
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 6 2012

Labels: -Merge-Approved merge-merged-1312
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=166239

------------------------------------------------------------------------
r166239 | avi@chromium.org | 2012-11-06T19:11:33.024250Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/content/shell/shell_gtk.cc?r1=166239&r2=166238&pathrev=166239
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/content/public/common/renderer_preferences.cc?r1=166239&r2=166238&pathrev=166239
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/content/public/common/renderer_preferences.h?r1=166239&r2=166238&pathrev=166239

Merge 166146 - Initialize renderer color preferences to reasonable defaults.

BUG= 158422 
TEST=as in bug


Review URL: https://chromiumcodereview.appspot.com/11365096

TBR=avi@chromium.org
------------------------------------------------------------------------
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 30 2012

Labels: merge-merged-1271
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=170383

------------------------------------------------------------------------
r170383 | avi@chromium.org | 2012-11-30T03:38:46.607204Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1271/src/content/public/common/renderer_preferences.cc?r1=170383&r2=170382&pathrev=170383
   M http://src.chromium.org/viewvc/chrome/branches/1271/src/content/public/common/renderer_preferences.h?r1=170383&r2=170382&pathrev=170383
   M http://src.chromium.org/viewvc/chrome/branches/1271/src/content/shell/shell_gtk.cc?r1=170383&r2=170382&pathrev=170383

Merge 166146 - Initialize renderer color preferences to reasonable defaults.

BUG= 158422 , 161346 
TEST=as in bug


Review URL: https://chromiumcodereview.appspot.com/11365096

TBR=avi@chromium.org
Review URL: https://codereview.chromium.org/11299269
------------------------------------------------------------------------
Verified with latest M23(23.0.1271.97) on Ubuntu 12.04 Lts.
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-Internals -Mstone-24 M-24 Cr-Internals

Sign in to add a comment