New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 158201 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2012
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Chrome: Crash Report - Stack Signature: GoogleURLTrackerMapEntry::Close(bool)-6d329...

Project Member Reported by dharani@google.com, Oct 28 2012

Issue description

could it be due to http://src.chromium.org/viewvc/chrome?view=rev&revision=162298

Product: Chrome
Stack Signature: GoogleURLTrackerMapEntry::Close(bool)-34915BB
New Signature Label: GoogleURLTrackerMapEntry::Close(bool)
New Signature Hash: 6d329551_f6e55a30_8e406a82_5cc6838a_00b2c385

Report link: http://go/crash/reportdetail?reportid=dde7b27465bb6b49

Meta information:
Product Name: Chrome
Product Version: 24.0.1309.0
Report ID: dde7b27465bb6b49
Report Time: 2012/10/27 23:45:32, Sat
Uptime: 53 sec
Cumulative Uptime: 0 sec
OS Name: Windows NT
OS Version: 6.1.7600 
CPU Architecture: x86
CPU Info: GenuineIntel family 6 model 37 stepping 5
ptype: browser


Thread 0 *CRASHED* ( EXCEPTION_ACCESS_VIOLATION_READ @ 0x632e6588 )

0x5cb3f3c7	 [chrome.dll]	 - google_url_tracker_map_entry.cc:50 (cs|src|ann)]	GoogleURLTrackerMapEntry::Close(bool)
0x5cac1d5f	 [chrome.dll]	 - google_url_tracker.cc:435 (cs|src|ann)]	GoogleURLTracker::OnNavigationCommittedOrTabClosed(InfoBarTabHelper *,GURL const &)
0x5cac1e1e	 [chrome.dll]	 - google_url_tracker.cc:244 (cs|src|ann)]	GoogleURLTracker::Observe(int,content::NotificationSource const &,content::NotificationDetails const &)
0x5bbf0bc5	 [chrome.dll]	 - notification_service_impl.cc:129 (cs|src|ann)]	NotificationServiceImpl::Notify(int,content::NotificationSource const &,content::NotificationDetails const &)
0x5c0bdab2	 [chrome.dll]	 - web_contents_impl.cc:345 (cs|src|ann)]	content::WebContentsImpl::~WebContentsImpl()
0x5c0bd9d9	 [chrome.dll]	 + 0x0055d9d9]	content::WebContentsImpl::`vector deleting destructor'(unsigned int)
0x5c0bd9c6	 [chrome.dll]	 - tab_contents.cc:198 (cs|src|ann)]	TabContents::~TabContents()
0x5c0bd991	 [chrome.dll]	 + 0x0055d991]	TabContents::`vector deleting destructor'(unsigned int)
0x5c0bd3aa	 [chrome.dll]	 - tab_strip_model.cc:1179 (cs|src|ann)]	TabStripModel::InternalCloseTab(TabContents *,int,bool)
0x5c0bd29f	 [chrome.dll]	 - tab_strip_model.cc:1160 (cs|src|ann)]	TabStripModel::InternalCloseTabs(std::vector<int,std::allocator<int> > const &,unsigned int)
0x5d16f19a	 [chrome.dll]	 - tab_strip_model.cc:396 (cs|src|ann)]	TabStripModel::CloseTabContentsAt(int,unsigned int)
0x5d1f78fa	 [chrome.dll]	 - browser_tab_strip_controller.cc:290 (cs|src|ann)]	BrowserTabStripController::CloseTab(int,CloseTabSource)
0x5d1c8fb0	 [chrome.dll]	 - tab_strip.cc:994 (cs|src|ann)]	TabStrip::CloseTab(BaseTab *,CloseTabSource)
0x5d21228d	 [chrome.dll]	 - base_tab.cc:617 (cs|src|ann)]	BaseTab::ButtonPressed(views::Button *,ui::Event const &)
0x5cc27c5a	 [chrome.dll]	 - button.cc:63 (cs|src|ann)]	views::Button::NotifyClick(ui::Event const &)
0x5cc248cf	 [chrome.dll]	 - custom_button.cc:145 (cs|src|ann)]	views::CustomButton::OnMouseReleased(ui::MouseEvent const &)
0x5d211830	 [chrome.dll]	 - base_tab.cc:94 (cs|src|ann)]	BaseTab::TabCloseButton::OnMouseReleased(ui::MouseEvent const &)
0x5cc20994	 [chrome.dll]	 - view.cc:1968 (cs|src|ann)]	views::View::ProcessMouseReleased(ui::MouseEvent const &)
0x5cc274a0	 [chrome.dll]	 - root_view.cc:301 (cs|src|ann)]	views::internal::RootView::OnMouseReleased(ui::MouseEvent const &)
0x5c0bb730	 [chrome.dll]	 - widget.cc:1114 (cs|src|ann)]	views::Widget::OnMouseEvent(ui::MouseEvent const &)
0x5c0baba8	 [chrome.dll]	 - hwnd_message_handler.cc:1537 (cs|src|ann)]	views::HWNDMessageHandler::OnMouseRange(unsigned int,unsigned int,long)
0x5bf17c32	 [chrome.dll]	 - hwnd_message_handler.h:235 (cs|src|ann)]	views::HWNDMessageHandler::_ProcessWindowMessage(HWND__ *,unsigned int,unsigned int,long,long &,unsigned long)
0x5bf17af9	 [chrome.dll]	 - hwnd_message_handler.h:233 (cs|src|ann)]	views::HWNDMessageHandler::ProcessWindowMessage(HWND__ *,unsigned int,unsigned int,long,long &,unsigned long)
0x5bf1772d	 [chrome.dll]	 - hwnd_message_handler.cc:921 (cs|src|ann)]	views::HWNDMessageHandler::OnWndProc(unsigned int,unsigned int,long)
0x5bf13926	 [chrome.dll]	 - window_impl.cc:243 (cs|src|ann)]	ui::WindowImpl::WndProc(HWND__ *,unsigned int,unsigned int,long)
0x5bf13838	 [chrome.dll]	 - wrapped_window_proc.h:76 (cs|src|ann)]	base::win::WrappedWindowProc<&ui::WindowImpl::WndProc(HWND__ *,unsigned int,unsigned int,long)>(HWND__ *,unsigned int,unsigned int,long)
0x77366237	 [user32.dll]	 + 0x00016237]	InternalCallWinProc
0x773668e9	 [user32.dll]	 + 0x000168e9]	UserCallWinProcCheckWow
0x77370aaf	 [user32.dll]	 + 0x00020aaf]	CallWindowProcAorW
0x77370ad5	 [user32.dll]	 + 0x00020ad5]	CallWindowProcW
...... (5 stack frames dropped.)
0x5c038b12	 [chrome.dll]	 - accelerator_handler_win.cc:51 (cs|src|ann)]	views::AcceleratorHandler::Dispatch(tagMSG const &)
0x5bd765cf	 [chrome.dll]	 - message_pump_win.cc:395 (cs|src|ann)]	base::MessagePumpForUI::ProcessMessageHelper(tagMSG const &)
0x5bd7599a	 [chrome.dll]	 - message_pump_win.cc:237 (cs|src|ann)]	base::MessagePumpForUI::DoRunLoop()
0x5bb90b52	 [chrome.dll]	 - message_loop.cc:422 (cs|src|ann)]	MessageLoop::RunInternal()
0x5bb90abd	 [chrome.dll]	 - run_loop.cc:45 (cs|src|ann)]	base::RunLoop::Run()
0x5c038835	 [chrome.dll]	 - chrome_browser_main.cc:1507 (cs|src|ann)]	ChromeBrowserMainParts::MainMessageLoopRun(int *)
0x5c03876e	 [chrome.dll]	 - browser_main_loop.cc:482 (cs|src|ann)]	content::BrowserMainLoop::RunMainMessageLoopParts()
0x5c038738	 [chrome.dll]	 - browser_main_runner.cc:120 (cs|src|ann)]	`anonymous namespace'::BrowserMainRunnerImpl::Run()
0x5bbdaa48	 [chrome.dll]	 - browser_main.cc:21 (cs|src|ann)]	BrowserMain(content::MainFunctionParams const &)
0x5bb78935	 [chrome.dll]	 - content_main_runner.cc:448 (cs|src|ann)]	content::RunNamedProcessTypeMain(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,content::MainFunctionParams const &,content::ContentMainDelegate *)
0x5bb788bc	 [chrome.dll]	 - content_main_runner.cc:741 (cs|src|ann)]	content::ContentMainRunnerImpl::Run()
0x5bb6a8f6	 [chrome.dll]	 - content_main.cc:35 (cs|src|ann)]	content::ContentMain(HINSTANCE__ *,sandbox::SandboxInterfaceInfo *,content::ContentMainDelegate *)
0x5bb6a5ec	 [chrome.dll]	 - chrome_main.cc:28 (cs|src|ann)]	ChromeMain
0x000b5244	 [chrome.exe]	 - client_util.cc:440 (cs|src|ann)]	MainDllLoader::Launch(HINSTANCE__ *,sandbox::SandboxInterfaceInfo *)
0x000b7c5f	 [chrome.exe]	 - chrome_exe_main_win.cc:76 (cs|src|ann)]	RunChrome(HINSTANCE__ *)
0x000b7cca	 [chrome.exe]	 - chrome_exe_main_win.cc:92 (cs|src|ann)]	wWinMain
0x0011079c	 [chrome.exe]	 - crt0.c:275]	__tmainCRTStartup
0x75c73676	 [kernel32.dll]	 + 0x00013676]	BaseThreadInitThunk
0x77919f41	 [ntdll.dll]	 + 0x00039f41]	__RtlUserThreadStart
0x77919f14	 [ntdll.dll]	 + 0x00039f14]	_RtlUserThreadStart
 
Labels: Merge-Requested
Fixed on trunk in r165468, requesting M24 merge
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 1 2012

Summary: Chrome: Crash Report - Stack Signature: GoogleURLTrackerMapEntry::Close(bool)-6d329...
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=165468

------------------------------------------------------------------------
r165468 | pkasting@chromium.org | 2012-11-01T19:24:12.111537Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/google/google_url_tracker_map_entry.cc?r1=165468&r2=165467&pathrev=165468
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/google/google_url_tracker_unittest.cc?r1=165468&r2=165467&pathrev=165468
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/google/google_url_tracker.cc?r1=165468&r2=165467&pathrev=165468
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/google/google_url_tracker.h?r1=165468&r2=165467&pathrev=165468

Fix a crash that could occur if the user closed a tab with an uncommitted search navigation that we were planning to show a GoogleURLTracker infobar for.  In this case the WebContents being destroyed does not necessarily have a valid InfoBarTabHelper anymore.

This also fixes names and comments relating to the EntryMap (nee InfoBarMap) that probably should have been changed when I added GoogleURLTrackerMapEntry.

BUG= 158201 
TEST=none
Review URL: https://codereview.chromium.org/11339060
------------------------------------------------------------------------
Let's wait for tomorrow's canary before approving.
Cc: mbollu@chromium.org
Are there steps for QA to verify the bug manually?
Only if you have a proxy that can cause loads to not commit for a few seconds.

Comment 6 by dharani@google.com, Nov 2 2012

Labels: -Merge-Requested Merge-Approved
so far didn't see any crash in today's canary. Hence approving the change.
Status: Fixed
Merged in r165801.
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 3 2012

Labels: -Merge-Approved merge-merged-1312
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=165801

------------------------------------------------------------------------
r165801 | pkasting@chromium.org | 2012-11-02T23:58:56.186247Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/google/google_url_tracker_map_entry.cc?r1=165801&r2=165800&pathrev=165801
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/google/google_url_tracker_unittest.cc?r1=165801&r2=165800&pathrev=165801
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/google/google_url_tracker.cc?r1=165801&r2=165800&pathrev=165801
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/google/google_url_tracker.h?r1=165801&r2=165800&pathrev=165801

Merge 165468 - Fix a crash that could occur if the user closed a tab with an uncommitted search navigation that we were planning to show a GoogleURLTracker infobar for.  In this case the WebContents being destroyed does not necessarily have a valid InfoBarTabHelper anymore.

This also fixes names and comments relating to the EntryMap (nee InfoBarMap) that probably should have been changed when I added GoogleURLTrackerMapEntry.

BUG= 158201 
TEST=none
Review URL: https://codereview.chromium.org/11339060

TBR=pkasting@chromium.org
Review URL: https://codereview.chromium.org/11366075
------------------------------------------------------------------------
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Mstone-24 M-24

Sign in to add a comment