New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 157365 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Oct 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

[Panels] Chrome crashes when ending extension process from Chrome TaskManager

Reported by jennb@chromium.org, Oct 23 2012

Issue description

(Separated out from crbug 156206)

Version: 24.0.1304.1
OS: all

Chrome is still crashing when closing GTalk from Chrome Taskbar. Below are the steps to reproduce:

1. Install the debug version of the GTalk extension from http://goto.google.com/gtalkpanel 
2. Log into Gmail and open 10-12 chat panels
3. From Chrome Wrench, launch Taskbar and end all the Chat Extenstions, Chrome crashes.

Crash ID: c182b5ecafbaeb78

Crash Report:
Thread 0 *CRASHED* ( EXCEPTION_ACCESS_VIOLATION_READ @ 0xfffffffff13908fb )

0x5d859d98	 [chrome.dll]	 - task_manager_resource_providers.cc:177]	TaskManagerRendererResource::Refresh()
0x5d7ef9ab	 [chrome.dll]	 - task_manager.cc:1055]	TaskManagerModel::Refresh()
0x5c940a66	 [chrome.dll]	 - message_loop.cc:470]	MessageLoop::RunTask(base::PendingTask const &)
0x5c940e9a	 [chrome.dll]	 - message_loop.cc:699]	MessageLoop::DoDelayedWork(base::TimeTicks *)
0x758979ef	 [user32.dll]	 + 0x000179ef]	NtUserKillTimer
0x5c98c43b	 [chrome.dll]	 - message_pump_win.cc:208]	base::MessagePumpForUI::WndProcThunk(HWND__ *,unsigned int,unsigned int,long)
0x5c98c333	 [chrome.dll]	 + 0x0007c333]	
0x758962f9	 [user32.dll]	 + 0x000162f9]	InternalCallWinProc
0x75896d39	 [user32.dll]	 + 0x00016d39]	UserCallWinProcCheckWow
0x758977c3	 [user32.dll]	 + 0x000177c3]	DispatchMessageWorker
0x75897889	 [user32.dll]	 + 0x00017889]	DispatchMessageW
0x5cde0ed6	 [chrome.dll]	 - accelerator_handler_win.cc:51]	views::AcceleratorHandler::Dispatch(tagMSG const &)
0x5caee004	 [chrome.dll]	 - message_pump_win.cc:395]	base::MessagePumpForUI::ProcessMessageHelper(tagMSG const &)
0x5caee15b	 [chrome.dll]	 - message_pump_win.cc:447]	base::MessagePumpForUI::ProcessPumpReplacementMessage()
0x5caedfb7	 [chrome.dll]	 - message_pump_win.cc:386]	base::MessagePumpForUI::ProcessMessageHelper(tagMSG const &)
0x5caed88a	 [chrome.dll]	 - message_pump_win.cc:237]	base::MessagePumpForUI::DoRunLoop()
0x5c9403ea	 [chrome.dll]	 - message_loop.cc:422]	MessageLoop::RunInternal()
0x5c940355	 [chrome.dll]	 - run_loop.cc:45]	base::RunLoop::Run()
0x5cde0c50	 [chrome.dll]	 - chrome_browser_main.cc:1514]	ChromeBrowserMainParts::MainMessageLoopRun(int *)
0x5cde0b89	 [chrome.dll]	 - browser_main_loop.cc:478]	content::BrowserMainLoop::RunMainMessageLoopParts()
0x5cde0b53	 [chrome.dll]	 - browser_main_runner.cc:122]	`anonymous namespace'::BrowserMainRunnerImpl::Run()
0x5c989477	 [chrome.dll]	 - browser_main.cc:21]	BrowserMain(content::MainFunctionParams const &)
0x5c928660	 [chrome.dll]	 - content_main_runner.cc:448]	content::RunNamedProcessTypeMain(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,content::MainFunctionParams const &,content::ContentMainDelegate *)
0x5c9285e7	 [chrome.dll]	 - content_main_runner.cc:741]	content::ContentMainRunnerImpl::Run()
0x5c91a620	 [chrome.dll]	 - content_main.cc:35]	content::ContentMain(HINSTANCE__ *,sandbox::SandboxInterfaceInfo *,content::ContentMainDelegate *)
0x5c91a5ac	 [chrome.dll]	 - chrome_main.cc:28]	ChromeMain
0x011b523d	 [chrome.exe]	 - client_util.cc:440]	MainDllLoader::Launch(HINSTANCE__ *,sandbox::SandboxInterfaceInfo *)
0x011b791b	 [chrome.exe]	 - chrome_exe_main_win.cc:76]	RunChrome(HINSTANCE__ *)
0x011b7986	 [chrome.exe]	 - chrome_exe_main_win.cc:92]	wWinMain
0x0121049c	 [chrome.exe]	 - crt0.c:275]	__tmainCRTStartup
0x752533a9	 [kernel32.dll]	 + 0x000133a9]	BaseThreadInitThunk
0x774c9ef1	 [ntdll.dll]	 + 0x00039ef1]	__RtlUserThreadStart
0x774c9ec4	 [ntdll.dll]	 + 0x00039ec4]	_RtlUserThreadStart
 

Comment 1 by jennb@chromium.org, Oct 23 2012

Cc: dim...@chromium.org
Bisect build results: 

You are probably looking for a change made after 162161 (known good), but no later than 162213 (first known bad).
WEBKIT CHANGELOG URL:
  http://trac.webkit.org/log/trunk/?rev=131457&stop_rev=131421&verbose=on&limit=10000
CHANGELOG URL:
  http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&range=162161%3A162213

Comment 2 by jennb@chromium.org, Oct 23 2012

Likely culprit is this change which makes the WebContents unavailable to the TaskManager earlier.

http://src.chromium.org/viewvc/chrome?view=rev&revision=162200

Will need to rework that fix.

Comment 3 by pavanv@chromium.org, Oct 23 2012

Labels: -Action-BisectNeeded
add back Action=BisectNeeded if further bisect is required.

Comment 4 by jennb@chromium.org, Oct 23 2012

Status: Started
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 24 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=163895

------------------------------------------------------------------------
r163895 | jennb@chromium.org | 2012-10-24T20:47:47.610460Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager_browsertest.cc?r1=163895&r2=163894&pathrev=163895
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager_resource_providers.cc?r1=163895&r2=163894&pathrev=163895

[Panels] Fix crash when killing panel extension from TaskManager.

When Panel closes, it destroys the WebContents triggering WEB_CONTENTS_DISCONNECTED notification. However, when the Panel is closed due to "End Process" from TaskManager window, the notification is triggered by RenderViewGone and the WebContents still exist. TaskManager needs to remove Panel from the resource list in both scenarios.

TBR=yoshiki
BUG= 157365 
TEST=TaskManagerBrowserTest.KillPanelExtension


Review URL: https://chromiumcodereview.appspot.com/11246005
------------------------------------------------------------------------

Comment 6 by jennb@chromium.org, Oct 24 2012

Status: Fixed
Crash happened on build: 24.0.1306.1 dev, From Chrome Task Manager end the chat extension.

Crash ID: e1cfb29f9fbaab9f

Comment 8 by dharani@google.com, Oct 26 2012

The fix isn't part of 1306.1 build. Please verify it in 1307.0 or higher builds.

Comment 9 by mbollu@chromium.org, Dec 20 2012

 Issue 166758  has been merged into this issue.
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Feature-Panels -Mstone-24 Cr-UI M-24 Cr-UI-Browser-Panels
Labels: hasTestcase

Sign in to add a comment