New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
link

Issue 157218: border-radius clipping without a stacking context does not apply to composited children

Reported by pardail...@gmail.com, Oct 22 2012

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/17.0 Firefox/17.0

Steps to reproduce the problem:
1. create a div with large border-radius and overflow hidden
2. create children expanded outside
3. in last canary it's ok: children are masked
4. apply a css transform with transition on children

What is the expected behavior?
children parts outside main div remains hidden

What went wrong?
during transition children are not masked anymore. At end of transition, situation becomes OK again.

Example URL:
http://dev.pardailhan.org/demo/widgets/hal9000/test.php

Does it occur on multiple sites: N/A

Is it a problem playing media? No

Is it a problem with a plugin? No 

Did this work before? No 

Does this work in other browsers? Yes firefox Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/17.0 Firefox/17.0

Chrome version: Version 24.0.1303.0 canary  Channel: canary
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
 

Comment 1 by dstockwell@chromium.org, Oct 23 2012

Cc: dstockwell@chromium.org
Labels: -OS-Windows OS-All Area-WebKit WebKit-Rendering WebKit-ID-68196
Status: Available
border-radius-transition.html
513 bytes View Download

Comment 2 by bugdroid1@chromium.org, Oct 23 2012

Project Member
Labels: -WebKit-ID-68196 WebKit-ID-68196-NEW
https://bugs.webkit.org/show_bug.cgi?id=68196

Comment 3 by laukst...@gmail.com, Oct 23 2012

Another test-case demo http://jsfiddle.net/laukstein/bhmka/2/show/ - try mouseover.

Comment 4 by jonat...@tumultco.com, Jan 18 2013

I've attached a simpler reproduction case of this bug; it does not requires transitions only a 3d transform on an element inside a div with overflow:hidden and a border-radius.

This affects Tumult Hype: http://tumult.com/hype/
Screen Shot 2013-01-18 at 11.05.42 AM.png
10.6 KB View Download
Rotate3dOverflowBug.html
416 bytes View Download

Comment 5 by laukst...@gmail.com, Jan 20 2013

Attached simplified testing-case http://jsfiddle.net/laukstein/bhmka/3/

Comment 6 by phistuck@chromium.org, Jan 20 2013

Labels: WebKit-Compositing
Note that this does not happen when using non hardware acceleration mode.

Comment 7 by vangelis@chromium.org, Jan 22 2013

Labels: Feature-GPU-Compositing
Thank you for the reduced test case! Safari and the WebKit nightlies also fail the same way.  Also being tracked in https://bugs.webkit.org/show_bug.cgi?id=68196 .

Comment 8 by bugdroid1@chromium.org, Mar 10 2013

Project Member
Labels: -Area-Compat -Type-Bug -Area-WebKit -WebKit-Rendering -WebKit-Compositing -Feature-GPU-Compositing Cr-Content Cr-Content-Compositing Type-Compat Cr-Internals-GPU-Compositing Cr-Content-Rendering

Comment 9 by tkent@chromium.org, Mar 18 2013

 Issue 177447  has been merged into this issue.

Comment 10 by tkent@chromium.org, Mar 18 2013

Cc: tasak@chromium.org

Comment 11 by bugdroid1@chromium.org, Apr 5 2013

Project Member
Labels: -Cr-Internals-GPU-Compositing Cr-Internals-Compositing

Comment 12 by bugdroid1@chromium.org, Apr 5 2013

Project Member
Labels: -Cr-Content Cr-Blink

Comment 13 by bugdroid1@chromium.org, Apr 6 2013

Project Member
Labels: -Cr-Content-Rendering Cr-Blink-Rendering

Comment 14 by bugdroid1@chromium.org, Apr 6 2013

Project Member
Labels: -Cr-Content-Compositing Cr-Blink-Compositing

Comment 15 by yael.aharon@chromium.org, May 21 2013

With Chrome Version 29.0.1514.0 (201303), I see this issue only when hardware acceleration is on. In my case, that means I need to add the flag --ignore-gpu-blacklist.

Comment 16 by sanjoy....@samsung.com, Jun 18 2013

<style>
.outer {
    overflow: hidden;
    width: 100px;
    height: 100px;
    background-color: rgb(0,238,228);
    border: 3px solid #000;
    border-radius: 50%;
}
.inner {
    height: 100%;
    line-height: 5.8;
    text-align: center;
    background-color: rgba(255,0,0,.5);
}
.transform {
    -webkit-transform: translate3d(10px,10px,0);
    transform: translate3d(10px,10px,0);
}
</style>
<html>
<div class=outer>
    <div class="inner transform">with transformdfdfdsfdsf</div>
</div>
</html>

While debugging this issue with the above html, <div class="inner transform"> is promoted to posZOrderList of <html> and gets a compositing layer. So, <html> also gets a compositing layer because of subtree reasons CompositingReasonClipsCompositingDescendants(as <div class="inner transform"> becomes child of <html> in pain-order). So, clippedByAncestor(RenderLayer* layer) for <div class="inner transform"> returns <html> element which is wrong. It should return <div class=outer> as clipping ancestor.

As per my understanding, <div class="inner transform"> should be child of <div class=outer> in paint-order and <div class=outer> should also get a compositing layer and  so that clipping works properly. 

Please correct me if my understanding is wrong.

Comment 17 by danakj@chromium.org, Jun 18 2013

Cc: jam...@chromium.org enne@chromium.org shawnsingh@chromium.org vollick@chromium.org
This is similar to https://code.google.com/p/chromium/issues/detail?id=137818 which was filed specifically for canvas.

Comment 18 by trchen@chromium.org, Jun 18 2013

Cc: trchen@chromium.org

Comment 19 by viktorli...@gmail.com, Jul 9 2013

@sanjoy...@samsung.com

Your comment about children getting promoted to a higher level higher than its parent led me to a workaround. All you have to do is to make the parent to also get promoted.

I had a border radius that werent honored when a child was rotated. All I did was to add a transform: rotate(0.000001deg) to the parent and it was promoted higher than the child and the border radius works.

Just to get stuff working while waiting for the bugfix.

Here is an example of my workaround. Click the clock to toggle the workaround.

http://jsfiddle.net/R8t4F/

Also duplicating the p tag and its content solves the problem for some reason?

Comment 21 by bugdroid1@chromium.org, Nov 21 2013

Project Member

Comment 22 by lme...@wiedes.nl, Sep 8 2014

@viktorli...@gmail.com: Thanks a lot, your tip lead me to trying `-webkit-transform: scale(1);` to the parent element with border-radius. With success, great workaround!

On Chrome 37 my problem was a child element jumping out of the parent element when for another element in the DOM (outside the parent) a CSS3 transform property was being transitioned. It seemed like `overflow: hidden;` on the parent temporarily had no effect.

On Chrome 39 Canary `overflow: hidden;` on the parent element seemed to have no effect at all.

(own ref: josefdettelbacher curvy)

Comment 23 by laforge@google.com, Jan 9 2015

Labels: -Cr-Blink-Rendering Cr-Blink-Layout
Migrate from Cr-Blink-Rendering to Cr-Blink-Layout

Comment 24 by Deleted ...@, Jan 13 2015

This issue was fixed, but has recently resurfaced. Is there any change to the CSS coding that we need to update, or is this an actual issue? I am not sure where to apply the `-webkit-transform: scale(1);` as the previous poster suggested.

My affected website (was previously okay in Chrome and Chrome mobile early last year): http://www.deadfishchronicles.com/gallery.php
chrome_bug.jpg
255 KB View Download

Comment 25 by hughiewi...@gmail.com, Jan 13 2015

To the poster above - to fix your issue, add "backface-visibility: hidden;" to your .lb-album li > a (line 18 of style-gal.css)

The issue I noticed was that the overflow: hidden; was being ignored, but only when it wasn't transitioning. During the animation, it was fine. Adding this property fixed that completely.

Comment 26 by Deleted ...@, Jan 13 2015

@Hughie Yes, that fixed it. Thank you for your reply, I did not know that about that property until now.

Comment 27 by phistuck@gmail.com, Jan 13 2015

The issue is not fixed, see the HTML from comment 4.
data:text/html;charset=utf8,<!DOCTYPE html><style> .outer { border: 4px solid #000; width: 100px; height: 100px; border-radius: 40px; overflow: hidden; } .inner { width: 80px; height: 80px; background-color: #aaf; padding: .5em; } .rotate3d { -webkit-transform: rotateY(0deg); } </style> <div class = "outer"> <div class = "inner">no transform</div> </div> <br> <div class = "outer"> <div class = "inner rotate3d">rotateY(0)</div> </div>

Comment 28 Deleted

Comment 29 by ask....@gmail.com, Jul 20 2015

The issue is still there.
Please, view this example: http://codepen.io/anon/pen/rVrgpR

Comment 30 by streltsy...@gmail.com, Jul 20 2015

My experiment with the latest example (http://codepen.io/SelenIT/pen/qdyzqR) suggests that there are 2 issues here that lead to the buggy behavior:

1) An element with 'border-radius' that makes a compositing layer but doesn't establish new stacking context doesn't clip its positioned content by the border-radius curve;

2) The compositing layer created for an invisible/zero height element can span to the adjacent visible element (are two elements with the same offsetTop considered overlapped?).

I can assume that the latter may be somehow related with the rendering optimization (although this behavior looks surprising and confusing). But the former seems clearly a bug.

Comment 31 by matthewyuan@chromium.org, Aug 10 2015

Labels: Hotlist-GPU-Fixit

Comment 32 by chrishtr@chromium.org, Oct 6 2015

Labels: -Type-Compat Type-Bug

Comment 33 by chrishtr@chromium.org, Oct 7 2015

Owner: chrishtr@chromium.org
Status: Assigned
Summary: border-radius clipping does not apply to composited children (was: css transform and transition break hidden overflow on border-radius)
The problem is that when descendants are composited, the border-radius above them is not applied.

One possible fix is to composite the parent which has the clip. We already do this for other cases.
Perhaps we just missed border-radius.

Comment 35 by junov@chromium.org, Oct 7 2015

Cc: danakj@chromium.org ligim...@chromium.org junov@chromium.org robertphillips@chromium.org rponnada@chromium.org ro...@adobe.com
 Issue 137818  has been merged into this issue.

Comment 36 by chrishtr@chromium.org, Oct 7 2015

The problem is harder than I thought. This is a case of clips without a stacking context, which is a mismatch with the code in CompositingRequirementsUpdater that
walks the tree in paint order.

Comment 37 by chrishtr@chromium.org, Oct 7 2015

Note: as expected, this is broken in Safari also.

Comment 38 by chrishtr@chromium.org, Oct 7 2015

Blockedon: chromium:471333
Unfortunately, it looks like fixing this bug will be too difficult and risky in the current compositing system. Either we can try to change CompositingRequirementsUpdater to pass along compositing requirements to child layers which are not stacking children, or augment the ancestorClippingLayer clipping layer to apply rounded rect clips via a mask layer in addition to its regular clip.

Neither is appetizing, considering the new system is coming Real Soon Now.

Comment 39 by chrishtr@chromium.org, Oct 7 2015

Owner: ----
Status: Available

Comment 40 by ajuma@chromium.org, Oct 7 2015

Cc: manoranj...@chromium.org sdayala@chromium.org nyerramilli@chromium.org chrishtr@chromium.org ajuma@chromium.org
 Issue 430184  has been merged into this issue.

Comment 41 by chrishtr@chromium.org, Oct 21 2015

 Issue 517670  has been merged into this issue.

Comment 42 by chrishtr@chromium.org, Oct 21 2015

Cc: dalecur...@chromium.org
 Issue 263662  has been merged into this issue.

Comment 43 by chrishtr@chromium.org, Oct 21 2015

 Issue 444700  has been merged into this issue.

Comment 44 by chrishtr@chromium.org, Oct 21 2015

Cc: creis@chromium.org kenrb@chromium.org
 Issue 513927  has been merged into this issue.

Comment 45 by chrishtr@chromium.org, Oct 21 2015

Cc: msrchandra@chromium.org
 Issue 439370  has been merged into this issue.

Comment 46 by zer...@gmail.com, Oct 28 2015

Instead of opening a bug report, I'll just add this here, because I suppose it's all the same problem.

Overflow: hidden also doesn't work when the child is a video, as probably expected.

Webkit bug for this specific use case -> https://bugs.webkit.org/show_bug.cgi?id=29824
Test http://codepen.io/anon/pen/meLxgm

Comment 47 by chrishtr@chromium.org, Oct 28 2015

Re #46: yes it's the same problem, since videos are composited.

Comment 48 by meade@chromium.org, Oct 29 2015

Yet another fiddle https://jsfiddle.net/e9sevjkh/

Comment 49 by meade@chromium.org, Oct 29 2015

Cc: schenney@chromium.org
 Issue 410054  has been merged into this issue.

Comment 50 by cbiesin...@chromium.org, Nov 2 2015

 Issue 332514  has been merged into this issue.

Comment 51 by chrishtr@chromium.org, Nov 2 2015

Cc: rnimmagadda@chromium.org
 Issue 520848  has been merged into this issue.

Comment 52 by chrishtr@chromium.org, Nov 3 2015

Owner: chrishtr@chromium.org
Status: Assigned
Assigning to myself. This is an important bug that we should fix as soon as we can.

Comment 53 by junov@chromium.org, Nov 11 2015

Cc: senorblanco@chromium.org kbr@chromium.org tkonch...@chromium.org
 Issue 237100  has been merged into this issue.

Comment 54 by chrishtr@chromium.org, Nov 30 2015

 Issue 520182  has been merged into this issue.

Comment 55 by vollick@chromium.org, Nov 30 2015

About #38 - I was tempted by making ACL fancier, but since we could have several nested overflow clips with border radius, I think we'll need something more general.

I'd also considered making the "clip parent" concept more general to handle this case, but this is pretty unappetizing, too (Wei was pointing out the scary implications for render surfaces).

Comment 56 by phistuck@chromium.org, Dec 8 2015

Blocking: chromium:471764

Comment 57 by dtapu...@chromium.org, Dec 10 2015

Labels: -Cr-Blink
Removing Cr-Blink from issues that already have Cr-Blink sub-label set.

Comment 58 by chrishtr@chromium.org, Mar 4 2016

Cc: timloh@chromium.org
 Issue 548679  has been merged into this issue.

Comment 59 by chrishtr@chromium.org, Mar 9 2016

Cc: pdr@chromium.org jbroman@chromium.org wangxianzhu@chromium.org
 Issue 187187  has been merged into this issue.

Comment 60 by chrishtr@chromium.org, Apr 6 2016

Update: we are going to fix this bug, but are currently blocking it on the 
slimming paint phase 2 project, which should fix it in a clean way.

Comment 61 by ajuma@chromium.org, Apr 18 2016

 Issue 601440  has been merged into this issue.

Comment 62 by chrishtr@chromium.org, Apr 18 2016

Summary: border-radius clipping without a stacking context does not apply to composited children (was: border-radius clipping does not apply to composited children)

Comment 63 by ajuma@chromium.org, Apr 19 2016

Cc: dcheng@chromium.org
 Issue 604380  has been merged into this issue.

Comment 64 by chrishtr@chromium.org, May 11 2016

Cc: brajkumar@chromium.org
 Issue 610711  has been merged into this issue.

Comment 65 by phistuck@chromium.org, May 11 2016

Labels: Hotlist-Interop
Since this works in Firefox (according to the original report) and in Internet Explorer 11 (I just tried. I have not tried Edge), this is an interoperability issue.

Comment 66 by chrishtr@chromium.org, Jun 14 2016

 Issue 449107  has been merged into this issue.

Comment 67 by chrishtr@chromium.org, Jun 24 2016

 Issue 619146  has been merged into this issue.

Comment 68 by chrishtr@chromium.org, Jul 8 2016

Owner: schenney@chromium.org
Stephen: sending to you since this is one of our top-starred bugs that needs to get fixed in Q3.

Comment 69 by trchen@chromium.org, Jul 9 2016

Note that we will need cc-side improvement for this to work for SPv2. It is desirable for SPv1 too.

There are a few issues, that combined, make it a hard problem.

1. border-radius is an overflow clip. That means it is inherited by containing block descendants, not paint descendants, and the "clip escaping" problem applies. This also means it is semantically a "raster clip" that applies to each applicable descendant individually at raster time, for example:

<div style="overflow:hidden; border-radius: 5px">
    <div>A</div>
    <div>B</div>
    <div>C</div>
</div>

= clip(A) + clip(B) + clip(C)

Where + stands for src-over compositing.

1.1. The infamous case "escaping clip that's applied to a painting ancestor".

<div style="overflow:hidden; border-radius: 5px; opacity:0.5;">
    <div>A</div>
    <div style="position:absolute">B</div>
    <div>C</div>
</div>

= opacity(clip(A) + B + clip(C))

1.2. Another infamous case "an element that's not my paint ancestor applied clip to me".

<div style="overflow:hidden; border-radius: 5px">
    <div>A</div>
    <div style="position:absolute">B</div>
    <div style="opacity:0.5;">C</div>
</div>

= clip(A) + B + opacity(clip(C))

2. Anti-alias rendering is preferred for rounded border, and anti-alias results in bleeding if we don't apply it to everything as a group. So this conversion is desirable:

Σclip(X_i) = clip(ΣX_i)

So for the example 1 above, we actually want to render it as clip(A + B + C).

3. Reuse of Stencil/mask is desirable. Today we implement rounded clip as an alpha mask. For the case of example 1.1., it would be the best if we can reuse the mask generated for clip(A) on clip(C).

Comment 70 by chrishtr@chromium.org, Jul 11 2016

@trchen: cases 1-3 are indeed problems, but:
(a) for better or worse the current compositing system approaches them in a particular
way, and we should be able to augment that system with some appropriate changes. I still think the approaches outlined in comment 38 should work.

(b) I'm not sure what you mean by "cc-side improvement" for SPv2. This topic was discussed
at length in these design documents:

https://docs.google.com/document/d/1Tzggk5iFfSIebUxUUWaa3UX_6Uo2yUPVh8AYAWLt05Q/edit
https://docs.google.com/document/d/1H_SfEixMCUUG5m3D0K1tc58xSVwNT3Sm1ak4V87qug0/edit
https://docs.google.com/document/d/1mRczt-Y8o_SX6oHPx9VLD0PEl4TtWgALwwyeBO3R9fI/edit

Is there something not captured there?

Comment 71 by chrishtr@chromium.org, Jul 28 2016

Brainstorm output:

1. Make a new child clipping mask layer in CompositedLayerMapping called m_ancestorClippingLayerMaskLayer
2. call m_ancestorClippingLayer->setMaskLayer(m_ancestorClippingLayerMaskLayer) under the same conditions in which m_childClippingMaskLayer is set
3. Set it to the same paint phase as m_childClippingMaskLayer
4. Set its bounds and offset from layout object to the same as m_ancestorClippingLayerMaskLayer
5. (tricky part) Add special code in CompositedLayerMapping::doPaintTask to paint w.r.t. the PaintLayer that owns
the mask, rather than the PaintLayer that owns the CompositedLayerMapping which owns the m_ancestorClippingLayer.
I think you can compute it by calling m_owningLayer.clippingContainer()

Comment 72 by schenney@chromium.org, Jul 29 2016

CSS Clip paths are probably also broken. And CSS mask. Need to test that.

Other things to test: Offsets? Add/Remove dynamically?

Comment 73 by vollick@chromium.org, Jul 29 2016

Neat idea! I think the approach in #71 neatly addresses the problem I was worried about in comment #55 by effectively combining a bunch of ancestor clipping layers into a single mask.

Comment 74 by schenney@chromium.org, Aug 8 2016

For my own tracking, 2 existing tests cover this:
compositing/overflow/respect-clip-for-non-composited-scrollers-when-prefering-compositing-over-lcd-text.html
fast/clip/overflow-border-radius-composited.html

Or putting it another way, both trigger my test for needing this bug fixed.

Comment 75 by schenney@chromium.org, Aug 9 2016

Currently looking at the tricky bit. The patch now applies the mask as expected, but the mask does not mask the layer that has the border-radius clipped overflow container and the result is wrong, as expected. I'm not clear whether we would get the right result if the mask is applied to the overflow hidden container layer because I'm not sure how that will then influence painting the child in its own entirely separate layer CLM. Investigation continues.

Comment 76 by ajuma@chromium.org, Aug 10 2016

Cc: loyso@chromium.org alancutter@chromium.org
 Issue 579481  has been merged into this issue.

Comment 77 by pdr@chromium.org, Sep 27 2016

Here's an example showing this bug affects clip-path too (but not clip?): http://jsbin.com/bogojib

Comment 78 by phistuck@gmail.com, Oct 13 2016

Is  issue 533047  pretty much a duplicate of this?

Comment 79 by schenney@chromium.org, Oct 13 2016

Re comment #78: Maybe. We'll see. Thanks for the pointer.

Comment 80 by senorblanco@chromium.org, Oct 24 2016

 Issue 533047  has been merged into this issue.

Comment 81 by schenney@chromium.org, Dec 8 2016

Blocking: 672561

Comment 82 by bugdroid1@chromium.org, Dec 12 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34

commit 0cfffd46dfaa1ee93d3d667f82b2fb3721078b34
Author: schenney <schenney@chromium.org>
Date: Mon Dec 12 23:16:47 2016

Fix border radius on composited children.

When a child of an overflow: hidden object is composited (and the ancestor is not) we were failing to apply the border-radius clip. This patch fixes the problem by adding a new masking layer for this situation, and modifying the layers used for painting to set the clip appropriately.

New tests are added to verify the behavior for border styles, and existing layout tests cover the bug (and fail before this patch). Unit testing is used for verifying update behavior.

There are remaining issues tracked in TODOs with corresponding bugs.

BUG= 157218 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2194273002
Cr-Commit-Position: refs/heads/master@{#437948}

[modify] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[add] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-styles-with-composited-child-expected.png
[add] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-styles-with-composited-child-expected.txt
[add] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-styles-with-composited-child.html
[add] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/LayoutTests/compositing/overflow/empty-composited-child-of-border-radius-ancestor-expected.html
[add] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/LayoutTests/compositing/overflow/empty-composited-child-of-border-radius-ancestor.html
[modify] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/LayoutTests/fast/borders/border-radius-with-composited-child.html
[modify] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-radius-with-composited-child-expected.png
[modify] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-radius-with-composited-child-expected.txt
[modify] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/LayoutTests/platform/linux/fast/clip/overflow-border-radius-composited-expected.png
[modify] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-radius-with-composited-child-expected.png
[modify] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-radius-with-composited-child-expected.txt
[modify] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/LayoutTests/platform/mac/fast/clip/overflow-border-radius-composited-expected.png
[modify] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-radius-with-composited-child-expected.png
[modify] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-radius-with-composited-child-expected.txt
[modify] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/LayoutTests/platform/win/fast/clip/overflow-border-radius-composited-expected.png
[modify] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h
[modify] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp
[modify] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/Source/core/paint/FilterPainter.cpp
[modify] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/Source/core/paint/LayerClipRecorder.cpp
[modify] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/Source/core/paint/LayerClipRecorder.h
[modify] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/Source/core/paint/PaintLayerClipper.h
[modify] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/Source/core/paint/PaintLayerPaintingInfo.h
[modify] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/Source/platform/graphics/CompositingReasons.cpp
[modify] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/Source/platform/graphics/CompositingReasons.h
[modify] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34/third_party/WebKit/Source/platform/graphics/GraphicsLayerClient.h

Comment 83 by phistuck@gmail.com, Dec 13 2016

Woo-hoo! :)

Comment 84 by senorblanco@chromium.org, Dec 13 2016

\o/

Comment 85 by bugdroid1@chromium.org, Dec 13 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed8391042f4acb62c7c89898e8dad01f8afb79e4

commit ed8391042f4acb62c7c89898e8dad01f8afb79e4
Author: schenney <schenney@chromium.org>
Date: Tue Dec 13 18:36:56 2016

Revert "Fix border radius on composited children."

This reverts commit https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34

Chrome's sign-in flow is broken as a result of this patch.
Content inside an element with border-radius is not rendering.

Reverted review URL: https://codereview.chromium.org/2194273002

TBR=chrishtr@chromium.org
BUG= 157218 , 673668 ,673725
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2569253002
Cr-Commit-Position: refs/heads/master@{#438234}

[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[delete] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-styles-with-composited-child-expected.png
[delete] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-styles-with-composited-child-expected.txt
[delete] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-styles-with-composited-child.html
[delete] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/third_party/WebKit/LayoutTests/compositing/overflow/empty-composited-child-of-border-radius-ancestor-expected.html
[delete] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/third_party/WebKit/LayoutTests/compositing/overflow/empty-composited-child-of-border-radius-ancestor.html
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/LayoutTests/fast/borders/border-radius-with-composited-child.html
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-radius-with-composited-child-expected.png
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-radius-with-composited-child-expected.txt
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/LayoutTests/platform/linux/fast/clip/overflow-border-radius-composited-expected.png
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-radius-with-composited-child-expected.png
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-radius-with-composited-child-expected.txt
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/LayoutTests/platform/mac/fast/clip/overflow-border-radius-composited-expected.png
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-radius-with-composited-child-expected.png
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-radius-with-composited-child-expected.txt
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/LayoutTests/platform/win/fast/clip/overflow-border-radius-composited-expected.png
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/Source/core/paint/FilterPainter.cpp
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/Source/core/paint/LayerClipRecorder.cpp
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/Source/core/paint/LayerClipRecorder.h
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/Source/core/paint/PaintLayerClipper.h
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/Source/core/paint/PaintLayerPaintingInfo.h
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/Source/platform/graphics/CompositingReasons.cpp
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/Source/platform/graphics/CompositingReasons.h
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/Source/platform/graphics/GraphicsLayerClient.h

Comment 86 by bugdroid1@chromium.org, Dec 13 2016

Project Member
Labels: merge-merged-2950
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58d839ef5c55dd8d388137a55a0bdbc8c57673c3

commit 58d839ef5c55dd8d388137a55a0bdbc8c57673c3
Author: Stephen Chenney <schenney@chromium.org>
Date: Tue Dec 13 19:14:40 2016

Revert "Fix border radius on composited children." on 2950 branch

This reverts commit https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34

Chrome's sign-in flow is broken as a result of this patch.
Content inside an element with border-radius is not rendering.

Reverted review URL: https://codereview.chromium.org/2194273002

TBR=chrishtr@chromium.org
BUG= 157218 , 673668 ,673725
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2569253002
Cr-Commit-Position: refs/heads/master@{#438234}
(cherry picked from commit ed8391042f4acb62c7c89898e8dad01f8afb79e4)

Conflicts:
	third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2

Review-Url: https://codereview.chromium.org/2571743003 .
Cr-Commit-Position: refs/branch-heads/2950@{#6}
Cr-Branched-From: 2c3ecceea409b42c873949bac0aa1acaa80451e3-refs/heads/master@{#438011}

[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[delete] https://crrev.com/e67f9b3395c12f01747246a5fc44836e34b510bd/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-styles-with-composited-child-expected.png
[delete] https://crrev.com/e67f9b3395c12f01747246a5fc44836e34b510bd/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-styles-with-composited-child-expected.txt
[delete] https://crrev.com/e67f9b3395c12f01747246a5fc44836e34b510bd/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-styles-with-composited-child.html
[delete] https://crrev.com/e67f9b3395c12f01747246a5fc44836e34b510bd/third_party/WebKit/LayoutTests/compositing/overflow/empty-composited-child-of-border-radius-ancestor-expected.html
[delete] https://crrev.com/e67f9b3395c12f01747246a5fc44836e34b510bd/third_party/WebKit/LayoutTests/compositing/overflow/empty-composited-child-of-border-radius-ancestor.html
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/LayoutTests/fast/borders/border-radius-with-composited-child.html
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-radius-with-composited-child-expected.png
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-radius-with-composited-child-expected.txt
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/LayoutTests/platform/linux/fast/clip/overflow-border-radius-composited-expected.png
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-radius-with-composited-child-expected.png
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-radius-with-composited-child-expected.txt
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/LayoutTests/platform/mac/fast/clip/overflow-border-radius-composited-expected.png
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-radius-with-composited-child-expected.png
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-radius-with-composited-child-expected.txt
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/LayoutTests/platform/win/fast/clip/overflow-border-radius-composited-expected.png
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/Source/core/paint/FilterPainter.cpp
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/Source/core/paint/LayerClipRecorder.cpp
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/Source/core/paint/LayerClipRecorder.h
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/Source/core/paint/PaintLayerClipper.h
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/Source/core/paint/PaintLayerPaintingInfo.h
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/Source/platform/graphics/CompositingReasons.cpp
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/Source/platform/graphics/CompositingReasons.h
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/Source/platform/graphics/GraphicsLayerClient.h

Comment 87 by schenney@chromium.org, Dec 14 2016

 Issue 673217  has been merged into this issue.

Comment 88 by schenney@chromium.org, Dec 14 2016

 Issue 673113  has been merged into this issue.

Comment 89 by bugdroid1@chromium.org, Jan 5 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e

commit d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e
Author: schenney <schenney@chromium.org>
Date: Thu Jan 05 05:58:45 2017

Fix border radius on composited children.

When a child of an overflow: hidden object is composited (and the ancestor is not) we were failing to apply the border-radius clip. This patch fixes the problem by adding a new masking layer for this situation, and modifying the layers used for painting to set the clip appropriately.

New tests are added to verify the behavior for border styles, and existing layout tests cover the bug (and fail before this patch). Unit testing is used for verifying update behavior.

There are remaining issues tracked in TODOs with corresponding bugs.

Reworked patch https://codereview.chromium.org/2194273002

BUG= 157218 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2588853002
Cr-Commit-Position: refs/heads/master@{#441592}

[modify] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[add] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-styles-with-composited-child-expected.png
[add] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-styles-with-composited-child-expected.txt
[add] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-styles-with-composited-child.html
[add] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/LayoutTests/compositing/overflow/empty-composited-child-of-border-radius-ancestor-expected.html
[add] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/LayoutTests/compositing/overflow/empty-composited-child-of-border-radius-ancestor.html
[add] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/LayoutTests/compositing/overflow/siblings-composited-with-border-radius-ancestor-expected.png
[add] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/LayoutTests/compositing/overflow/siblings-composited-with-border-radius-ancestor-expected.txt
[add] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/LayoutTests/compositing/overflow/siblings-composited-with-border-radius-ancestor.html
[add] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/LayoutTests/compositing/overflow/siblings-with-border-radius-ancestor-expected.png
[add] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/LayoutTests/compositing/overflow/siblings-with-border-radius-ancestor-expected.txt
[add] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/LayoutTests/compositing/overflow/siblings-with-border-radius-ancestor.html
[modify] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/LayoutTests/fast/borders/border-radius-with-composited-child.html
[modify] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-radius-with-composited-child-expected.png
[modify] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-radius-with-composited-child-expected.txt
[modify] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/LayoutTests/platform/linux/fast/clip/overflow-border-radius-composited-expected.png
[modify] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-radius-with-composited-child-expected.png
[modify] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-radius-with-composited-child-expected.txt
[modify] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/LayoutTests/platform/mac/fast/clip/overflow-border-radius-composited-expected.png
[modify] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-radius-with-composited-child-expected.png
[modify] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-radius-with-composited-child-expected.txt
[modify] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/LayoutTests/platform/win/fast/clip/overflow-border-radius-composited-expected.png
[modify] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h
[modify] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp
[modify] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/Source/core/paint/FilterPainter.cpp
[modify] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/Source/core/paint/LayerClipRecorder.cpp
[modify] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/Source/core/paint/LayerClipRecorder.h
[modify] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/Source/core/paint/PaintLayerPainter.h
[modify] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/Source/core/paint/PaintLayerPaintingInfo.h
[modify] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/Source/platform/graphics/CompositingReasons.cpp
[modify] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/Source/platform/graphics/CompositingReasons.h
[modify] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e/third_party/WebKit/Source/platform/graphics/GraphicsLayerClient.h

Comment 90 by schenney@chromium.org, Jan 18 2017

Cc: hdodda@chromium.org
 Issue 682062  has been merged into this issue.

Comment 91 by sshru...@google.com, Jan 23 2017

It looks like this bug is being actively worked on. schenney@, could you please give a quick update on what the current status/plan is? Predictability program has set an OKR to gain traction on the top 50 starred bugs this quarter: either by closing them, stating what milestone the fix will ship, or setting a NextAction date so that we know when to check back in.

Comment 92 by schenney@chromium.org, Jan 24 2017

The bug is fixed for the most important cases. We just have a memory optimization in progress. The fix is the one referenced in Comment #89, so it has made the m57 branch.

Comment 93 by schenney@chromium.org, Jan 24 2017

Status: Fixed (was: Assigned)

Comment 94 by chrishtr@chromium.org, Jan 25 2017

 Issue 684778  has been merged into this issue.

Comment 95 Deleted

Comment 96 by schenney@chromium.org, Feb 28 2017

 Issue 696511  has been merged into this issue.

Sign in to add a comment