New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 155871 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Chrome: Crash Report - Stack Signature: extensions::AppRestoreService::RestoreApps(...

Project Member Reported by dharani@google.com, Oct 15 2012

Issue description

This is due to http://src.chromium.org/viewvc/chrome?view=rev&revision=161827

Product: Chrome
Stack Signature: extensions::AppRestoreService::RestoreApps()-23465C3
New Signature Label: extensions::AppRestoreService::RestoreApps()
New Signature Hash: da888cac_0c08611e_237ab9f6_8803f8d5_1f39f680

Report link: http://go/crash/reportdetail?reportid=2d5c438ad23a729f

Meta information:
Product Name: Chrome
Product Version: 24.0.1296.0
Report ID: 2d5c438ad23a729f
Report Time: 2012/10/15 16:11:15, Mon
Uptime: 1 sec
Cumulative Uptime: 0 sec
OS Name: Windows NT
OS Version: 6.1.7601 Service Pack 1
CPU Architecture: x86
CPU Info: GenuineIntel family 6 model 23 stepping 10
ptype: browser


Thread 0 *CRASHED* ( EXCEPTION_ACCESS_VIOLATION_READ @ 0x00000018 )

0x5f31051e	 [chrome.dll]	 - app_restore_service.cc:39 (cs|src|ann)]	extensions::AppRestoreService::RestoreApps()
0x5e152c8c	 [chrome.dll]	 - startup_browser_creator_impl.cc:648 (cs|src|ann)]	StartupBrowserCreatorImpl::ProcessStartupURLs(std::vector<GURL,std::allocator<GURL> > const &)
0x5e152972	 [chrome.dll]	 - startup_browser_creator_impl.cc:585 (cs|src|ann)]	StartupBrowserCreatorImpl::ProcessLaunchURLs(bool,std::vector<GURL,std::allocator<GURL> > const &)
0x5e15103a	 [chrome.dll]	 - startup_browser_creator_impl.cc:388 (cs|src|ann)]	StartupBrowserCreatorImpl::Launch(Profile *,std::vector<GURL,std::allocator<GURL> > const &,bool)
0x5e14fa6d	 [chrome.dll]	 - startup_browser_creator.cc:203 (cs|src|ann)]	StartupBrowserCreator::LaunchBrowser(CommandLine const &,Profile *,FilePath const &,chrome::startup::IsProcessStartup,chrome::startup::IsFirstRun,int *)
0x5e14d7cc	 [chrome.dll]	 - startup_browser_creator.cc:484 (cs|src|ann)]	StartupBrowserCreator::ProcessCmdLineImpl(CommandLine const &,FilePath const &,bool,Profile *,std::vector<Profile *,std::allocator<Profile *> > const &,int *,StartupBrowserCreator *)
0x5dedf384	 [chrome.dll]	 - chrome_browser_main.cc:1402 (cs|src|ann)]	ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
0x5dede726	 [chrome.dll]	 - chrome_browser_main.cc:902 (cs|src|ann)]	ChromeBrowserMainParts::PreMainMessageLoopRun()
0x5dede66a	 [chrome.dll]	 - chrome_browser_main_win.cc:223 (cs|src|ann)]	ChromeBrowserMainPartsWin::PreMainMessageLoopRun()
0x5de695e7	 [chrome.dll]	 - browser_main_loop.cc:449 (cs|src|ann)]	content::BrowserMainLoop::CreateThreads()
0x5de5fc4e	 [chrome.dll]	 - browser_main_runner.cc:109 (cs|src|ann)]	`anonymous namespace'::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const &)
0x5de5fa1a	 [chrome.dll]	 - browser_main.cc:17 (cs|src|ann)]	BrowserMain(content::MainFunctionParams const &)
0x5dde8230	 [chrome.dll]	 - content_main_runner.cc:448 (cs|src|ann)]	content::RunNamedProcessTypeMain(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,content::MainFunctionParams const &,content::ContentMainDelegate *)
0x5dde81b7	 [chrome.dll]	 - content_main_runner.cc:741 (cs|src|ann)]	content::ContentMainRunnerImpl::Run()
0x5ddda61a	 [chrome.dll]	 - content_main.cc:35 (cs|src|ann)]	content::ContentMain(HINSTANCE__ *,sandbox::SandboxInterfaceInfo *,content::ContentMainDelegate *)
0x5ddda5a6	 [chrome.dll]	 - chrome_main.cc:28 (cs|src|ann)]	ChromeMain
0x01305224	 [chrome.exe]	 - client_util.cc:440 (cs|src|ann)]	MainDllLoader::Launch(HINSTANCE__ *,sandbox::SandboxInterfaceInfo *)
0x013078f7	 [chrome.exe]	 - chrome_exe_main_win.cc:76 (cs|src|ann)]	RunChrome(HINSTANCE__ *)
0x01307962	 [chrome.exe]	 - chrome_exe_main_win.cc:92 (cs|src|ann)]	wWinMain
0x0136046c	 [chrome.exe]	 - crt0.c:275]	__tmainCRTStartup
0x76a0ed6b	 [kernel32.dll]	 + 0x0004ed6b]	BaseThreadInitThunk
0x77bd377a	 [ntdll.dll]	 + 0x0006377a]	__RtlUserThreadStart
0x77bd374d	 [ntdll.dll]	 + 0x0006374d]	_RtlUserThreadStart
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 16 2012

Summary: Chrome: Crash Report - Stack Signature: extensions::AppRestoreService::RestoreApps(...
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=162083

------------------------------------------------------------------------
r162083 | koz@chromium.org | 2012-10-16T06:33:10.463778Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/startup/startup_browser_creator_impl.cc?r1=162083&r2=162082&pathrev=162083

Prevent app restore from happening on restart when user is in incognito mode.

BUG= 155871 
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/11143034
------------------------------------------------------------------------

Comment 2 by koz@chromium.org, Oct 16 2012

Status: Fixed

Comment 3 by dharani@google.com, Oct 19 2012

I see a slightly different crash - https://crash.corp.google.com/reportdetail?reportid=3bda60fc3f3fb332#crashing_thread

Is this related to this bug?

Comment 4 by koz@chromium.org, Oct 21 2012

It is related - the original crasher obscured this one. I've got a patch in the commit queue to fix this one as well.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 21 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=163204

------------------------------------------------------------------------
r163204 | koz@chromium.org | 2012-10-21T13:56:23.438402Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/app_restore_service.cc?r1=163204&r2=163203&pathrev=163204

Handle null Extension*s in AppRestoreService.


BUG= 155871 
TBR=benwells@chromium.org

Review URL: https://chromiumcodereview.appspot.com/11231033
------------------------------------------------------------------------

Comment 6 by dharani@google.com, Oct 25 2012

Status: Assigned
This is still happening :( in 1305.3 build which has your latest fix - https://crash.corp.google.com/reportdetail?reportid=d4a8a204c951480c#crashing_thread

Comment 7 by koz@chromium.org, Oct 25 2012

Cc: koz@chromium.org
Owner: benwells@chromium.org
Ah, this is a different, but related crash. benwells@ could you add the NULL check at the appropriate place for me? I won't be able to fix this for a few days.

Comment 8 by benwells@google.com, Oct 25 2012

yeap i'll have a looksy.
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 25 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=164035

------------------------------------------------------------------------
r164035 | benwells@chromium.org | 2012-10-25T09:33:21.829310Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/app_restore_service.cc?r1=164035&r2=164034&pathrev=164035

Add NULL check to AppRestoreService

Turns out extension hosts can have their extensions become NULL in some cases, e.g. the extension is unloaded.

TBR=koz@chromium.org

BUG= 155871 

Review URL: https://codereview.chromium.org/11275031
------------------------------------------------------------------------
Status: Fixed
That should be fixed but if there are more, reopen.
Cc: benwells@chromium.org
Issue 157972 has been merged into this issue.
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Mstone-24 -Feature-Extensions Cr-Platform-Extensions M-24

Sign in to add a comment