New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 15558 link

Starred by 27 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Apr 2010
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocked on:
issue 14756

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

Add Hungarian dictionary after verifying quality

Reported by szenf...@gmail.com, Jun 29 2009

Issue description

Chrome Version       : 3.0.189.0 same problem for 2.x
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
     Safari 4: N/A
  Firefox 3.x: OK
         IE 7: N/A
         IE 8: N/A

What steps will reproduce the problem?
1. Try to choose hungarian dictionary for spellcheck


What is the expected result?
Able to select hungarian spellcheck from chrome

What happens instead?
Hungarian spellcheck missing from chrome.


 

Comment 1 by xlyuan@chromium.org, Jun 29 2009

Labels: -Type-Bug -Area-Misc Type-Feature Area-BrowserUI
Status: Untriaged

Comment 2 by brettw@chromium.org, Jun 29 2009

Status: Available
Summary: Add Hungarian dictionary after verifying quality
We evaluated the Hungarian dictionary and whoever checked it found it to be not good 
enough to bother distributing. We should probably re-evaluate the latest version to see 
if it can be implemented. This may be blocked on updating to the latest version of 
Hunspell.

Comment 3 by szenf...@gmail.com, Jun 30 2009

Check the firefox hunspell plugin. That is great. Maybe that could give you some
direction.

Comment 4 by js...@chromium.org, Jul 1 2009

Blockedon: 14756

Comment 5 by mhm@chromium.org, Aug 1 2009

Comment 6 by syp...@gmail.com, Aug 31 2009

Hungarian language widely uses agglutination, therefore it needs much more memory than 
e.g. English spell checking. We need it badly, though :(

Comment 7 by szenf...@gmail.com, Aug 31 2009

When will you plan to implement the hungarian dictionary?
We plan to implement it once we upgrade to newest hunspell version, soon :)

Comment 9 by syp...@gmail.com, Oct 25 2009

"Soon" was like 2 months ago. Is there still any problem with including it?

Comment 11 by szenf...@gmail.com, Oct 27 2009

So when will this option available? It could be great. I could start using the
browser continously.

Comment 12 by Deleted ...@, Nov 10 2009

Please provide at least a status update so we can set our expectations accordingly. For 
me personally, this is a must to have before switching to Chrome.

Comment 13 by hbono@chromium.org, Nov 12 2009

Sorry for our slow updates and inconveniences.
Currently, we have been discussing how to evaluate new spell-check dictionaries, 
including Hungarian.

Regards,

Comment 14 Deleted

Comment 15 Deleted

This is a hack -> download the dictionary tool to convert the .dic .aff files into 
the 
chrome's .bdic format.

// This tool converts Hunspell .aff/.dic pairs to a combined binary dictionary
// format (.bdic). This format is more compact, and can be more efficiently
// read by the client application.
//
// We do this conversion manually before publishing dictionary files. It is not
// part of any build process.

src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/convert_dict/convert_dict.cc?
view=markup

int PrintHelp() {
  printf("Usage: convert_dict <dicfile base name>\n\n");
  printf("Example:\n");
  printf("  convert_dict en-US\nwill read en-US.dic / en-US.aff and\n");
  printf("generate en-US.bdic\n\n");
  return 1;
}

and get the 1.5 data files from here (or 1.4) ->

sourceforge.net/projects/magyarispell/files/Magyar%20Ispell/1.5/hu_HU-
1.5.tar.gz/download

\chromium\src\chrome\browser\spellchecker.cc

static const struct {
// The language.
const char* language;

// The corresponding language and region, used by the dictionaries.
const char* language_region;
} g_supported_spellchecker_languages[] = {
{"en-US", "en-US"},
{"en-GB", "en-GB"},
{"en-AU", "en-AU"},
{"fr", "fr-FR"},
...
{"pl", "pl-PL"},
// {"th", "th-TH"}, // Not to be included in Spellchecker as per B=1277824
{"sv", "sv-SE"},
...
// {"hu", "hu-HU"}, // Not to be included in Spellchecker as per B=1277824
{"he", "he-IL"},

This is a bug id, or what B=1277824 ?
piszes
Megírtam a dolgot a Hunspell csomag fejlesztőjének Németh Lászlónak. Ez volt a 
válasza ->

Németh László to me

Szia Péter!

Köszönöm szépen a levelet és a nyomozást! Ennél többet, ami a blogon
van, én sem tudok. Remélem, hogy megoldják hamarosan.

Egyébként volt már olyan, hogy az utólagos "optimalizálás" eredménye
az lett, hogy a magyar szótárral nem működött együtt a foltozott
Hunspell. A Go-oo OpenOffice.org-ág novelles fejlesztői inkább
visszavonták a foltjukat, hogy ne sérüljön 
a magyar helyesírás-ellenőrzés.

Üdvözlettel:
Laci

Comment 18 by oritm@chromium.org, Dec 18 2009

Labels: -Area-BrowserUI Area-UI-Features
Area-UI-Features label replaces Area-BrowserUI label

Comment 19 by nyen...@gmail.com, Jan 12 2010

Could you give an update on this issue?

Is there a way an external developer could help moving it forward?

Comment 20 by syp...@gmail.com, Jan 28 2010

Now that 4.0 is out, I hope you can find the resources to tackle this issue.

Comment 21 by hbono@chromium.org, Jan 29 2010

Sorry for the lack of updates.
These days, I have been looking into problems of Hungarian dictionaries created with our convert_dict program. For 
example, when we create a Hungarian dictionary from the one downloaded from 
<http://sourceforge.net/projects/magyarispell/>, it somehow marks some basic Hungarian words (e.g. "a", "hogy", etc.) 
as misspelled. A change that fixes the above problem is currently under review: <http://codereview.chromium.org/553087/show>.

Regards,
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=37816 

------------------------------------------------------------------------
r37816 | hbono@chromium.org | 2010-02-02 02:02:26 -0800 (Tue, 02 Feb 2010) | 11 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=37816&r2=37815
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/convert_dict/aff_reader.cc?r1=37816&r2=37815
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/convert_dict/convert_dict_unittest.cc
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/convert_dict/dic_reader.cc?r1=37816&r2=37815
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/convert_dict/hunspell_reader.cc?r1=37816&r2=37815

The first step towards supporting the Hungarian spell-checking dictionary.
This change fixes a couple of problems needed for using a Hungarian dictionary in Chrome.
1. Use TrimWhitespace() in TrimLine()
Sorry, this is caused by my mistake that used TrimWhiteSpaceUTF8() without checking it deeply.
2. Replace morphing rules with compound rules.
it seems existing Hungarian dictionaries use (language-specific) morphing rules to handle words that have both prefixes and suffixes, e.g. "legjobb" (best). It is better to replace such (language-dependent) morphing rules with (language-independent) compound rules to avoid language-specific issues. (As far as I tested, this change fixes many quality problems caused by Hungarian compounds.)
This change also adds simple tests for our dictionary converter.

BUG= 15558 
TEST=unit_test --gtest_filter=ConvertDictTest*
Review URL: http://codereview.chromium.org/553087
------------------------------------------------------------------------

Labels: -Area-UI-Features Area-UI
So, what is the newest status?
I'm curious for it too... I use it more than 20 place, where I suggested to swith to 
it... (some offices...) so please :)
when will be downloadable?
On Thu, Mar 4, 2010 at 6:38 PM,  <sze...@gmail.com> wrote:
> when will be downloadable?

We have been updating several spellchecker dictionaries (including Hungarian) these days. When we finish updating all 
dictionaries, these dictionaries will be available from Chrome.
Sorry for your inconveniences.

Regards,
Will this dictionary available as a standalon dictionary? I would like to use it in
stable 4.x chrome as well.
May I ask, that if I have 30 clients in a LAN, and all of these uses Chrome, and I must 
manually change Spell-Checket lang ? Is it possible, that Chrome change it on it's own, 
if the computer's location is Hungary ?

(Thanks the anwser)
On Fri, Mar 5, 2010 at 2:03 AM,  <rol...@gmail.com> wrote:

> Comment #30 on  issue 15558  by rol...: Add Hungarian dictionary after verifying quality
> http://code.google.com/p/chromium/issues/detail?id=15558
>
> May I ask, that if I have 30 clients in a LAN, and all of these uses Chrome,
> and I must manually change Spell-Checket lang ? Is it possible, that Chrome
> change it on it's own, if the computer's location is Hungary?

Thank you for your feedback.
As you know, Chrome automatically changes its UI language according to the OS language, i.e. if Chrome is running on 
the Hungarian version of Windows (Mac or Linux), its UI language automatically becomes Hungarian. Same as the UI 
language, we are going to change the default spell-checker language to Hungarian if Chrome is running on the Hungarian 
version of Windows (Mac or Linux). It is definitely helpful to give me your feedback whether or not this option is 
suitable for you.

Regards,
What will happen with the already installed stable versions? How the stable version
will be able to use the hungarian dictionary?

There will be a patch or is it possible to download the dictionary file separately?
On Fri, Mar 5, 2010 at 3:54 PM,  <sze...@gmail.com> wrote:
> Comment #32 on  issue 15558  by sze...: Add Hungarian dictionary after verifying quality
> http://code.google.com/p/chromium/issues/detail?id=15558
>
> What will happen with the already installed stable versions? How the stable
> version will be able to use the hungarian dictionary?
> There will be a patch or is it possible to download the dictionary file
> separately?

Unfortunately, as written in comment 16, we need to change some more Chromium code to use this dictionary. 
That is, we cannot use this dictionary even though we download it.

By the way, writing more comments here prevents us from spending time in writing Chromium changes. Spending 
less time in writing Chromium changes makes its release later. So, it is definitely helpful for us to focus on 
writing Chromium changes so we can release it earlier.

Regards,
Hi,

If you can't wait then try this little nasty hack -> download the hungarian bdic file
 
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/hunspell128/dictionaries
/hu-HU-2-0.bdic

to here c:\Documents and Settings\peter\Local Settings\Application 
Data\Google\Chrome\Application\Dictionaries\

because now we can't choose 'Magyar' from the Spell-checker language combo -> we have 
to make a little hack. Rename the file to ro-RO-1-2.bdic then choose 'Romanian' from 
the combo box and BINGO.

I was type 'almáspito' then see the attached photo :-)

*** ONLY FOR TESTING PURPOSE ***

lang-hu.png
15.8 KB View Download

Comment 35 Deleted

Comment 36 Deleted

If you can't wait but can build from the sources -> then you will know what to do 
here ;-)

/trunk/src/chrome/common/spellcheck_common.cc

namespace SpellCheckCommon {

static const struct {
  // The language.
  const char* language;

  // The corresponding language and region, used by the dictionaries.
  const char* language_region;
} g_supported_spellchecker_languages[] = {

  // Several languages are not to be included in the spellchecker list:
  //   th-TH, hu-HU, bg-BG, uk-UA

  {"ca", "ca-ES"},
  {"cs", "cs-CZ"},
  {"da", "da-DK"},
  {"de", "de-DE"},
  {"el", "el-GR"},
  {"en-AU", "en-AU"},
  {"en-GB", "en-GB"},
  {"en-US", "en-US"},
  {"es", "es-ES"},
...
  {"vi", "vi-VN"},
};

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=40887 

------------------------------------------------------------------------
r40887 | hbono@chromium.org | 2010-03-08 01:00:48 -0800 (Mon, 08 Mar 2010) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=40887&r2=40886

Pulls the Hungarian dictionary.
This change pulls the Hungarian dictionary added as r40614 to the Chromium source tree.

BUG= 15558 
TEST=http://codereview.chromium.org/661460
Review URL: http://codereview.chromium.org/668054
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=41562 

------------------------------------------------------------------------
r41562 | hbono@chromium.org | 2010-03-14 20:43:58 -0700 (Sun, 14 Mar 2010) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/spellcheck_common.cc?r1=41562&r2=41561
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/spellchecker/spellcheck_unittest.cc?r1=41562&r2=41561

Uses the new spellchecker dictionaries on Chromium.
This change enables Chromium users to use the new spellchecker dictionaries added by r39400, r40614, and r41000. This change also adds a unit test for Hungarian and rebaselines the unit test for Romanian. As written in  Issue 33024 , the correct Romanian characters are U+0219 and U+021B even though our old Romanian dictionary uses U+015F and U+0163. So, this change rebaselined to use the correct Romanian characters.

BUG= 8397 , 15558 , 33024 
TEST=unit_test.exe --gtest_filter=SpellCheckTest.SpellCheckText
Review URL: http://codereview.chromium.org/661460
------------------------------------------------------------------------

Comment 41 by hbono@chromium.org, Mar 16 2010

Sorry for my slow updates.
The latest Chromium snapshots (*1) now includes the Hungarian and the Romanian 
spellchecker dictionaries. Also it updates the Russian dictionary to add words. It is 
definitely helpful to try the snapshots and give us your feedback.

(*1) http://build.chromium.org/buildbot/snapshots/

Regards,
Yep, now this is live in the dev branch :-) 

Just a little more info.

Németh fsf László to me

Szia Péter!

Köszönöm a jó hírt! Valószínűleg köze lehet a Hunspell 1.2.9-es hibajavító kiadásához 
is, amiben azt hiszem, a Google által küldött foltokat is integrált Caolan McNamara a 
Red Hat Linuxtól. (Ő nemrégiben csatlakozott a Hunspell fejlesztéshez, de már 
korábban is sok foltot küldött.) A következő kiadás (illetve a fejlesztői forrásfa) 
tartalmaz egy-két újdonságot, amiről itt 
írtam:http://blog.fsf.hu/2010/03/04/hunspell-1-2-9/

Remélem, hogy hamarosan ki tudom próbálni a Chrome-t.

Üdvözlettel:
Laci

chrome-hun-spellcheck.png
19.5 KB View Download

Comment 43 Deleted

Comment 44 Deleted

if you use linux, that dictionary is:
~/.config/google-chrome/Dictionaries
than follow the balla.peter's instructions; it worked for me... thanks
Status: Fixed
Project Member

Comment 47 by bugdroid1@chromium.org, Oct 12 2012

Blockedon: -chromium:14756
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 48 by bugdroid1@chromium.org, Mar 11 2013

Labels: -Area-UI Cr-UI

Sign in to add a comment