New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 155388 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"Create application shortcuts" displays chrome in full-screen'ish mode

Reported by pavanv@chromium.org, Oct 11 2012

Issue description

Version: 23.0.1271.32
OS: Win8

What steps will reproduce the problem?
1. launch chrome metro and navigate to any page
2. select menu -> More tools -> create application shortcuts
3. Select all three options from the dialog (I don't think selection matters)

What is the expected output? What do you see instead?
New application window (frameless) appears as if in full-screen. Notice that top-down swipe only seems to be switching between full screen and normal modes while window remains the same (tabstrip/omnibox not visible)

Note: the main problem could be that new application shortcut opens a different window which is not handled in chrome metro.
 
Would be awesome if you could upload a screenshot for this one as well. Thank you!

Comment 2 by pavanv@chromium.org, Oct 11 2012

I understand that this feature may be heading for removal (refer the bug below), which moots the issue. But since we don't have conclusion on the feature yet, I will leave this bug open.

http://code.google.com/p/chromium/issues/detail?id=126196
Ah, good point. We're going to remove it in Metro in M24, indeed. Let's temporarily leave this open for now nevertheless.

Comment 4 by pavanv@chromium.org, Oct 11 2012

Chrome panels are also behaving the same way, though panels were supposed to open as pop-ups per - http://code.google.com/p/chromium/issues/detail?id=130187

calendar panel app: https://chrome.google.com/webstore/search/calendar?utm_source=chrome-ntp-icon
Owner: ananta@chromium.org
Status: Assigned
Sigh, this is a bad regression. Ananta, can you look at this tomorrow and see whether you can figure it out? Oddly, this doesn't happen when you create application shortcuts from the right-click menu on the NTP.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 17 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=162290

------------------------------------------------------------------------
r162290 | ananta@chromium.org | 2012-10-17T00:33:21.321711Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/extensions/application_launch.cc?r1=162290&r2=162289&pathrev=162290

Attempt to reuse an existing Browser instance for application launches in Chrome on Windows 8 Metro mode.

BUG= 155388 
R=mihaip
Review URL: https://codereview.chromium.org/11191017
------------------------------------------------------------------------

Comment 7 by ananta@chromium.org, Oct 17 2012

Labels: Merge-Requested

Comment 8 by ananta@chromium.org, Oct 17 2012

Status: Fixed

Comment 9 by kareng@google.com, Oct 18 2012

this went to canary and didn't break the world right? :)
yes. If it makes you feel any better, this is Windows 8 metro specific.

Comment 11 by kareng@google.com, Oct 18 2012

Labels: -Merge-Requested Merge-Approved
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 18 2012

Labels: -Merge-Approved merge-merged-1271
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=162798

------------------------------------------------------------------------
r162798 | ananta@chromium.org | 2012-10-18T21:37:25.423251Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1271/src/chrome/browser/ui/extensions/application_launch.cc?r1=162798&r2=162797&pathrev=162798

Merge 162290 - Attempt to reuse an existing Browser instance for application launches in Chrome on Windows 8 Metro mode.

BUG= 155388 
R=mihaip
Review URL: https://codereview.chromium.org/11191017

TBR=ananta@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11183072
------------------------------------------------------------------------
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Mstone-23 M-23 Cr-UI

Sign in to add a comment