New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 155281 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Chrome fails to activate from chrome.exe when setting "Continue where I left off" is trying to restore tabs.

Project Member Reported by gab@chromium.org, Oct 11 2012

Issue description

Version: r161286
OS: Win8

What steps will reproduce the problem?
1. Launch Chrome in Metro
2. Turn on "Continue where I left off" in settings
3. Wrench->Exit Chrome
4. Launch chrome.exe from command-line.

What is the expected output?
Chrome is re-activated when previous tabs opened.

What do you see instead?
Chrome activates, we see previous tabs for a short period and then activation fails (and the chrome.exe that activated opens on Desktop (or FATAL fails in debug builds as a result of failing activation)).

Note that simply re-activating Chrome from the shortcut works fine and the tabs are brought back as expected... might be related to  issue 155134 ?
 
Cc: -ananta@chromium.org
Owner: ananta@chromium.org
Status: Assigned
Ananta, let us know if you think this is in fact related to the general command-line-launching bug or whether there's something else going on here.

Comment 2 by gab@chromium.org, Oct 12 2012

In fact, launching chrome.exe from the command-line with a URL when Chrome Metro isn't running crashes in the same way (which is probably related); however launching chrome.exe with a URL when Chrome Metro is already running correctly results in a new tab opened to this URL with the other tabs remaining opened... so something is almost correct, but not quite...
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 16 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=162269

------------------------------------------------------------------------
r162269 | ananta@chromium.org | 2012-10-16T22:19:46.818321Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/win8/metro_driver/chrome_url_launch_handler.cc?r1=162269&r2=162268&pathrev=162269

Fix a crash seen at times when chrome in desktop mode attempts to activate Chrome in Windows 8 mode. The crash
occurs because we attempt to initiate a navigation when there are no frame windows registered with the metro driver.

Fix is to ignore the navigation request in this case.

I also updated the ChromeUrlLaunchHandler::GetUrlFromLaunchArgs function to return the chrome://newtab url if the verb
coming in is opennewwindow. This should address bug http://code.google.com/p/chromium/issues/detail?id=135122

BUG= 155281 , 135122 
R=cpu
Review URL: https://codereview.chromium.org/11193007
------------------------------------------------------------------------
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 16 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=162279

------------------------------------------------------------------------
r162279 | ananta@chromium.org | 2012-10-16T23:18:44.703073Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/startup/startup_browser_creator_impl.cc?r1=162279&r2=162278&pathrev=162279
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/startup/startup_browser_creator_impl.h?r1=162279&r2=162278&pathrev=162279
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/startup/startup_browser_creator_win.cc?r1=162279&r2=162278&pathrev=162279

If chrome in desktop mode on Windows 8 defers to Windows 8 metro chrome, then we only want to create a new window/incognito
window is one does not exist. To achieve this we look at the startup url being opened and if it is the new tab page, then
we attempt to find an existing browser window and activate it.

For non Windows platforms and Windows desktop mode the behavior is unchanged.

BUG= 155134 , 155281 
R=sky
Review URL: https://codereview.chromium.org/11137031
------------------------------------------------------------------------

Comment 5 by ananta@chromium.org, Oct 17 2012

Labels: m Re Merge-Requested
Labels: -m -Re

Comment 7 by ananta@chromium.org, Oct 17 2012

Status: Fixed
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 18 2012

Labels: merge-merged-1271
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=162789

------------------------------------------------------------------------
r162789 | ananta@chromium.org | 2012-10-18T21:15:12.336758Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1271/src/chrome/browser/ui/startup/startup_browser_creator_impl.h?r1=162789&r2=162788&pathrev=162789
   M http://src.chromium.org/viewvc/chrome/branches/1271/src/chrome/browser/ui/startup/startup_browser_creator_win.cc?r1=162789&r2=162788&pathrev=162789
   M http://src.chromium.org/viewvc/chrome/branches/1271/src/chrome/browser/ui/startup/startup_browser_creator_impl.cc?r1=162789&r2=162788&pathrev=162789

Merge 162279 - If chrome in desktop mode on Windows 8 defers to Windows 8 metro chrome, then we only want to create a new window/incognito
window is one does not exist. To achieve this we look at the startup url being opened and if it is the new tab page, then
we attempt to find an existing browser window and activate it.

For non Windows platforms and Windows desktop mode the behavior is unchanged.

BUG= 155134 , 155281 
R=sky
Review URL: https://codereview.chromium.org/11137031

TBR=ananta@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11195050
------------------------------------------------------------------------

Comment 9 by kareng@google.com, Oct 18 2012

Labels: -Merge-Requested Merge-Approved
https://codereview.chromium.org/11193007 appproved
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 18 2012

Labels: -Merge-Approved
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=162799

------------------------------------------------------------------------
r162799 | ananta@chromium.org | 2012-10-18T21:38:02.000893Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1271/src/win8/metro_driver/chrome_url_launch_handler.cc?r1=162799&r2=162798&pathrev=162799

Merge 162269 - Fix a crash seen at times when chrome in desktop mode attempts to activate Chrome in Windows 8 mode. The crash
occurs because we attempt to initiate a navigation when there are no frame windows registered with the metro driver.

Fix is to ignore the navigation request in this case.

I also updated the ChromeUrlLaunchHandler::GetUrlFromLaunchArgs function to return the chrome://newtab url if the verb
coming in is opennewwindow. This should address bug http://code.google.com/p/chromium/issues/detail?id=135122

BUG= 155281 , 135122 
R=cpu
Review URL: https://codereview.chromium.org/11193007

TBR=ananta@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11190062
------------------------------------------------------------------------
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI Cr-UI

Sign in to add a comment