New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 155134 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Launching Chrome in Metro from command-line results in a overlayed Chrome window

Project Member Reported by gab@chromium.org, Oct 10 2012

Issue description

Version: r161080
OS:  Win8

What steps will reproduce the problem?
1. Launch Chrome in Metro
2. Open some tabs
3. Now launch chrome.exe via the command-line (a user-created shortcut with no appid would likely have the same effect)

What is the expected output?
Chrome Metro is activated back to the same Chrome with all tabs opened

What do you see instead?
Chrome launches in Metro, but a new window is flashed on top of the current window.
You can create tabs in this window. When you finally close all tabs you get back the original window you had meant to go back to originally.
 
Owner: ananta@chromium.org
Status: Assigned
Ananta, mind taking a look?

Comment 2 by gab@chromium.org, Oct 11 2012

Cc: gab@chromium.org
 Issue 155199  has been merged into this issue.

Comment 3 by gab@chromium.org, Oct 11 2012

I just found something that I think is also related: when launching from the command-line, two Chrome windows are overlayed in Metro (you can see it by closing the 1st one or by relaunching in Desktop and getting 2 windows).
Labels: Hotlist-ConOps
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 16 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=162279

------------------------------------------------------------------------
r162279 | ananta@chromium.org | 2012-10-16T23:18:44.703073Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/startup/startup_browser_creator_impl.cc?r1=162279&r2=162278&pathrev=162279
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/startup/startup_browser_creator_impl.h?r1=162279&r2=162278&pathrev=162279
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/startup/startup_browser_creator_win.cc?r1=162279&r2=162278&pathrev=162279

If chrome in desktop mode on Windows 8 defers to Windows 8 metro chrome, then we only want to create a new window/incognito
window is one does not exist. To achieve this we look at the startup url being opened and if it is the new tab page, then
we attempt to find an existing browser window and activate it.

For non Windows platforms and Windows desktop mode the behavior is unchanged.

BUG= 155134 , 155281 
R=sky
Review URL: https://codereview.chromium.org/11137031
------------------------------------------------------------------------

Comment 6 by ananta@chromium.org, Oct 17 2012

Labels: Mstone-23 ReleaseBlock-Stable Merge-Requested

Comment 7 by ananta@chromium.org, Oct 17 2012

 Issue 155609  has been merged into this issue.

Comment 8 by ananta@chromium.org, Oct 17 2012

Status: Fixed

Comment 9 by kareng@google.com, Oct 18 2012

Labels: -Merge-Requested Merge-Approved
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 18 2012

Labels: -Merge-Approved merge-merged-1271
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=162789

------------------------------------------------------------------------
r162789 | ananta@chromium.org | 2012-10-18T21:15:12.336758Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1271/src/chrome/browser/ui/startup/startup_browser_creator_impl.h?r1=162789&r2=162788&pathrev=162789
   M http://src.chromium.org/viewvc/chrome/branches/1271/src/chrome/browser/ui/startup/startup_browser_creator_win.cc?r1=162789&r2=162788&pathrev=162789
   M http://src.chromium.org/viewvc/chrome/branches/1271/src/chrome/browser/ui/startup/startup_browser_creator_impl.cc?r1=162789&r2=162788&pathrev=162789

Merge 162279 - If chrome in desktop mode on Windows 8 defers to Windows 8 metro chrome, then we only want to create a new window/incognito
window is one does not exist. To achieve this we look at the startup url being opened and if it is the new tab page, then
we attempt to find an existing browser window and activate it.

For non Windows platforms and Windows desktop mode the behavior is unchanged.

BUG= 155134 , 155281 
R=sky
Review URL: https://codereview.chromium.org/11137031

TBR=ananta@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11195050
------------------------------------------------------------------------
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Mstone-23 M-23 Cr-UI

Sign in to add a comment