New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 155133 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Oct 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Chrome: Crash Report - Stack Signature: FaviconTabHelper::GetFavicon()-5b0de728_b6f...

Reported by dharani@chromium.org, Oct 10 2012

Issue description

sky@: please triage this.

Product: Chrome
Stack Signature: FaviconTabHelper::GetFavicon()-5CAAFAA
New Signature Label: FaviconTabHelper::GetFavicon()
New Signature Hash: 5b0de728_b6f66574_f66208c2_4fc4d13c_c7f03cef

Report link: http://go/crash/reportdetail?reportid=2758001dc8230087

Meta information:
Product Name: Chrome
Product Version: 24.0.1290.1
Report ID: 2758001dc8230087
Report Time: 2012/10/10 11:47:15, Wed
Uptime: 7522 sec
Cumulative Uptime: 0 sec
OS Name: Windows NT
OS Version: 6.1.7601 Service Pack 1
CPU Architecture: x86
CPU Info: GenuineIntel family 6 model 23 stepping 10
ptype: browser


Thread 0 *CRASHED* ( EXCEPTION_ACCESS_VIOLATION_READ @ 0x00000000 )

0x5b34e6b4	 [chrome.dll]	 - favicon_tab_helper.cc:60 (cs|src|ann)]	FaviconTabHelper::GetFavicon()
0x5c4c667a	 [chrome.dll]	 - panel_host.cc:83 (cs|src|ann)]	PanelHost::GetPageIcon()
0x5c480f75	 [chrome.dll]	 - panel.cc:791 (cs|src|ann)]	Panel::GetCurrentPageIcon()
0x5c4c6e7d	 [chrome.dll]	 - panel_view.cc:554 (cs|src|ann)]	PanelView::GetWindowIcon()
0x5c50e48a	 [chrome.dll]	 - panel_frame_view.cc:495 (cs|src|ann)]	PanelFrameView::GetFaviconForTabIconView()
0x5c5393a2	 [chrome.dll]	 - tab_icon_view.cc:146 (cs|src|ann)]	TabIconView::OnPaint(gfx::Canvas *)
0x5b379663	 [chrome.dll]	 - view.cc:1533 (cs|src|ann)]	views::View::PaintCommon(gfx::Canvas *)
0x5b378bcb	 [chrome.dll]	 - view.cc:730 (cs|src|ann)]	views::View::Paint(gfx::Canvas *)
0x5b37cfbb	 [chrome.dll]	 - view.cc:1123 (cs|src|ann)]	views::View::PaintChildren(gfx::Canvas *)
0x5b379679	 [chrome.dll]	 - view.cc:1536 (cs|src|ann)]	views::View::PaintCommon(gfx::Canvas *)
0x5b378bcb	 [chrome.dll]	 - view.cc:730 (cs|src|ann)]	views::View::Paint(gfx::Canvas *)
0x5b37cfbb	 [chrome.dll]	 - view.cc:1123 (cs|src|ann)]	views::View::PaintChildren(gfx::Canvas *)
0x5b379679	 [chrome.dll]	 - view.cc:1536 (cs|src|ann)]	views::View::PaintCommon(gfx::Canvas *)
0x5b378bcb	 [chrome.dll]	 - view.cc:730 (cs|src|ann)]	views::View::Paint(gfx::Canvas *)
0x5b37cfbb	 [chrome.dll]	 - view.cc:1123 (cs|src|ann)]	views::View::PaintChildren(gfx::Canvas *)
0x5b379679	 [chrome.dll]	 - view.cc:1536 (cs|src|ann)]	views::View::PaintCommon(gfx::Canvas *)
0x5b378bcb	 [chrome.dll]	 - view.cc:730 (cs|src|ann)]	views::View::Paint(gfx::Canvas *)
0x5b3a077e	 [chrome.dll]	 - hwnd_message_handler.cc:1844 (cs|src|ann)]	views::HWNDMessageHandler::OnPaint(HDC__ *)
0x5b253573	 [chrome.dll]	 - hwnd_message_handler.h:300 (cs|src|ann)]	views::HWNDMessageHandler::_ProcessWindowMessage(HWND__ *,unsigned int,unsigned int,long,long &,unsigned long)
0x5b2530eb	 [chrome.dll]	 - hwnd_message_handler.h:233 (cs|src|ann)]	views::HWNDMessageHandler::ProcessWindowMessage(HWND__ *,unsigned int,unsigned int,long,long &,unsigned long)
0x5b252c4f	 [chrome.dll]	 - hwnd_message_handler.cc:926 (cs|src|ann)]	views::HWNDMessageHandler::OnWndProc(unsigned int,unsigned int,long)
0x5b24e948	 [chrome.dll]	 - window_impl.cc:243 (cs|src|ann)]	ui::WindowImpl::WndProc(HWND__ *,unsigned int,unsigned int,long)
0x5b24e880	 [chrome.dll]	 - wrapped_window_proc.h:76 (cs|src|ann)]	base::win::WrappedWindowProc<&ui::WindowImpl::WndProc(HWND__ *,unsigned int,unsigned int,long)>(HWND__ *,unsigned int,unsigned int,long)
0x766b62f9	 [user32.dll]	 + 0x000162f9]	InternalCallWinProc
0x766b6d39	 [user32.dll]	 + 0x00016d39]	UserCallWinProcCheckWow
0x766c0d26	 [user32.dll]	 + 0x00020d26]	CallWindowProcAorW
0x766c0d4c	 [user32.dll]	 + 0x00020d4c]	CallWindowProcW
0x5b2eddaa	 [chrome.dll]	 - hwnd_subclass.cc:131 (cs|src|ann)]	ui::HWNDSubclass::OnWndProc(HWND__ *,unsigned int,unsigned int,long)
0x766b62f9	 [user32.dll]	 + 0x000162f9]	InternalCallWinProc
0x766b7315	 [user32.dll]	 + 0x00017315]	NtUserGetDC
...... (48 stack frames dropped.)
0x5b3a0655	 [chrome.dll]	 - accelerator_handler_win.cc:51 (cs|src|ann)]	views::AcceleratorHandler::Dispatch(tagMSG const &)
0x5b09f078	 [chrome.dll]	 - message_pump_win.cc:395 (cs|src|ann)]	base::MessagePumpForUI::ProcessMessageHelper(tagMSG const &)
0x5b09ebe4	 [chrome.dll]	 - message_pump_win.cc:237 (cs|src|ann)]	base::MessagePumpForUI::DoRunLoop()
0x5aee7701	 [chrome.dll]	 - message_loop.cc:422 (cs|src|ann)]	MessageLoop::RunInternal()
0x5aee766c	 [chrome.dll]	 - run_loop.cc:45 (cs|src|ann)]	base::RunLoop::Run()
0x5b3a0478	 [chrome.dll]	 - chrome_browser_main.cc:1502 (cs|src|ann)]	ChromeBrowserMainParts::MainMessageLoopRun(int *)
0x5b3a03b1	 [chrome.dll]	 - browser_main_loop.cc:481 (cs|src|ann)]	content::BrowserMainLoop::RunMainMessageLoopParts()
0x5b3a037b	 [chrome.dll]	 - browser_main_runner.cc:122 (cs|src|ann)]	`anonymous namespace'::BrowserMainRunnerImpl::Run()
0x5af4fee1	 [chrome.dll]	 - browser_main.cc:21 (cs|src|ann)]	BrowserMain(content::MainFunctionParams const &)
0x5aed8207	 [chrome.dll]	 - content_main_runner.cc:441 (cs|src|ann)]	content::RunNamedProcessTypeMain(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,content::MainFunctionParams const &,content::ContentMainDelegate *)
0x5aed818e	 [chrome.dll]	 - content_main_runner.cc:734 (cs|src|ann)]	content::ContentMainRunnerImpl::Run()
0x5aeca5f0	 [chrome.dll]	 - content_main.cc:35 (cs|src|ann)]	content::ContentMain(HINSTANCE__ *,sandbox::SandboxInterfaceInfo *,content::ContentMainDelegate *)
0x5aeca57c	 [chrome.dll]	 - chrome_main.cc:28 (cs|src|ann)]	ChromeMain
0x00a05224	 [chrome.exe]	 - client_util.cc:440 (cs|src|ann)]	MainDllLoader::Launch(HINSTANCE__ *,sandbox::SandboxInterfaceInfo *)
0x00a07a55	 [chrome.exe]	 - chrome_exe_main_win.cc:76 (cs|src|ann)]	RunChrome(HINSTANCE__ *)
0x00a07ac0	 [chrome.exe]	 - chrome_exe_main_win.cc:92 (cs|src|ann)]	wWinMain
0x00a6044c	 [chrome.exe]	 - crt0.c:275]	__tmainCRTStartup
0x76c53399	 [kernel32.dll]	 + 0x00013399]	BaseThreadInitThunk
0x778b9ef1	 [ntdll.dll]	 + 0x00039ef1]	__RtlUserThreadStart
0x778b9ec4	 [ntdll.dll]	 + 0x00039ec4]	_RtlUserThreadStart
 

Comment 1 by sky@chromium.org, Oct 10 2012

I could be wrong, but it looks like PanelHost is holding onto a WebContents that has been deleted.
Owner: jennb@chromium.org
Status: Assigned
jennb@: could you please take a look? thanks

Comment 3 by jennb@chromium.org, Oct 11 2012

Wish there was some way to get repro steps... I have no idea what might be deleting the WebContents out from under PanelHost in the Win implementation. Could the WebContentsUserData somehow be getting corrupted so that the FavIconTabHelper cannot be retrieved?

All I can think of right now is to add a dcheck to make sure the WebContents are not deleted somewhere else unexpectedly and another dcheck to ensure we can retrieve a FavIconTabHelper to help catch more occurrences of whatever is going on.

Comment 4 by jennb@chromium.org, Oct 11 2012

Cc: dim...@chromium.org jianli@chromium.org
Labels: -Feature-TabContents Feature-Panels OS-Windows
Earliest occurrence is 24.0.1284.0 and all occurrences are on Win.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 16 2012

Summary: Chrome: Crash Report - Stack Signature: FaviconTabHelper::GetFavicon()-5b0de728_b6f...
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=162200

------------------------------------------------------------------------
r162200 | jennb@chromium.org | 2012-10-16T19:12:29.770522Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/panels/panel_host.cc?r1=162200&r2=162199&pathrev=162200
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager_resource_providers.cc?r1=162200&r2=162199&pathrev=162200

[Panels] Fix favicon crash from using deleted WebContents.

Updated TaskManagerPanelResourceProvider to no longer expect Panel to have web contents after web contents are disconnected.

BUG= 155133 
TEST=updated

Review URL: https://chromiumcodereview.appspot.com/11092066
------------------------------------------------------------------------

Comment 6 by jennb@chromium.org, Oct 22 2012

Status: Fixed
No new crashes seen in branches containing fix.
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Mstone-24 -Area-UI -Feature-Panels Cr-UI M-24 Cr-UI-Browser-Panels

Sign in to add a comment