New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 154940 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

After restart, sync has all datatypes except bookmarks disabled

Project Member Reported by zea@chromium.org, Oct 9 2012

Issue description

Chrome just crashed (unrelated to sync), and on restart my personal profile (it's a two-profile setup) had all datatypes except bookmarks disabled.

About
Data
Notifications
Events
Sync Node Browser
Search
Traffic
Some personal info may be in the data dump. Be careful about posting data dumps on bug reports.

Dump to text
======
Status
======
{
  "actionable_error": [
    {
      "is_valid": false,
      "stat_name": "Error Type",
      "stat_value": "Uninitialized"
    },
    {
      "is_valid": false,
      "stat_name": "Action",
      "stat_value": "Uninitialized"
    },
    {
      "is_valid": false,
      "stat_name": "URL",
      "stat_value": "Uninitialized"
    },
    {
      "is_valid": false,
      "stat_name": "Error Description",
      "stat_value": "Uninitialized"
    }
  ],
  "actionable_error_detected": false,
  "details": [
    {
      "data": [
        {
          "is_valid": true,
          "stat_name": "Summary",
          "stat_value": "Sync service initialized"
        }
      ],
      "title": "Summary"
    },
    {
      "data": [
        {
          "is_valid": true,
          "stat_name": "Client Version",
          "stat_value": " Mac OS X 23.0.1271.10 (158896) dev"
        },
        {
          "is_valid": true,
          "stat_name": "Server URL",
          "stat_value": "https://clients4.google.com/chrome-sync/dev"
        }
      ],
      "title": "Version Info"
    },
    {
      "data": [
        {
          "is_valid": true,
          "stat_name": "Client ID",
          "stat_value": "NBi7r+8iNSg5Lkvm+qQBRw=="
        },
        {
          "is_valid": true,
          "stat_name": "Username",
          "stat_value": "Nicolas.Zea@gmail.com"
        },
        {
          "is_valid": true,
          "stat_name": "Sync Token Available",
          "stat_value": true
        }
      ],
      "title": "Credentials"
    },
    {
      "data": [
        {
          "is_valid": true,
          "stat_name": "Last Synced",
          "stat_value": "30 mins ago"
        },
        {
          "is_valid": true,
          "stat_name": "Sync First-Time Setup Complete",
          "stat_value": true
        },
        {
          "is_valid": true,
          "stat_name": "Sync Backend Initialized",
          "stat_value": true
        },
        {
          "is_valid": true,
          "stat_name": "Initial Download Complete",
          "stat_value": true
        },
        {
          "is_valid": true,
          "stat_name": "Syncing",
          "stat_value": false
        }
      ],
      "title": "Local State"
    },
    {
      "data": [
        {
          "is_valid": false,
          "stat_name": "Throttled",
          "stat_value": false
        },
        {
          "is_valid": true,
          "stat_name": "Notifications Enabled",
          "stat_value": true
        }
      ],
      "title": "Network"
    },
    {
      "data": [
        {
          "is_valid": true,
          "stat_name": "Explicit Passphrase",
          "stat_value": false
        },
        {
          "is_valid": true,
          "stat_name": "Passphrase Required",
          "stat_value": false
        },
        {
          "is_valid": true,
          "stat_name": "Cryptographer Ready",
          "stat_value": true
        },
        {
          "is_valid": true,
          "stat_name": "Cryptographer Has Pending Keys",
          "stat_value": false
        },
        {
          "is_valid": true,
          "stat_name": "Encrypted Types",
          "stat_value": "Passwords"
        },
        {
          "is_valid": true,
          "stat_name": "Has Keystore Key",
          "stat_value": false
        },
        {
          "is_valid": true,
          "stat_name": "Keystore Migration Time",
          "stat_value": "Tuesday, September 25, 2012 2:42:45 PM"
        },
        {
          "is_valid": true,
          "stat_name": "Passphrase Type",
          "stat_value": "KEYSTORE_PASSPHRASE"
        }
      ],
      "title": "Encryption"
    },
    {
      "data": [
        {
          "is_valid": false,
          "stat_name": "Sync Source",
          "stat_value": "Uninitialized"
        },
        {
          "is_valid": false,
          "stat_name": "GetKey Step Result",
          "stat_value": "Uninitialized"
        },
        {
          "is_valid": false,
          "stat_name": "Download Step Result",
          "stat_value": "Uninitialized"
        },
        {
          "is_valid": false,
          "stat_name": "Commit Step Result",
          "stat_value": "Uninitialized"
        }
      ],
      "title": "Status from Last Completed Session"
    },
    {
      "data": [
        {
          "is_valid": true,
          "stat_name": "Notifications Received",
          "stat_value": 0
        },
        {
          "is_valid": true,
          "stat_name": "Cycles Without Updates",
          "stat_value": 0
        },
        {
          "is_valid": true,
          "stat_name": "Cycles With Updated",
          "stat_value": 0
        },
        {
          "is_valid": true,
          "stat_name": "Cycles Without Commits",
          "stat_value": 0
        },
        {
          "is_valid": true,
          "stat_name": "Cycles With Commits",
          "stat_value": 0
        },
        {
          "is_valid": true,
          "stat_name": "Cycles Without Commits or Updates",
          "stat_value": 0
        },
        {
          "is_valid": true,
          "stat_name": "Cycles With Commit or Update",
          "stat_value": 0
        },
        {
          "is_valid": true,
          "stat_name": "Updates Downloaded",
          "stat_value": 0
        },
        {
          "is_valid": true,
          "stat_name": "Tombstone Updates",
          "stat_value": 0
        },
        {
          "is_valid": true,
          "stat_name": "Reflected Updates",
          "stat_value": 0
        },
        {
          "is_valid": true,
          "stat_name": "Syccessful Commits",
          "stat_value": 0
        },
        {
          "is_valid": true,
          "stat_name": "Conflicts Resolved: Client Wins",
          "stat_value": 0
        },
        {
          "is_valid": true,
          "stat_name": "Conflicts Resolved: Server Wins",
          "stat_value": 0
        }
      ],
      "title": "Running Totals"
    },
    {
      "data": [
        {
          "is_valid": true,
          "stat_name": "Encryption Conflicts",
          "stat_value": 0
        },
        {
          "is_valid": true,
          "stat_name": "Hierarchy Conflicts",
          "stat_value": 0
        },
        {
          "is_valid": true,
          "stat_name": "Simple Conflicts",
          "stat_value": 0
        },
        {
          "is_valid": true,
          "stat_name": "Server Conflicts",
          "stat_value": 0
        },
        {
          "is_valid": true,
          "stat_name": "Committed Items",
          "stat_value": 0
        },
        {
          "is_valid": true,
          "stat_name": "Updates Remaining",
          "stat_value": 0
        }
      ],
      "title": "Transient Counters (this cycle)"
    },
    {
      "data": [
        {
          "is_valid": false,
          "stat_name": "Updates Downloaded",
          "stat_value": 0
        },
        {
          "is_valid": false,
          "stat_name": "Committed Count",
          "stat_value": 0
        },
        {
          "is_valid": false,
          "stat_name": "Entries",
          "stat_value": 0
        }
      ],
      "title": "Transient Counters (last cycle of last completed session)"
    }
  ],
  "type_status": [
    {
      "name": "Bookmarks",
      "status": "ok",
      "value": "Active: GROUP_UI"
    },
    {
      "name": "Preferences",
      "status": "warning",
      "value": "Disabled by User"
    },
    {
      "name": "Passwords",
      "status": "warning",
      "value": "Disabled by User"
    },
    {
      "name": "Autofill Profiles",
      "status": "warning",
      "value": "Disabled by User"
    },
    {
      "name": "Autofill",
      "status": "warning",
      "value": "Disabled by User"
    },
    {
      "name": "Themes",
      "status": "warning",
      "value": "Disabled by User"
    },
    {
      "name": "Typed URLs",
      "status": "warning",
      "value": "Disabled by User"
    },
    {
      "name": "Extensions",
      "status": "warning",
      "value": "Disabled by User"
    },
    {
      "name": "Search Engines",
      "status": "warning",
      "value": "Disabled by User"
    },
    {
      "name": "Sessions",
      "status": "warning",
      "value": "Disabled by User"
    },
    {
      "name": "Apps",
      "status": "warning",
      "value": "Disabled by User"
    },
    {
      "name": "App settings",
      "status": "warning",
      "value": "Disabled by User"
    },
    {
      "name": "Extension settings",
      "status": "warning",
      "value": "Disabled by User"
    },
    {
      "name": "App Notifications",
      "status": "warning",
      "value": "Disabled by User"
    }
  ],
  "unrecoverable_error_detected": false
}

=============
Notifications
=============
{
  "App Notifications": {
    "payload": "",
    "totalCount": 0,
    "type": "App Notifications",
    "sessionCount": 0
  },
  "App settings": {
    "payload": "",
    "totalCount": 0,
    "type": "App settings",
    "sessionCount": 0
  },
  "Apps": {
    "payload": "",
    "totalCount": 0,
    "type": "Apps",
    "sessionCount": 0
  },
  "Autofill": {
    "payload": "",
    "totalCount": 0,
    "type": "Autofill",
    "sessionCount": 0
  },
  "Autofill Profiles": {
    "payload": "",
    "totalCount": 0,
    "type": "Autofill Profiles",
    "sessionCount": 0
  },
  "Bookmarks": {
    "payload": "",
    "totalCount": 0,
    "type": "Bookmarks",
    "sessionCount": 0
  },
  "Encryption keys": {
    "payload": "",
    "totalCount": 0,
    "type": "Encryption keys",
    "sessionCount": 0
  },
  "Extension settings": {
    "payload": "",
    "totalCount": 0,
    "type": "Extension settings",
    "sessionCount": 0
  },
  "Extensions": {
    "payload": "",
    "totalCount": 0,
    "type": "Extensions",
    "sessionCount": 0
  },
  "Passwords": {
    "payload": "",
    "totalCount": 0,
    "type": "Passwords",
    "sessionCount": 0
  },
  "Preferences": {
    "payload": "",
    "totalCount": 0,
    "type": "Preferences",
    "sessionCount": 0
  },
  "Search Engines": {
    "payload": "",
    "totalCount": 0,
    "type": "Search Engines",
    "sessionCount": 0
  },
  "Sessions": {
    "payload": "",
    "totalCount": 0,
    "type": "Sessions",
    "sessionCount": 0
  },
  "Themes": {
    "payload": "",
    "totalCount": 0,
    "type": "Themes",
    "sessionCount": 0
  },
  "Typed URLs": {
    "payload": "",
    "totalCount": 0,
    "type": "Typed URLs",
    "sessionCount": 0
  }
}

===
Log
===
[]
 

Comment 1 by zea@chromium.org, Oct 15 2012

Interestingly, after restarting again this appears to have fixed itself? Likely "keep everything synced was still true", but the question is why didn't that work in the first place?
For the record, the "Disabled by user" type is a fallback.  We assume the type has been disabled by the user if:
- it's not in an error state,
- it's not throttled,
- it's not in GROUP_PASSIVE, and
- it's not "active".

By "active", I mean that the type is in the routing info and has a non GROUP_PASSIVE group assigned.  

This implies that a type is considered disabled if it is not in the routing info.

Comment 3 by zea@chromium.org, Oct 15 2012

Note also that the default "enabled" value of all types is false, with the exception of bookmarks (see sync_prefs.cc). Normally we rely on KeepEverythingSynced to override this though, so for some reason it appears to have failed in this instance.

Fred experience this same issue a couple weeks back too.

Comment 4 Deleted

Comment 5 by zea@chromium.org, Oct 16 2012

This repro'd on my windows machine, and continues to repro on restart. Sync preferences:

   "sync": {
      "encryption_bootstrap_token": "bla",
      "has_setup_completed": true,
      "last_synced_time": "12994863039002471",
      "session_sync_guid": "session_syncUS89mfkZk46HecpebxUxjg==",
      "suppress_start": false
   },

It appears the preferences have all been lost...perhaps sync tried to disable itself but didn't finish?

Comment 6 by zea@chromium.org, Oct 16 2012

It might be relevant as well, but I had signed in to this machine via one-click-signin. It's possible I had signed in to my mac machine with that as well (since it allows me to bypass ASP's).

Comment 7 by zea@chromium.org, Oct 16 2012

 Issue 147351  has been merged into this issue.

Comment 8 by zea@chromium.org, Oct 16 2012

Owner: rogerta@chromium.org
Status: Assigned
Okay, I can repro this reliably by signing in to sync via one-click-signin. It appears sync isn't being properly configured (Keep everything sync is not getting set).

Roger, could you take a look?

Comment 9 by zea@chromium.org, Oct 16 2012

Summary: After restart, sync has all datatypes except bookmarks disabled
To be clear, this only repro's after restarting having set up sync using one-click-signin
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 17 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=162479

------------------------------------------------------------------------
r162479 | rogerta@chromium.org | 2012-10-17T19:11:50.666197Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/sync/one_click_signin_sync_starter.cc?r1=162479&r2=162478&pathrev=162479

Tell profile sync svc to use all datatypes when the user chooses the default
sync options with one click sign in.

BUG= 154940 
TEST=Create a new profile.  Don't use sync promo.  Sign in to gmail and use
the one-click sign in feature.  In the bubble that shows up pointing to the
wrench menu, make sure to use the default option and not the advanced option.
Stop and restart chrome.  Go to the settings page and click the "Advanced
sync settings..." button.  Make sure all data types are selected.


Review URL: https://chromiumcodereview.appspot.com/11187030
------------------------------------------------------------------------
Labels: -Mstone-24 Mstone-23 ReleaseBlock-Stable
It looks like this repro-ed on M23? If so, we should get this merged asap -- lots of users are likely to hit this.

Comment 12 by kareng@google.com, Oct 22 2012

Labels: Merge-Approved
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 22 2012

Labels: -Merge-Approved merge-merged-1271
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=163353

------------------------------------------------------------------------
r163353 | rogerta@chromium.org | 2012-10-22T19:59:59.461959Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1271/src/chrome/browser/ui/sync/one_click_signin_sync_starter.cc?r1=163353&r2=163352&pathrev=163353

Merge 162479 - Tell profile sync svc to use all datatypes when the user chooses the default
sync options with one click sign in.

BUG= 154940 
TEST=Create a new profile.  Don't use sync promo.  Sign in to gmail and use
the one-click sign in feature.  In the bubble that shows up pointing to the
wrench menu, make sure to use the default option and not the advanced option.
Stop and restart chrome.  Go to the settings page and click the "Advanced
sync settings..." button.  Make sure all data types are selected.


Review URL: https://chromiumcodereview.appspot.com/11187030

TBR=rogerta@chromium.org
Review URL: https://codereview.chromium.org/11225034
------------------------------------------------------------------------

Comment 14 by kareng@google.com, Oct 23 2012

can we close this?
Status: Fixed
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 30 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=164975

------------------------------------------------------------------------
r164975 | zea@chromium.org | 2012-10-30T19:39:40.737538Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service.cc?r1=164975&r2=164974&pathrev=164975
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc?r1=164975&r2=164974&pathrev=164975
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service.h?r1=164975&r2=164974&pathrev=164975

[Sync] Fix up users who were affected by  bug 154940 

These users did not have their Keep Everything Synced preference set
properly, or the preferences for the preferred datatypes. We detect this
and manually fix up the preference before reconfiguring sync.

BUG= 158391 


Review URL: https://chromiumcodereview.appspot.com/11342022
------------------------------------------------------------------------
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 30 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=164991

------------------------------------------------------------------------
r164991 | zea@chromium.org | 2012-10-30T20:30:55.121933Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service.cc?r1=164991&r2=164990&pathrev=164991
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc?r1=164991&r2=164990&pathrev=164991
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service.h?r1=164991&r2=164990&pathrev=164991

Revert 164975 - [Sync] Fix up users who were affected by  bug 154940 

These users did not have their Keep Everything Synced preference set
properly, or the preferences for the preferred datatypes. We detect this
and manually fix up the preference before reconfiguring sync.

BUG= 158391 


Review URL: https://chromiumcodereview.appspot.com/11342022

TBR=zea@chromium.org
Review URL: https://codereview.chromium.org/11342053
------------------------------------------------------------------------
Project Member

Comment 20 by bugdroid1@chromium.org, Nov 1 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=165521

------------------------------------------------------------------------
r165521 | zea@chromium.org | 2012-11-01T22:18:52.979134Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service.cc?r1=165521&r2=165520&pathrev=165521
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc?r1=165521&r2=165520&pathrev=165521
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service.h?r1=165521&r2=165520&pathrev=165521

[Sync] Re-reland fix for  bug 154940 

Speculatively fixed test by making syncer::UserTypes() stack allocated at
a higher scope, instead of within the for loop. I suspect on certain windows
builds the for loop allocation was being dealloc'd early, hence invalidating
the iterator.

Original codereview at http://codereview.chromium.org/11342022/

BUG= 158391 
TBR=tim@chromium.org

Review URL: https://chromiumcodereview.appspot.com/11365041
------------------------------------------------------------------------
Project Member

Comment 21 by bugdroid1@chromium.org, Nov 12 2012

Labels: merge-merged-1312
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=167222

------------------------------------------------------------------------
r167222 | zea@chromium.org | 2012-11-12T19:26:58.223934Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/sync/profile_sync_service.h?r1=167222&r2=167221&pathrev=167222
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/sync/profile_sync_service.cc?r1=167222&r2=167221&pathrev=167222
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc?r1=167222&r2=167221&pathrev=167222

Merge 165521 - [Sync] Re-reland fix for  bug 154940 

Speculatively fixed test by making syncer::UserTypes() stack allocated at
a higher scope, instead of within the for loop. I suspect on certain windows
builds the for loop allocation was being dealloc'd early, hence invalidating
the iterator.

Original codereview at http://codereview.chromium.org/11342022/

BUG= 158391 
TBR=tim@chromium.org

Review URL: https://chromiumcodereview.appspot.com/11365041

TBR=zea@chromium.org
Review URL: https://codereview.chromium.org/11369194
------------------------------------------------------------------------
Project Member

Comment 22 by bugdroid1@chromium.org, Nov 20 2012

The following revision refers to this bug:
    http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=31010

------------------------------------------------------------------------
r31010 | zea@google.com | 2012-11-20T02:23:02.546633Z

------------------------------------------------------------------------
Project Member

Comment 23 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-Internals -Feature-Sync -Mstone-23 Cr-Services-Sync Cr-Internals M-23
webrtc_internals_dump.txt
47 bytes View Download

Sign in to add a comment