New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 154663 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 0
Type: Bug-Regression



Sign in to add a comment

Unable to uninstall Chrome when it is Default browser and user sets preference to run Chrome in Windows 8 mode.

Project Member Reported by pbomm...@chromium.org, Oct 8 2012

Issue description

Version: 24.0.1289.1
OS: Windows 8 RTM

What steps will reproduce the problem?
1. Install chrome(mini_installer.exe --chrome --multi-install --verbose-logging)
2. Make chrome as default browser 
3. Using Mode switcher switch from Desktop mode to Windows 8 mode of chrome.
4. Chrome gets launched in Windows 8 mode 
5. Exit chrome from wrench 
6. Try to uninstall chrome from control panel

What is the expected output?
Chrome should get uninstalled

What do you see instead?
When clicked on Uninstall, Launches chrome in Windows 8 mode.
Even Unable to switch mode from Windows 8 to Desktop mode.
Unable to uninstall chrome, Tried on 2 machines.





 
In registry under HKCU\Software\Google\Chrome\Metro--> launch_mode is set to "0" instead of "1" when launched in Windows 8 mode. 
Cc: cpu@chromium.org gab@chromium.org grt@chromium.org
Yikes. Apparently this doesn't repro in M23. Gab/Greg, could one of you take a look? Also +cc cpu.

Comment 3 by gab@chromium.org, Oct 9 2012

Labels: -ReleaseBlock-Dev ReleaseBlock-Beta
Owner: gab@chromium.org
Status: Started
Will fix asap, but this shouldn't block dev.
Summary: Unable to uninstall Chrome when it is Default browser.
Work around to uninstall is make another browser as default and then uninstall chrome.
Updated summary accordingly.

Comment 5 by gab@chromium.org, Oct 9 2012

Summary: Unable to uninstall Chrome when it is Default browser and user sets preference to run Chrome in Windows 8 mode.
That works, but I prefer a workaround involving only Chrome:
1) Launch Chrome in Metro
2) Using the wrench menu relaunch Chrome on the desktop
3) Close all Chrome windows on the desktop
4) Uninstall Chrome

Comment 6 by gab@chromium.org, Oct 9 2012

I was finally able to repro this, to clarify this requires a user-level install (doesn't seem to repro at system-level); furthermore, when uninstalling and Chrome is set to prefer Metro, two things happen:
1) Chrome launches in Metro
2) Chrome pops the dialog saying to "Please close all Chrome windows..."

I have no idea how it is possible for both of these things to happen no matter how messed up the state is....

If I manually switch the registry preference back to 0 (desktop) I can uninstall, if I set it back to 1 (Metro) manually, I can't uninstall anymore (i.e. this bug)... this is non-sense as DoUninstallTasks() -- which pops the uninstall dialog -- is called before anything that should care about this preference (and furthermore it returns so that the rest should have no chance of happening...).

I'm confused... but I g2g for now... will see tomorrow.

Comment 7 Deleted

The uninstall behavior on different Windows 8 machines

 Hp touchsmart
 -----------------------------------------------------------------
 1. Changed system resolution to 1920 X 1080(In order to avoid chrome to launch in windows 8 mode)
 2. Installed chrome and made as default 
 3. Frome wrench mode switcher launched chrome in Windows 8 mode 
 4. From wrench exited chrome
 5. Tried to uninstall chrome from Control panel and CMD 
 6. Saw a dialog on desktop "Please close all Google Chrome windows(including those in Windows8 mode) and try again"
 7. On clicking "Ok" will dismiss the dialog.
 8. Again launched chrome in Windows 8 mode 
 9. Tried to switch mode using wrench "Relaunch Chrome on the Desktop"
10. Chrome launched in Desktop mode 
11. Uninstall works In this case.

 Hp Touchsmart, Lenovo
 ------------------------------------------------------------------------------------------------------------
 1. Screen resolution 1366 X 768(lenovo)
 2. Installed chrome and made as  default
 3. Chrome launched in windows 8 mode 
 4. From Wrench exited chrome 
 5. Tried to uninstall chrome from control panel and CMD
 6. Saw a dialog on desktop "Please close all Google Chrome windows(including those in Windows8 mode) and try again"
 7. On clicking "Ok" will dismiss the dialog.
 8. Again launched chrome in windows 8 mode 
 9. Tried to switch mode using wrench "Relaunch Chrome on the Desktop"
 10. Chrome gets relaunched in Windows 8 mode instead of Desktop mode

Comment 9 by gab@chromium.org, Oct 10 2012

Points 9+10 on tablet looks like a separate bug to me (i.e. "Can't relaunch on Desktop on Win8 tablet."). Can you confirm this (i.e. is this true, independent of trying to uninstall?)? If so can you please log another bug?

Thanks,
Gab
Owner: ananta@chromium.org
Status: Assigned
Have a fix for this.
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 10 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=161217

------------------------------------------------------------------------
r161217 | ananta@chromium.org | 2012-10-10T22:27:53.168441Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/process_singleton_win.cc?r1=161217&r2=161216&pathrev=161217

Fix a regression which caused Chrome to always launch in Windows 8 mode on tablets. This was caused by 
my change to fix bug  http://code.google.com/p/chromium/issues/detail?id=153318 which attempted to 
activate chrome in Windows 8 mode if the previous launch mode was Windows 8.

We also don't attempt to activate into metro if the command line contains the uninstall switch.

BUG= 154663 
R=sky
Review URL: https://codereview.chromium.org/11066102
------------------------------------------------------------------------

Comment 12 by kareng@google.com, Oct 10 2012

Labels: -Mstone-24 Mstone-23 Merge-Approved
Status: Fixed
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 10 2012

Labels: -Merge-Approved merge-merged-1271
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=161220

------------------------------------------------------------------------
r161220 | ananta@chromium.org | 2012-10-10T22:41:33.000588Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1271/src/chrome/browser/process_singleton_win.cc?r1=161220&r2=161219&pathrev=161220

Merge 161217 - Fix a regression which caused Chrome to always launch in Windows 8 mode on tablets. This was caused by 
my change to fix bug  http://code.google.com/p/chromium/issues/detail?id=153318 which attempted to 
activate chrome in Windows 8 mode if the previous launch mode was Windows 8.

We also don't attempt to activate into metro if the command line contains the uninstall switch.

BUG= 154663 
R=sky
Review URL: https://codereview.chromium.org/11066102

TBR=ananta@chromium.org
Review URL: https://codereview.chromium.org/11092063
------------------------------------------------------------------------
Project Member

Comment 15 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Type-Regression -Area-Internals -Internals-Install -Mstone-23 Type-Bug-Regression Cr-Internals M-23 Cr-Internals-Install
Project Member

Comment 16 by bugdroid1@chromium.org, Apr 5 2013

Labels: -Cr-Internals-Install Cr-Internals-Installer

Sign in to add a comment