New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 154379 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[Classic, Text input]Omnibox auto-complete highlight does not appear using Chinese /Japanese IME English mode

Project Member Reported by songsuk@chromium.org, Oct 5 2012

Issue description

Chrome Version       :23.0.1271.20 (Official Build 160301)
Platform : Windows 8 Tablet


What steps will reproduce the problem?
1. navigate to any websites, (http://daum.net)
2. set IME to Japanese ( or Chinese )   
2. convert IME to English,"A" from Hiragana、あ  
3. open a new tab, enter "hu" on the omnibox 
4. check the address field and suggestion dropdown menu

What is the expected result?
"hu" should appear on omnibox.  
www.hulu.com... or the other suggestions info should appear on the dropdown menu. 

What happens instead?
"huttp://daum.net" appears on the omnibox and dropdown menu


Please provide any additional information below. Attach a screenshot if
possible.
 
Capture.JPG
54.5 KB View Download

After Step2, enter "daum.net" on the Omnibox. 

Expected result : daum.net on the omnibox & drop down menu

Actual result : daum.netaum.net appear on the omnibox & drop down menu.

====
The issue isn't reproducible with Korean IME.


Cc: vivianz@chromium.org
this does not sound like bug in IME, Song, do you get the same result if you just use English keyboard? "huttp://daum.net" is likely a website mistakenly entered by user in the past. 
Summary: [Classic, Text input]Omnibox auto-complete highlight does not appear using Chinese /Japanese IME English mode
talked to Song, looks like the problem here is that for frequently entered urls, omnibox offers auto-complete when it detect the first match for the first or sencond characters inputted, the auto-complete bring up the entire URL highlighted. so if user continue typing , when it detect a mismatch in later characters, the auto-completed url will go away. 

but in Win8 touch unit only, when input mode is in Chinese or Japanese IME English mode,  it will bring up auto-complete without highlight selection, so if user later input mismatch characters, the auto-complete url just append at the end.
Cc: yukawa@chromium.org
Labels: Mstone-24
Owner: nona@chromium.org
Status: Assigned
We have been able to repro it.

Investigation results so far: input from a hardware keyboard does not trigger the issue.

nona@ will take a look.
Hopefully, we can get this fixed by M24 (crossing fingers).
Cc: nona@chromium.org
Labels: -Mstone-24
Owner: ----
Status: Available
Just talked with nona@ and yukawa@: this is a heavy one (also broken on Windows 7 when using handwritten input).

Reverting to Available and temporarily removing mstone-24 until we have a new owner and a better understanding of the scope.

Comment 7 by nona@chromium.org, Oct 12 2012

Owner: nona@chromium.org
Status: Started
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 12 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=161515

------------------------------------------------------------------------
r161515 | nona@chromium.org | 2012-10-12T06:29:41.870333Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/omnibox/omnibox_view_win.cc?r1=161515&r2=161514&pathrev=161515
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/omnibox/omnibox_view_win.h?r1=161515&r2=161514&pathrev=161515

Fix omnibox suggestion: restore selection on WM_IME_ENDCOMPOSITION

BUG= 154379 
TEST=Manually done one Win XP, Win 7, Win 8 including jp, kr, cn

Review URL: https://chromiumcodereview.appspot.com/11093044
------------------------------------------------------------------------
Cc: pkasting@chromium.org kareng@google.com
Labels: mstone-23 Merge-Requested
Status: Fixed
Kareng: this is fixed. The patch itself is very small but given the impact (not limited to Win8) as Peter suggested, let's give this patch enough mileage before merging it back to M23. I am afraid we'll forget about it so let me add the labels but postpone the actual merge.

Comment 10 by kareng@google.com, Oct 16 2012

so we're getting close to stable. not a lot of time to wait. pls keep a solid eye on this and if we have to have it, it will have to be before the end of this week.
Working fine on 24.0.1297.0
Status: Verified

Comment 13 by nona@chromium.org, Oct 18 2012

I checked with Canary on
Windows XP SP3 and Windows 7 with MSIME, Baidu IME, Google Japanese Input.
And above patch works fine.

Kareng: Please let me merge to M23, I think this is enough safe.

Comment 14 by kareng@google.com, Oct 18 2012

Labels: -Merge-Requested Merge-Approved
ok
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 18 2012

Labels: -Merge-Approved merge-merged-1271
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=162717

------------------------------------------------------------------------
r162717 | nona@chromium.org | 2012-10-18T16:23:56.053798Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1271/src/chrome/browser/ui/views/omnibox/omnibox_view_win.cc?r1=162717&r2=162716&pathrev=162717
   M http://src.chromium.org/viewvc/chrome/branches/1271/src/chrome/browser/ui/views/omnibox/omnibox_view_win.h?r1=162717&r2=162716&pathrev=162717

Merge 161515 - Fix omnibox suggestion: restore selection on WM_IME_ENDCOMPOSITION

BUG= 154379 
TEST=Manually done one Win XP, Win 7, Win 8 including jp, kr, cn

Review URL: https://chromiumcodereview.appspot.com/11093044

TBR=nona@chromium.org
Review URL: https://codereview.chromium.org/11188063
------------------------------------------------------------------------

Comment 16 by nona@chromium.org, Oct 18 2012

Thanks! merged.
Thanks to everyone!
Project Member

Comment 18 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Feature-TextInput -Area-UI -mstone-23 Cr-UI M-23 Cr-UI-Input-Text-IME

Sign in to add a comment