Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user
Status: Fixed
Owner:
No longer on Chrome
Closed: Oct 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment
Zoom icon doesn't work on virtual URLs with a different origin
Project Member Reported by dbeam@chromium.org, Oct 4 2012 Back to list
When zooming on a page that maps the URL in the omnibox to a virtual/vanity URL (i.e. chrome://bookmarks, chrome://settings, chrome://extensions, chrome://history) the zoom icon doesn't show because we're probably listening for zoom changes from a different origin.

I'll accept this for now but anybody else is welcome to look at it.  Also, we'll see if it's feasible to merge this to M23 if it's small enough.
 
Project Member Comment 2 by bugdroid1@chromium.org, Oct 4 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=160228

------------------------------------------------------------------------
r160228 | dbeam@chromium.org | 2012-10-04T21:07:27.868032Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/zoom/zoom_controller.cc?r1=160228&r2=160227&pathrev=160228

Fix zoom icon/bubble for virtual URLs (i.e. chrome://settings).

R=khorimoto@chromium.org,sky@chromium.org
BUG= 153950 


Review URL: https://chromiumcodereview.appspot.com/11040031
------------------------------------------------------------------------
Comment 3 by dbeam@chromium.org, Oct 4 2012
Status: Fixed
I'll request a merge for this a day or two after it "simmers".
Comment 4 by dbeam@chromium.org, Oct 4 2012
in a day or two**
Comment 5 by dbeam@chromium.org, Oct 4 2012
Labels: Merge-Requested
We'll revisit tomorrow or sometime soon about merging
Comment 6 by kareng@google.com, Oct 10 2012
Labels: -Mstone-24 Mstone-23
i assume u meant m23?
Comment 7 by kareng@google.com, Oct 10 2012
looks small-ish. is it workin on and safe?
Comment 8 by kareng@google.com, Oct 10 2012
Labels: -Merge-Requested Merge-Approved
Comment 9 by dbeam@chromium.org, Oct 10 2012
Labels: -Mstone-23 -Merge-Approved Mstone-24
Actually, the issue cropped up in M24, no merge necessary.
Project Member Comment 10 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Area-UI -Feature-Browser -Mstone-24 Cr-UI M-24 Cr-UI-Browser-Core
Sign in to add a comment