New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 152582 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Oct 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Default apps are getting synced

Reported by grv@chromium.org, Sep 27 2012

Issue description

With the new implementation of default apps, we don't want to sync them.
However, Issue 10855190 introduces the bug, where default apps get synced.
 

Comment 1 by mihaip@chromium.org, Sep 27 2012

Labels: Mstone-23 ReleaseBlock-Stable
Cc: annapop@chromium.org
Tracking implications to sync: are all platforms affected, in particular ChromeOS? Thanks.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 2 2012

Summary: Default apps are getting synced
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=159612

------------------------------------------------------------------------
r159612 | grv@chromium.org | 2012-10-02T01:42:16.952269Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/installed_loader.cc?r1=159612&r2=159611&pathrev=159612

Temporary fix bug in disabling sync for default apps

We added a new creation_flag for default apps was_installed_by_default,
but every time we add a new creation_flag, we need to update the
installedLoader as it does not directly pick the creation_flags but
re-creates them through other preferences.

This is temporary fix for M-23 branch. A more fundamental fix is 10977048

BUG= 152582 


Review URL: https://chromiumcodereview.appspot.com/11034009
------------------------------------------------------------------------
Labels: Merge-Requested

Comment 5 by kareng@google.com, Oct 2 2012

this just landed. did it go to canary?
It should be in today's canary (brancy 1285, cut at r159856, this was fixed at r159612)

Comment 7 by kareng@google.com, Oct 3 2012

can one of you check that it works as expected?

Comment 8 by grv@chromium.org, Oct 3 2012

Verifying it now.

Comment 9 by kareng@google.com, Oct 4 2012

and? :)

Comment 10 by grv@chromium.org, Oct 4 2012

Yes it works as expected. Thanks

Comment 11 by kareng@google.com, Oct 4 2012

Labels: -Merge-Requested Merge-Approved
ty pls land.

Comment 12 by kareng@google.com, Oct 4 2012

Status: Fixed
Status: Started
Not merged yet.
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 4 2012

Labels: -Merge-Approved merge-merged-1271
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=160208

------------------------------------------------------------------------
r160208 | mihaip@chromium.org | 2012-10-04T20:06:05.035554Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1271/src/chrome/browser/extensions/installed_loader.cc?r1=160208&r2=160207&pathrev=160208

Merge 159612 - Temporary fix bug in disabling sync for default apps

We added a new creation_flag for default apps was_installed_by_default,
but every time we add a new creation_flag, we need to update the
installedLoader as it does not directly pick the creation_flags but
re-creates them through other preferences.

This is temporary fix for M-23 branch. A more fundamental fix is 10977048

BUG= 152582 


Review URL: https://chromiumcodereview.appspot.com/11034009

TBR=grv@chromium.org
Review URL: https://codereview.chromium.org/11066025
------------------------------------------------------------------------
Leaving the bug open for the more fundamental fix (http://codereview.chromium.org/10977048).
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 4 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=160259

------------------------------------------------------------------------
r160259 | grv@chromium.org | 2012-10-04T23:03:32.345423Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension.h?r1=160259&r2=160258&pathrev=160259
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/media_gallery/media_galleries_preferences_unittest.cc?r1=160259&r2=160258&pathrev=160259
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/test/integration/sync_extension_helper.cc?r1=160259&r2=160258&pathrev=160259
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_service_unittest.cc?r1=160259&r2=160258&pathrev=160259
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/panels/base_panel_browser_test.cc?r1=160259&r2=160258&pathrev=160259
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_service.cc?r1=160259&r2=160258&pathrev=160259
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_service.h?r1=160259&r2=160258&pathrev=160259
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/installed_loader.cc?r1=160259&r2=160258&pathrev=160259
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/app_process_apitest.cc?r1=160259&r2=160258&pathrev=160259
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/unpacked_installer.cc?r1=160259&r2=160258&pathrev=160259
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/crx_installer.cc?r1=160259&r2=160258&pathrev=160259
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_prefs_unittest.cc?r1=160259&r2=160258&pathrev=160259
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/test_extension_prefs.cc?r1=160259&r2=160258&pathrev=160259
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_prefs.cc?r1=160259&r2=160258&pathrev=160259
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_prefs.h?r1=160259&r2=160258&pathrev=160259
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browsertest.cc?r1=160259&r2=160258&pathrev=160259
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_sorting_unittest.cc?r1=160259&r2=160258&pathrev=160259

Fix bug in disabling sync for default apps

We added a new creation_flag for default apps was_installed_by_default,
 but every time we add a new creation_flag, we need to update the installedLoader
 as it does not directly pick the creation_flags but re-creates them
 through other preferences.
To fix this, I added a new preference to save creation_flags in preference,
 and read that directly.

BUG= 152582 
TBR=nick@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10977048
------------------------------------------------------------------------
Status: Fixed
Project Member

Comment 18 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-Internals -Feature-Apps -Mstone-23 Cr-Platform-Apps Cr-Internals M-23

Sign in to add a comment