Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Issue 14937 Alternate nav url infobar
Starred by 1 user Project Member Reported by pinkerton@chromium.org, Jun 22 2009 Back to list
Status: Verified
Owner:
Closed: Jul 2009
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment
ben explains thusly:

when you type 'cheeze', the default is to go and search for cheeze. however
it also kicks off a request to see if a hostname exists on the local
network. If found, it shows an infobar that asks if you really meant
http://cheeze.
 
Status: Assigned
Hi Scott, If this is omnibox is this you? Otherwise, please assign to Rohit for infobar.
Comment 2 by sh...@chromium.org, Jul 8 2009
I cannot offhand find something which clearly indicates that the Omnibox code does this.  I can see us passing 
things around, AFAICT we're passing things the same as win or gtk.  It looks like shared code in 
chrome/browser/alternate_nav_url_fetcher.cc should be handling it.
Comment 3 by bugdro...@gmail.com, Jul 17 2009
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=20930 

------------------------------------------------------------------------
r20930 | rohitrao@chromium.org | 2009-07-16 20:16:58 -0700 (Thu, 16 Jul 2009) | 10 lines
Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/en.lproj/InfoBar.xib
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/en.lproj/InfoBarContainer.xib
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm?r1=20930&r2=20929
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h?r1=20930&r2=20929
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm?r1=20930&r2=20929
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm?r1=20930&r2=20929
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.h?r1=20930&r2=20929
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.mm?r1=20930&r2=20929
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/infobar.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/infobar_container_controller.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/infobar_container_controller.mm
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/infobar_container_controller_unittest.mm
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/infobar_controller.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/infobar_controller.mm
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/infobar_controller_unittest.mm
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/infobar_test_helper.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/infobar_text_field.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/infobar_text_field.mm
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/infobar_text_field_unittest.mm
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.h?r1=20930&r2=20929
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.mm?r1=20930&r2=20929
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm?r1=20930&r2=20929
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=20930&r2=20929
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/temp_scaffolding_stubs.cc?r1=20930&r2=20929

First cut at infobars on Mac.  These are not expected to be
pretty.  Animations and aesthetic appeal will come in a
future CL.

BUG= http://crbug.com/14462 
BUG= http://crbug.com/14937 
BUG= http://crbug.com/15839 
BUG= http://crbug.com/16487 
TEST=Infobars should show up when expected.
Review URL: http://codereview.chromium.org/155494
------------------------------------------------------------------------

Status: Fixed
Status: Verified
3.0.195.0 rev: 21075
Project Member Comment 6 by bugdroid1@chromium.org, Oct 12 2012
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Sign in to add a comment