New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 7 users
Status: Verified
Owner:
User never visited
Closed: Jul 2009
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: ----

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment
bzip2 encoded results may be corrupted by proxies (such as Vodaphone (UK) Mobile Broadband)
Project Member Reported by jar@chromium.org, Jun 20 2009 Back to list
What steps will reproduce the problem?
1.Use a proxy with an ISP such as Vodaphone (UK) Mobile Broadband
2.Visit a page that is bzip2 encoded, such as 
http://ukcp09.defra.gov.uk/content/view/16/6/index.html
3. Page will be corrupted.

What is the expected output? What do you see instead?

Garbled characters.

To repro, use another ISP, and visit the above URL:
http://ukcp09.defra.gov.uk/content/view/16/6/index.html
Then modify the URL to read:
view-cache:http://ukcp09.defra.gov.uk/content/view/16/6/index.html
You should see it was bzip2 encoded.

Repeat the process using a problematic proxy.
You'll (incorrectly) see a content encoding of gzip.
Extract the gzip decoded file.  Run bzip2 on it, and it should decompress 
porperly.

The above bug was deduced from reports in the following forum thread:
http://www.google.com/support/forum/p/Chrome/thread?
tid=24436bd4ef660e1e&hl=en

Possible remedition: Terminate support for bzip2. ...or convince Vodaphone 
to stop trashing content... or find a way to tell Vodaphone and others like 
it to not damage content.  Perhaps there is a way (for example) to to have 
serving sites add an HTTP header when serving bzip2:

Warning: 214 msgwsl11 "Transformation applied"

and that would discourage Vodaphone. Alternatively, perhaps the above 
warning header can be detected by chrome, and then bzip can be 
discontinued.
 
Comment 1 by jar@chromium.org, Jun 24 2009
Status: Started
Plan is to disable advertisment of bzip in headers, and eventually yank all support for 
it from the browser.  The risk of incompatibility (corrupting content) when passing 
through proxies is too high. 
Comment 2 by jar@chromium.org, Jun 24 2009
 Issue 5579  has been merged into this issue.
Note: Not sure if it was hoped to, but unfortunately adding --enable-sdch=nowhere to 
the end of my chrome shortcut (aka Step 3 in 
<http://www.google.com/support/forum/p/Chrome/thread?tid=24436bd4ef660e1e&hl=en>) did 
not fix  Issue 5579  for me.
Comment 4 by jar@chromium.org, Jun 24 2009
Jamesda: This bug is really concerned with "bzip2" compression.  The flag you 
mentioned was meant to disable "sdch" compression.  There is currently no flag to 
disable bzip2.  As noted above, I'm working on disabling bzip2 completely to avoid 
problems that appear to be happening with proxies.

As a side not, it would be helpful if you mentioned who your ISP was when you saw the 
corruption.

Thanks in advance for your help!

Jim
Comment 5 by bugdro...@gmail.com, Jun 24 2009
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=19173 

------------------------------------------------------------------------
r19173 | jar@chromium.org | 2009-06-24 14:26:27 -0700 (Wed, 24 Jun 2009) | 16 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/url_request/url_request_http_job.cc?r1=19173&r2=19172
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/url_request/url_request_unittest.cc?r1=19173&r2=19172

Start to disable bzip2 support.  First step: Stop advertising support.

Although it would be nice to just yank it all, it is good to do
so slowly so that any cached data that might required bzip2 decoding
will still decode and render.  Maybe I'm being paranoid... but this seems
like a nice first small step.

I also disabled the tests that depend on this modified code, and linted
the unittest file a bit.

BUG= 14801 

TEST= Be sure you can still view http://ukcp09.defra.gov.uk/content/view/16/6/index.html which is (currently) bzip encoded.

r=hunar
Review URL: http://codereview.chromium.org/147058
------------------------------------------------------------------------

Thanks, good to hear I can soon use chrome to browse xkcd :)

"it would be helpful if you mentioned who your ISP was when you saw the corruption"

At home, I experience no corruption and I use Optimum Online residential cable 
internet.
At work, I do experience the corruption, but I do not know who my company's ISP is. I 
only know that my company uses a proxy server. I have no way to bypass the company's 
proxy server and still access whoever their ISP is.
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=19926 

------------------------------------------------------------------------
r19926 | mal@chromium.org | 2009-07-03 18:50:39 -0700 (Fri, 03 Jul 2009) | 17 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/172/src/net/url_request/url_request_http_job.cc?r1=19926&r2=19925
   M http://src.chromium.org/viewvc/chrome/branches/172/src/net/url_request/url_request_unittest.cc?r1=19926&r2=19925

Merge r19173.

Start to disable bzip2 support.  First step: Stop advertising support.

Although it would be nice to just yank it all, it is good to do
so slowly so that any cached data that might required bzip2 decoding
will still decode and render.  Maybe I'm being paranoid... but this seems
like a nice first small step.

I also disabled the tests that depend on this modified code, and linted
the unittest file a bit.

BUG= 14801 

TEST= Be sure you can still view http://ukcp09.defra.gov.uk/content/view/16/6/index.html which is (currently) bzip encoded.

Review URL: http://codereview.chromium.org/155065
------------------------------------------------------------------------

Comment 8 by ace@chromium.org, Jul 14 2009
Status: Verified
Verified the behavior change in the fix meant to address the bug for 2.0.172.37
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=34047 

------------------------------------------------------------------------
r34047 | thestig@chromium.org | 2009-12-08 00:28:17 -0800 (Tue, 08 Dec 2009) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/base/DEPS?r1=34047&r2=34046
   D /trunk/src/net/base/bzip2_filter.cc
   D /trunk/src/net/base/bzip2_filter.h
   D /trunk/src/net/base/bzip2_filter_unittest.cc
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/base/filter.cc?r1=34047&r2=34046
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/base/filter.h?r1=34047&r2=34046
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/base/filter_unittest.cc?r1=34047&r2=34046
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/net.gyp?r1=34047&r2=34046
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/url_request/url_request_unittest.cc?r1=34047&r2=34046

Remove bzip2 decoding support completely.

BUG= 14801 , 26577 
TEST=see bug.
Review URL: http://codereview.chromium.org/466038
------------------------------------------------------------------------

Project Member Comment 10 by bugdroid1@chromium.org, Oct 12 2012
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Sign in to add a comment