New issue
Advanced search Search tips
Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2015
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment
link

Issue 147644: Browser plugin should be aware of tab direction

Reported by fsam...@chromium.org, Sep 10 2012 Project Member

Issue description

The browser plugin should be aware of the tab direction (if any) when it takes focus so that it knows what initial element within the guest to focus.
 

Comment 1 by fsam...@chromium.org, Oct 2 2012

Labels: -Pri-2 Mstone-24 Pri-1

Comment 2 by fsam...@chromium.org, Oct 15 2012

Labels: -Mstone-24 Mstone-25
This requires some WebKit work that probably won't make it in until M25. Moving to M25.

Comment 3 by finnur@chromium.org, Oct 26 2012

Status: Assigned
We seem to have accumulated a lot of issues with an owner assigned without the Assigned tag. Bulk fixing.

Comment 4 by fsam...@chromium.org, Dec 11 2012

Labels: -Mstone-25 Mstone-26

Comment 5 by fsam...@chromium.org, Jan 14 2013

Labels: Hotlist-GoodFirstBug

Comment 6 by fsam...@chromium.org, Feb 4 2013

Labels: -Pri-1 Pri-2
Lowering priority for this.

Comment 7 by fsam...@chromium.org, Feb 11 2013

Labels: -Mstone-26 Mstone-27

Comment 8 by bugdroid1@chromium.org, Mar 10 2013

Project Member
Labels: -Area-Internals -Feature-Apps-BrowserTag -Mstone-27 Cr-Internals Cr-Platform-Apps-BrowserTag M-27

Comment 9 by kareng@google.com, Apr 15 2013

Labels: -M-27 MovedFrom-27 M-28
Moving all non essential bugs to the next Milestone

Comment 10 by kareng@google.com, Apr 15 2013

Moving all non essential bugs to the next Milestone

Comment 11 by bugdroid1@chromium.org, May 8 2013

Project Member
Labels: -M-28 MovedFrom-28
This issue has already been moved once and is lower than Priority 1,therefore removing mstone.

Comment 12 by fsam...@chromium.org, Aug 26 2014

Labels: -Pri-2 Pri-3

Comment 13 by bugdroid1@chromium.org, Jan 16 2015

Project Member
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=188535

------------------------------------------------------------------
r188535 | fsamuel@chromium.org | 2015-01-16T13:26:21.732335Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLSelectElement.h?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/ChromeClientImpl.h?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/SpatialNavigation.cpp?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/forms/InputTypeView.h?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/EventHandler.cpp?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Document.cpp?r1=188535&r2=188534&pathrev=188535
   A http://src.chromium.org/viewvc/blink/trunk/public/platform/WebFocusType.h?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/Chrome.h?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLLegendElement.cpp?r1=188535&r2=188534&pathrev=188535
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/page/FocusType.h?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLInputElement.cpp?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/FocusController.h?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/forms/TextFieldInputType.cpp?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Element.cpp?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGAElement.cpp?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebPluginContainerImpl.h?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTextFormControlElement.cpp?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLFormControlElement.h?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLAnchorElement.cpp?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTextAreaElement.cpp?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLSelectElement.cpp?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/ChromeClientImpl.cpp?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/forms/InputTypeView.cpp?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLLabelElement.h?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/Chrome.cpp?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/EmptyClients.h?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/ChromeClient.h?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/SpatialNavigation.h?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/FocusController.cpp?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/EventHandler.h?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Document.h?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/public/web/WebPlugin.h?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebPluginContainerImpl.cpp?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLLegendElement.h?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLInputElement.h?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLFormControlElement.cpp?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/forms/TextFieldInputType.h?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Element.h?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGAElement.h?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebViewImpl.cpp?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTextFormControlElement.h?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLAnchorElement.h?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLLabelElement.cpp?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/Widget.h?r1=188535&r2=188534&pathrev=188535
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTextAreaElement.h?r1=188535&r2=188534&pathrev=188535

Propagate focus type to plugins

<webview> needs to be aware of tab direction so that it can set the appropriate
initial focus. This issue is manifested in the Chrome signin-based which is now
<webview> based.

BUG= 448716 ,  147644 

Review URL: https://codereview.chromium.org/852083002
-----------------------------------------------------------------

Comment 14 by bugdroid1@chromium.org, Jan 19 2015

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ec049ddf4a699a2fe3cf9531de78f91def7da07

commit 5ec049ddf4a699a2fe3cf9531de78f91def7da07
Author: fsamuel <fsamuel@chromium.org>
Date: Mon Jan 19 16:57:41 2015

Browser Plugin: Make aware of focus direction.

In order to fix focus ordering into and out of GuestViews, this CL makes focus
aware of tab direction.

This CL is the content side change for this Blink change:
https://codereview.chromium.org/852083002

BUG= 448716 ,  147644 
TBR=kenrb@chromium.org for trivial browser_plugin_messages.h change (added focus type to existing IPC).

Review URL: https://codereview.chromium.org/853333002

Cr-Commit-Position: refs/heads/master@{#312126}

[modify] http://crrev.com/5ec049ddf4a699a2fe3cf9531de78f91def7da07/components/plugins/renderer/webview_plugin.cc
[modify] http://crrev.com/5ec049ddf4a699a2fe3cf9531de78f91def7da07/components/plugins/renderer/webview_plugin.h
[modify] http://crrev.com/5ec049ddf4a699a2fe3cf9531de78f91def7da07/content/browser/DEPS
[modify] http://crrev.com/5ec049ddf4a699a2fe3cf9531de78f91def7da07/content/browser/browser_plugin/browser_plugin_embedder.cc
[modify] http://crrev.com/5ec049ddf4a699a2fe3cf9531de78f91def7da07/content/browser/browser_plugin/browser_plugin_embedder.h
[modify] http://crrev.com/5ec049ddf4a699a2fe3cf9531de78f91def7da07/content/browser/browser_plugin/browser_plugin_guest.cc
[modify] http://crrev.com/5ec049ddf4a699a2fe3cf9531de78f91def7da07/content/browser/browser_plugin/browser_plugin_guest.h
[modify] http://crrev.com/5ec049ddf4a699a2fe3cf9531de78f91def7da07/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] http://crrev.com/5ec049ddf4a699a2fe3cf9531de78f91def7da07/content/common/DEPS
[modify] http://crrev.com/5ec049ddf4a699a2fe3cf9531de78f91def7da07/content/common/browser_plugin/browser_plugin_messages.h
[modify] http://crrev.com/5ec049ddf4a699a2fe3cf9531de78f91def7da07/content/renderer/browser_plugin/browser_plugin.cc
[modify] http://crrev.com/5ec049ddf4a699a2fe3cf9531de78f91def7da07/content/renderer/browser_plugin/browser_plugin.h
[modify] http://crrev.com/5ec049ddf4a699a2fe3cf9531de78f91def7da07/content/renderer/browser_plugin/browser_plugin_manager.cc
[modify] http://crrev.com/5ec049ddf4a699a2fe3cf9531de78f91def7da07/content/renderer/npapi/webplugin_impl.cc
[modify] http://crrev.com/5ec049ddf4a699a2fe3cf9531de78f91def7da07/content/renderer/npapi/webplugin_impl.h
[modify] http://crrev.com/5ec049ddf4a699a2fe3cf9531de78f91def7da07/content/renderer/pepper/pepper_webplugin_impl.cc
[modify] http://crrev.com/5ec049ddf4a699a2fe3cf9531de78f91def7da07/content/renderer/pepper/pepper_webplugin_impl.h

Comment 15 by fsam...@chromium.org, Jan 19 2015

Status: Fixed

Comment 16 by bugdroid1@chromium.org, Feb 23 2015

Project Member
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=190679

------------------------------------------------------------------
r190679 | bratell@opera.com | 2015-02-23T19:16:17.826712Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/core.gypi?r1=190679&r2=190678&pathrev=190679

Updating gypi after moving FocusType.h.

Source/core/page/FocusType was moved to
public/WebFocusType.h in https://codereview.chromium.org/852083002
This updates the gypi file to reflect that change and to avoid
a warning in the msvs-ninja gyp generator.

Note: there is no gypi file that tracks the files in public/platform.

R=fsamuel@chromium.org,jochen@chromium.org

BUG= 448716 , 147644 , 459058 

Review URL: https://codereview.chromium.org/950833002
-----------------------------------------------------------------

Comment 17 by bugdroid1@chromium.org, Aug 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5eeadd143332f6fc6c26af924d8a38d5f49b06a2

commit 5eeadd143332f6fc6c26af924d8a38d5f49b06a2
Author: Kevin McNee <mcnee@chromium.org>
Date: Fri Aug 10 17:57:31 2018

Remove unnecessary tab key press from Focus_AdvanceFocus test

The associated bug which required this extra tab is fixed.

Bug:  147644 
Change-Id: Ied21533accc82613053e119aa2c5c64fc9de8343
Reviewed-on: https://chromium-review.googlesource.com/1170986
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582240}
[modify] https://crrev.com/5eeadd143332f6fc6c26af924d8a38d5f49b06a2/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc

Comment 18 by bugdroid1@chromium.org, Aug 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6df1590559bd965c71b181b4d948e0ea3318189a

commit 6df1590559bd965c71b181b4d948e0ea3318189a
Author: Peter Kasting <pkasting@chromium.org>
Date: Sat Aug 11 05:15:47 2018

Revert "Remove unnecessary tab key press from Focus_AdvanceFocus test"

This reverts commit 5eeadd143332f6fc6c26af924d8a38d5f49b06a2.

Reason for revert: Seems to have caused failures on mac_cocoa_rel, see e.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8938549477439492256/+/steps/interactive_ui_tests/0/logs/WebViewFocusInteractiveTest.Focus_AdvanceFocus/0

Original change's description:
> Remove unnecessary tab key press from Focus_AdvanceFocus test
> 
> The associated bug which required this extra tab is fixed.
> 
> Bug:  147644 
> Change-Id: Ied21533accc82613053e119aa2c5c64fc9de8343
> Reviewed-on: https://chromium-review.googlesource.com/1170986
> Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
> Commit-Queue: Kevin McNee <mcnee@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582240}

TBR=ekaramad@chromium.org,mcnee@chromium.org

Change-Id: I6c84e6950d7f74ae5b15eec084a536115e635ceb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  147644 
Reviewed-on: https://chromium-review.googlesource.com/1172002
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582429}
[modify] https://crrev.com/6df1590559bd965c71b181b4d948e0ea3318189a/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc

Comment 19 by bugdroid1@chromium.org, Aug 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecf80c2fa1790fb10e2df42ed5ae8c60c9bad1a1

commit ecf80c2fa1790fb10e2df42ed5ae8c60c9bad1a1
Author: Kevin McNee <mcnee@chromium.org>
Date: Tue Aug 14 14:03:37 2018

Remove unnecessary tab key press from Focus_AdvanceFocus test

The associated bug which required this extra tab is fixed.

Bug:  147644 
Change-Id: Ic256c30eda064134d670f3ce49ca7483a0ed5ff7
Reviewed-on: https://chromium-review.googlesource.com/1173400
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582904}
[modify] https://crrev.com/ecf80c2fa1790fb10e2df42ed5ae8c60c9bad1a1/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc

Sign in to add a comment