New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 145622 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Sep 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Inline disposition not displaying correctly

Reported by mgaba@chromium.org, Aug 30 2012

Issue description

Version: 23.0.1248.0 canary
OS: OSX 10.8

What steps will reproduce the problem?
1. Go to webintents.org
2. Select pick intent
3. Pick from "webpage screenshot" app

What is the expected output? What do you see instead?
We expect the inline disposition to look like the mocks (attached). Instead it looks like the attached screenshot

Please use labels and text to provide additional information.
 
Screen Shot 2012-08-29 at 4.14.02 PM.png
151 KB View Download
This bug is not particularly useful.  What, in particular, is not displaying correctly?  Yes I can see a few things, but it would really help to have UI reviewers point out specific issues they are seeing, e.g., the 'Use another service' button should be right-aligned in the header.

Comment 2 by mgaba@chromium.org, Aug 30 2012

Differences from the mock (header):

No service icon in top left corner.
Wrong font for service name. (Bold) 
No line separating header from service body.
Use another service is not right aligned.
Use another service has incorrect string.
Use another service should not be underlined.
Use another service may be incorrectly positioned vertically. (Difficult to tell without header line)
Mousein on "Use another service" shows hand selector, but mouseout does not reset to normal pointer until you enter into the service content.

In general, the look and feel of the inline disposition is not at all polished, and the point of this bug is to call attention to that fact. Once we get closer to the mocks, then more specific UI nits from a UI reviewer are appropriate, imo.

Rachel, if you don't already have more specific UI guidelines (px values, font names, etc.) please let me know. I am assuming that that's something you already have :)

Additionally (maybe these should be other bugs):
The inline window is overly shrinking the content. For shrunken content, there is lots of whitespace to the right of the shrunk content.

In some apps (Google+) the service content overflows into the header. 

Also, this may be hard to repro, but I was just trying to test again on the same version of canary, and approximately 2/10 times I chose "pick" the content just did not display, only the header. 




Comment 3 by groby@chromium.org, Aug 30 2012

"Use another service" is a hyperlink. As such, it comes with an underline.  Do we want a completely different controls style, or is that a mistake in the headers?

Which bold font? Technically, constrained dialogs are supposed to use BaseFont and/or MediumBoldFont. The size is BaseFont. 

Use another service has identical vertical alignment to the service name.

Can't repro mouse hover issue.
Can't repro non-display of content.

Please file inline resize as a different bug. 

And no, I don't have font names, px values, etc :)


 

Comment 4 by mgaba@chromium.org, Aug 30 2012

I think the "Use Another Service" definitely looks better without the underline. Only concern is whether users would know to click on it w/o the underline. I say no underline for now, and if we get feedback that people are struggling w/ discovery, then we can add the underline back.

Let's see how MediumBoldFont looks for the service name.

Mouse hover issue is a little hard to explain, might be easier to demo over VC. 


Comment 5 by mgaba@chromium.org, Aug 30 2012

I'll try to explain the mouseover thing. Mouseover the link, then move your mouse right over the whitespace to the right of the link. The pointer will not reset. When you click, nothing will happen. 

Now mouseover the link, slide your mouse directly down into the white space below the link. The pointer will not reset until your cursor enters into the service content area.

Comment 6 by groby@chromium.org, Sep 4 2012

Screenshot for OSX. Specifically fixing the block of issues called out at the top of comment #2

Screen shot 2012-09-04 at 1.58.13 PM.png
174 KB View Download

Comment 7 by mgaba@chromium.org, Sep 4 2012

Cool! To my untrained eye, it looks like the title font is smaller than the title font in the mock. Should we have Jeff take a look at this screenshot and give his feedback?

Comment 8 by groby@chromium.org, Sep 6 2012

Additional UI feedback
web-intents-header-markup.png
2.1 MB View Download

Comment 9 by groby@chromium.org, Sep 6 2012

Inline disposition header as rendered with newest code.
Screen shot 2012-09-05 at 7.40.26 PM.png
31.3 KB View Download

Comment 10 by mgaba@chromium.org, Sep 10 2012

Labels: -Pri-1 Pri-2
Labels: -Pri-2 -Mstone-23 Pri-1 Mstone-24
Owner: mgaba@chromium.org
Needs to be broken into individual tasks.

Comment 12 by groby@chromium.org, Sep 12 2012

These items are done on Mac:

No service icon in top left corner.
Wrong font for service name. (Bold) 
No line separating header from service body.
Use another service is not right aligned.
Use another service has incorrect string.
Use another service should not be underlined.
Use another service may be incorrectly positioned vertically. (Difficult to tell without header line)
Mousein on "Use another service" shows hand selector, but mouseout does not reset to normal pointer until you enter into the service content.



Comment 13 by groby@chromium.org, Sep 12 2012

> In general, the look and feel of the inline disposition is not at all polished, and the point of this bug is to call attention to that fact. Once we get closer to the mocks, then more specific UI nits from a UI reviewer are appropriate, imo.

Please do call out individual issues as separate bugs and we'll be happy to address them.

> Rachel, if you don't already have more specific UI guidelines (px values, font names, etc.) please let me know. I am assuming that that's something you already have :)

We still need these. Ideally, Jeff will annotate the mocks.

>The inline window is overly shrinking the content. For shrunken content, there is lots of whitespace to the right of the shrunk content.

Standard resize behavior. There is a separate bug to force a min size if no CSS width is set. (But setting a CSS width will force the proper size right now)

> In some apps (Google+) the service content overflows into the header. 

Resizing bug on Mac.  bug #146679 

> Also, this may be hard to repro, but I was just trying to test again on the same version of canary, and approximately 2/10 times I chose "pick" the content just did not display, only the header. 

As far as I can tell, same resizing bug on Mac. (Note to implementers: We do not preserve the size of the inline HTML view. If we get additional performLayout messages after the auto-resizing, we can overflow or loose content. Preserve size, account for it in performLayout)

The items called out as being fixed in Comment 12 are in change http://codereview.chromium.org/10917077. Should be submitted today.

Status: Fixed
Okay. At this point I think we've addressed all of the issues raise directly in this bug. All outstanding issues are tracked in other bugs, or should be filed as new specific bugs.

Personal note: I know this can a bit of a difficult processes, fine tuning things via bugs. I really appreciate everyone working though this together.

FYI, the "set minimum size" issues is tracked at #145637

Project Member

Comment 16 by bugdroid1@chromium.org, Sep 19 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=157616

------------------------------------------------------------------------
r157616 | groby@chromium.org | 2012-09-19T21:52:40.324941Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=157616&r2=157615&pathrev=157616
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/web_intent_sheet_controller.mm?r1=157616&r2=157615&pathrev=157616

[WebIntents, OSX] Clean up inline disposition to match mock.

R=thakis@chromium.org
BUG= 145622 

Review URL: https://chromiumcodereview.appspot.com/10917077
------------------------------------------------------------------------
Project Member

Comment 17 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Mstone-24 -Feature-WebIntents Cr-UI-Browser-WebIntents Cr-UI M-24

Sign in to add a comment