New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 144874 link

Starred by 8 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Clear browsing data never completes with PPAPI flash plugin disabled

Reported by imorth...@gmail.com, Aug 26 2012

Issue description

Chrome Version       : 21.0.1180.83
OS Version: 5.1 (Windows XP)
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 5:
Firefox 4.x:
IE 7/8/9:

What steps will reproduce the problem?
1.Disable PPAPI plugin pepflashplayer.dll using chrome://plugins/
2.CTRL-Shift-Del to delete browsing data
3.Clear browsing data
4.Wait a long time...
What is the expected result?
Browsing data delete and dialog box exited

What happens instead?
Process never completes.

Please provide any additional information below. Attach a screenshot if possible.
It appears the data is deleted but the process then hangs. Specific settings were delete everything, all of time.

If I enable PPAPI and try again problem goes away.

Note: PPAPI disabled because of slow performance eg  issue 142102 

UserAgentString: Mozilla/5.0 (Windows NT 5.1) AppleWebKit/537.1 (KHTML, like Gecko) Chrome/21.0.1180.83 Safari/537.1


 

Comment 1 by meh...@chromium.org, Aug 26 2012

Labels: -Area-Undefined Area-Internals OS-Mac Feature-Plugins Feature-Plugins-Pepper
Status: Untriaged
Thanks for the report. Confirmed with latest Canary on Mac OS 10.6.8.

Comment 2 by mark@chromium.org, Aug 27 2012

Labels: Feature-Privacy

Comment 3 by battre@chromium.org, Aug 27 2012

Cc: mkwst@chromium.org bauerb@chromium.org

Comment 4 by nepper@chromium.org, Aug 27 2012

Cc: viettrungluu@chromium.org jeffreyc@chromium.org
Labels: -Pri-2 Pri-1 Mstone-23
Status: Available
This should certainly be fixed for M23. Would be even better to have it merged back to earlier releases as soon as we have a fix.

As Bernhard is out atm, can anyone try a fix?

Comment 5 by mkwst@google.com, Aug 27 2012

If no one cleverer than I picks it up tonight, I'll take it tomorrow.

Comment 6 by mkwst@chromium.org, Aug 28 2012

mehmet@ can you try again with today's Canary? I don't see the issue on 23.0.1246.0, and can't replicate it on Linux or Mac ToT.

Comment 7 by meh...@chromium.org, Aug 28 2012

@mkwst: The issue is still present in Chrome Version 23.0.1247.1 canary on Mac OS 10.6.8.

Comment 8 by mkwst@google.com, Aug 28 2012

Ok. And all you're doing to replicate it is disabling the PPAPI Flash plugin, right? Doing exactly that on my laptop (also 10.6.8) didn't produce a hang.

If you don't have anything particularly personal in your profile, would you mind zipping it up and sending it over?

Comment 9 by meh...@chromium.org, Aug 28 2012

@Mike: My default profile is sended over to you via my gmx account. Hope it doesn't ends in your spam folder :-) 

Gmail does not allow it to send zipped files ?!?!?

Thanks 
Mehmet
Hi, what's the status of this?
jeffreyc: It is still an issue for me in Chrome Version 23.0.1255.0 canary.

mkwst: Did you receive my profile ?

Comment 12 by mkwst@chromium.org, Sep 24 2012

Owner: engedy@chromium.org
Balazs stepped up to take this. Thanks!

Comment 13 by mkwst@chromium.org, Sep 24 2012

Cc: markusheintz@chromium.org
 Issue 144375  has been merged into this issue.
Status: Started
Labels: -OS-Windows -OS-Mac OS-All
It turns out that there is one more key ingredient to reproducing this issue: prior to disabling the PPAPI flash plugin, an initial deletion of browsing data (with "Remove Content Licenses" checked) is also required as Step 0. If you start from Step 1. with an empty profile (clean slate), the hang will not occur.

--

The issue itself is an unfortunate case of a UI glitch exercising an error-handling path in the underlying implementation that itself has an error. More specifically:

1.) "UI glitch": the checked-state for the "Remove Content Licenses" check-box in the "Clear Browsing Data" dialog is persisted for consecutive showings of the dialog. Although disabling the PPAPI Flash plugin correctly hides this check-box (because removing Content Licences is only possible with the PPAPI Flash),  behind the curtain the checked state remains and this causes the REMOVE_CONTENT_LICENSES flag to be added to the |remove_mask| with which BrowsingDataRemover::RemoveImpl is invoked.

2.) "Error in error-handling": recognizing that REMOVE_CONTENT_LICENSES is set, the BrowsingDataRemover calls out to PepperFlashSettingsManager to remove the licenses. In normal cases, to this end, PepperFlashSettingsManager::Core::InitializeOnIOThread would try to initiate a channel to the plug-in, but seeing that the PPAPI Flash is disabled, it instead fails early. It has a mechanism (NotifyErrorFromIOThread) in place that is responsible for firing the callbacks (with result=failure) for all the en-queued tasks in these error situations, but unfortunately this mechanism is also called from EnsureCoreExists, which is in turn called before the DeauthorizeContentLicenses task would get en-queued. Consequently, the callback for this task will never get fired by NotifyErrorFromIOThread, and will end up stuck in the queue. Finally, BrowsingDataRemover will never get a notification from PepperFlashSettingsManager saying that it has finished removing stuff, so the dialog window will never disappear.

We will fix these two issues in two separate CLs.



Project Member

Comment 16 by bugdroid1@chromium.org, Oct 1 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=159569

------------------------------------------------------------------------
r159569 | bauerb@chromium.org | 2012-10-01T22:05:27.613917Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/pepper_flash_settings_manager.cc?r1=159569&r2=159568&pathrev=159569
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/pepper_flash_settings_manager.h?r1=159569&r2=159568&pathrev=159569

Fail incoming requests in PepperFlashSettingsManager after an error.

This is the second of two CLs to address the issue mentioned below. It is in itself enough in itself to fix the issue, but given that the issue actually discovered two bugs, there is an other CL to fix the other bug too. See issue for details.

BUG= 144874 

Review URL: https://chromiumcodereview.appspot.com/10986059
------------------------------------------------------------------------
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 2 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=159667

------------------------------------------------------------------------
r159667 | engedy@chromium.org | 2012-10-02T10:34:49.110680Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/clear_browser_data_handler.cc?r1=159667&r2=159666&pathrev=159667
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/clear_browser_data_handler.h?r1=159667&r2=159666&pathrev=159667

Sanity checks to make sure we are not trying to clear Content Licenses when Flash Pepper is not in use.

Added sanity checks to ClearBrowserDataHandler to ensure that when it calls BrowsingDataRemover::Remove, the |remove_mask| will not have the REMOVE_CONTENT_LICENSES flag set when PPAPI Flash is disabled -- even if the corresponding "Deauthorize Content Licenses" checkbox on the "Clear Browsing Data" dialog is checked.

This is required because while removing Content Licenses is only possible with PPAPI Flash, the checked state for the check-box is persisted, and thus even though the check-box gets hidden when PPAPI Flash is disabled, it will still be checked behind the curtains, and would cause the above-mentioned flag to be set.

We opt to keep the persisted checked-state for the check-box though, to provide consistency in the case PPAPI Flash gets re-enabled later.

This is the first of two CLs to address the issue mentioned below. It is in itself enough to fix the issue, but given that the issue actually discovered two bugs, there is an other CL to fix the other bug too. See issue for details.

BUG= 144874 


Review URL: https://chromiumcodereview.appspot.com/11000022
------------------------------------------------------------------------
Status: Fixed
Both CLs committed. I will check if we want to merge this.
Probably,  issue 133780  (http://code.google.com/p/chromium/issues/detail?id=133780) must be merged with this one and also be closed.
Cc: yzshen@chromium.org
 Issue 133780  has been merged into this issue.
 Issue 153790  has been merged into this issue.
Cc: brettw@chromium.org
 Issue 154999  has been merged into this issue.
I am not a programmer and know not the fancy language I disabled pepper flash and cleared all aspects of my browser data...know it just hangs.

Comment 24 by Deleted ...@, Dec 19 2012

Same here won't quit, just crashes and pepperflash is disabled on my system too.19 Dec 2012
Untitled-1.jpg
58.8 KB View Download
Do you have a crash ID (from chrome://crashes)?
Project Member

Comment 26 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-Internals -Feature-Plugins -Feature-Plugins-Pepper -Feature-Privacy -Mstone-23 Cr-Privacy Cr-Internals M-23 Cr-Content-Plugins Cr-Content-Plugins-Pepper
Project Member

Comment 27 by bugdroid1@chromium.org, Apr 6 2013

Labels: Cr-Blink
Project Member

Comment 28 by bugdroid1@chromium.org, Apr 6 2013

Labels: -Cr-Content-Plugins Cr-Internals-Plugins
Project Member

Comment 29 by bugdroid1@chromium.org, Apr 6 2013

Labels: -Cr-Content-Plugins-Pepper Cr-Internals-Plugins-Pepper

Comment 30 by laforge@google.com, Jul 24 2013

Cc: -jeffreyc@chromium.org

Sign in to add a comment