New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 18 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment
link

Issue 144425: Tab strip context menu not working

Reported by nyerramilli@chromium.org, Aug 23 2012 Project Member

Issue description

Chrome Version       : 23.0.1243.0 and latest canary 23.0.1243.0
URLs (if applicable) : NA
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
     Safari 5: NA
  Firefox 4.x: NA
       IE 7/8/9: NA

What steps will reproduce the problem?
1. Open Google chrome
2. Right click on the tab strip
3. Check 'Minimize','Maximize' and 'Restore' options.

What is the expected result?
Minimize option--browser window should be minimized.
Maximize option -- browser window should be maximized.
Restore option -- browser window restore to previous state.

What happens instead?
Minimize,Restore option are disabled.
Maximize option is not working.

Please provide any additional information below. Attach a screenshot if
possible.

Tested in 22.0.1229.12(dev),21.0.1180.83(beta) and 21.0.1180.79(previous stable)---Not reproducible.


Please check the attached screenshot.
 
TabStrip_Windows7.jpg
134 KB View Download

Comment 1 by ligim...@chromium.org, Aug 23 2012

Cc: pavanv@chromium.org
Labels: -Type-Bug -Pri-2 Type-Regression Pri-1 ReleaseBlock-Beta Feature-TabStrip Action-BisectNeeded
Status: Untriaged
Summary: Tab strip context menu not working
Good Build # 22.0.1229.12 (Official Build 152477)
Bad Build # 23.0.1243.0 

Narayana.. Please Install the bisect tool & narrow down the regression window

Comment 2 by pavanv@chromium.org, Aug 23 2012

Labels: -Action-BisectNeeded
bisect output for reference:

You are probably looking for a change made after 152373 (known good), but no lat
er than 152392 (first known bad).
CHANGELOG URL:
  http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/tru
nk/src&range=152373%3A152392

Comment 3 by kareng@google.com, Aug 23 2012

Owner: sky@chromium.org
Status: Assigned
scott is this possibly due to some of ben's changes in the range?

Comment 4 by sky@chromium.org, Aug 23 2012

Owner: ben@chromium.org
That is certainly possible.

Comment 5 by kareng@google.com, Aug 24 2012

ben did u get a chance to look at this?

Comment 6 by ben@chromium.org, Aug 27 2012

Status: Fixed

Comment 7 by bugdroid1@chromium.org, Aug 27 2012

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=153501

------------------------------------------------------------------------
r153501 | ben@chromium.org | 2012-08-27T17:31:35.539683Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/win/hwnd_message_handler.cc?r1=153501&r2=153500&pathrev=153501

Fix max/min window menu items by calling the correct version of EnableMenuItem.

I moved the code that enabled these items to HWNDMessageHandler, but forgot to move the definition of the function. This wasn't a compile error because Win32 defines the same function with the same signature, in the global namespace. DOH!

I renamed the helper function to a unique name: EnableMenuItembyCommand to prevent this from happening again.

This change also moves ScopedRedrawLock to the top of the file, since it needs to be called in onInitMenu also.

 http://crbug.com/144425 
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10870104
------------------------------------------------------------------------

Comment 8 by sky@chromium.org, Aug 27 2012

Cc: mrvalla@chromium.org manoranj...@chromium.org rayanna@chromium.org rponnada@chromium.org pbomm...@chromium.org
 Issue 144404  has been merged into this issue.

Comment 9 by manoranj...@chromium.org, Aug 31 2012

 Issue 145210  has been merged into this issue.

Comment 10 by bugdroid1@chromium.org, Oct 14 2012

Project Member
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.

Comment 11 by bugdroid1@chromium.org, Mar 9 2013

Project Member
Labels: -Type-Regression -Area-UI -Mstone-23 -Feature-TabStrip Type-Bug-Regression Cr-UI-Browser-TabStrip Cr-UI M-23

Comment 12 by bugdroid1@chromium.org, Mar 14 2013

Project Member
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment