New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 144332 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Secondary tile UI gets temporarily confused if the user cancels a pin or unpin action.

Project Member Reported by benwells@chromium.org, Aug 23 2012

Issue description

OS: Windows 8

What steps will reproduce the problem?
0. Start chrome in metro mode
1. Click the menu item "Pin to Start screen"
2. Cancel the Windows UI to pin the page

What is the expected output? What do you see instead?
The menu will now say "Unpin from Start screen" until the next navigation. It should say "Pin to Start screen"

 
Labels: -Mstone-23 Mstone-24
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 3 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=165818

------------------------------------------------------------------------
r165818 | benwells@chromium.org | 2012-11-03T00:50:07.929867Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/wrench_menu_model.cc?r1=165818&r2=165817&pathrev=165818
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/metro_pin_tab_helper_win.cc?r1=165818&r2=165817&pathrev=165818
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/metro_pin_tab_helper_win.h?r1=165818&r2=165817&pathrev=165818

[Win8] Fix pin / unpin status if the user cancels an action or pins / unpins from start screen.

Previously the state was cached whenever a navigation happened, or whenever the user started a pin / unpin action. As the state query does not happen on the metro thread (it happens on the UI thread and is synchronous) there is no need for the caching.

BUG= 144332 


Review URL: https://chromiumcodereview.appspot.com/11362050
------------------------------------------------------------------------
Sweetness :). Thanks, Ben. Let's request a merge to M24 when we've had a chance to verify that it looks good?
Yep that's the plan. It looks like i missed dev channel so will need to wait for the next one. The fix was super simple.
Labels: Merge-Requested
Tested on dev channel, very simple fix.
Labels: -Merge-Requested Merge-Approved
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 16 2012

Labels: -Merge-Approved merge-merged-1312
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=168089

------------------------------------------------------------------------
r168089 | benwells@chromium.org | 2012-11-16T00:11:46.291393Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/ui/metro_pin_tab_helper_win.cc?r1=168089&r2=168088&pathrev=168089
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/ui/metro_pin_tab_helper_win.h?r1=168089&r2=168088&pathrev=168089
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/ui/toolbar/wrench_menu_model.cc?r1=168089&r2=168088&pathrev=168089

Merge 165818 - [Win8] Fix pin / unpin status if the user cancels an action or pins / unpins from start screen.

Previously the state was cached whenever a navigation happened, or whenever the user started a pin / unpin action. As the state query does not happen on the metro thread (it happens on the UI thread and is synchronous) there is no need for the caching.

BUG= 144332 


Review URL: https://chromiumcodereview.appspot.com/11362050

TBR=benwells@chromium.org
Review URL: https://codereview.chromium.org/11411023
------------------------------------------------------------------------
Status: Fixed
Status: Verified
Verified this on latest M24(24.0.1312.25) and the issue is fixed.

Steps followed to verify :
--------------------------------
1. Install chrome and launch in windows 8 mode 
2. Open any Web page 
3. Navigate to Wrench--> bookmarks --> Pin this page to Start screen
4. A Window Dialog opens
5. Ignore the Window Dialog and click some where on the web page.
6. Window dialog should disappear and selected web page shouldn't be pinned to start screen, The wrench --> Bookmarks --> Option should still remain as "Pin this page to Start screen.


Project Member

Comment 10 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Mstone-24 M-24 Cr-UI

Sign in to add a comment