New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug-Security

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment
link

Issue 144051: Security: Memory address disclosure through JavaScript in Print Preview WebUI

Reported by thestig@chromium.org, Aug 21 2012 Project Member

Issue description

Every once in a while, I actually read through the security bugs and I saw  bug 134519 . Print preview is guilty of the same issue that affected the cookies page in  bug 134519 . I've been meaning to fix this for a while.

VULNERABILITY DETAILS

In the print preview JS, raw PrintPreviewUI pointer addresses are exposed.

VERSION
Chrome Version: All current versions in release. (21-23, and older releases as well)
Operating System: All OS.
 

Comment 1 by palmer@chromium.org, Aug 22 2012

Labels: SecImpacts-Stable SecImpacts-Beta SecSeverity-Low Mstone-23

Comment 2 by bugdroid1@chromium.org, Aug 24 2012

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=153342

------------------------------------------------------------------------
r153342 | thestig@chromium.org | 2012-08-24T23:22:28.191717Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/print_preview/preview_generator.js?r1=153342&r2=153341&pathrev=153342
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/print_messages.cc?r1=153342&r2=153341&pathrev=153342
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/print_messages.h?r1=153342&r2=153341&pathrev=153342
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/print_preview/print_preview_data_source.cc?r1=153342&r2=153341&pathrev=153342
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/printing_message_filter.cc?r1=153342&r2=153341&pathrev=153342
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/print_preview/print_preview_data_source.h?r1=153342&r2=153341&pathrev=153342
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/printing_message_filter.h?r1=153342&r2=153341&pathrev=153342
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_mock_render_thread.cc?r1=153342&r2=153341&pathrev=153342
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_data_service.cc?r1=153342&r2=153341&pathrev=153342
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_mock_render_thread.h?r1=153342&r2=153341&pathrev=153342
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_data_service.h?r1=153342&r2=153341&pathrev=153342
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/print_web_view_helper.cc?r1=153342&r2=153341&pathrev=153342
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/print_web_view_helper_browsertest.cc?r1=153342&r2=153341&pathrev=153342
   M http://src.chromium.org/viewvc/chrome/trunk/src/printing/print_job_constants.cc?r1=153342&r2=153341&pathrev=153342
   M http://src.chromium.org/viewvc/chrome/trunk/src/printing/print_job_constants.h?r1=153342&r2=153341&pathrev=153342
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc?r1=153342&r2=153341&pathrev=153342
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/print_preview/print_preview_ui.cc?r1=153342&r2=153341&pathrev=153342
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/print_preview/print_preview_handler.cc?r1=153342&r2=153341&pathrev=153342
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/print_preview/native_layer.js?r1=153342&r2=153341&pathrev=153342
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/print_preview/print_preview_ui.h?r1=153342&r2=153341&pathrev=153342

Print preview: Use an ID instead of memory pointer string in WebUI.

BUG= 144051 

Review URL: https://chromiumcodereview.appspot.com/10870003
------------------------------------------------------------------------

Comment 3 by thestig@chromium.org, Aug 24 2012

Status: Fixed

Comment 4 by scarybea...@gmail.com, Aug 24 2012

Labels: -Restrict-View-SecurityTeam -Mstone-23 Restrict-View-SecurityNotify Mstone-22 Merge-Approved
Status: FixUnreleased

Comment 5 by bugdroid1@chromium.org, Aug 27 2012

Project Member
Labels: -Merge-Approved merge-merged-1229
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=153586

------------------------------------------------------------------------
r153586 | thestig@chromium.org | 2012-08-27T23:49:41.093239Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1229/src/chrome/renderer/print_web_view_helper.cc?r1=153586&r2=153585&pathrev=153586
   M http://src.chromium.org/viewvc/chrome/branches/1229/src/chrome/renderer/print_web_view_helper_browsertest.cc?r1=153586&r2=153585&pathrev=153586
   M http://src.chromium.org/viewvc/chrome/branches/1229/src/printing/print_job_constants.cc?r1=153586&r2=153585&pathrev=153586
   M http://src.chromium.org/viewvc/chrome/branches/1229/src/printing/print_job_constants.h?r1=153586&r2=153585&pathrev=153586
   M http://src.chromium.org/viewvc/chrome/branches/1229/src/chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc?r1=153586&r2=153585&pathrev=153586
   M http://src.chromium.org/viewvc/chrome/branches/1229/src/chrome/browser/ui/webui/print_preview/print_preview_handler.cc?r1=153586&r2=153585&pathrev=153586
   M http://src.chromium.org/viewvc/chrome/branches/1229/src/chrome/browser/ui/webui/print_preview/print_preview_ui.cc?r1=153586&r2=153585&pathrev=153586
   M http://src.chromium.org/viewvc/chrome/branches/1229/src/chrome/browser/resources/print_preview/native_layer.js?r1=153586&r2=153585&pathrev=153586
   M http://src.chromium.org/viewvc/chrome/branches/1229/src/chrome/browser/ui/webui/print_preview/print_preview_ui.h?r1=153586&r2=153585&pathrev=153586
   M http://src.chromium.org/viewvc/chrome/branches/1229/src/chrome/browser/resources/print_preview/preview_generator.js?r1=153586&r2=153585&pathrev=153586
   M http://src.chromium.org/viewvc/chrome/branches/1229/src/chrome/common/print_messages.cc?r1=153586&r2=153585&pathrev=153586
   M http://src.chromium.org/viewvc/chrome/branches/1229/src/chrome/common/print_messages.h?r1=153586&r2=153585&pathrev=153586
   M http://src.chromium.org/viewvc/chrome/branches/1229/src/chrome/browser/ui/webui/print_preview/print_preview_data_source.cc?r1=153586&r2=153585&pathrev=153586
   M http://src.chromium.org/viewvc/chrome/branches/1229/src/chrome/browser/printing/printing_message_filter.cc?r1=153586&r2=153585&pathrev=153586
   M http://src.chromium.org/viewvc/chrome/branches/1229/src/chrome/browser/ui/webui/print_preview/print_preview_data_source.h?r1=153586&r2=153585&pathrev=153586
   M http://src.chromium.org/viewvc/chrome/branches/1229/src/chrome/renderer/chrome_mock_render_thread.cc?r1=153586&r2=153585&pathrev=153586
   M http://src.chromium.org/viewvc/chrome/branches/1229/src/chrome/browser/printing/printing_message_filter.h?r1=153586&r2=153585&pathrev=153586
   M http://src.chromium.org/viewvc/chrome/branches/1229/src/chrome/browser/printing/print_preview_data_service.cc?r1=153586&r2=153585&pathrev=153586
   M http://src.chromium.org/viewvc/chrome/branches/1229/src/chrome/renderer/chrome_mock_render_thread.h?r1=153586&r2=153585&pathrev=153586
   M http://src.chromium.org/viewvc/chrome/branches/1229/src/chrome/browser/printing/print_preview_data_service.h?r1=153586&r2=153585&pathrev=153586

Merge 153342 - Print preview: Use an ID instead of memory pointer string in WebUI.

BUG= 144051 

Review URL: https://chromiumcodereview.appspot.com/10870003

TBR=thestig@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10873097
------------------------------------------------------------------------

Comment 6 by scarybea...@gmail.com, Aug 28 2012

Thanks for the merge! :D

Comment 7 by bugdroid1@chromium.org, Oct 13 2012

Project Member
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.

Comment 8 by jsc...@chromium.org, Dec 20 2012

Status: Fixed

Comment 9 by tsepez@chromium.org, Jan 4 2013

Cc: jiayl@chromium.org

Comment 10 by bugdroid1@chromium.org, Jan 18 2013

Project Member
Labels: Restrict-View-EditIssue
Restrict-View-EditIssue is preferred since it allows anyone who can edit an issue (committers and contributors) to view the bug.

Comment 11 by bugdroid1@chromium.org, Jan 18 2013

Project Member
Restrict-View-EditIssue is preferred since it allows anyone who can edit an issue (committers and contributors) to view the bug.

Comment 12 by bugdroid1@chromium.org, Mar 10 2013

Project Member
Labels: -Type-Security -Area-Internals -Feature-Printing -SecImpacts-Stable -SecImpacts-Beta -SecSeverity-Low -Mstone-22 Security-Severity-Low Security-Impact-Stable Security-Impact-Beta M-22 Cr-Internals Cr-Internals-Printing Type-Bug-Security

Comment 13 by bugdroid1@chromium.org, Mar 14 2013

Project Member
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Comment 14 by scarybea...@gmail.com, Mar 21 2013

Labels: -Restrict-View-SecurityNotify -Restrict-View-EditIssue

Comment 15 by bugdroid1@chromium.org, Mar 21 2013

Project Member
Labels: -Security-Severity-Low Security_Severity-Low

Comment 16 by bugdroid1@chromium.org, Mar 21 2013

Project Member
Labels: -Security-Impact-Stable Security_Impact-Stable

Comment 17 by bugdroid1@chromium.org, Mar 21 2013

Project Member
Labels: -Security-Impact-Beta Security_Impact-Beta

Comment 18 by sheriffbot@chromium.org, Jun 14 2016

Project Member
Labels: -security_impact-beta

Comment 19 by sheriffbot@chromium.org, Oct 1 2016

Project Member
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 20 by sheriffbot@chromium.org, Oct 2 2016

Project Member
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 21 by mbarbe...@chromium.org, Oct 2 2016

Labels: allpublic

Sign in to add a comment