New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 143454 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2012
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Add field trial for asynchronous DNS

Project Member Reported by szym@chromium.org, Aug 17 2012

Issue description

A field trial of asynchronous DNS should be enabled to allow unbiased measurement of correctness, and in the future performance.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 22 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=152876

------------------------------------------------------------------------
r152876 | szym@chromium.org | 2012-08-22T23:53:40.615601Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/async_dns_field_trial.cc?r1=152876&r2=152875&pathrev=152876
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/about_flags.cc?r1=152876&r2=152875&pathrev=152876
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/test_launcher_utils.cc?r1=152876&r2=152875&pathrev=152876
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/async_dns_field_trial.h?r1=152876&r2=152875&pathrev=152876
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=152876&r2=152875&pathrev=152876
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=152876&r2=152875&pathrev=152876
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/io_thread.cc?r1=152876&r2=152875&pathrev=152876
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=152876&r2=152875&pathrev=152876

[net] Add AsyncDns field trial.

This adds AsyncDns field trial which sets --enable-async-dns for 50% of users
who have not configured any HostResolverImpl-related flags.

BUG= 143454 

Review URL: https://chromiumcodereview.appspot.com/10828373
------------------------------------------------------------------------

Comment 2 by szym@chromium.org, Aug 24 2012

Blockedon: chromium:121085
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 24 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=153252

------------------------------------------------------------------------
r153252 | szym@chromium.org | 2012-08-24T19:08:56.115369Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/async_dns_field_trial.cc?r1=153252&r2=153251&pathrev=153252

[net] Temporarily turn the AsyncDns field trial off

Until we address check failures:  http://crbug.com/121085 

BUG= 143454 

Review URL: https://chromiumcodereview.appspot.com/10867055
------------------------------------------------------------------------
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 27 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=153550

------------------------------------------------------------------------
r153550 | szym@chromium.org | 2012-08-27T21:50:58.133109Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/async_dns_field_trial.cc?r1=153550&r2=153549&pathrev=153550

[net] Re-enable async DNS field trial (on canary only)

BUG= 143454 

Review URL: https://chromiumcodereview.appspot.com/10867091
------------------------------------------------------------------------
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 31 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=154369

------------------------------------------------------------------------
r154369 | szym@chromium.org | 2012-08-31T04:08:26.665078Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/async_dns_field_trial.cc?r1=154369&r2=154368&pathrev=154369

[net] Disable Async DNS field trial

Disabling due to  http://crbug.com/121085 

NOTRY=true
BUG= 143454 


Review URL: https://chromiumcodereview.appspot.com/10894041
------------------------------------------------------------------------
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 20 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=157744

------------------------------------------------------------------------
r157744 | szym@chromium.org | 2012-09-20T11:22:19.067783Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/async_dns_field_trial.cc?r1=157744&r2=157743&pathrev=157744

[net] Enable async DNS field trial on CrOS (canary+dev channels).

BUG= 143454 


Review URL: https://chromiumcodereview.appspot.com/10945041
------------------------------------------------------------------------
Labels: Mstone Merge-Requested
Request to merge r157744 to M23 branch.
Labels: -Mstone Mstone-23

Comment 9 by kareng@google.com, Sep 20 2012

Labels: -Merge-Requested Merge-Approved
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 20 2012

Labels: -Merge-Approved merge-merged-1271
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=157791

------------------------------------------------------------------------
r157791 | cbentzel@chromium.org | 2012-09-20T17:09:30.700161Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1271/src/chrome/browser/net/async_dns_field_trial.cc?r1=157791&r2=157790&pathrev=157791

Merge 157744 - [net] Enable async DNS field trial on CrOS (canary+dev channels).

BUG= 143454 


Review URL: https://chromiumcodereview.appspot.com/10945041

TBR=szym@chromium.org
Review URL: https://codereview.chromium.org/10970017
------------------------------------------------------------------------
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 21 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=158024

------------------------------------------------------------------------
r158024 | szym@chromium.org | 2012-09-21T18:12:08.928696Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/async_dns_field_trial.cc?r1=158024&r2=158023&pathrev=158024

[net/dns] Extend async DNS field trial to other supported platforms.

BUG= 143454 

' will be ignored, and an empty message aborts the commit.

R=cbentzel@chromium.org

Review URL: https://codereview.chromium.org/10968036
------------------------------------------------------------------------

Comment 12 by karen@chromium.org, Oct 10 2012

Labels: -Mstone-23 MovedFrom-23 Mstone-24
Moving all non essential bugs to the next Milestone
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 26 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=164375

------------------------------------------------------------------------
r164375 | szym@chromium.org | 2012-10-26T19:37:04.659902Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/async_dns_field_trial.cc?r1=164375&r2=164374&pathrev=164375
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/async_dns_field_trial.h?r1=164375&r2=164374&pathrev=164375

Move AsyncDns field trial to server-side control.

BUG= 143454 

Review URL: https://codereview.chromium.org/11262018
------------------------------------------------------------------------
Labels: -Mstone-24
Please target the right milestone to which this can be fixed. For now, removing the milestone label.
Project Member

Comment 15 by bugdroid1@chromium.org, Nov 7 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=166472

------------------------------------------------------------------------
r166472 | szym@chromium.org | 2012-11-07T18:24:02.647234Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/base/host_cache.cc?r1=166472&r2=166471&pathrev=166472

[net] Set default HostCache size according to HostCacheSize field trial.

BUG= 114277 , 143454 


Review URL: https://chromiumcodereview.appspot.com/11358125
------------------------------------------------------------------------
Project Member

Comment 16 by bugdroid1@chromium.org, Nov 12 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=167254

------------------------------------------------------------------------
r167254 | szym@chromium.org | 2012-11-12T23:03:54.995144Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/base/host_cache.cc?r1=167254&r2=167253&pathrev=167254

[net] Fix parsing of HostCacheSize field trial group name.

The group name is <number><suffix>, e.g., 100A, so base::StringToSizeT will
return false.

BUG= 114277 , 143454 
TEST=chrome --force-fieldtrials=HostCacheSize/8723suffix/; open 'chrome://net-internals/#dns' and verify 'Capacity: 8723'

Review URL: https://codereview.chromium.org/11366201
------------------------------------------------------------------------

Comment 17 by szym@chromium.org, Nov 15 2012

Blockedon: -chromium:121085

Comment 18 by szym@chromium.org, Dec 1 2012

Status: Fixed
Closing this issue, since the field trial is now configured by finch.
Project Member

Comment 19 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-Internals -internals-network-dns Cr-Internals Cr-Internals-Network-DNS

Sign in to add a comment